{"id":2232521,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2232521/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260504155642.2216040-1-holger.brunck@hitachienergy.com/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/1.1/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/"},"msgid":"<20260504155642.2216040-1-holger.brunck@hitachienergy.com>","date":"2026-05-04T15:56:42","name":"[net] net: wan: fsl_uhdlc_hdlc: fix dma_rmb usage in hdlc_rx_done","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"f428f9a73ee79828b8c00db86696acad8b5421a5","submitter":{"id":82682,"url":"http://patchwork.ozlabs.org/api/1.1/people/82682/?format=json","name":"Holger Brunck","email":"holger.brunck@hitachienergy.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260504155642.2216040-1-holger.brunck@hitachienergy.com/mbox/","series":[{"id":502691,"url":"http://patchwork.ozlabs.org/api/1.1/series/502691/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=502691","date":"2026-05-04T15:56:42","name":"[net] net: wan: fsl_uhdlc_hdlc: fix dma_rmb usage in hdlc_rx_done","version":1,"mbox":"http://patchwork.ozlabs.org/series/502691/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2232521/comments/","check":"success","checks":"http://patchwork.ozlabs.org/api/patches/2232521/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=hitachienergy.com header.i=@hitachienergy.com\n header.a=rsa-sha256 header.s=duo-1630306886989-947ac67a header.b=tDkts/HC;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=outbound.mailhop.org header.i=@outbound.mailhop.org\n header.a=rsa-sha256 header.s=dkim-high header.b=G7n3067C;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-20426-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=18.158.144.38","lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=hitachienergy.com","lists.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=hitachienergy.com header.i=@hitachienergy.com\n header.a=rsa-sha256 header.s=duo-1630306886989-947ac67a header.b=tDkts/HC;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=outbound.mailhop.org header.i=@outbound.mailhop.org\n header.a=rsa-sha256 header.s=dkim-high header.b=G7n3067C;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=hitachienergy.com\n (client-ip=18.158.144.38; helo=out-ip0052.fra.mailhop.org;\n envelope-from=holger.brunck@hitachienergy.com; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g8RC010yKz1yJV\n\tfor ; Tue, 05 May 2026 01:58:34 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4g8RBy2nhMz2yZ6;\n\tTue, 05 May 2026 01:58:34 +1000 (AEST)","from out-ip0052.fra.mailhop.org (out-ip0052.fra.mailhop.org\n [18.158.144.38])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4g8RBw2ty4z2xS2\n\tfor ; Tue, 05 May 2026 01:58:31 +1000 (AEST)","from HPG0000000534.corp.hitachi-powergrids.com (unknown\n [20.62.140.138])\n\tby outbound3.eu.mailhop.org (Halon) with ESMTPSA\n\tid eb4e0fb5-47d1-11f1-8ef3-f54febe22707;\n\tMon, 04 May 2026 15:57:16 +0000 (UTC)","from gitsiv.hitachienergy.com (unknown [10.54.139.14])\n\tby HPG0000000534.corp.hitachi-powergrids.com (Postfix) with ESMTP id\n 541C9402502;\n\tMon, 4 May 2026 15:57:14 +0000 (UTC)","from chbrn3-p-dev015.keymile.net (chbrn3-p-dev015.keymile.net\n [172.31.41.201])\n\tby gitsiv.hitachienergy.com (Postfix) with ESMTP id CB2EF60B7D47;\n\tMon, 4 May 2026 17:57:13 +0200 (CEST)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1777910314;\n\tcv=none;\n b=jDAjZW7I6VsJkO9zVdNetQj1BSpmHLS+9tP53jmAm4Dxyls1+3bLDKL8zE6tEQz2gR7pGtsovDKd0jX4VWzAQq/9kAHaxUtdTJE+i3UHHN3Fz8FHJsIBTwgaMV4MLF7k5/YIbWQzJCHdKFIWo23IwlJNi4hiqhLlaOQUGAKjAFnD9nrlAJahGNRQhtyWd2gTLBsyOr1fficFpXroDMUe0o9o7f3hCmau+MYevpYLFX0RgsnLA8TJDSdSSZqsUNeEVOEGnbL4GVT1+Ozx+IzKcM823frEUa9XeP9C5c6IsqBk4x7dUCKwcVxSLH6hqhHPQ6EbzwjEOraGOhEAFWeTqQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1777910314; c=relaxed/relaxed;\n\tbh=0BKXpo1u7lWawTu7f0xL5Pp283L9bUuja2ZdCCoXRl0=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=dD9OJM5YOSr8+W+rEdFwP1Y9C32W9sdLf6Ah7li8zVri8elq3PmcshgSqPbiTnyg5plmsQrs1tD8oI9EAzmKSBMCb2qIpdDnaK89Uc6aP0ufG50xNZ0lrPYbe2w1RDKLTE554OfDCvhzt6Y8VO+4TYroShZjZqa92hky/tkDQiXzt8mnuquUz6VgkA4UJS2d+qbuHsSksFA4hG69fN+hbbykM6sOCdF4EuzKhtyPfLDgO2bB/mIm0nWL/TWb2lD3EQ18sKl4ZQhaukuuHhnP8ozMbm3p2I377dFj6DoAMS7INaI1MWrahqqLExz11vFKC6cTROnIxFnxvFQRIAXUwg==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=hitachienergy.com;\n dkim=pass (1024-bit key;\n unprotected) header.d=hitachienergy.com header.i=@hitachienergy.com\n header.a=rsa-sha256 header.s=duo-1630306886989-947ac67a header.b=tDkts/HC;\n dkim=pass (2048-bit key;\n unprotected) header.d=outbound.mailhop.org header.i=@outbound.mailhop.org\n header.a=rsa-sha256 header.s=dkim-high header.b=G7n3067C; dkim-atps=neutral;\n spf=pass (client-ip=18.158.144.38; helo=out-ip0052.fra.mailhop.org;\n envelope-from=holger.brunck@hitachienergy.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=hitachienergy.com","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=hitachienergy.com; s=duo-1630306886989-947ac67a;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc:to:from:\n\t cfbl-address:cfbl-feedback-id:from;\n\tbh=0BKXpo1u7lWawTu7f0xL5Pp283L9bUuja2ZdCCoXRl0=;\n\tb=tDkts/HCeoqL5MpBao8w1vVnuT2uVkhib1kiGNTc1qQpr8KH/EmekgJAUVXkeq+Ca+qVjL3YewOYQ\n\t T6d9rcuo1Ef2SZJojde3ul6q2IXgBogEqZAmzbUlG1Cn8zY2wA+8qOXGsSR/V+8XgobrY25cmKk0R2\n\t 2ZK7c3kotn1wjPsk=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=outbound.mailhop.org; s=dkim-high;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc:to:from:\n\t cfbl-address:cfbl-feedback-id:from;\n\tbh=0BKXpo1u7lWawTu7f0xL5Pp283L9bUuja2ZdCCoXRl0=;\n\tb=G7n3067CxRdbA8JM+u6wHrwQCKxfEXduN8A+FnFJcq9gw4PTGpj5smHCCP2CQJPwNBo3oWCD82Dae\n\t cBKlNwYmYQbkA4Hgaq19w30dZlzwXrI2EaMUZyEoTbjxIr6C1/5JD/lkWuXSG+YdVH6ZPGl3faVduq\n\t 6bKVTnljKswCMTNFiO2GeTscesW1eAPS5zLca3UC6L0yvlBi2qUF2gdt/wMdK13/hr9/xTeVU+Cqn2\n\t Zw8qigyMj9ZVsFEd06LxG3drfzhFfOiSO7Wq0s5ZQvb8vLsP6axNcCLVOLXgF//NUZ2taZ80WwP1hi\n\t 2YXmRg1zwH3J0sPv+QngKKikEH7Adxg=="],"X-Originating-IP":"20.62.140.138","X-MHO-RoutePath":"aGVkY3NtdHA=","X-MHO-User":"eb4e0fb5-47d1-11f1-8ef3-f54febe22707","X-Report-Abuse-To":"\n https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information","X-Mail-Handler":"DuoCircle Outbound SMTP","CFBL-Feedback-ID":"eb4e0fb5-47d1-11f1-8ef3-f54febe22707:7","CFBL-Address":"prvs=058485b737=abuse@outbound.mailhop.org; report=arf","From":"Holger Brunck ","To":"netdev@vger.kernel.org","Cc":"linuxppc-dev@lists.ozlabs.org,\n\tandrew+netdev@lunn.ch,\n\tchleroy@kernel.org,\n\tqiang.zhao@nxp.com,\n\thorms@kernel.org,\n\tHolger Brunck ","Subject":"[PATCH net] net: wan: fsl_uhdlc_hdlc: fix dma_rmb usage in\n hdlc_rx_done","Date":"Mon, 4 May 2026 17:56:42 +0200","Message-ID":"<20260504155642.2216040-1-holger.brunck@hitachienergy.com>","X-Mailer":"git-send-email 2.52.0.120.gb31ab939fe","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Spam-Status":"No, score=-0.3 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED,\n\tDKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,\n\tSPF_HELO_NONE,SPF_PASS autolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"},"content":"If dma_rmb is used it has to be done after reading bd_status and checking\nif R_E_S is zero. Therefore we need to move it into the while loop.\n\nFixes: c19b6d246a35 (\"drivers/net: support hdlc function for QE-UCC\")\nSigned-off-by: Holger Brunck \n---\n drivers/net/wan/fsl_ucc_hdlc.c | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)","diff":"diff --git a/drivers/net/wan/fsl_ucc_hdlc.c b/drivers/net/wan/fsl_ucc_hdlc.c\nindex 15bfb78381d4..09081f128a98 100644\n--- a/drivers/net/wan/fsl_ucc_hdlc.c\n+++ b/drivers/net/wan/fsl_ucc_hdlc.c\n@@ -523,12 +523,12 @@ static int hdlc_rx_done(struct ucc_hdlc_private *priv, int rx_work_limit)\n \tu16 length, howmany = 0;\n \tu8 *bdbuffer;\n \n-\tdma_rmb();\n \tbd = priv->currx_bd;\n \tbd_status = be16_to_cpu(bd->status);\n \n \t/* while there are received buffers and BD is full (~R_E) */\n \twhile (!((bd_status & (R_E_S)) || (--rx_work_limit < 0))) {\n+\t\tdma_rmb();\n \t\tif (bd_status & (RX_BD_ERRORS)) {\n \t\t\tdev->stats.rx_errors++;\n \n@@ -610,7 +610,6 @@ static int hdlc_rx_done(struct ucc_hdlc_private *priv, int rx_work_limit)\n \n \t\tbd_status = be16_to_cpu(bd->status);\n \t}\n-\tdma_rmb();\n \n \tpriv->currx_bd = bd;\n \treturn howmany;\n","prefixes":["net"]}