{"id":2232495,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2232495/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260504154205.21394-1-atrajeev@linux.ibm.com/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/1.1/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/"},"msgid":"<20260504154205.21394-1-atrajeev@linux.ibm.com>","date":"2026-05-04T15:42:04","name":"[V4,1/2] tools/perf: Fix the check for parameterized field in event term","commit_ref":null,"pull_url":null,"state":"handled-elsewhere","archived":false,"hash":"3640932a68b018b9aef7095e174af1b058e46af0","submitter":{"id":90290,"url":"http://patchwork.ozlabs.org/api/1.1/people/90290/?format=json","name":"Athira Rajeev","email":"atrajeev@linux.ibm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260504154205.21394-1-atrajeev@linux.ibm.com/mbox/","series":[{"id":502686,"url":"http://patchwork.ozlabs.org/api/1.1/series/502686/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=502686","date":"2026-05-04T15:42:04","name":"[V4,1/2] tools/perf: Fix the check for parameterized field in event term","version":4,"mbox":"http://patchwork.ozlabs.org/series/502686/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2232495/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2232495/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=fwtRl8ql;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-20424-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=148.163.158.5","lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=fwtRl8ql;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=linux.ibm.com\n (client-ip=148.163.158.5; helo=mx0b-001b2d01.pphosted.com;\n envelope-from=atrajeev@linux.ibm.com; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g8QrT13lbz1yJV\n\tfor ; Tue, 05 May 2026 01:42:32 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4g8QrL2lM3z2yZ6;\n\tTue, 05 May 2026 01:42:26 +1000 (AEST)","from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com\n [148.163.158.5])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4g8QrK3QkVz2xS2\n\tfor ; Tue, 05 May 2026 01:42:24 +1000 (AEST)","from pps.filterd (m0356516.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 644Eklfk3011871;\n\tMon, 4 May 2026 15:42:19 GMT","from ppma21.wdc07v.mail.ibm.com\n (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91])\n\tby mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4dw9w67k87-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tMon, 04 May 2026 15:42:18 +0000 (GMT)","from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1])\n\tby ppma21.wdc07v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id\n 644EsSIK016761;\n\tMon, 4 May 2026 15:42:18 GMT","from smtprelay05.fra02v.mail.ibm.com ([9.218.2.225])\n\tby ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4dwvkjnrmb-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tMon, 04 May 2026 15:42:17 +0000 (GMT)","from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com\n [10.20.54.105])\n\tby smtprelay05.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 644FgDHC44106170\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n\tMon, 4 May 2026 15:42:14 GMT","from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id DCBFE2004B;\n\tMon, 4 May 2026 15:42:13 +0000 (GMT)","from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 2683220040;\n\tMon, 4 May 2026 15:42:08 +0000 (GMT)","from localhost.localdomain (unknown [9.124.208.70])\n\tby smtpav06.fra02v.mail.ibm.com (Postfix) with ESMTP;\n\tMon, 4 May 2026 15:42:07 +0000 (GMT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1777909346;\n\tcv=none;\n b=kEZseliirxo0mKIxgUiPusFtwHVulONyjYUPKC5R4Q/wkAAvcCeSpMd4nhLPUD731iHWsB+BpCTiP7wugN/5QtYTtbj/Vr1LErn9AIUnKE+DfFDRMR5he4iVPqK0Md0l3XPZf9gSEtbMk3atZPg1UYOSoX3EqtEa12yvoH8OfFoSNO0XSMg4Z/EYWSNNWm4SSemECQo40A27TVFCTImfpFAsDFi9efV8PtP7r5wlcCSanE8oV+2Bwsh1S8rm7IkxpEIOHXKdo2mhWzujUDhqE0ARgFWKtGIX86RnyiuTZXy/ZBkck8tYxgez6vgIXfKAySD7+gun8VhunUqwcmNe5Q==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1777909346; c=relaxed/relaxed;\n\tbh=iU+kuad77WgAER0Xt0/0sHxheaJL/nbFKFSiMXKtYnY=;\n\th=From:To:Cc:Subject:Date:Message-Id:MIME-Version;\n b=YH8MsRpmewsEE9+0La4ZvBZ441hfTDsHY3PChOoyxk96yclbqz7p2MbphhUf7T/W+tSncrKEYIEBDr0ujsIoR3Tt2ELOjMmqoe7hWjIbUpKXKIGCdofQlYxtjnWIFc6eK6txkE7xkEDTS8LRWI0Rv2ZA0Us6z1Iv3xcUO/xHPpRqMhiZf/+FEEo7BBfvKZVtJxErW09YWgLXFDXrOFg03tkZJggalMwzBv1TeAokcFcId0txw0O56FYDMBLQhvRnzzyLXLK1ECXa5qc1FTDTfGUe12vKO0Ue+ihrlOmvo9mYjUQlJhN8JsGmcYIrFL5MKk8MiXlMVmyIbqJaojmz0Q==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com;\n dkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=fwtRl8ql; dkim-atps=neutral;\n spf=pass (client-ip=148.163.158.5; helo=mx0b-001b2d01.pphosted.com;\n envelope-from=atrajeev@linux.ibm.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=linux.ibm.com","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n\t:content-transfer-encoding:date:from:message-id:mime-version\n\t:subject:to; s=pp1; bh=iU+kuad77WgAER0Xt0/0sHxheaJL/nbFKFSiMXKtY\n\tnY=; b=fwtRl8qlT+oReezR5b2x0NLGODYDBrryqhojpNE+IHGEoekz4RIndOkaA\n\tejSt72pW89MZMXsyY2CFYBT1fMcvzv9Kny1RK78ViztI9lDE43dGSYTTikdPkzxe\n\t+cIvuE5EnxDPLQ6qUEGDYRfQ8GnB+g3rmoJucAA8M+8N1rNAkYqX6gXx7/K2QB2T\n\t9G4KInwIWb55OOdqUMnNndMBwgQAaoaL32GSCWknYVc/TJTyJLbWpCH7QxJjwL5r\n\t7fttYoGoM31wXq9kUgMH1XBcxwGVfsgMBJ4juzj+oArieqPJUnfYZPsNJqs2ns90\n\tAQtK6pqczb4JuL2AuxVaVzOdcKBZg==","From":"Athira Rajeev ","To":"acme@kernel.org, jolsa@kernel.org, adrian.hunter@intel.com,\n mpetlan@redhat.com, tmricht@linux.ibm.com, maddy@linux.ibm.com,\n irogers@google.com, namhyung@kernel.org","Cc":"linux-perf-users@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,\n atrajeev@linux.ibm.com, hbathini@linux.vnet.ibm.com,\n Tejas.Manhas1@ibm.com, Tanushree.Shah@ibm.com, shivani@linux.ibm.com","Subject":"[PATCH V4 1/2] tools/perf: Fix the check for parameterized field in\n event term","Date":"Mon, 4 May 2026 21:12:04 +0530","Message-Id":"<20260504154205.21394-1-atrajeev@linux.ibm.com>","X-Mailer":"git-send-email 2.39.5 (Apple Git-154)","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-TM-AS-GCONF":"00","X-Proofpoint-Reinject":"loops=2 maxloops=12","X-Authority-Analysis":"v=2.4 cv=XPQAjwhE c=1 sm=1 tr=0 ts=69f8be5a cx=c_pps\n a=GFwsV6G8L6GxiO2Y/PsHdQ==:117 a=GFwsV6G8L6GxiO2Y/PsHdQ==:17\n a=KlCRr-_lrQmZq1rU:21 a=NGcC8JguVDcA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=RnoormkPH1_aCDwRdu11:22 a=Y2IxJ9c9Rs8Kov3niI8_:22 a=VnNF1IyMAAAA:8\n a=g2m9RzfYH6J901Z4KtUA:9","X-Proofpoint-ORIG-GUID":"nexF7THWWWeXZv-unOZSwrOuqnh5ojho","X-Proofpoint-GUID":"Z74undJVeWR371vXreh52SxflY17yq4-","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNTA0MDE1MiBTYWx0ZWRfX5tfB1+DguB4H\n uC+j6R5uZb71wmilrBx21DgF3KlGJSc7uohgDc+J5uaCy+J423PVqOnAkxHklWoYO+7SCRtUM/v\n dT3tTf4zSyRo+uFdVmeY/Mi2T3b+18kqx4TBNBCMFyR8B4P4a8+dUzBj+ss0wXhg5o0As/erp2m\n FyqESk4c0GkGMNidlvnd18H3AWNAhUc0xo2+2/D53gHsefBlbA3GyfjZOLjzPpp8/ooazkz1ij8\n 7HR1GzkT88VAm5RBnx1ZpD5Nr+z2EOI/8XZnE4fRWQUkT7esC7W/MClcsJ2nqwtqbZNJLSMmPcM\n ewYw+T5V+hmcGl0T/mgGIbG7zjvx+ZkFTKhzlw55IhIa2L+gS0vui1h9eNkMPGUcoIJwZ0+qAUE\n SIfM89tgLkLAgWsD3J/MCC45gM7BzyezGLQW33HuSDVfArkkBOrcFlxRbDSzKpDoCa1S0hwDw75\n MdU8Ko/Cu3vmW0xUZGA==","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-05-04_05,2026-04-30_02,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n bulkscore=0 lowpriorityscore=0 suspectscore=0 adultscore=0 spamscore=0\n priorityscore=1501 impostorscore=0 phishscore=0 malwarescore=0 clxscore=1015\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605040152","X-Spam-Status":"No, score=-0.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tRCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,\n\tSPF_PASS autolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"},"content":"The format_alias() function in util/pmu.c has a check to\ndetect whether the event has parameterized field ( =? ).\nThe string alias->terms contains the event and if the event\nhas user configurable parameter, there will be presence of\nsub string \"=?\" in the alias->terms.\n\nSnippet of code:\n\n /* Paramemterized events have the parameters shown. */\n if (strstr(alias->terms, \"=?\")) {\n /* No parameters. */\n snprintf(buf, len, \"%.*s/%s/\", (int)pmu_name_len, pmu->name, alias->name);\n\nif \"strstr\" contains the substring, it returns a pointer\nand hence enters the above check which is not the expected\ncheck. And hence \"perf list\" doesn't have the parameterized\nfields in the result.\n\nFix this check to use:\n\nif (!strstr(alias->terms, \"=?\")) {\n\nWith this change, perf list shows the events correctly with\nthe strings showing parameters.\n\nBefore the fix:\n\n # ./perf list|grep -w PM_PAU_CYC\n hv_24x7/PM_PAU_CYC/ [Kernel PMU event]\n\nWith this fix:\n\n # ./perf list|grep -w PM_PAU_CYC\n hv_24x7/PM_PAU_CYC,chip=?/ [Kernel PMU event]\n\nSigned-off-by: Athira Rajeev \n---\nChangelog:\nv3 -> v4:\nUpdated commit message to show real example\naddressing review comment from Namhyung.\n\nv2 -> v3:\nSplit the strstr correction in a single patch\n\n tools/perf/util/pmu.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c\nindex 23337d2fa281..0b8d58543f17 100644\n--- a/tools/perf/util/pmu.c\n+++ b/tools/perf/util/pmu.c\n@@ -2117,7 +2117,7 @@ static char *format_alias(char *buf, int len, const struct perf_pmu *pmu,\n \t\t\t\t\t\t skip_duplicate_pmus);\n \n \t/* Paramemterized events have the parameters shown. */\n-\tif (strstr(alias->terms, \"=?\")) {\n+\tif (!strstr(alias->terms, \"=?\")) {\n \t\t/* No parameters. */\n \t\tsnprintf(buf, len, \"%.*s/%s/\", (int)pmu_name_len, pmu->name, alias->name);\n \t\treturn buf;\n","prefixes":["V4","1/2"]}