{"id":2232475,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2232475/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260504151321.12346-1-atrajeev@linux.ibm.com/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/1.1/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/"},"msgid":"<20260504151321.12346-1-atrajeev@linux.ibm.com>","date":"2026-05-04T15:13:20","name":"[V5,1/2] powerpc tools perf: Initialize error code in auxtrace_record_init function","commit_ref":null,"pull_url":null,"state":"handled-elsewhere","archived":false,"hash":"f4b8b1973afaea02837e2c67f4e6607b73bf2fd7","submitter":{"id":90290,"url":"http://patchwork.ozlabs.org/api/1.1/people/90290/?format=json","name":"Athira Rajeev","email":"atrajeev@linux.ibm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260504151321.12346-1-atrajeev@linux.ibm.com/mbox/","series":[{"id":502679,"url":"http://patchwork.ozlabs.org/api/1.1/series/502679/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=502679","date":"2026-05-04T15:13:20","name":"[V5,1/2] powerpc tools perf: Initialize error code in auxtrace_record_init function","version":5,"mbox":"http://patchwork.ozlabs.org/series/502679/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2232475/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2232475/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=B++gdd0A;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-20422-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=148.163.156.1","lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=B++gdd0A;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=linux.ibm.com\n (client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com;\n envelope-from=atrajeev@linux.ibm.com; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g8QCF48t0z1yJV\n\tfor ; Tue, 05 May 2026 01:13:44 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4g8QCC2gFnz2ygf;\n\tTue, 05 May 2026 01:13:43 +1000 (AEST)","from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com\n [148.163.156.1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4g8QC91wvZz2xfB\n\tfor ; Tue, 05 May 2026 01:13:40 +1000 (AEST)","from pps.filterd (m0356517.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 644EoSYB2607845;\n\tMon, 4 May 2026 15:13:35 GMT","from ppma12.dal12v.mail.ibm.com\n (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220])\n\tby mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4dw9y17mxa-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tMon, 04 May 2026 15:13:35 +0000 (GMT)","from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1])\n\tby ppma12.dal12v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id\n 644EsSeJ017439;\n\tMon, 4 May 2026 15:13:34 GMT","from smtprelay05.fra02v.mail.ibm.com ([9.218.2.225])\n\tby ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 4dwukq5tsh-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tMon, 04 May 2026 15:13:34 +0000 (GMT)","from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com\n [10.20.54.105])\n\tby smtprelay05.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 644FDVwI38601176\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n\tMon, 4 May 2026 15:13:31 GMT","from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id EED9C2004B;\n\tMon, 4 May 2026 15:13:30 +0000 (GMT)","from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 1013920049;\n\tMon, 4 May 2026 15:13:26 +0000 (GMT)","from localhost.localdomain (unknown [9.124.208.70])\n\tby smtpav06.fra02v.mail.ibm.com (Postfix) with ESMTP;\n\tMon, 4 May 2026 15:13:25 +0000 (GMT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1777907623;\n\tcv=none;\n b=AK3XPDtxRr9Nvxk/sb08jh+SckUt0fjTPNH2c9kGZpRzBEU/ArigGsxFWF34GiIR73EhaOJ5chynf3Ofm5xKS47eogPyNtU82d8xNb1gkid2VUdjhRPgUhwpIl+J/r/jhkb0vpcHtJmvYT+liXDxEd8gBOHpOmIW0fH37HvFG7hechI+zbZR9Zglx5m/m/IQ/GI2ykomw306td6wzHUss0qtE+oAKdZXW+qQApyXqYZ9NMor3ANu1UC/r4JBY/+lbxSETnVsglRNTvBQe+JNNgIiuSTt9g+wJrA6/OpPnwfwXHqOCussOQMpEkZK7zTUH4bXQwnxNPDpcvFzzJ2oeg==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1777907623; c=relaxed/relaxed;\n\tbh=gXgbgzfQRi7AGx3+dyd8Lfq9Z/7JkNqsY55X/jMKO5k=;\n\th=From:To:Cc:Subject:Date:Message-Id:MIME-Version;\n b=XwNCmIEf9biU8e/qLGB5cX+lBntffnNjipvQT2B1BO111wmC/yCQ3qNE8bCj97koJC0OpaYWitM/Rsyu09EcTIjFvCUwAa2Yz/k3rSr1mXv63KzTtz6L1wN+nCr3S1iKBwGgYoQZNGSV4umCGM7ZMzODCgnOCCkeIFVtaodQokhuihpIJb9pRGAktRdqrc/OYK6yQxCbBBIx3ztzyTYbThjODe97hFg2b/R5fhV8DzEc24V3wdO7SrsQTlaDC8TmKQfYJ1T3tE3yQ+0ZKWFCB5oKpYcb7BXGa9nFPXLHhTxazIDoGxBHnUkB9PqA5h2smK9xeNkffOWKSN3ImswijQ==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com;\n dkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=B++gdd0A; dkim-atps=neutral;\n spf=pass (client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com;\n envelope-from=atrajeev@linux.ibm.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=linux.ibm.com","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n\t:content-transfer-encoding:date:from:message-id:mime-version\n\t:subject:to; s=pp1; bh=gXgbgzfQRi7AGx3+dyd8Lfq9Z/7JkNqsY55X/jMKO\n\t5k=; b=B++gdd0A9EcXy9FL+Al2frStPz6G9DmrrOFlMbUm2sd8Dqxq6xddoe2YF\n\t9Nl4tiSWFEg1PDm+vLVv/QRhm6PzDMeSH2yHJvfF+B7DMuR4kaFdJJjzbsodXxWS\n\tgWSPkWBeR2NkAnnzzy1Glhqc4mE8+llhwOVpaJ9tHmmtD4YYhIcpKFlgklsRibTi\n\tDUxY35nUdMsZw+JHKtphzePl2mvPEo06x0AnRYz0Faf+g7jRZfYDqZkg3+5u/k6s\n\tih6z6orAoibBsTd+WChH2kGGPH0j+f4a9RT4BhKCUQ5syMa8AQQXYh3deCmQBbEc\n\tuiBWKUOElmeOUoS0DBlOUyu3adPfg==","From":"Athira Rajeev ","To":"acme@kernel.org, jolsa@kernel.org, adrian.hunter@intel.com,\n mpetlan@redhat.com, tmricht@linux.ibm.com, maddy@linux.ibm.com,\n irogers@google.com, namhyung@kernel.org","Cc":"linux-perf-users@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,\n atrajeev@linux.ibm.com, hbathini@linux.vnet.ibm.com,\n Tejas.Manhas1@ibm.com, Tanushree.Shah@ibm.com, shivani@linux.ibm.com","Subject":"[PATCH V5 1/2] powerpc tools perf: Initialize error code in\n auxtrace_record_init function","Date":"Mon, 4 May 2026 20:43:20 +0530","Message-Id":"<20260504151321.12346-1-atrajeev@linux.ibm.com>","X-Mailer":"git-send-email 2.39.5 (Apple Git-154)","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-TM-AS-GCONF":"00","X-Proofpoint-Reinject":"loops=2 maxloops=12","X-Proofpoint-ORIG-GUID":"iLo4FBlXZTFexpenr-Z1FOO_JKBSAAdf","X-Proofpoint-GUID":"LgL2sFeULV6Dx3LSwXtiP8dXqu0polC6","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNTA0MDE1NCBTYWx0ZWRfX+VQA66onVwNg\n 6BVDVExLZLMUz2Cu32Cc+oXgLx87ZibEnDK67MPnZ/228mtisSmZVUh5xRhAkiyS242ZOUr05tu\n cH+rc81IZPD1KeVShyMrLesjuCDiNtCgfMHdMjtGmfRGKLdhpCUc7h2v+xlB0guWUzKtEE5lIvc\n 3HWGtyWQjdpQ26h9x2KMlJuszTl/CE8uT1Wjxjf91iT7ydv6J/kzw0Qy/dx5ZwrNwo56BUzqLK4\n 7IHHnzwSRRJz+D2O75toc+lO+CHUfO8CWVhXSE6G08LOwWnqHzic0AR7mOG2oV7PC2/gzcLOT94\n bUqBPEWOgfEtDmsAkmNxzQi8VPohwOgLwSrnitI+ZwN9fRSV3zg5CIqEqLbWWcRPxgN+2GDmmuW\n a1PxiNywgdaKbcsA5Mwzii9+TaVERwK/mHRUc07PX+GJ0EbmyFk+pp67TKkfpreKz4rFEiHBY3n\n NXXHbW4GA64KWAxhM5Q==","X-Authority-Analysis":"v=2.4 cv=UbFhjqSN c=1 sm=1 tr=0 ts=69f8b79f cx=c_pps\n a=bLidbwmWQ0KltjZqbj+ezA==:117 a=bLidbwmWQ0KltjZqbj+ezA==:17\n a=NGcC8JguVDcA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22\n a=U7nrCbtTmkRpXpFmAIza:22 a=QyXUC8HyAAAA:8 a=VnNF1IyMAAAA:8\n a=UYfmDeaf6v5XVjAx5qsA:9","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-05-04_05,2026-04-30_02,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n clxscore=1015 spamscore=0 lowpriorityscore=0 malwarescore=0 suspectscore=0\n adultscore=0 priorityscore=1501 bulkscore=0 phishscore=0 impostorscore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605040154","X-Spam-Status":"No, score=-0.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tRCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,\n\tSPF_PASS autolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"},"content":"perf trace record fails some cases in powerpc\n\n # ./perf test \"perf trace record and replay\"\n 128: perf trace record and replay : FAILED!\n\n # ./perf trace record sleep 1\n # echo $?\n 32\n\nThis is happening because of non-zero err value from\nauxtrace_record__init() function.\n\n static int record__auxtrace_init(struct record *rec)\n {\n int err;\n\n if ((rec->opts.auxtrace_snapshot_opts || rec->opts.auxtrace_sample_opts)\n && record__threads_enabled(rec)) {\n pr_err(\"AUX area tracing options are not available in parallel streaming mode.\\n\");\n return -EINVAL;\n }\n\n if (!rec->itr) {\n rec->itr = auxtrace_record__init(rec->evlist, &err);\n if (err)\n return err;\n }\n\nHere \"int err\" is not initialised. The code expects \"err\" to be set\nfrom auxtrace_record__init() function.\n\nUpdate auxtrace_record__init() in arch/powerpc/util/auxtrace.c to clear\nerr value in the beginning.\n\n- Clear err value in beginning of function. Any fail later will\nset appropriate return code to err.\n- Even if we haven't found any event for auxtrace, perf record\nshould continue for other events. NULL return\nwill indicate that there is no auxtrace record initialized.\n- Not having \"err\" set here will affect monitoring of other events\nalso because perf record will fail seeing random value in err.\n\nSet err to -EINVAL before invoking auxtrace_record__init() in\nbuiltin-record.c\n\nWith the fix,\n\n # ./perf trace record sleep 1\n [ perf record: Woken up 2 times to write data ]\n [ perf record: Captured and wrote 0.033 MB perf.data (228 samples) ]\n\nFixes: 1dbfaf94cf66 (\"perf powerpc: Add basic CONFIG_AUXTRACE support for VPA pmu on powerpc\")\nReviewed-by: Adrian Hunter \nSigned-off-by: Athira Rajeev \n---\nChangelog:\nv4:\nAdded Reviewed-by from Adrian\n\nv1 -> v2\nAddressed review comment from Adrian:\n- Set err to -EINVAL before invoking auxtrace_record__init() in\n builtin-record.c\n- Added kernel-doc to auxtrace_record__init() in tools/perf/util/auxtrace.c\nAddressed review comment from Namhyung:\n- Added fixes tag\n\n tools/perf/arch/powerpc/util/auxtrace.c | 6 ++++++\n tools/perf/builtin-record.c | 1 +\n 2 files changed, 7 insertions(+)","diff":"diff --git a/tools/perf/arch/powerpc/util/auxtrace.c b/tools/perf/arch/powerpc/util/auxtrace.c\nindex e39deff6c857..4600a1661b4f 100644\n--- a/tools/perf/arch/powerpc/util/auxtrace.c\n+++ b/tools/perf/arch/powerpc/util/auxtrace.c\n@@ -71,6 +71,12 @@ struct auxtrace_record *auxtrace_record__init(struct evlist *evlist,\n \tstruct evsel *pos;\n \tint found = 0;\n \n+\t/*\n+\t * Set err value to zero here. Any fail later\n+\t * will set appropriate return code to err.\n+\t */\n+\t*err = 0;\n+\n \tevlist__for_each_entry(evlist, pos) {\n \t\tif (strstarts(pos->name, \"vpa_dtl\")) {\n \t\t\tfound = 1;\ndiff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c\nindex 4a5eba498c02..708825747af5 100644\n--- a/tools/perf/builtin-record.c\n+++ b/tools/perf/builtin-record.c\n@@ -865,6 +865,7 @@ static int record__auxtrace_init(struct record *rec)\n \t}\n \n \tif (!rec->itr) {\n+\t\terr = -EINVAL;\n \t\trec->itr = auxtrace_record__init(rec->evlist, &err);\n \t\tif (err)\n \t\t\treturn err;\n","prefixes":["V5","1/2"]}