{"id":2232368,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2232368/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260504-qom-tests-v2-43-ef7e3dc94f7a@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260504-qom-tests-v2-43-ef7e3dc94f7a@redhat.com>","date":"2026-05-04T11:35:31","name":"[v2,43/46] target/riscv: use hash table as set for user_options","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"052605fe6ec29aecf340d7a3ef285ca02b97fb63","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.1/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260504-qom-tests-v2-43-ef7e3dc94f7a@redhat.com/mbox/","series":[{"id":502649,"url":"http://patchwork.ozlabs.org/api/1.1/series/502649/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502649","date":"2026-05-04T11:34:48","name":"Fix various QOM object life-cycle issues","version":2,"mbox":"http://patchwork.ozlabs.org/series/502649/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2232368/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2232368/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=FZYihoy/;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g8KTb1pdpz1y04\n\tfor ; Mon, 04 May 2026 21:40:51 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wJreN-0001kt-P9; Mon, 04 May 2026 07:39:47 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wJre6-0001Ri-Pj\n for qemu-devel@nongnu.org; Mon, 04 May 2026 07:39:38 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wJre2-0001Uh-Iq\n for qemu-devel@nongnu.org; Mon, 04 May 2026 07:39:29 -0400","from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-400-xqMvUuXYN42jy80Wv5BOOw-1; Mon,\n 04 May 2026 07:39:24 -0400","from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id CC6FF1956089\n for ; Mon, 4 May 2026 11:39:23 +0000 (UTC)","from localhost (unknown [10.44.24.4])\n by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 4FD4319560B1; Mon, 4 May 2026 11:39:21 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777894765;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=42hjY28IGCdulA5mo/QwK+Hh01CMs8vQW8q3n61V0m4=;\n b=FZYihoy/4Yp6deNS4UGUfkGaJOUJWtjMeVocutNPjAe7vgUid3OJ1/sKJYXs7Kv76KTujL\n MDQB+ao3UqfEFxy6uScIOCXiL2bnKanRmaey5sYHgbkTxCWyinvZa9ycJHuxvGYwYayoal\n f3aIxPGhjYlTjAEZ+HBrvPrqXZnWHiY=","X-MC-Unique":"xqMvUuXYN42jy80Wv5BOOw-1","X-Mimecast-MFC-AGG-ID":"xqMvUuXYN42jy80Wv5BOOw_1777894763","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Mon, 04 May 2026 15:35:31 +0400","Subject":"[PATCH v2 43/46] target/riscv: use hash table as set for user_options","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260504-qom-tests-v2-43-ef7e3dc94f7a@redhat.com>","References":"<20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com>","In-Reply-To":"<20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"armbru@redhat.com,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=4750;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=54UipZhX3LhBC9douJgP5Ilofu4C5/F+Xe5+6aIzMYI=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRuxC2J2JbOk0qhObiNeQTTAwuC0UuX9oUFc\n etWTpDay7OJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEbgAKCRDa6OEJdZac\n 5W8XD/9DTzLInq4OCKY5xexqCOK4vp6zvv0yfpoUyimFh18JfQF4B9B2xjMOkggs3jWxuGYsHyl\n iQNL5liQ5qQV93AWmKrYLiWMCNBSNozaUQuLFKAYuhxrIljNPVf9G98/UwqX8jWOxxTChFpVhel\n vU7OL8izw5F75bM/SOEElDM3SmyztH7YVkG2NQFlOOef+8VU6w3fcO0zfB7XE4Q9rHP5cz1tm4j\n 8onYn+h45mJ6k+Y00OBeeh4fgPDZiuDnoCON/dr2+5RlvREkckwm9mSKjcI6WPz143nxA8udo/t\n b9azjL/WfUTK7keQMdaEs+1NwUzwXMhGXWW6pBOixWcmu5inaYWtfPcSNygRyl8PWtlWmD7Cj3e\n 6zsw8OK48vXP2JgN/9srO11oB963oS1TVZNWXxf3hjxyApEgl+2KQRO4kir1V7/Ts+ABHCZBGQ7\n EfZ91c9RYf+fhk4NbPUIt8J5nzIhvKF7j2lpD8N9odyOUNGwX0y25tAdHbCbgEEA3nl1nzzj+sE\n St/mVI6rwbrywZJBdidAsIva/LkOeQIWPsq22J/WjSYjb56AMvrJzLvwRzFYobw6/5LbhKH46nB\n 8smdd+Uyb4A+FU5C7eKVLQQwNt2COG8SngoKZy0UVrcH7IL+BVJUlCBkI27ddsUZXkbBXz88kfz\n sW+ZbIkOnzbC0Wg==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.12","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"8","X-Spam_score":"0.8","X-Spam_bar":"/","X-Spam_report":"(0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"The values stored in user_options are never retrieved, only key\npresence is checked. Use g_hash_table_add() instead of\ng_hash_table_insert() and drop the unused value parameter.\n\nSigned-off-by: Marc-André Lureau \n---\n target/riscv/cpu.c | 32 +++++++++++++++-----------------\n 1 file changed, 15 insertions(+), 17 deletions(-)","diff":"diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c\nindex be9a3ac13e7..52b89e274f4 100644\n--- a/target/riscv/cpu.c\n+++ b/target/riscv/cpu.c\n@@ -60,11 +60,9 @@ bool riscv_cpu_is_32bit(RISCVCPU *cpu)\n return riscv_cpu_mxl(&cpu->env) == MXL_RV32;\n }\n \n-static void cpu_option_add_user_setting(RISCVCPU *cpu, const char *optname,\n- uint32_t value)\n+static void cpu_option_add_user_setting(RISCVCPU *cpu, const char *optname)\n {\n- g_hash_table_insert(cpu->user_options, (gpointer)optname,\n- GUINT_TO_POINTER(value));\n+ g_hash_table_add(cpu->user_options, (gpointer)optname);\n }\n \n bool riscv_cpu_option_set(RISCVCPU *cpu, const char *optname)\n@@ -1452,7 +1450,7 @@ static void prop_pmu_num_set(Object *obj, Visitor *v, const char *name,\n \n warn_report(\"\\\"pmu-num\\\" property is deprecated; use \\\"pmu-mask\\\"\");\n cpu->cfg.pmu_mask = pmu_mask;\n- cpu_option_add_user_setting(cpu, \"pmu-mask\", pmu_mask);\n+ cpu_option_add_user_setting(cpu, \"pmu-mask\");\n }\n \n static void prop_pmu_num_get(Object *obj, Visitor *v, const char *name,\n@@ -1494,7 +1492,7 @@ static void prop_pmu_mask_set(Object *obj, Visitor *v, const char *name,\n return;\n }\n \n- cpu_option_add_user_setting(cpu, name, value);\n+ cpu_option_add_user_setting(cpu, name);\n cpu->cfg.pmu_mask = value;\n }\n \n@@ -1526,7 +1524,7 @@ static void prop_mmu_set(Object *obj, Visitor *v, const char *name,\n return;\n }\n \n- cpu_option_add_user_setting(cpu, name, value);\n+ cpu_option_add_user_setting(cpu, name);\n cpu->cfg.mmu = value;\n }\n \n@@ -1558,7 +1556,7 @@ static void prop_pmp_set(Object *obj, Visitor *v, const char *name,\n return;\n }\n \n- cpu_option_add_user_setting(cpu, name, value);\n+ cpu_option_add_user_setting(cpu, name);\n cpu->cfg.pmp = value;\n }\n \n@@ -1598,7 +1596,7 @@ static void prop_num_pmp_regions_set(Object *obj, Visitor *v, const char *name,\n return;\n }\n \n- cpu_option_add_user_setting(cpu, name, value);\n+ cpu_option_add_user_setting(cpu, name);\n cpu->cfg.pmp_regions = value;\n }\n \n@@ -1636,7 +1634,7 @@ static void prop_pmp_granularity_set(Object *obj, Visitor *v, const char *name,\n return;\n }\n \n- cpu_option_add_user_setting(cpu, name, value);\n+ cpu_option_add_user_setting(cpu, name);\n cpu->cfg.pmp_granularity = value;\n }\n \n@@ -1709,7 +1707,7 @@ static void prop_priv_spec_set(Object *obj, Visitor *v, const char *name,\n return;\n }\n \n- cpu_option_add_user_setting(cpu, name, priv_version);\n+ cpu_option_add_user_setting(cpu, name);\n cpu->env.priv_ver = priv_version;\n }\n \n@@ -1743,7 +1741,7 @@ static void prop_vext_spec_set(Object *obj, Visitor *v, const char *name,\n return;\n }\n \n- cpu_option_add_user_setting(cpu, name, VEXT_VERSION_1_00_0);\n+ cpu_option_add_user_setting(cpu, name);\n cpu->env.vext_ver = VEXT_VERSION_1_00_0;\n }\n \n@@ -1786,7 +1784,7 @@ static void prop_vlen_set(Object *obj, Visitor *v, const char *name,\n return;\n }\n \n- cpu_option_add_user_setting(cpu, name, value);\n+ cpu_option_add_user_setting(cpu, name);\n cpu->cfg.vlenb = value >> 3;\n }\n \n@@ -1827,7 +1825,7 @@ static void prop_elen_set(Object *obj, Visitor *v, const char *name,\n return;\n }\n \n- cpu_option_add_user_setting(cpu, name, value);\n+ cpu_option_add_user_setting(cpu, name);\n cpu->cfg.elen = value;\n }\n \n@@ -1863,7 +1861,7 @@ static void prop_cbom_blksize_set(Object *obj, Visitor *v, const char *name,\n return;\n }\n \n- cpu_option_add_user_setting(cpu, name, value);\n+ cpu_option_add_user_setting(cpu, name);\n cpu->cfg.cbom_blocksize = value;\n }\n \n@@ -1899,7 +1897,7 @@ static void prop_cbop_blksize_set(Object *obj, Visitor *v, const char *name,\n return;\n }\n \n- cpu_option_add_user_setting(cpu, name, value);\n+ cpu_option_add_user_setting(cpu, name);\n cpu->cfg.cbop_blocksize = value;\n }\n \n@@ -1935,7 +1933,7 @@ static void prop_cboz_blksize_set(Object *obj, Visitor *v, const char *name,\n return;\n }\n \n- cpu_option_add_user_setting(cpu, name, value);\n+ cpu_option_add_user_setting(cpu, name);\n cpu->cfg.cboz_blocksize = value;\n }\n \n","prefixes":["v2","43/46"]}