{"id":2232359,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2232359/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260504-qom-tests-v2-31-ef7e3dc94f7a@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260504-qom-tests-v2-31-ef7e3dc94f7a@redhat.com>","date":"2026-05-04T11:35:19","name":"[v2,31/46] hw/i386/pc: free pcspk on finalization","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"a089512ad10636b67707fbff5771a9a575e4b6fa","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.1/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260504-qom-tests-v2-31-ef7e3dc94f7a@redhat.com/mbox/","series":[{"id":502649,"url":"http://patchwork.ozlabs.org/api/1.1/series/502649/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502649","date":"2026-05-04T11:34:48","name":"Fix various QOM object life-cycle issues","version":2,"mbox":"http://patchwork.ozlabs.org/series/502649/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2232359/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2232359/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=S1Ibgy0S;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g8KRn0D7Dz1yJV\n\tfor ; Mon, 04 May 2026 21:39:17 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wJrd1-00056J-2J; Mon, 04 May 2026 07:38:23 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wJrcx-0004bd-16\n for qemu-devel@nongnu.org; Mon, 04 May 2026 07:38:19 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wJrcv-0001AU-Al\n for qemu-devel@nongnu.org; Mon, 04 May 2026 07:38:18 -0400","from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-318-zvlHHODKOOG1f7_53V6GZg-1; Mon,\n 04 May 2026 07:38:15 -0400","from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 9409E1955F12\n for ; Mon, 4 May 2026 11:38:14 +0000 (UTC)","from localhost (unknown [10.44.24.4])\n by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 372461800480; Mon, 4 May 2026 11:38:12 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777894696;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=u94aymaMQos4Ok1FqE43DnNiM5L1ZW3yqR+cto55E4c=;\n b=S1Ibgy0SLLNBuTcNWJLyOVb4z3WWkzmzcfsNgd/YWSGuJfTjWflDA2US2BTG8pvYpPes6U\n wITNlOFxd6eIn5ESjCzwriimzdnVaHsimGQjpg3tdn4kiTQfBQmtjBM0YYGdRPcNSRQO8N\n f7BLerkPiu9krmL1/F137u4tC2CRihU=","X-MC-Unique":"zvlHHODKOOG1f7_53V6GZg-1","X-Mimecast-MFC-AGG-ID":"zvlHHODKOOG1f7_53V6GZg_1777894694","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Mon, 04 May 2026 15:35:19 +0400","Subject":"[PATCH v2 31/46] hw/i386/pc: free pcspk on finalization","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260504-qom-tests-v2-31-ef7e3dc94f7a@redhat.com>","References":"<20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com>","In-Reply-To":"<20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"armbru@redhat.com,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=1234;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=nx/Hm05PL6UbVe3ziRxkh2R3TZg6+6BhzI4zbHucfHg=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRtm7mN7Afu/0v0L3zWLhbBpXKAZusND8HOT\n VQpfdOuuieJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEbQAKCRDa6OEJdZac\n 5ReWEACLpjVlXaq/KPe5L00IqE6NJs6VX7jhxffAfw6cr73p9YC8IFL7VKMHyVAKLOEa3M8CNZH\n 3JvjxbDtEEyKXxYVWemhDTucRtDtAJBhPXyMUaMWd8F82CqFCxBC1dDJ38fVDMt/Vd+nFlvH3b+\n lpuWNG+HjIrmn5XgfFBxHVPLVQr4jAHTRSJTbVT/ZJup400f9voWmf5GMQr1+gW2P4H7eSP3K1H\n F3sBVz8hwEfTvzxd0dbPUOMZXQCoXP/sgSG1eMSnIhY8Z2ubaSRZvYeHvClmX6P5DzcL3pcJfpu\n L4UbqahC9JRTprHohCVStmTq5Cd7Ypi6DDzUHEXvJFVYEsiTOwkbRo8LwH1QMppUmMOjRR96ZcU\n 43uC2wNduII/qJL+q31eAcWwmoFftikgO6X3kP1jq9tCwkJNG535mjS0Kj4e4JptclLyOLB7dIg\n GbxusVrdYfy5yKP5ECAERAf/5vTqieIpj94ikOS+D+4fdbFGgs9BHujqjjM5pMaNXCGSbWtDlP0\n GN2zlLzQRiwRnJ90W27OoCr5lrkCb2vRgCnsufAHmMlWECMkozWGyl6uG7VrZ3FTgQfOB5fIR7a\n DIwNowhr9DrjOtbsSbGWLx5ELm42tA+XAhUzf4OKjl55l8NN+qJufYg2aGcw4ja6hLweBbvkQ3m\n x/+I5YujeOQhmUg==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.93","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"8","X-Spam_score":"0.8","X-Spam_bar":"/","X-Spam_report":"(0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Add pc_machine_finalize() to unref the pcspk device when it was never\nrealized. Once realized, the bus owns it and no action is needed.\n\nFixes: 6b8d1416482f (\"audio: create pcspk device early\")\nSigned-off-by: Marc-André Lureau \n---\n hw/i386/pc.c | 10 ++++++++++\n 1 file changed, 10 insertions(+)","diff":"diff --git a/hw/i386/pc.c b/hw/i386/pc.c\nindex 2ecad3c503f..7b6ad97e5a9 100644\n--- a/hw/i386/pc.c\n+++ b/hw/i386/pc.c\n@@ -1610,6 +1610,15 @@ static void pc_machine_initfn(Object *obj)\n }\n }\n \n+static void pc_machine_finalize(Object *obj)\n+{\n+ PCMachineState *pcms = PC_MACHINE(obj);\n+\n+ if (pcms->pcspk && !qdev_is_realized(DEVICE(pcms->pcspk))) {\n+ object_unref(OBJECT(pcms->pcspk));\n+ }\n+}\n+\n static void pc_machine_reset(MachineState *machine, ResetType type)\n {\n CPUState *cs;\n@@ -1748,6 +1757,7 @@ static const TypeInfo pc_machine_info = {\n .abstract = true,\n .instance_size = sizeof(PCMachineState),\n .instance_init = pc_machine_initfn,\n+ .instance_finalize = pc_machine_finalize,\n .class_size = sizeof(PCMachineClass),\n .class_init = pc_machine_class_init,\n .interfaces = (const InterfaceInfo[]) {\n","prefixes":["v2","31/46"]}