{"id":2232355,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2232355/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260504-qom-tests-v2-29-ef7e3dc94f7a@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260504-qom-tests-v2-29-ef7e3dc94f7a@redhat.com>","date":"2026-05-04T11:35:17","name":"[v2,29/46] accel/kvm: free device path on finalization","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"9fdf1eb2769fd6357c48d161cbcc3f2cb9fa0537","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.1/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260504-qom-tests-v2-29-ef7e3dc94f7a@redhat.com/mbox/","series":[{"id":502649,"url":"http://patchwork.ozlabs.org/api/1.1/series/502649/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502649","date":"2026-05-04T11:34:48","name":"Fix various QOM object life-cycle issues","version":2,"mbox":"http://patchwork.ozlabs.org/series/502649/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2232355/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2232355/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=Voal91GO;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g8KRG4kQnz1yJV\n\tfor ; Mon, 04 May 2026 21:38:50 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wJrcr-0003pG-O7; Mon, 04 May 2026 07:38:13 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wJrcn-0003Rw-PY\n for qemu-devel@nongnu.org; Mon, 04 May 2026 07:38:09 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wJrcm-00019E-6I\n for qemu-devel@nongnu.org; Mon, 04 May 2026 07:38:09 -0400","from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-294-J3WzS-EkPz6dGcGkuAukjA-1; Mon,\n 04 May 2026 07:38:04 -0400","from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id AC9BE1800348; Mon, 4 May 2026 11:38:03 +0000 (UTC)","from localhost (unknown [10.44.24.4])\n by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 55F951955D84; Mon, 4 May 2026 11:38:01 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777894687;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=xc4SYT3UnDMGDLgyYV/qbHsyXvfJpgId4SJTPvnG1QY=;\n b=Voal91GO1/1uKbf3xrIUQ1A4fSwJDuLerhJugPkA3AFc5hNu/V+zgjlncAF1OzLSTgoySE\n TqK87WYyfijZToMG27Haq9wPMUPKCRaGgA+IURtUx0EiCEx7ZWaJzLbWi0JNX8j74WsvL2\n llH0rf6T/Kz1u8fdSZIy7fPNdJEYScI=","X-MC-Unique":"J3WzS-EkPz6dGcGkuAukjA-1","X-Mimecast-MFC-AGG-ID":"J3WzS-EkPz6dGcGkuAukjA_1777894683","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Mon, 04 May 2026 15:35:17 +0400","Subject":"[PATCH v2 29/46] accel/kvm: free device path on finalization","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260504-qom-tests-v2-29-ef7e3dc94f7a@redhat.com>","References":"<20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com>","In-Reply-To":"<20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"armbru@redhat.com,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n Peter Maydell ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=1095;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=+3VxTolW7meb5x/gWd6Oe4Wp6U24+GJpNUhUzxlJdXM=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRtXo4gNvFN5HsiKYwHneoRWVXav8hTQaR9/\n EN2lVcNGwWJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEbQAKCRDa6OEJdZac\n 5ZBLD/sF0VqaziShcXG9xeWw77zl588M9pJcs/ZQYVWCQ/IlBXh6bm8n4cPzffKDtQ2gIiXl61L\n Jr4LMbhviar5ovhH2XAExwvFs9afnt8eUouzjp8SeXuyJP0YfBAFUv4TzVWf0ss3pNW/tAg7L8W\n 515m8v8/PJ5lesgjc1Nhq/J7iIWcaaCzU2cSY6SuwMcj3NQMcr6rW8UUfUvIoXBEpiH7c1ZW/ZV\n qnz6SzdjDGs7QObn4kfnCmbKSqPX21a7xHibrBfcJnzU6MkFoYGWQsTTHocJD3pzQQ1MaxZhLuY\n lSwdZ6V9u3Sl7Yu6Tdv67VU4m1pqlk97jsvqEkUwZA/PxllwpLko7g87kU8KQj0ty3epXf/XZ07\n /q5BUE9RucA/DClbHWmQ0Qkb7MfiN+Iauic9XmHlbZLW52mytAJGqT0ZUX2QmbAFJFFE2ADbhB7\n NLKx+SB1UHoMuYCMx4xW3+I7uFstuQQusPAsVWMRXxKtiFAbtwUvAFf1sIRI16rObmXGQ4GjTIn\n 2fVAj8PzTqeHVr9efIy8+uOeid87g/p26ioZJWvGAwBg7+Vk8IUxsDbdlUK3dqhRnoQCXSj/947\n gYhADucZ10I9ZlYiw2Vxkk3VdC0EHtwW89V339GzANaCA7dpi1DD1WBbgFos8tp93+aiSRvDxim\n IlRoC1M85MVVM9A==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.17","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-24","X-Spam_score":"-2.5","X-Spam_bar":"--","X-Spam_report":"(-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"kvm_set_device allocates device via g_strdup, but no\ninstance_finalize existed for the KVM accelerator type.\n\nFixes: aef158b093b9 (\"Add class property to configure KVM device node to use\")\nReviewed-by: Peter Maydell \nSigned-off-by: Marc-André Lureau \n---\n accel/kvm/kvm-all.c | 8 ++++++++\n 1 file changed, 8 insertions(+)","diff":"diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c\nindex 92af42503b1..96f90ebb240 100644\n--- a/accel/kvm/kvm-all.c\n+++ b/accel/kvm/kvm-all.c\n@@ -4342,10 +4342,18 @@ static void kvm_accel_class_init(ObjectClass *oc, const void *data)\n kvm_arch_accel_class_init(oc);\n }\n \n+static void kvm_accel_finalize(Object *obj)\n+{\n+ KVMState *s = KVM_STATE(obj);\n+\n+ g_free(s->device);\n+}\n+\n static const TypeInfo kvm_accel_type = {\n .name = TYPE_KVM_ACCEL,\n .parent = TYPE_ACCEL,\n .instance_init = kvm_accel_instance_init,\n+ .instance_finalize = kvm_accel_finalize,\n .class_init = kvm_accel_class_init,\n .instance_size = sizeof(KVMState),\n };\n","prefixes":["v2","29/46"]}