{"id":2232341,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2232341/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260504-qom-tests-v2-26-ef7e3dc94f7a@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260504-qom-tests-v2-26-ef7e3dc94f7a@redhat.com>","date":"2026-05-04T11:35:14","name":"[v2,26/46] net/can: free ifname on socketcan finalization","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"6b04fc6338e143fe7384a56ca409257dee637e9e","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.1/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260504-qom-tests-v2-26-ef7e3dc94f7a@redhat.com/mbox/","series":[{"id":502649,"url":"http://patchwork.ozlabs.org/api/1.1/series/502649/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502649","date":"2026-05-04T11:34:48","name":"Fix various QOM object life-cycle issues","version":2,"mbox":"http://patchwork.ozlabs.org/series/502649/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2232341/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2232341/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=HZif3JeQ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g8KQd1gp5z1yJV\n\tfor ; Mon, 04 May 2026 21:38:17 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wJrcl-00039M-V5; Mon, 04 May 2026 07:38:08 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wJrcY-0002Dh-Na\n for qemu-devel@nongnu.org; Mon, 04 May 2026 07:37:57 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wJrcV-00016G-6l\n for qemu-devel@nongnu.org; Mon, 04 May 2026 07:37:53 -0400","from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-652-HogCm4hkNRioY7Qz0HDcsQ-1; Mon,\n 04 May 2026 07:37:44 -0400","from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 5BD5118004AD; Mon, 4 May 2026 11:37:43 +0000 (UTC)","from localhost (unknown [10.44.24.4])\n by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 9843B180045E; Mon, 4 May 2026 11:37:41 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777894667;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=gVFopIo4aSSG9uooap2o+5uLHAWlxkdOp59XKcHx7rk=;\n b=HZif3JeQ1zs3KM8uNLb0JrV3QX47kvc4Q0j9fQco3nbXduwx8DqEX+tYaHMeNKkGixxRyT\n ADLBjudCvyIeM+QeZ5pCv4B6PYnlRBuzkKzWyG9pi8yP8MVdy4546d3Tdcd1h3sAKMuMVn\n ghrU/ltKNaaGKK+/QZjvMIKz67bHEq4=","X-MC-Unique":"HogCm4hkNRioY7Qz0HDcsQ-1","X-Mimecast-MFC-AGG-ID":"HogCm4hkNRioY7Qz0HDcsQ_1777894663","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Mon, 04 May 2026 15:35:14 +0400","Subject":"[PATCH v2 26/46] net/can: free ifname on socketcan finalization","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260504-qom-tests-v2-26-ef7e3dc94f7a@redhat.com>","References":"<20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com>","In-Reply-To":"<20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"armbru@redhat.com,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n Pavel Pisa ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=1201;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=Zz6LxsmODDv3AxwQF3PTITI8cMLmWmAnaqtuQzNPavQ=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRtP/pxDCUA7gzmwBBgDaAXf2tPzWjir9CVN\n mhXb5fLtfGJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEbQAKCRDa6OEJdZac\n 5aqZEACoc+x0pzK3+Ha3fErGfb03Im66Oig27xFf5Y6akdleok27fjDwFwSky5yfDpTvsXt8mmC\n LuwdwRs0mRqKovcPX7P/if68pxukbBPcx8GiRGoS6kryKapjh4ntRrn2D6r4Oe5AIsaPXpQgOk/\n b6V0LcCIPLv2E4O9pllHl96NGtxoGitiiKajVpTllqAMB7suMMa/vBnnHY/V+THQP/o9hbWR7sA\n 0AvBKfVKIJT1Wsb+I29yojnRR3aVDpdVLRorBGPF9+Q+aXiG3FBBaYweXyrF2R4iX0CXQptxlsn\n cBzY0aW0O5Q6SHbo70sdAoZij+irCqKNOKzWnOB1/RuECQNoXkYwBHaCHkden7+3k3xEOO2FKVD\n a/yaOTXRzlrRKfQLv1WgTVGPJVntBQ/zaS5PHQDcyTrc1HS16/uz8bt3Mx+H/LQX3evvGrhncdz\n YFTSqUx88oKDJFT0ZH3jXd5jDy5F6DS/hx8FUax0n+wZWQFLkMMAZ3+1kHLMFDDBXpp/0FzcAHH\n vYREhtL9SMqGVoLoEb73SH0e0hBChy1ChkZnYvFPUXlPW85J2Pugo2fkcNVEOuP0tlq716kzvQE\n 3Soa/KvrD9oggdpX9Y6MSSOxmSdinqSXRxCkB88L8bh/DMmeDrUKF7HpqfkgCKNeykjQhAXZ5N9\n onDFho4D8ihSSAA==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.111","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-24","X-Spam_score":"-2.5","X-Spam_bar":"--","X-Spam_report":"(-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"can_host_socketcan_set_if allocates ifname via g_strdup, but no\ninstance_finalize existed to free it.\n\nFixes: ea15ea8a7c67 (\"net/can: support for connecting to Linux host SocketCAN interface.\")\nAcked-by: Pavel Pisa \nSigned-off-by: Marc-André Lureau \n---\n net/can/can_socketcan.c | 8 ++++++++\n 1 file changed, 8 insertions(+)","diff":"diff --git a/net/can/can_socketcan.c b/net/can/can_socketcan.c\nindex 8a57ae07178..be67ed7f5a9 100644\n--- a/net/can/can_socketcan.c\n+++ b/net/can/can_socketcan.c\n@@ -319,11 +319,19 @@ static void can_host_socketcan_class_init(ObjectClass *klass,\n chc->disconnect = can_host_socketcan_disconnect;\n }\n \n+static void can_host_socketcan_finalize(Object *obj)\n+{\n+ CanHostSocketCAN *c = CAN_HOST_SOCKETCAN(obj);\n+\n+ g_free(c->ifname);\n+}\n+\n static const TypeInfo can_host_socketcan_info = {\n .parent = TYPE_CAN_HOST,\n .name = TYPE_CAN_HOST_SOCKETCAN,\n .instance_size = sizeof(CanHostSocketCAN),\n .instance_init = can_host_socketcan_instance_init,\n+ .instance_finalize = can_host_socketcan_finalize,\n .class_init = can_host_socketcan_class_init,\n };\n \n","prefixes":["v2","26/46"]}