{"id":2232340,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2232340/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260504-qom-tests-v2-17-ef7e3dc94f7a@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260504-qom-tests-v2-17-ef7e3dc94f7a@redhat.com>","date":"2026-05-04T11:35:05","name":"[v2,17/46] ui/console: remove console from global list on finalization","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"fe25e39b8a0eececddc2519646dcbab5352d281e","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.1/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260504-qom-tests-v2-17-ef7e3dc94f7a@redhat.com/mbox/","series":[{"id":502649,"url":"http://patchwork.ozlabs.org/api/1.1/series/502649/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502649","date":"2026-05-04T11:34:48","name":"Fix various QOM object life-cycle issues","version":2,"mbox":"http://patchwork.ozlabs.org/series/502649/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2232340/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2232340/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=SlHD6Zgt;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g8KQL2H11z1yJV\n\tfor ; Mon, 04 May 2026 21:38:02 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wJrc3-0001Ay-AH; Mon, 04 May 2026 07:37:25 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wJrbb-0000WV-QX\n for qemu-devel@nongnu.org; Mon, 04 May 2026 07:36:57 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wJrba-00011K-BR\n for qemu-devel@nongnu.org; Mon, 04 May 2026 07:36:55 -0400","from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-452-nCrX5OxGNl6fPPGtpfiS2Q-1; Mon,\n 04 May 2026 07:36:52 -0400","from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 5D4821800578\n for ; Mon, 4 May 2026 11:36:51 +0000 (UTC)","from localhost (unknown [10.44.24.4])\n by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 127FE19560A6; Mon, 4 May 2026 11:36:49 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777894613;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=tn0OCpP159HA+f6R+KQP0S44C9uWxut2R7clX9nuNXk=;\n b=SlHD6ZgtUZO2w6OoQnO/LScgHVhjPBWX2FZXFcLZmVabszpMYliTu9ybZp3ULa4lr4kY/B\n SGioiBXL8E4tLN4wxWZ4sm7iV8hCD2pf+WUZlc8s3ZGxmpL40o3b1A1BiWAD6TFoWCYKT0\n F9inb2bZDtaYEBk7anHGp58o29me7zU=","X-MC-Unique":"nCrX5OxGNl6fPPGtpfiS2Q-1","X-Mimecast-MFC-AGG-ID":"nCrX5OxGNl6fPPGtpfiS2Q_1777894611","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Mon, 04 May 2026 15:35:05 +0400","Subject":"[PATCH v2 17/46] ui/console: remove console from global list on\n finalization","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260504-qom-tests-v2-17-ef7e3dc94f7a@redhat.com>","References":"<20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com>","In-Reply-To":"<20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"armbru@redhat.com,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=1375;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=mcTfYn3iaVcXEtf37PXP/OHeHd23/2dVTmMNCHATXSw=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRsDmam5idYskbVhqMU75Wwoe6oS5IUKeUog\n mZkSoIx+uOJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEbAAKCRDa6OEJdZac\n 5bnKD/9x/MtQkRHJYXCgDOYTS7fOYJiRYwH+KP75H0e4shXK5aLXrow7IhNuSIBYWWVXKDs2dAY\n jWZhZb8g7qjZs10t5yTySq4u1Fr+wYNLOWbUm4L+hPJiywCmqx/aDMVWqVIaghwKJ/lHANtGMpi\n acYkOsxOBi8jGdGOGjTYAmgI0Hi3+B1jL+252xtscdGY5mbcERwuWqQVLCiDSIGyN8fg8mWg2Gg\n ojdkjej7MwgKNWvh+yL8NvcHQkWf22KRecpTvWngCLnnZY3MyOWIl4AotAqhmrNtUv66+b8bn6g\n /myeuLhjV44qALUapHkY/5iMA9l50BJSrfcU7BqD1nj7TOxWS6wW0Vsqe29ARx1p7YGONSx1AZQ\n uYRMluAY/r39tcEasxVdeleTu/phQSNf+H8IG3lmySn0aCB5wlfiZ1POUeHLhL1WAGUd+c8muX6\n v2c4WYoa4uOGU2e0Hk0bgM5O7qFtl2ONQ/EXNykuqTK5MgXJNbZZq8zw9VlwXttrBryQN048dqU\n mu3a2REcVPl9ILq0p2q2GlsM7DFeEIO6hXRgR7OGxedvXI+jEr7OUTITzWoOj6J7jgNdBURAQHN\n IjE83gWjL6wvF7d+7p0pNP/g1Oiimm6SzsTl+4Qh9QVRCMImZ15ZI9L1zI4KFt11IvNcIvp4zgy\n 0BoS2NNwYfvJWMA==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.12","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-24","X-Spam_score":"-2.5","X-Spam_bar":"--","X-Spam_report":"(-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"This commit removes the QemuConsole from the global \"consoles\" list when\nit is finalized, fixing use-after-free on throw-away objects.\n\nReproducer: QMP command qom-list-properties with typename\n\"qemu-text-console\", \"qemu-fixed-text-console\" or\n\"qemu-graphic-console\".\n\nThe assertions added ensure that `dcls`, `gl_block`, and the\n`dump_queue` are empty before removal, confirming the console is in a\nclean state. This is left to handle correctly in a future series for\nhot-unplug case.\n\nReported-by: Markus Armbruster \nSigned-off-by: Marc-André Lureau \n---\n ui/console.c | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)","diff":"diff --git a/ui/console.c b/ui/console.c\nindex 799d61ec1a5..2adffb6f04d 100644\n--- a/ui/console.c\n+++ b/ui/console.c\n@@ -390,10 +390,13 @@ qemu_console_finalize(Object *obj)\n {\n QemuConsole *c = QEMU_CONSOLE(obj);\n \n- /* TODO: check this code path, and unregister from consoles */\n+ /* TODO: fix hot-unplug support of consoles */\n+ assert(c->gl_block == 0);\n+ assert(qemu_co_queue_empty(&c->dump_queue));\n g_clear_pointer(&c->surface, qemu_free_displaysurface);\n g_clear_pointer(&c->gl_unblock_timer, timer_free);\n g_clear_pointer(&c->ui_timer, timer_free);\n+ QTAILQ_REMOVE(&consoles, c, next);\n }\n \n static void\n","prefixes":["v2","17/46"]}