{"id":2232338,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2232338/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260504-qom-tests-v2-3-ef7e3dc94f7a@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260504-qom-tests-v2-3-ef7e3dc94f7a@redhat.com>","date":"2026-05-04T11:34:51","name":"[v2,03/46] hw/pci-bridge: handle missing parent in prop_pxb_uid_get","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"b83177884f9cb7f9d6377e8e282a266b7ae7deec","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.1/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260504-qom-tests-v2-3-ef7e3dc94f7a@redhat.com/mbox/","series":[{"id":502649,"url":"http://patchwork.ozlabs.org/api/1.1/series/502649/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502649","date":"2026-05-04T11:34:48","name":"Fix various QOM object life-cycle issues","version":2,"mbox":"http://patchwork.ozlabs.org/series/502649/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2232338/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2232338/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=MhUWjgQ6;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g8KPh04Jxz1yKS\n\tfor ; Mon, 04 May 2026 21:37:28 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wJraM-0007W4-Qo; Mon, 04 May 2026 07:35:38 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wJraK-0007Vi-Uo\n for qemu-devel@nongnu.org; Mon, 04 May 2026 07:35:36 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wJraJ-0000n2-HW\n for qemu-devel@nongnu.org; Mon, 04 May 2026 07:35:36 -0400","from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-443-PbwEgQtUPgqRxd4yaUU3sg-1; Mon,\n 04 May 2026 07:35:33 -0400","from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id AD3051956094\n for ; Mon, 4 May 2026 11:35:32 +0000 (UTC)","from localhost (unknown [10.44.24.4])\n by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 9CC191955D84; Mon, 4 May 2026 11:35:31 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777894534;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=1bgLA9Zp+Jow51t/607ELa0KrzfqLyYWWcupN4GZiYQ=;\n b=MhUWjgQ67+duDdvxRfRjraAn4vm4wLtemQDf4uAzhNXgfrk7tuJdBfwLIeBgEBtlXUIIat\n c1SHQkeI9OH2V6BpPeOF8zHIB6A7be66INg1pz416G36G5HghKYQn6gZp23xW/VQtjdhZy\n 5Hr1UxYtqoD971+h63Gxx/s/gAY/WNU=","X-MC-Unique":"PbwEgQtUPgqRxd4yaUU3sg-1","X-Mimecast-MFC-AGG-ID":"PbwEgQtUPgqRxd4yaUU3sg_1777894533","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Mon, 04 May 2026 15:34:51 +0400","Subject":"[PATCH v2 03/46] hw/pci-bridge: handle missing parent in\n prop_pxb_uid_get","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260504-qom-tests-v2-3-ef7e3dc94f7a@redhat.com>","References":"<20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com>","In-Reply-To":"<20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"armbru@redhat.com,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=1195;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=mzt68/PqLMn279UizfyFsnOjTDYKE+7gRPi+R9njaM4=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRsckuSlnRVxucpGu4M0o1VGTtJdQeSBN24i\n 0JKwN1ohfOJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEbAAKCRDa6OEJdZac\n 5eaGEACcv47TTEn0QNkcSwsvf0I7AhjqGNBqwnrSqQpQa6H946t2+MD7BJ+v5vpxJYsS+f8l7JR\n Ip7W7cxPJQyqW4k3Xx26e2f6oeDeL5bbopzf7HJgfHQP1IitVsTOZFWimOvMTc5rKqSdd527X0n\n KGw9lBj+9ny2DNElw0Qaj8zAWeWUCSwvFuS/Imkivl3FpJPHrhyL8uNLDdbk2NPZeNmUu5HHq3l\n jpFRBSESPulgrKPhNeNuSN6+EI5VIWa7Ycp05tmCDjh1OO13Y4Q87pJH1bHteQbsp2pQ/O5F6iR\n /Jn+TeGIFSaK6ka8ZILlw0B4dVAMuENabn7vY2unPXMVPGm8mHR9M8cxHzwJG9/WBbwOUeKwTW5\n ejXD3hUh+MKbm8wMRIissX6LIJ8DAmVbYXjEpCPY2LBDRykFf9VO0gt4AGTZ+ft1ifCMEe/u4eV\n YGYF/ag+uUQlqqME6lGimHSN0NSXegxdyKybGtCkNX+EdNooPQE7LPacXIjAgPzUgewrMvIRdHj\n IrZauSvO99khd5vR+wgaxMUP3V0i3VXE1VvPzKDdmd5/JLU24SNSrdza6eNKEviAw0TSW1oCyrB\n As4yo5KckwFGH5/XEsUilQ3huA7t41W+3N7X1KuaS8pnybYyCj/Lw8mS+hUPvn1bjSIH4DGgBV9\n I/aUwA1g5O/HUKA==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.17","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"8","X-Spam_score":"0.8","X-Spam_bar":"/","X-Spam_report":"(0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"When called on an unrealized pxb bus (e.g. from\nqmp_qom_list_properties), bus->parent_dev is NULL. The pxb_bus_num()\ncallback dereferences it unconditionally. Check for this to avoid a\nNULL dereference.\n\nFixes: 97b9cb066e5f (\"hw/pci-bridge: Add acpi_uid property to TYPE_PXB_BUS\")\nSigned-off-by: Marc-André Lureau \n---\n hw/pci-bridge/pci_expander_bridge.c | 8 +++++++-\n 1 file changed, 7 insertions(+), 1 deletion(-)","diff":"diff --git a/hw/pci-bridge/pci_expander_bridge.c b/hw/pci-bridge/pci_expander_bridge.c\nindex 11623a5666f..40ffbc4e082 100644\n--- a/hw/pci-bridge/pci_expander_bridge.c\n+++ b/hw/pci-bridge/pci_expander_bridge.c\n@@ -85,8 +85,14 @@ static uint16_t pxb_bus_numa_node(PCIBus *bus)\n static void prop_pxb_uid_get(Object *obj, Visitor *v, const char *name,\n void *opaque, Error **errp)\n {\n- uint32_t uid = pci_bus_num(PCI_BUS(obj));\n+ PCIBus *bus = PCI_BUS(obj);\n+ uint32_t uid;\n \n+ if (!bus->parent_dev) {\n+ error_setg(errp, \"bus not attached to a device\");\n+ return;\n+ }\n+ uid = pci_bus_num(bus);\n visit_type_uint32(v, name, &uid, errp);\n }\n \n","prefixes":["v2","03/46"]}