{"id":2232335,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2232335/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260504-qom-tests-v2-12-ef7e3dc94f7a@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260504-qom-tests-v2-12-ef7e3dc94f7a@redhat.com>","date":"2026-05-04T11:35:00","name":"[v2,12/46] backends/cryptodev-lkcf: skip cleanup when not initialized","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"8304e232824148795c8dd7612e151120aa529ad5","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.1/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260504-qom-tests-v2-12-ef7e3dc94f7a@redhat.com/mbox/","series":[{"id":502649,"url":"http://patchwork.ozlabs.org/api/1.1/series/502649/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502649","date":"2026-05-04T11:34:48","name":"Fix various QOM object life-cycle issues","version":2,"mbox":"http://patchwork.ozlabs.org/series/502649/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2232335/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2232335/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=K7tYd2Z4;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g8KP51lLfz1yJV\n\tfor ; Mon, 04 May 2026 21:36:57 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wJrbU-0000BQ-N9; Mon, 04 May 2026 07:36:49 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wJrb9-00082u-K4\n for qemu-devel@nongnu.org; Mon, 04 May 2026 07:36:29 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wJrb8-0000vc-3U\n for qemu-devel@nongnu.org; Mon, 04 May 2026 07:36:27 -0400","from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-654-Pwc5-e1MNqSPd-zVpa3VCg-1; Mon,\n 04 May 2026 07:36:23 -0400","from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id EFF4E180034C\n for ; Mon, 4 May 2026 11:36:22 +0000 (UTC)","from localhost (unknown [10.44.24.4])\n by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id E9AE81800347; Mon, 4 May 2026 11:36:21 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777894585;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=Feyzoi72st3BK6uw08MumeJ0heMFM0ajonX0WOp0f0U=;\n b=K7tYd2Z4HGQPIIE1xRGRFRDCgGgU/2aEFLLhRDWysWlybHoNJZVEyX4jpeT1inK8LAhG6x\n 7TrNfoC88RqBcqHarbKa3x99PlrA/9DGP0Z44fxVBMviV9XSiMiWV8lsj/sLUQZZyiT8zt\n pXUpY5zbt3CQQYHg0e3Qg23gw68Z+CI=","X-MC-Unique":"Pwc5-e1MNqSPd-zVpa3VCg-1","X-Mimecast-MFC-AGG-ID":"Pwc5-e1MNqSPd-zVpa3VCg_1777894583","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Mon, 04 May 2026 15:35:00 +0400","Subject":"[PATCH v2 12/46] backends/cryptodev-lkcf: skip cleanup when not\n initialized","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260504-qom-tests-v2-12-ef7e3dc94f7a@redhat.com>","References":"<20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com>","In-Reply-To":"<20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"armbru@redhat.com,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=1186;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=XKESI/0DSqdUBTRFIDl2KEKlv25ZaJ+0o7RYfGRaK9M=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRsFkq5gFoGkhdtbX0XtTDFatKfr3ENADZrN\n KHIfiztfiCJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEbAAKCRDa6OEJdZac\n 5S6vD/0Qn/ePgQg1XfJ43ptN3E0NTKDPf8P2rc3lhhVr6HatnbxRMZyv3cckuT55Z5ls7sKtJSg\n AowLOFQHMGAr0NhjTmtH9x4TO0GdLxiH8PBdXFN9fKvEJvmmF9ajzOpcmuojb6/qs6Z9yuO9iV3\n SxOua5lZyXpQoMbWKZZsW+ooB+TzRqgk7D8WHFcYXbMVnPP/pcOraYRFBIcPQECoMYx6gffMeKF\n Xa7f8q6SuIOLH9U9/kATD+TAsaL9eIqr1UEiGM1Nkd8qDbBDHhmsmpyzXVO+hePrbhBJilhwdCh\n OFhWFz4zA9zRKwbCZMYWFRMaKi+/bPGUgvE5Uvlx3YtnmzuqCqhtVKSaM/RTl0I9HyqYSTNhCE9\n maQDKMkPQ0JkjEzrqc8hfQQKqJvRVi0OPN6VMSVVwZM9WYzdVlaXJdlGC7UF7+7tNr63QVQlAF3\n zn3bMPK0OYXv7qRiOovnfUchN8Y9M1b1h2zUuFXFTCsEDBZecBJnLZdGgHTOj4WvlJGrUdU1hqz\n 3duQ9I5nUm2AiQBq0oMy/NwntzQxnoRADqdBX0lM1yRdTxDqYTvsoq3v91qFJL36z7Khl+l1xLv\n Lu3z1KRTfDX+fIAFG9xoFKEp8xsiQMEooK/ZDJoRxqT8b70Ded8qf6drMh2rXAmmahN8gDKiGET\n bgUFotrBHM1hj0g==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.111","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-24","X-Spam_score":"-2.5","X-Spam_bar":"--","X-Spam_report":"(-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"cryptodev_lkcf_cleanup() locks a mutex that is only initialized\nduring the init vfunc (called at realize time). When the backend\nis destroyed without ever being realized, the mutex is uninitialized\nand the lock aborts.\n\nReturn early from cleanup when the backend was never started.\n\nNote: it looks like cryptodev init/cleanup callbacks should rather be\nregular complete/finalize overrides (calling the parent method).\n\nFixes: 39fff6f3e8b3 (\"cryptodev: Add a lkcf-backend for cryptodev\")\nSigned-off-by: Marc-André Lureau \n---\n backends/cryptodev-lkcf.c | 4 ++++\n 1 file changed, 4 insertions(+)","diff":"diff --git a/backends/cryptodev-lkcf.c b/backends/cryptodev-lkcf.c\nindex 40c7bd3c5a0..3fe29d3104c 100644\n--- a/backends/cryptodev-lkcf.c\n+++ b/backends/cryptodev-lkcf.c\n@@ -255,6 +255,10 @@ static void cryptodev_lkcf_cleanup(CryptoDevBackend *backend, Error **errp)\n CryptoDevBackendClient *cc;\n CryptoDevLKCFTask *task, *next;\n \n+ if (!cryptodev_backend_is_ready(backend)) {\n+ return;\n+ }\n+\n qemu_mutex_lock(&lkcf->mutex);\n lkcf->running = false;\n qemu_mutex_unlock(&lkcf->mutex);\n","prefixes":["v2","12/46"]}