{"id":2232333,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2232333/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260504-qom-tests-v2-10-ef7e3dc94f7a@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260504-qom-tests-v2-10-ef7e3dc94f7a@redhat.com>","date":"2026-05-04T11:34:58","name":"[v2,10/46] hw/intc/apic: move checks to realize()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"b2fe546b232f4a015e4fcc7197714bebf699f63d","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.1/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260504-qom-tests-v2-10-ef7e3dc94f7a@redhat.com/mbox/","series":[{"id":502649,"url":"http://patchwork.ozlabs.org/api/1.1/series/502649/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502649","date":"2026-05-04T11:34:48","name":"Fix various QOM object life-cycle issues","version":2,"mbox":"http://patchwork.ozlabs.org/series/502649/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2232333/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2232333/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=WBdzyYQS;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g8KP40GSBz1yKS\n\tfor ; Mon, 04 May 2026 21:36:56 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wJrbI-0008NE-6k; Mon, 04 May 2026 07:36:37 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wJrb2-0007oz-8J\n for qemu-devel@nongnu.org; Mon, 04 May 2026 07:36:22 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wJraz-0000v2-6x\n for qemu-devel@nongnu.org; Mon, 04 May 2026 07:36:19 -0400","from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-434-xDvQBCAQM1STPmBlb00yLw-1; Mon,\n 04 May 2026 07:36:13 -0400","from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 8EB311800473\n for ; Mon, 4 May 2026 11:36:12 +0000 (UTC)","from localhost (unknown [10.44.24.4])\n by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 458641955D84; Mon, 4 May 2026 11:36:10 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777894576;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=tzBsqml/dM6fWiSEjTcIGoL9jK84pwIUG7THdwR6FSc=;\n b=WBdzyYQSRpG4ZXVwjaDfQSXCHiAWJrd6SbkIGa0A92TO9jHFcHuE7jrZPKkiegAejKMWu6\n cFtlJ1kPGc7xwCZuvtwHS4jO7lYEVfFvkEm079fXd6YvJCmhSJPy7XHZbxKF8kBgmybpb4\n pEvTdmZmQiByEdQAANbU33ryl7up8GY=","X-MC-Unique":"xDvQBCAQM1STPmBlb00yLw-1","X-Mimecast-MFC-AGG-ID":"xDvQBCAQM1STPmBlb00yLw_1777894572","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Mon, 04 May 2026 15:34:58 +0400","Subject":"[PATCH v2 10/46] hw/intc/apic: move checks to realize()","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260504-qom-tests-v2-10-ef7e3dc94f7a@redhat.com>","References":"<20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com>","In-Reply-To":"<20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"armbru@redhat.com,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=2954;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=V/1REB7hPU3r4nVJQdLs+FCZBO0CucW41h7dOvCiAK8=;\n b=kA0DAAoB2ujhCXWWnOUByyZiAGn4hGzIPORZThbpGxpUr0ANHG0nhpVwWJ9c+X/SSwi4rpsGY\n YkCMwQAAQoAHRYhBIepvZM/h8YG0nb2Ldro4Ql1lpzlBQJp+IRsAAoJENro4Ql1lpzl7iIP/RpA\n Mj2HsuOXfqr66hJkiLvpWPwYVSC1Fiv3b5O7B43y2jtKkaU5OLNSvMo0bADgucmIkseS/g+1hbE\n WYnhjuTlsG07ckHNIFdoHHWHAuBa5bRmRmt/1Arp9EH0uKdmSSCyzO7EKWfyfgMWkmO5JT0eq9T\n lkyGfQ1hQS4HHwVfY1Ho02ne3dHPAhNtV+FEBkZXi46a0znR/pDFoVl/rEVCZSHY+G7WmBJDTC0\n l/pNOjtIr1Car0pvMENUVJ3hIr69ry3foYmqReEOlK8G1INf0JCIB+V1mJnCp5AZhMambCUIz8p\n eSGxQG912nqN5gjIiQ8EaFweGLbxytYddVkh7CHFq4VcT0gKFRIVw5did+X6H8RnlXR/tHrtFBP\n H6T5rXt65p7quO8hlRAERdZ/nHNmkL9CfD0TbC6tMhFfJKBO/hMveafm8h7rSc0wZ8CQwyhcyu1\n Sve8UDUQiqPuhLcuDWVFWadJFGL69lfGThcOuhHog3jZFbDKPihDl/iia8AYht1zm/71/kcrtJf\n NM2cDr2FIyXKkXG/vs/PEdANlSTA3p33Zkqz94UJWkLUzDNdhgMzkn8l9AOxd8RvgUjSOkuzT+j\n UzNEkF7a4ZN0Rhq9qVblC1A7S3uuXaLelpPPNAO0/mFqfjMWQFscRZFGPZDONtS1D7f1Tvlhzex\n 6xgRS","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.17","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-24","X-Spam_score":"-2.5","X-Spam_bar":"--","X-Spam_report":"(-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"apic_common_set_id() dereferences s->cpu to check for x2APIC support\nwhen the APIC ID is >= 255. On a standalone APIC object that has not\nbeen attached to a CPU, s->cpu is NULL, causing a segfault.\n\nTo solve this, move validation during realize().\n\nFixes: b5ee0468e9d2 (\"apic: add support for x2APIC mode\")\nSigned-off-by: Marc-André Lureau \n---\n hw/intc/apic_common.c | 23 +++++++++++++----------\n target/i386/cpu-apic.c | 6 +-----\n 2 files changed, 14 insertions(+), 15 deletions(-)","diff":"diff --git a/hw/intc/apic_common.c b/hw/intc/apic_common.c\nindex bf4abc21d7b..49c03a5bcee 100644\n--- a/hw/intc/apic_common.c\n+++ b/hw/intc/apic_common.c\n@@ -257,6 +257,19 @@ static void apic_common_realize(DeviceState *dev, Error **errp)\n static DeviceState *vapic;\n uint32_t instance_id = s->initial_apic_id;\n \n+ if (!s->cpu) {\n+ error_setg(errp, \"APIC is not attached to a CPU\");\n+ return;\n+ }\n+\n+ if (s->initial_apic_id >= 255 &&\n+ !cpu_has_x2apic_feature(&s->cpu->env)) {\n+ error_setg(errp, \"APIC ID %d requires x2APIC feature in CPU\",\n+ s->initial_apic_id);\n+ error_append_hint(errp, \"Try x2apic=on in -cpu.\\n\");\n+ return;\n+ }\n+\n /* Normally initial APIC ID should be no more than hundreds */\n assert(instance_id != VMSTATE_INSTANCE_ID_ANY);\n \n@@ -410,7 +423,6 @@ static void apic_common_set_id(Object *obj, Visitor *v, const char *name,\n APICCommonState *s = APIC_COMMON(obj);\n DeviceState *dev = DEVICE(obj);\n uint32_t value;\n- Error *local_err = NULL;\n \n if (dev->realized) {\n qdev_prop_set_after_realize(dev, name, errp);\n@@ -421,15 +433,6 @@ static void apic_common_set_id(Object *obj, Visitor *v, const char *name,\n return;\n }\n \n- if (value >= 255 && !cpu_has_x2apic_feature(&s->cpu->env)) {\n- error_setg(&local_err,\n- \"APIC ID %d requires x2APIC feature in CPU\",\n- value);\n- error_append_hint(&local_err, \"Try x2apic=on in -cpu.\\n\");\n- error_propagate(errp, local_err);\n- return;\n- }\n-\n s->initial_apic_id = value;\n s->id = (uint8_t)value;\n }\ndiff --git a/target/i386/cpu-apic.c b/target/i386/cpu-apic.c\nindex eaa10ad2a3d..f4f7f6b4d67 100644\n--- a/target/i386/cpu-apic.c\n+++ b/target/i386/cpu-apic.c\n@@ -57,11 +57,7 @@ void x86_cpu_apic_create(X86CPU *cpu, Error **errp)\n cpu->apic_state->cpu = cpu;\n cpu->apic_state->apicbase = APIC_DEFAULT_ADDRESS | MSR_IA32_APICBASE_ENABLE;\n \n- /*\n- * apic_common_set_id needs to check if the CPU has x2APIC\n- * feature in case APIC ID >= 255, so we need to set cpu->apic_state->cpu\n- * before setting APIC ID\n- */\n+ /* cpu must be set before realize, which validates the APIC ID */\n qdev_prop_set_uint32(DEVICE(cpu->apic_state), \"id\", cpu->apic_id);\n }\n \n","prefixes":["v2","10/46"]}