{"id":2231981,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2231981/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260501202438.376033-1-florian.fainelli@broadcom.com/","project":{"id":28,"url":"http://patchwork.ozlabs.org/api/1.1/projects/28/?format=json","name":"Linux PCI development","link_name":"linux-pci","list_id":"linux-pci.vger.kernel.org","list_email":"linux-pci@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260501202438.376033-1-florian.fainelli@broadcom.com>","date":"2026-05-01T20:24:38","name":"PCI: brcmstb: Assign pcie->gen from pcie_get_link_speed()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"4c937dfd87f2bea13ee3f0b7ec508fa027abdc53","submitter":{"id":68940,"url":"http://patchwork.ozlabs.org/api/1.1/people/68940/?format=json","name":"Florian Fainelli","email":"florian.fainelli@broadcom.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260501202438.376033-1-florian.fainelli@broadcom.com/mbox/","series":[{"id":502495,"url":"http://patchwork.ozlabs.org/api/1.1/series/502495/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/list/?series=502495","date":"2026-05-01T20:24:38","name":"PCI: brcmstb: Assign pcie->gen from pcie_get_link_speed()","version":1,"mbox":"http://patchwork.ozlabs.org/series/502495/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2231981/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2231981/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=broadcom.com header.i=@broadcom.com header.a=rsa-sha256\n header.s=dkimrelay header.b=iqtzmaeD;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-pci+bounces-53606-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com\n header.b=\"iqtzmaeD\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=192.19.144.207","smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=broadcom.com","smtp.subspace.kernel.org;\n spf=fail smtp.mailfrom=broadcom.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g6jQj0170z1yHZ\n\tfor ; Sat, 02 May 2026 06:32:44 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 582C830142AE\n\tfor ; Fri, 1 May 2026 20:32:20 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 96BFC421F01;\n\tFri, 1 May 2026 20:32:19 +0000 (UTC)","from relay.smtp-ext.broadcom.com (relay.smtp-ext.broadcom.com\n [192.19.144.207])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BEB435F610;\n\tFri, 1 May 2026 20:32:17 +0000 (UTC)","from mail-lvn-it-01.broadcom.com (mail-lvn-it-01.lvn.broadcom.net\n [10.36.132.253])\n\tby relay.smtp-ext.broadcom.com (Postfix) with ESMTP id AF029C011567;\n\tFri, 1 May 2026 13:24:43 -0700 (PDT)","from fainelli-desktop.igp.broadcom.net\n (fainelli-desktop.dhcp.broadcom.net [10.67.48.245])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby mail-lvn-it-01.broadcom.com (Postfix) with ESMTPSA id 49E2EB85;\n\tFri, 1 May 2026 13:24:43 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777667539; cv=none;\n b=D67WFKtWDWh8dKfK+N16vZ8RfJSCSLZ+/SsoYhX7xQ1Ji3ciJVzAdqFzv17zVQEY5ixq16FLF3h522abCI3+4IWW04Ya8pv+WizIWdqRg4fwse9VbpkYomGHNoSd2lwbtWELUSkpM6mPfHX9vzjRFEoQOMuAaRMG4CER79R1W7Y=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777667539; c=relaxed/simple;\n\tbh=U0cMOOEs8vuicbsDgb1uUaBP6prmFBje5WPlrU6/glI=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=ezpqhxOuUQuKnvGjtpkD3ngRzGb/ei7tuGdZz05dXn4cqy+k/g8GN4kOHcoZQSuMY9LaX97Uoh4VNapLrujLmW/xrAbaKibi//lhWi4D/V2dmRYlasFeRKXjGtdS2r5YWnLBDw8Lnz15LX5Jy0rkh8IA594hug5DKqsDusxlmM8=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=broadcom.com;\n spf=fail smtp.mailfrom=broadcom.com;\n dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com\n header.b=iqtzmaeD; arc=none smtp.client-ip=192.19.144.207","DKIM-Filter":"OpenDKIM Filter v2.11.0 relay.smtp-ext.broadcom.com AF029C011567","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n\ts=dkimrelay; t=1777667083;\n\tbh=U0cMOOEs8vuicbsDgb1uUaBP6prmFBje5WPlrU6/glI=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=iqtzmaeDc6muw48aUvqjppWJmf8yEKCnfGDrp3PgQl1jK8ZTw3TyJ498AuW7VaAXp\n\t AjtCMjLToOWrVWnL+USpPhkqn5j1Tkk/5FytTPkSFDDJAAJCizIzT6eH8TQvnc8+rv\n\t CkSxsMUOiefixYejTV2V9ksnsaTx+Gpmj3Rjk59g=","From":"Florian Fainelli ","To":"linux-pci@vger.kernel.org","Cc":"Florian Fainelli ,\n Dom Cobley , Phil Elwell ,\n Jim Quinlan ,\n Broadcom internal kernel review list ,\n Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84?=\n\t=?utf-8?q?ski?= ,\n Manivannan Sadhasivam , Rob Herring ,\n Bjorn Helgaas , Hans Zhang <18255117159@163.com>,\n linux-rpi-kernel@lists.infradead.org (moderated list:BROADCOM BCM2711/BCM2835\n ARM ARCHITECTURE),\n linux-arm-kernel@lists.infradead.org (moderated list:BROADCOM BCM2711/BCM2835\n ARM ARCHITECTURE), linux-kernel@vger.kernel.org (open list)","Subject":"[PATCH] PCI: brcmstb: Assign pcie->gen from pcie_get_link_speed()","Date":"Fri, 1 May 2026 13:24:38 -0700","Message-ID":"<20260501202438.376033-1-florian.fainelli@broadcom.com>","X-Mailer":"git-send-email 2.43.0","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"After commit 03f920936977 (\"PCI: controller: Validate max-link-speed\"),\npcie->gen stopped being assigned and as a result the established PCIe\nlink would stop supporting Gen3 speeds on 2712 since pcie->gen is used\nto populate LnkCntl2 and LnkCap in brcm_pcie_set_gen().\n\nLink: https://github.com/raspberrypi/linux/issues/7343\nReported-by: Dom Cobley \nReported-by: Phil Elwell \nFixes: 03f920936977 (\"PCI: controller: Validate max-link-speed\")\nSigned-off-by: Florian Fainelli \n---\n drivers/pci/controller/pcie-brcmstb.c | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)","diff":"diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c\nindex 714bcab97b60..6138fc4bc064 100644\n--- a/drivers/pci/controller/pcie-brcmstb.c\n+++ b/drivers/pci/controller/pcie-brcmstb.c\n@@ -2072,8 +2072,7 @@ static int brcm_pcie_probe(struct platform_device *pdev)\n \t\treturn PTR_ERR(pcie->clk);\n \n \tret = of_pci_get_max_link_speed(np);\n-\tif (pcie_get_link_speed(ret) == PCI_SPEED_UNKNOWN)\n-\t\tpcie->gen = 0;\n+\tpcie->gen = pcie_get_link_speed(ret);\n \n \tpcie->ssc = of_property_read_bool(np, \"brcm,enable-ssc\");\n \n","prefixes":[]}