{"id":2231904,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2231904/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260501145436.1327-1-atrajeev@linux.ibm.com/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/1.1/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/"},"msgid":"<20260501145436.1327-1-atrajeev@linux.ibm.com>","date":"2026-05-01T14:54:35","name":"[V2,1/2] powerpc tools perf: Initialize error code in auxtrace_record_init function","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"f4b8b1973afaea02837e2c67f4e6607b73bf2fd7","submitter":{"id":90290,"url":"http://patchwork.ozlabs.org/api/1.1/people/90290/?format=json","name":"Athira Rajeev","email":"atrajeev@linux.ibm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260501145436.1327-1-atrajeev@linux.ibm.com/mbox/","series":[{"id":502470,"url":"http://patchwork.ozlabs.org/api/1.1/series/502470/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=502470","date":"2026-05-01T14:54:35","name":"[V2,1/2] powerpc tools perf: Initialize error code in auxtrace_record_init function","version":2,"mbox":"http://patchwork.ozlabs.org/series/502470/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2231904/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2231904/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=SBYRZ9S3;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-20365-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=148.163.158.5","lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=SBYRZ9S3;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=linux.ibm.com\n (client-ip=148.163.158.5; helo=mx0b-001b2d01.pphosted.com;\n envelope-from=atrajeev@linux.ibm.com; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g6Ywz5FHmz1y04\n\tfor ; Sat, 02 May 2026 00:54:59 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4g6Ywy5Sr9z30CB;\n\tSat, 02 May 2026 00:54:58 +1000 (AEST)","from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com\n [148.163.158.5])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4g6Ywx477Pz309S\n\tfor ; Sat, 02 May 2026 00:54:56 +1000 (AEST)","from pps.filterd (m0356516.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 6415ZO4o3232750;\n\tFri, 1 May 2026 14:54:50 GMT","from ppma12.dal12v.mail.ibm.com\n (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220])\n\tby mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4drk1k39ej-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tFri, 01 May 2026 14:54:50 +0000 (GMT)","from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1])\n\tby ppma12.dal12v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id\n 641ErnDj015289;\n\tFri, 1 May 2026 14:54:49 GMT","from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230])\n\tby ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 4ds7xqr056-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tFri, 01 May 2026 14:54:49 +0000 (GMT)","from smtpav07.fra02v.mail.ibm.com (smtpav07.fra02v.mail.ibm.com\n [10.20.54.106])\n\tby smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 641EskPw27918840\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n\tFri, 1 May 2026 14:54:46 GMT","from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id F1B0420043;\n\tFri, 1 May 2026 14:54:45 +0000 (GMT)","from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 8013520040;\n\tFri, 1 May 2026 14:54:39 +0000 (GMT)","from localhost.localdomain (unknown [9.39.19.167])\n\tby smtpav07.fra02v.mail.ibm.com (Postfix) with ESMTP;\n\tFri, 1 May 2026 14:54:39 +0000 (GMT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1777647298;\n\tcv=none;\n b=VkUzWJvWHgbckpPxhXe5oGCBjhTfdDvmhFtXDM+yMIdZdiTfITelm7TqxoWhYXqYrjj4zIKCcJgIO4EoiR/V/UHxVpnRov3tEtYrvmqwSjv3Q3nNV5y9mY6sEm2Ukk1rQLq3k3ROLmRFuPcJyoddTiEIqVuo0dArlK8l/pAkdoerTVgYKhAoKnbezJXVe703ofqQPGoq0grcCPlp2HaGea/yEivQwoZOtYuQv4BPxTjmH/qPkXuDJVBxxtv1/hRdOJXb3f5kySJc4Hmu2gE52bCYZyg/SC37f2g1OIqYUgriULJvdWkTFZhw8e6mKXOi4Q4TjpiLBdKddvTeLnrF1A==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1777647298; c=relaxed/relaxed;\n\tbh=kuHqVdlej+Yn0HOXIpjPZZdn1xMOEqKbsgmm1UXRwMU=;\n\th=From:To:Cc:Subject:Date:Message-Id:MIME-Version;\n b=FZ0L0nBsfehXGjqAfNaERlqGVPJKXw/wq5YOInXopU+eEuVx/R0nBPEJdXeu+XKA8RCEMgZxmAr6ZVRIJtqDTV1B9hek99f1kNGz+uPuAihXVknyiPLWnsfCaVSkeG7CK+Ffx8ikqFOb9lDVtPD0orvHp3WhXT/5WLJaBowCpFIl7CJd/jo1JJIDK2PF74L/idt7tPiYU6u2GD9NLOh5WQyOdCZhpF6tABqjSg5Yeo/3PhzsTdEFMxY79kaeQnPY6owYUHjba0NAGH4HDIApbaF51bnPrB00lw+UeebbeD0AJykIDShHTs8KsxhM5JLmw8B4NwoZ/cxaxw1c8evNnw==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com;\n dkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=SBYRZ9S3; dkim-atps=neutral;\n spf=pass (client-ip=148.163.158.5; helo=mx0b-001b2d01.pphosted.com;\n envelope-from=atrajeev@linux.ibm.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=linux.ibm.com","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n\t:content-transfer-encoding:date:from:message-id:mime-version\n\t:subject:to; s=pp1; bh=kuHqVdlej+Yn0HOXIpjPZZdn1xMOEqKbsgmm1UXRw\n\tMU=; b=SBYRZ9S3cwCc+ijcXzzUkgUoDzR4d3nHzz9VHawxk6E8hBaY32/8yUWZJ\n\ticIR5Zizr8QMY7U8XHw7rScLDVD2zYaXmQXTZ7wAfJlO9Ml+iF07wtoP7Z3Lqas1\n\t1Rf/2LyZQq1wce+bM6YvLmRpU/KmAVDQKxVUxiz4Kc18D8VOy2IRW3MlSJjFBhoo\n\tCFG0GgUuqOwlNCMl+fB/uKjXz7LLsd0ZjXdWkdGWguQo5vMH7DhOFssVaSefeP6Z\n\t8ypDi1agFNiHBaZOODfhGWmr02OLsf0secMtfju1xAGFOipEVMBbUim1dsBsN8U0\n\tBnU4Ix9vl3o0sni/Y6HgHSOQQVISQ==","From":"Athira Rajeev ","To":"acme@kernel.org, jolsa@kernel.org, adrian.hunter@intel.com,\n mpetlan@redhat.com, tmricht@linux.ibm.com, maddy@linux.ibm.com,\n irogers@google.com, namhyung@kernel.org","Cc":"linux-perf-users@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,\n atrajeev@linux.ibm.com, hbathini@linux.vnet.ibm.com,\n Tejas.Manhas1@ibm.com, Tanushree.Shah@ibm.com, shivani@linux.ibm.com","Subject":"[PATCH V2 1/2] powerpc tools perf: Initialize error code in\n auxtrace_record_init function","Date":"Fri, 1 May 2026 20:24:35 +0530","Message-Id":"<20260501145436.1327-1-atrajeev@linux.ibm.com>","X-Mailer":"git-send-email 2.39.5 (Apple Git-154)","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-TM-AS-GCONF":"00","X-Proofpoint-Reinject":"loops=2 maxloops=12","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNTAxMDE0NCBTYWx0ZWRfXzw7Kyx3OOjLu\n GQeUXRnJ6nu6bW0s/Mykpu0fhIqoAC36qPa9GpWQ4ADRf/QJ5KcRCMiWlAEVOk+7fMVFHq55w05\n 2Kb660OGsup3VT00U7tkqsYtDD1hrCgEG6VE931M3C5zWWQshV6ux4mkHeLTpJjoztrBwh+1Z+w\n 5v4d9lNJYq7fhZn6GdWYZqotcaMDMSiIpaceepzdsFkzGabaZ+7ZTtmnXeMRny+16G77l45LZ+A\n UFlC8wZgy8tL4YppsA2mqFWyNWF1VQbzGDMV0qO6CSHbxfQqmI5It3+X20ZBImXrcv+4xyXgwz4\n P6sh9pyrBZo7jtj39V6QlI6rH1mFTJn+LNh+F3sD8JPQP48T1rW/IxNe47Gojc+QCBomStMPKaL\n xl23mu6GVCMEmX6cHgT7OlMIlVur1KQmU4T2U/8IrMJMZY5T5BFlrtsqQto2CbzhR8A54J7AP1M\n H/Gw2KqoxFv3vKUNJUw==","X-Proofpoint-GUID":"HIVe6_rP_G6RzeSe3zHGvRG6kq2VIf2S","X-Proofpoint-ORIG-GUID":"wYbumdJK_kxEKnTysEdaOU5mWy_afGsX","X-Authority-Analysis":"v=2.4 cv=MohiLWae c=1 sm=1 tr=0 ts=69f4beba cx=c_pps\n a=bLidbwmWQ0KltjZqbj+ezA==:117 a=bLidbwmWQ0KltjZqbj+ezA==:17\n a=NGcC8JguVDcA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22\n a=Y2IxJ9c9Rs8Kov3niI8_:22 a=VnNF1IyMAAAA:8 a=UYfmDeaf6v5XVjAx5qsA:9","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-05-01_04,2026-04-30_02,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n phishscore=0 adultscore=0 suspectscore=0 bulkscore=0 spamscore=0\n priorityscore=1501 malwarescore=0 clxscore=1015 lowpriorityscore=0\n impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc=\n route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000\n definitions=main-2605010144","X-Spam-Status":"No, score=-0.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tRCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,\n\tSPF_PASS autolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"},"content":"perf trace record fails some cases in powerpc\n\n # ./perf test \"perf trace record and replay\"\n 128: perf trace record and replay : FAILED!\n\n # ./perf trace record sleep 1\n # echo $?\n 32\n\nThis is happening because of non-zero err value from\nauxtrace_record__init() function.\n\n static int record__auxtrace_init(struct record *rec)\n {\n int err;\n\n if ((rec->opts.auxtrace_snapshot_opts || rec->opts.auxtrace_sample_opts)\n && record__threads_enabled(rec)) {\n pr_err(\"AUX area tracing options are not available in parallel streaming mode.\\n\");\n return -EINVAL;\n }\n\n if (!rec->itr) {\n rec->itr = auxtrace_record__init(rec->evlist, &err);\n if (err)\n return err;\n }\n\nHere \"int err\" is not initialised. The code expects \"err\" to be set\nfrom auxtrace_record__init() function.\n\nUpdate auxtrace_record__init() in arch/powerpc/util/auxtrace.c to clear\nerr value in the beginning.\n\n- Clear err value in beginning of function. Any fail later will\nset appropriate return code to err.\n- Even if we haven't found any event for auxtrace, perf record\nshould continue for other events. NULL return\nwill indicate that there is no auxtrace record initialized.\n- Not having \"err\" set here will affect monitoring of other events\nalso because perf record will fail seeing random value in err.\n\nSet err to -EINVAL before invoking auxtrace_record__init() in\nbuiltin-record.c\n\nWith the fix,\n\n # ./perf trace record sleep 1\n [ perf record: Woken up 2 times to write data ]\n [ perf record: Captured and wrote 0.033 MB perf.data (228 samples) ]\n\nFixes: 1dbfaf94cf66 (\"perf powerpc: Add basic CONFIG_AUXTRACE support for VPA pmu on powerpc\")\nSigned-off-by: Athira Rajeev \n---\nChangelog:\nv1 -> v2\nAddressed review comment from Adrian:\n- Set err to -EINVAL before invoking auxtrace_record__init() in\n builtin-record.c\n- Added kernel-doc to auxtrace_record__init() in tools/perf/util/auxtrace.c\nAddressed review comment from Namhyung:\n- Added fixes tag\n\n tools/perf/arch/powerpc/util/auxtrace.c | 6 ++++++\n tools/perf/builtin-record.c | 1 +\n 2 files changed, 7 insertions(+)","diff":"diff --git a/tools/perf/arch/powerpc/util/auxtrace.c b/tools/perf/arch/powerpc/util/auxtrace.c\nindex e39deff6c857..4600a1661b4f 100644\n--- a/tools/perf/arch/powerpc/util/auxtrace.c\n+++ b/tools/perf/arch/powerpc/util/auxtrace.c\n@@ -71,6 +71,12 @@ struct auxtrace_record *auxtrace_record__init(struct evlist *evlist,\n \tstruct evsel *pos;\n \tint found = 0;\n \n+\t/*\n+\t * Set err value to zero here. Any fail later\n+\t * will set appropriate return code to err.\n+\t */\n+\t*err = 0;\n+\n \tevlist__for_each_entry(evlist, pos) {\n \t\tif (strstarts(pos->name, \"vpa_dtl\")) {\n \t\t\tfound = 1;\ndiff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c\nindex 4a5eba498c02..708825747af5 100644\n--- a/tools/perf/builtin-record.c\n+++ b/tools/perf/builtin-record.c\n@@ -865,6 +865,7 @@ static int record__auxtrace_init(struct record *rec)\n \t}\n \n \tif (!rec->itr) {\n+\t\terr = -EINVAL;\n \t\trec->itr = auxtrace_record__init(rec->evlist, &err);\n \t\tif (err)\n \t\t\treturn err;\n","prefixes":["V2","1/2"]}