{"id":2231774,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2231774/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260501122237.296262-8-pablo@netfilter.org/","project":{"id":26,"url":"http://patchwork.ozlabs.org/api/1.1/projects/26/?format=json","name":"Netfilter Development","link_name":"netfilter-devel","list_id":"netfilter-devel.vger.kernel.org","list_email":"netfilter-devel@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260501122237.296262-8-pablo@netfilter.org>","date":"2026-05-01T12:22:30","name":"[net,07/14] netfilter: nf_tables: fix netdev hook allocation memleak with dormant tables","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"4ff484942d2970355302e62c3f43ef9894a50d58","submitter":{"id":1315,"url":"http://patchwork.ozlabs.org/api/1.1/people/1315/?format=json","name":"Pablo Neira Ayuso","email":"pablo@netfilter.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260501122237.296262-8-pablo@netfilter.org/mbox/","series":[{"id":502449,"url":"http://patchwork.ozlabs.org/api/1.1/series/502449/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/list/?series=502449","date":"2026-05-01T12:22:23","name":"[net,01/14] netfilter: replace skb_try_make_writable() by skb_ensure_writable()","version":1,"mbox":"http://patchwork.ozlabs.org/series/502449/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2231774/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2231774/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","netfilter-devel@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=netfilter.org header.i=@netfilter.org\n header.a=rsa-sha256 header.s=2025 header.b=sio3TbyT;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-12377-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=netfilter.org header.i=@netfilter.org\n header.b=\"sio3TbyT\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=217.70.190.124","smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=netfilter.org","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=netfilter.org"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g6Vbk25j1z1y04\n\tfor ; Fri, 01 May 2026 22:24:50 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id A1286303A87E\n\tfor ; Fri, 1 May 2026 12:22:55 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 68FFE39E193;\n\tFri, 1 May 2026 12:22:55 +0000 (UTC)","from mail.netfilter.org (mail.netfilter.org [217.70.190.124])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 8756F3A1E7F;\n\tFri, 1 May 2026 12:22:53 +0000 (UTC)","from localhost.localdomain (mail-agni [217.70.190.124])\n\tby mail.netfilter.org (Postfix) with ESMTPSA id 80FF560254;\n\tFri, 1 May 2026 14:22:51 +0200 (CEST)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777638175; cv=none;\n b=f86s9bncWY4Dv+r7/Fju8L1BDJGXpSScXglahy78eJGY/DjoDR4+IZ4m9m+rMabMPZaPlrZylcPMEdvuylgeYD12J8iCNUpp6MmcHxtmLWbF85p8TKIftZuDCfuGoU42tvlnfNfVfefgNddR+Y2pBGgsy+i9GOIowEPZbZAw178=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777638175; c=relaxed/simple;\n\tbh=7cVhC4mHuC0X7QDUWV7jjfBUkCP2haTgkhRBZrub6cg=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=N/UEEzPE237nvXdGbYY+0FTalrJO5Wol+K89pxSkAIHthor/WWy3yoR0KrGLynt7Y0EBcJ3nLzDmqtJ/iDBvTniTjP4E6Gg2RTq9LfPwonp8PUFsAwEOBSvcI1M9Sy6DsMdHdKuEnjx36uf8aS0XZElNYX7J7XF45pA5vSBupnQ=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=netfilter.org;\n spf=pass smtp.mailfrom=netfilter.org;\n dkim=pass (2048-bit key) header.d=netfilter.org header.i=@netfilter.org\n header.b=sio3TbyT; arc=none smtp.client-ip=217.70.190.124","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=netfilter.org;\n\ts=2025; t=1777638172;\n\tbh=hnkzbGd5HMf6I7DzRoyho73vMYVHs0QfInsJSnj6z3E=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=sio3TbyTUgXjXc5emWPBiHbcpzv3yWrhCuWvoh8wQ7e/SShb8scmSznYqv8gEgllj\n\t mMSozqBrN8paP80qY1afGuzthca8t2IARTIc4ZrsG2E8M7o5WSp+IxRlJe2yxPP9RU\n\t /jOsqZOqjo1Pdq2XGzwmEV2YsFwHOubmwsYupgDVzflZdmSbxjO46SC4iCuflu89zU\n\t Zp93itxBVyEyo/jVkoibCwn2+zae0EH9rzDGFUIrWPA9Mlcgj1gfPPMhBxjKD1T4eh\n\t llrvwKr8af5/PIBm9gEb24muQsF5WPdCT04x2/YDnNU9O++4LE0Yt11GOoJpWUjzjN\n\t NvFOWdqh4xxfw==","From":"Pablo Neira Ayuso ","To":"netfilter-devel@vger.kernel.org","Cc":"davem@davemloft.net,\n\tnetdev@vger.kernel.org,\n\tkuba@kernel.org,\n\tpabeni@redhat.com,\n\tedumazet@google.com,\n\tfw@strlen.de,\n\thorms@kernel.org","Subject":"[PATCH net 07/14] netfilter: nf_tables: fix netdev hook allocation\n memleak with dormant tables","Date":"Fri, 1 May 2026 14:22:30 +0200","Message-ID":"<20260501122237.296262-8-pablo@netfilter.org>","X-Mailer":"git-send-email 2.47.3","In-Reply-To":"<20260501122237.296262-1-pablo@netfilter.org>","References":"<20260501122237.296262-1-pablo@netfilter.org>","Precedence":"bulk","X-Mailing-List":"netfilter-devel@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"From: Florian Westphal \n\nsashiko says:\n could the related code in __nf_tables_abort() leak the struct nft_hook objects when the table is dormant?\n\n In __nf_tables_abort(), when rolling back a NEWCHAIN transaction that\n updates hooks, the code conditionally unregisters and frees the hooks only\n if the table is not dormant [..]\n if (!(table->flags & NFT_TABLE_F_DORMANT)) {\n nft_netdev_unregister_hooks(net,\n &nft_trans_chain_hooks(trans),\n true);\n }\n ...\n nft_trans_destroy(trans);\n\nUnfortunately netdev family mixes hook registration and allocation.\nPush table struct down and only check for the flag to unregister.\n\nFixes: 216e7bf7402c (\"netfilter: nf_tables: skip netdev hook unregistration if table is dormant\")\nSigned-off-by: Florian Westphal \nSigned-off-by: Pablo Neira Ayuso \n---\n net/netfilter/nf_tables_api.c | 34 ++++++++++++++++++++--------------\n 1 file changed, 20 insertions(+), 14 deletions(-)","diff":"diff --git a/net/netfilter/nf_tables_api.c b/net/netfilter/nf_tables_api.c\nindex 38e33c66c618..87387adbca65 100644\n--- a/net/netfilter/nf_tables_api.c\n+++ b/net/netfilter/nf_tables_api.c\n@@ -407,6 +407,7 @@ static void nft_netdev_unregister_trans_hook(struct net *net,\n }\n \n static void nft_netdev_unregister_hooks(struct net *net,\n+\t\t\t\t\tconst struct nft_table *table,\n \t\t\t\t\tstruct list_head *hook_list,\n \t\t\t\t\tbool release_netdev)\n {\n@@ -414,8 +415,10 @@ static void nft_netdev_unregister_hooks(struct net *net,\n \tstruct nf_hook_ops *ops;\n \n \tlist_for_each_entry_safe(hook, next, hook_list, list) {\n-\t\tlist_for_each_entry(ops, &hook->ops_list, list)\n-\t\t\tnf_unregister_net_hook(net, ops);\n+\t\tif (!(table->flags & NFT_TABLE_F_DORMANT)) {\n+\t\t\tlist_for_each_entry(ops, &hook->ops_list, list)\n+\t\t\t\tnf_unregister_net_hook(net, ops);\n+\t\t}\n \t\tif (release_netdev)\n \t\t\tnft_netdev_hook_unlink_free_rcu(hook);\n \t}\n@@ -452,20 +455,25 @@ static void __nf_tables_unregister_hook(struct net *net,\n \tstruct nft_base_chain *basechain;\n \tconst struct nf_hook_ops *ops;\n \n-\tif (table->flags & NFT_TABLE_F_DORMANT ||\n-\t !nft_is_base_chain(chain))\n+\tif (!nft_is_base_chain(chain))\n \t\treturn;\n \tbasechain = nft_base_chain(chain);\n \tops = &basechain->ops;\n \n+\t/* must also be called for dormant tables */\n+\tif (nft_base_chain_netdev(table->family, basechain->ops.hooknum)) {\n+\t\tnft_netdev_unregister_hooks(net, table, &basechain->hook_list,\n+\t\t\t\t\t release_netdev);\n+\t\treturn;\n+\t}\n+\n+\tif (table->flags & NFT_TABLE_F_DORMANT)\n+\t\treturn;\n+\n \tif (basechain->type->ops_unregister)\n \t\treturn basechain->type->ops_unregister(net, ops);\n \n-\tif (nft_base_chain_netdev(table->family, basechain->ops.hooknum))\n-\t\tnft_netdev_unregister_hooks(net, &basechain->hook_list,\n-\t\t\t\t\t release_netdev);\n-\telse\n-\t\tnf_unregister_net_hook(net, &basechain->ops);\n+\tnf_unregister_net_hook(net, &basechain->ops);\n }\n \n static void nf_tables_unregister_hook(struct net *net,\n@@ -11282,11 +11290,9 @@ static int __nf_tables_abort(struct net *net, enum nfnl_abort_action action)\n \t\t\tbreak;\n \t\tcase NFT_MSG_NEWCHAIN:\n \t\t\tif (nft_trans_chain_update(trans)) {\n-\t\t\t\tif (!(table->flags & NFT_TABLE_F_DORMANT)) {\n-\t\t\t\t\tnft_netdev_unregister_hooks(net,\n-\t\t\t\t\t\t\t\t &nft_trans_chain_hooks(trans),\n-\t\t\t\t\t\t\t\t true);\n-\t\t\t\t}\n+\t\t\t\tnft_netdev_unregister_hooks(net, table,\n+\t\t\t\t\t\t\t &nft_trans_chain_hooks(trans),\n+\t\t\t\t\t\t\t true);\n \t\t\t\tfree_percpu(nft_trans_chain_stats(trans));\n \t\t\t\tkfree(nft_trans_chain_name(trans));\n \t\t\t\tnft_trans_destroy(trans);\n","prefixes":["net","07/14"]}