{"id":2231766,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2231766/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260501115506.3792110-1-peter.maydell@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260501115506.3792110-1-peter.maydell@linaro.org>","date":"2026-05-01T11:55:06","name":"tests/functional/qemu_test/asset.py: Don't use setxattr when it doesn't exist","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"379d01829f88acbaad28d0aa9f3a35b1a2400b6a","submitter":{"id":5111,"url":"http://patchwork.ozlabs.org/api/1.1/people/5111/?format=json","name":"Peter Maydell","email":"peter.maydell@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260501115506.3792110-1-peter.maydell@linaro.org/mbox/","series":[{"id":502447,"url":"http://patchwork.ozlabs.org/api/1.1/series/502447/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502447","date":"2026-05-01T11:55:06","name":"tests/functional/qemu_test/asset.py: Don't use setxattr when it doesn't exist","version":1,"mbox":"http://patchwork.ozlabs.org/series/502447/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2231766/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2231766/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=YyPHegs8;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g6TyQ27xjz1xqf\n\tfor ; Fri, 01 May 2026 21:55:56 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wImSf-0006Jc-2Z; Fri, 01 May 2026 07:55:13 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wImSd-0006JQ-CK\n for qemu-devel@nongnu.org; Fri, 01 May 2026 07:55:11 -0400","from mail-wm1-x336.google.com ([2a00:1450:4864:20::336])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wImSb-0007sl-Ji\n for qemu-devel@nongnu.org; Fri, 01 May 2026 07:55:11 -0400","by mail-wm1-x336.google.com with SMTP id\n 5b1f17b1804b1-488a88aeec9so19159025e9.2\n for ; Fri, 01 May 2026 04:55:08 -0700 (PDT)","from lanath.. (wildly.archaic.org.uk. [81.2.115.145])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48a8fee325asm14374745e9.7.2026.05.01.04.55.06\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 01 May 2026 04:55:06 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777636507; x=1778241307; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=ri3eUcDTlecVfmcTVYau6OSqjmsbZRWYAoIVa4ILugU=;\n b=YyPHegs8wXTFBv7GERjFceFVVshsXUp9LnAAr9+AhLCtHiUWHB0P6dP3AFzXtP9Twj\n SQkSmrcItxsvVKtQkQOBfrZ1HdC8NztzWfNT21KJqRRAYhjgh/b5jrlEoGMAhEuDBjqk\n uIZze0iEcQ7UVLTvvtZ6F9hEkbgrD7cpZQ/bts7Lt28/IQoEW9d3rlOchYQZEBaimRD6\n Iae9NThNAkXH+kl/nr0xV1LTqi3FJ3e4tOWi19U7+uTRIk3RCWQFkYTrzSTfBQ2Euxd3\n kByen7eZ0PLrspRvkSWM3wyXDSwem7tBA/IdjjYuxhI7s7dChNAKoyAY1mHDPM8AJKy5\n xDVw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777636507; x=1778241307;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=ri3eUcDTlecVfmcTVYau6OSqjmsbZRWYAoIVa4ILugU=;\n b=MtyHBaDuYGmpBD5X3RZhYSvMImAjcsNcOoR1m1aObJanrynjLAPAh65gxAb9KyDqB3\n 2i2eLlemDVXvx10fxtM3/JcAif+x2TscbZM+kMR7aHKTX8LL1t0t3L6wvPzRqfQFQIE1\n wU0jKl2OdUlLUP4PkgKSeVpxaAde6nXC9WHZtmDLZnIzXkDB1NzrYBhNwiMq5LE/vOYF\n qjmdqUF2ePw1fNDdqO4vcUcLKF0iNH7FqHpSGMOCu756pCb8x8nLw0fP9olJZ0VZs6aJ\n PBLWbzGCfYLMyNgu/5a7WQ91PnpvNWF8HgilW4eV8VGToHM4EimtaqKkucL4SyD3x1aS\n TFmQ==","X-Gm-Message-State":"AOJu0YwPxXUyK8lA974oN90vdJ3Iw+kgudAMWCk0FidNQX29paDA4nVD\n 3fGGXHIY3Sp1rg1T5esnOwG8NMQG/BPj8/ea1vwxitfH9DL/lYdZMqnbE8RLaOe91nc5002I4G3\n ptMXZ","X-Gm-Gg":"AeBDiesYarVTIcCt0AWYjuRreZN6JI9Gr1ek23mcj6LpphsMTggFYkdPadqrsUa0E/9\n b/rhiwvibLFD8zv3jyOVuveGB2CTXCry3OBszCC0iLYkgRVRQYrtRfStp/7Y8t+jFpR7ZvNw7DU\n 0eFaf8F+g7BlfpzGK5Mqszm2Owx2uPwMkNHwyuCnhnhw85ycU+DgSvfKwDID8+okLGB6ihVQ8Gl\n lRgxZn6jwWIjGWbags/zZKCafiUEfU3FmYtnX9kojmZbAIGeVI+eQhaKuHrN7rMwkN7HzR3oLIv\n s+6BF5AIl4lHqE8bjV7ZGlWNPl1D3BzApr7HkHZ/paDu3MvkOm36v0e4fxx/9Fw95iYYJZGzUwN\n 52u5kfXEHEuqtY1KOyKhbpI8iur4QCCNBn6h7oqMxkC1TClVz2t+Oll30EDADwVj9UVuRZgQOat\n AfGwxH9eALmpEGOXPGLaqsZHRakyI+C9zI/lh2QyKCTzKNVtdGJ7lFAWgHYDPJ4kTbEh2KGRtOT\n x7BN/Bre2IPU5EBiVtTruYi82ByIJ7QRbt1wg3ZFw==","X-Received":"by 2002:a05:600c:83c5:b0:48a:5574:3a5b with SMTP id\n 5b1f17b1804b1-48a8eba3b09mr42874505e9.27.1777636507451;\n Fri, 01 May 2026 04:55:07 -0700 (PDT)","From":"Peter Maydell ","To":"qemu-devel@nongnu.org","Cc":"Thomas Huth , =?utf-8?q?Daniel_P=2E_Berrang?=\n\t=?utf-8?q?=C3=A9?= , =?utf-8?q?Philippe_Mathieu-Daud?=\n\t=?utf-8?q?=C3=A9?= ","Subject":"[PATCH] tests/functional/qemu_test/asset.py: Don't use setxattr when\n it doesn't exist","Date":"Fri, 1 May 2026 12:55:06 +0100","Message-ID":"<20260501115506.3792110-1-peter.maydell@linaro.org>","X-Mailer":"git-send-email 2.43.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::336;\n envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x336.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"The Python os.setxattr() API is Linux-specific, so trying to use\nit on other OSes triggers a failure:\n\n File \"/Users/pm215/src/qemu/tests/functional/qemu_test/asset.py\",\nline 227, in fetch\n os.setxattr(str(tmp_cache_file), \"user.qemu-asset-url\",\n ^^^^^^^^^^^\nAttributeError: module 'os' has no attribute 'setxattr'\n\nSince we only set the attributes here for informational\npurposes, skip them when os.setxattr() isn't available.\n\nCc: qemu-stable@nongnu.org\nFixes: 9903217a4ed013 (\"tests/functional: add a module for handling asset download & caching\")\nSigned-off-by: Peter Maydell \n---\n tests/functional/qemu_test/asset.py | 13 ++++++++-----\n 1 file changed, 8 insertions(+), 5 deletions(-)","diff":"diff --git a/tests/functional/qemu_test/asset.py b/tests/functional/qemu_test/asset.py\nindex 51a434b2b7..0abd89e0a3 100644\n--- a/tests/functional/qemu_test/asset.py\n+++ b/tests/functional/qemu_test/asset.py\n@@ -223,11 +223,14 @@ def fetch(self):\n raise AssetError(self, \"Download retries exceeded\", transient=True)\n \n try:\n- # Set these just for informational purposes\n- os.setxattr(str(tmp_cache_file), \"user.qemu-asset-url\",\n- self.url.encode('utf8'))\n- os.setxattr(str(tmp_cache_file), \"user.qemu-asset-hash\",\n- self.hash.encode('utf8'))\n+ # Set these just for informational purposes. Note that\n+ # setxattr is Linux-only; as this is only informational\n+ # we can simply skip it on other platforms.\n+ if hasattr(os, \"setxattr\"):\n+ os.setxattr(str(tmp_cache_file), \"user.qemu-asset-url\",\n+ self.url.encode('utf8'))\n+ os.setxattr(str(tmp_cache_file), \"user.qemu-asset-hash\",\n+ self.hash.encode('utf8'))\n except OSError as e:\n self.log.debug(\"Unable to set xattr on %s: %s\", tmp_cache_file, e)\n \n","prefixes":[]}