{"id":2231763,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2231763/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260501112023.338005-14-sprasad@microsoft.com/","project":{"id":12,"url":"http://patchwork.ozlabs.org/api/1.1/projects/12/?format=json","name":"Linux CIFS Client","link_name":"linux-cifs-client","list_id":"linux-cifs.vger.kernel.org","list_email":"linux-cifs@vger.kernel.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260501112023.338005-14-sprasad@microsoft.com>","date":"2026-05-01T11:20:17","name":"[v4,14/19] cifs: option to set unlimited number of cached dirs","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"021301991d8a9da154e4716779cc497ee017d143","submitter":{"id":79368,"url":"http://patchwork.ozlabs.org/api/1.1/people/79368/?format=json","name":"Shyam Prasad N","email":"nspmangalore@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260501112023.338005-14-sprasad@microsoft.com/mbox/","series":[{"id":502444,"url":"http://patchwork.ozlabs.org/api/1.1/series/502444/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/list/?series=502444","date":"2026-05-01T11:20:06","name":"[v4,01/19] cifs: change_conf needs to be called for session setup","version":4,"mbox":"http://patchwork.ozlabs.org/series/502444/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2231763/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2231763/checks/","tags":{},"headers":{"Return-Path":"\n <linux-cifs+bounces-11339-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-cifs@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=EiDqf00o;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-cifs+bounces-11339-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"EiDqf00o\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.210.178","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g6TSX3f0jz1yHZ\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 01 May 2026 21:33:32 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 442F630C4F7D\n\tfor <incoming@patchwork.ozlabs.org>; Fri,  1 May 2026 11:23:02 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 7E2A93A16AF;\n\tFri,  1 May 2026 11:20:49 +0000 (UTC)","from mail-pf1-f178.google.com (mail-pf1-f178.google.com\n [209.85.210.178])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 487D23A169A\n\tfor <linux-cifs@vger.kernel.org>; Fri,  1 May 2026 11:20:47 +0000 (UTC)","by mail-pf1-f178.google.com with SMTP id\n d2e1a72fcca58-82fbdd60b64so1357514b3a.3\n        for <linux-cifs@vger.kernel.org>;\n Fri, 01 May 2026 04:20:47 -0700 (PDT)","from sprasad-dev1.corp.microsoft.com ([167.220.110.216])\n        by smtp.gmail.com with ESMTPSA id\n d2e1a72fcca58-8351587db67sm2331922b3a.13.2026.05.01.04.20.45\n        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n        Fri, 01 May 2026 04:20:46 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777634449; cv=none;\n b=LBh7NqXel14EoJzOUysTnCAOHRrClJLlPQSuQISFf9/g1ORAXarnnrfyXT5tN5JnGPRix4ortXxCOwVs9iAOCCT12hAqittrLdxPBRkVlo4/Eb/7FOhWOiVka/9N636R2fDxchsU8nJS/xNluq2Iyf3K205cYH/g0nAuJZGIkCo=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777634449; c=relaxed/simple;\n\tbh=2VOV5tqwf3NFwCRY4AHpMHJQv246kLMl9Cpe8yfdGyM=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=nKVptmqtc5jIHl0lo1OMv27HTLmIcA9hSbZSFDdjjm6MyxXuuJqALYahdUqk7vZu2KKtiLu+kokYmd3BulcjAaBzxC9H58cE722MibLfSbBbmxorU2vRSUFuk1Ww/Il1Wnhpek48Z+62Z0/ueVv5trhfSK3hs8Ire1rtblfeMkM=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=EiDqf00o; arc=none smtp.client-ip=209.85.210.178","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n        d=gmail.com; s=20251104; t=1777634447; x=1778239247;\n darn=vger.kernel.org;\n        h=content-transfer-encoding:mime-version:references:in-reply-to\n         :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n         :message-id:reply-to;\n        bh=9o5H0O8dBnbcBaUn3Ic/j16+H1InseCGstPTG4iokWY=;\n        b=EiDqf00o9Av/SClE3IQo6u9InF4ZHFp5DQb67rtBCbjTomE8+uPFZq90XvgpbgNGD/\n         YawCJl/wt7rIdV+aU+PbYWV1z3FQxJRn9VwwXaICqrIrOuTxI5ZqqUwran5VJ38NEGrD\n         InuDdjO6FhazYwgkHUmLDDKzsjUOo6unZKMrU4+Twxe5JMHJq1YEKoPbr8jfFO9wKgeh\n         MS2/HFCHX+9WnZi1qjILZ0vk1TaRWfAOjnSQhP6ERmZNfKeW8iUafy1KNKB44J3+NrEy\n         UWwpe73VnpJ9OtIrFhpn6CD4ZPG3TST/qQhYwy8Srr3RUbfCFe6lXeCDSwKsjj0T5/9P\n         20Uw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n        d=1e100.net; s=20251104; t=1777634447; x=1778239247;\n        h=content-transfer-encoding:mime-version:references:in-reply-to\n         :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n         :to:cc:subject:date:message-id:reply-to;\n        bh=9o5H0O8dBnbcBaUn3Ic/j16+H1InseCGstPTG4iokWY=;\n        b=GiltptvJCJrwwGlE6Q6uriXYf3RAg98RMCFxh9MSKcMyC2HfM4AEWn1qk4owi4bVEy\n         mpd9alJBG8xhyxMzM2gs7lRPXg/6kS0fJ3sUb16zl8+C900vP2VvkP/ZAVMBZMM82NbQ\n         xHy6NruVeOZjMkL1AEsW8fDpI1BC02EqJbtUbXPakT0Ah6ldLlr2Fd1dzRzm+4+WR8KE\n         AyJULtg7JvnzEUZA3vGssHAOCJ/fd04wJPM+9fo0nHNtjkCR0LLyaO0djThcjpt8LfI3\n         KY4fj9vItDHCuOLZ3JzcrjTsb5bMEQPwwWnr1t7ksLDSQCTnn3vRL6deAsG11As8l0DR\n         2qPw==","X-Gm-Message-State":"AOJu0YyQTeAP/1Lwq3jK8h3VPuHSiVxQSTugiy9sF/KS15Ce/3MkM7S/\n\tmutKZE6+rQduUNzft5jGqWtvgY8MK6LVXk+24AQDT6RgT/URcW4UkTwmbQEp7BOIdbI=","X-Gm-Gg":"AeBDievuhULsrm2yzIx+DAKgdbbC+XQw135nCf2kDp8+yg8MOgUCoboZCheHLriDc23\n\t1QOSpIL4ttz5kxFtCP9iNd4ckSjo4YDCUHSq2A+lT+DoSbjTQe6DZfwonghqpIuBcwH+JSEX4OW\n\tqcwte02E9gIx6IGIqbkVtvfcKp8kxRmJelp/4EeAnKjOFVZG825KyqLEjP/uMTEyCPgAtSy3Iuy\n\tRjKwjIoILSadSryzCqmjA9HaaJDYXkQ27ZHfFYbO4mngU1dyPJ9BN5EgzUMJHcaqvi1RutMn72b\n\tqw5yGWojAwO286yMmhp1fNjO7VAagWv0ECSZ/6xxNAl1zPVwcHO/kutnFH82js5i4Exh4N7D2iR\n\tM7sj9hvva49A2cX3kbEFAUIM/2Iq1uaulm1xDDBA6hin58xQQLlMAN8TK8DhyDqf4F+hYq7LFIP\n\t3ylKteZpVPbl3/zJH0TNPww4p5XkGX/OSuHtCipn7MUxyhbLhSeISCnaT9W90YV1of","X-Received":"by 2002:a05:6a00:950c:b0:82f:721f:10ea with SMTP id\n d2e1a72fcca58-8351a308c24mr2877687b3a.18.1777634446899;\n        Fri, 01 May 2026 04:20:46 -0700 (PDT)","From":"nspmangalore@gmail.com","X-Google-Original-From":"sprasad@microsoft.com","To":"linux-cifs@vger.kernel.org,\n\tsmfrench@gmail.com,\n\tpc@manguebit.org,\n\tbharathsm@microsoft.com,\n\tdhowells@redhat.com,\n\thenrique.carvalho@suse.com,\n\tematsumiya@suse.de","Cc":"Shyam Prasad N <sprasad@microsoft.com>","Subject":"[PATCH v4 14/19] cifs: option to set unlimited number of cached dirs","Date":"Fri,  1 May 2026 16:50:17 +0530","Message-ID":"<20260501112023.338005-14-sprasad@microsoft.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260501112023.338005-1-sprasad@microsoft.com>","References":"<20260501112023.338005-1-sprasad@microsoft.com>","Precedence":"bulk","X-Mailing-List":"linux-cifs@vger.kernel.org","List-Id":"<linux-cifs.vger.kernel.org>","List-Subscribe":"<mailto:linux-cifs+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-cifs+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"From: Shyam Prasad N <sprasad@microsoft.com>\n\nToday we can control the number of cached dirs on the system using\nthe mount option max_cached_dirs. The default value is 16.\n\nThis change allows setting this option to a special value of 0,\nwhich means unlimited number of cached dirs. Shrinker can still\nevict the cached dirs.\n\nSigned-off-by: Shyam Prasad N <sprasad@microsoft.com>\n---\n fs/smb/client/cached_dir.c |  2 +-\n fs/smb/client/fs_context.c | 10 +++++-----\n 2 files changed, 6 insertions(+), 6 deletions(-)","diff":"diff --git a/fs/smb/client/cached_dir.c b/fs/smb/client/cached_dir.c\nindex 7cfbe50db66f5..863b8d666ea95 100644\n--- a/fs/smb/client/cached_dir.c\n+++ b/fs/smb/client/cached_dir.c\n@@ -1256,7 +1256,7 @@ static struct cached_fid *find_or_create_cached_dir(struct cached_fids *cfids,\n \tif (lookup_only) {\n \t\treturn NULL;\n \t}\n-\tif (cfids->num_entries >= max_cached_dirs) {\n+\tif (max_cached_dirs && cfids->num_entries >= max_cached_dirs) {\n \t\treturn NULL;\n \t}\n \tcfid = init_cached_dir(path);\ndiff --git a/fs/smb/client/fs_context.c b/fs/smb/client/fs_context.c\nindex a46764c247107..3eff94df70d45 100644\n--- a/fs/smb/client/fs_context.c\n+++ b/fs/smb/client/fs_context.c\n@@ -1493,12 +1493,12 @@ static int smb3_fs_context_parse_param(struct fs_context *fc,\n \t\tctx->max_channels = result.uint_32;\n \t\tbreak;\n \tcase Opt_max_cached_dirs:\n-\t\tif (result.uint_32 < 1) {\n-\t\t\tcifs_errorf(fc, \"%s: Invalid max_cached_dirs, needs to be 1 or more\\n\",\n-\t\t\t\t    __func__);\n-\t\t\tgoto cifs_parse_mount_err;\n+\t\tif (result.uint_32 > 0) {\n+\t\t\tctx->max_cached_dirs = result.uint_32;\n+\t\t} else {\n+\t\t\t/* 0 means unlimited */\n+\t\t\tctx->max_cached_dirs = 0;\n \t\t}\n-\t\tctx->max_cached_dirs = result.uint_32;\n \t\tbreak;\n \tcase Opt_handletimeout:\n \t\tctx->handle_timeout = result.uint_32;\n","prefixes":["v4","14/19"]}