{"id":2231755,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2231755/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260501112023.338005-13-sprasad@microsoft.com/","project":{"id":12,"url":"http://patchwork.ozlabs.org/api/1.1/projects/12/?format=json","name":"Linux CIFS Client","link_name":"linux-cifs-client","list_id":"linux-cifs.vger.kernel.org","list_email":"linux-cifs@vger.kernel.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260501112023.338005-13-sprasad@microsoft.com>","date":"2026-05-01T11:20:16","name":"[v4,13/19] cifs: option to disable time-based eviction of cache","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"2d4d3d001b83b63086d10ee79705072b89b8f278","submitter":{"id":79368,"url":"http://patchwork.ozlabs.org/api/1.1/people/79368/?format=json","name":"Shyam Prasad N","email":"nspmangalore@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260501112023.338005-13-sprasad@microsoft.com/mbox/","series":[{"id":502444,"url":"http://patchwork.ozlabs.org/api/1.1/series/502444/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/list/?series=502444","date":"2026-05-01T11:20:06","name":"[v4,01/19] cifs: change_conf needs to be called for session setup","version":4,"mbox":"http://patchwork.ozlabs.org/series/502444/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2231755/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2231755/checks/","tags":{},"headers":{"Return-Path":"\n <linux-cifs+bounces-11338-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-cifs@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=e1jxpDE4;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-cifs+bounces-11338-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"e1jxpDE4\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.210.177","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g6TLS4nvCz1xqf\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 01 May 2026 21:28:16 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id A24DA3022046\n\tfor <incoming@patchwork.ozlabs.org>; Fri,  1 May 2026 11:23:00 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 7FFD23A6F15;\n\tFri,  1 May 2026 11:20:48 +0000 (UTC)","from mail-pf1-f177.google.com (mail-pf1-f177.google.com\n [209.85.210.177])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 398423A0E84\n\tfor <linux-cifs@vger.kernel.org>; Fri,  1 May 2026 11:20:47 +0000 (UTC)","by mail-pf1-f177.google.com with SMTP id\n d2e1a72fcca58-82f33d28c1dso1055690b3a.3\n        for <linux-cifs@vger.kernel.org>;\n Fri, 01 May 2026 04:20:47 -0700 (PDT)","from sprasad-dev1.corp.microsoft.com ([167.220.110.216])\n        by smtp.gmail.com with ESMTPSA id\n d2e1a72fcca58-8351587db67sm2331922b3a.13.2026.05.01.04.20.44\n        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n        Fri, 01 May 2026 04:20:45 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777634448; cv=none;\n b=fe0baJUBdPgdBEK7uS6iH3/07yVE7tSMJ4SAuyXXafD3+INEGmsGV/W6mBU2Pgtr83qzhRL09DAfOYtH6FTonaofkLN49agchhtVPVhToJQaum0BCnaMacWO/dXy9ulu6hCvcxvR7JFTe3w6gIqXfzO/XyTujem2njS0g1Fh/qg=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777634448; c=relaxed/simple;\n\tbh=9v6XO9ylEL8LwjPW3xmhI3J94s+qIyMUgsSxkjgdOXk=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=dYkPqL+HifKfk3lTWjtBmb1EOS+8znJs33YdwQSuvKyDBP0aEcHi8hZ0ZIVt6WAUbl+7uIPRClWyHhFV86c925tItLiwvb6sB0FngzPKTHwKSfN6ECKbXnx3qkxd0nD4TfnBSe6fvUbXtrme/TixO7M9dJDyrly8y5KRovWSVkc=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=e1jxpDE4; arc=none smtp.client-ip=209.85.210.177","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n        d=gmail.com; s=20251104; t=1777634446; x=1778239246;\n darn=vger.kernel.org;\n        h=content-transfer-encoding:mime-version:references:in-reply-to\n         :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n         :message-id:reply-to;\n        bh=go18YIiEwWbQ57FroEFcnRyZ9WBWa63cQdoyTHIy0po=;\n        b=e1jxpDE4ykO2BPchcB7mYRiNmBcbJoLXw5IVg5tLBczFhxtQsBOXLwXFu69FmjY6Tk\n         Uqe5HTwJB4cUczDaVApn0iYc2j73zO3JnimateJJBmSxZBcsbvciKOK/8SF4ha0k0qi0\n         qVYTsvk0ranbW8TjgivZhpd2cVjhnQDv0RdxBwyFiErYr027wt9/QXrihmzuylC/P/s0\n         g3lRITgTzw2hvpNJJ6JKgGsX5S/EG8vOMd5iH8PC0ZJvQ0mMulx/qdyBunK03HH/dl9l\n         JEh0TXfdcejNXXRF4VjpxeL6OqdagpT7q7Ci2eGkrsyThBFukOTWkEzx2hXnXJC7bAIy\n         LsCw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n        d=1e100.net; s=20251104; t=1777634446; x=1778239246;\n        h=content-transfer-encoding:mime-version:references:in-reply-to\n         :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n         :to:cc:subject:date:message-id:reply-to;\n        bh=go18YIiEwWbQ57FroEFcnRyZ9WBWa63cQdoyTHIy0po=;\n        b=o9Jl/su9a+doYxDwU5Ia1/Ixo1+BXDD6E2JRSaWPDXSUse3sAWqRbgwWCBehtNqeev\n         7LBB9IfxpwOtpMfKnUrDvkxm2fE53qmDSpfYV2rXJcA3hB6xT/BS8FWxtrq6eF3mXiYz\n         FIw8QwUBgGrpRUhI3yXxPZPr6zkSyv7gWbJIUfWs4fTEWBCYWn8v2lhDM8NcZ1vBBH+v\n         SMz49HnZ1zg2JS2Smqo4G7JxMAucxpp9TyGjdscM0MrsCQ3UihlCtV2XcxiZXwlGoQ1D\n         BJrtduLHc8J6iQPfnG15dacG7xpSAAuzepPzopoUyVTRg6w1/JDd12zCxL13uh+T1OKp\n         edNA==","X-Gm-Message-State":"AOJu0YxGTWEpk52tDhVUlHcbzsL9aKceNC0SbwimdRMeafUKv5PFLhRZ\n\t68I8rQy7Xt+51Xy2p/a8uMIGSgFMlnx0B15l60XtUjs8cbVi5yoT+Lzze4c+9mdh4MY=","X-Gm-Gg":"AeBDieuApRLr5yZhPeDqqcxHD12mT18MuhwiJqRq0JAGdeVH38Yq4RIvl55vBEpkUvf\n\tJTq3IFAXZ10aYsjQY44Xw+atKmouF7nNWifHr5GzWNNUmeJ1/4farckwGbZRtpQGRU8k9cmpk+0\n\t8nb9o7Whi7eTPNXvBsiiiAFr//cDgnqAzqy8AKwF0xNRIo6AobUOiiA1tIp0sotPrRgcXOwdRig\n\tlRCJs2HQXs0omekflTd9Mlx6ZTd5bq/FxMHZryfcDq21DkFI44BcWddMzhKwq47nNZ2zqNZ9ozX\n\tFlBiqKO0XQV/reIi3WyXuonA7DK/BopDcfe0O2S+/dKwUssgINb76zScgi71G0FvVK4WX8wKJoI\n\tbqAiJrdPlzX6FU38sNb8FSchDZyfYHfFdokucPbrDHvOY5ApJF411pFGhfCipUb/LOsf4nPo1Xu\n\tgQ670l1GiK1Gakyg9rPRsnxx2lEDjTcC/RI+m5KbuX1CHg+4xc6mIHOzT95Ohr5qQqnJdxtT1D2\n\tw0=","X-Received":"by 2002:a05:6a00:21d4:b0:82c:e816:4135 with SMTP id\n d2e1a72fcca58-8351a659d4fmr2697730b3a.47.1777634445805;\n        Fri, 01 May 2026 04:20:45 -0700 (PDT)","From":"nspmangalore@gmail.com","X-Google-Original-From":"sprasad@microsoft.com","To":"linux-cifs@vger.kernel.org,\n\tsmfrench@gmail.com,\n\tpc@manguebit.org,\n\tbharathsm@microsoft.com,\n\tdhowells@redhat.com,\n\thenrique.carvalho@suse.com,\n\tematsumiya@suse.de","Cc":"Shyam Prasad N <sprasad@microsoft.com>","Subject":"[PATCH v4 13/19] cifs: option to disable time-based eviction of cache","Date":"Fri,  1 May 2026 16:50:16 +0530","Message-ID":"<20260501112023.338005-13-sprasad@microsoft.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260501112023.338005-1-sprasad@microsoft.com>","References":"<20260501112023.338005-1-sprasad@microsoft.com>","Precedence":"bulk","X-Mailing-List":"linux-cifs@vger.kernel.org","List-Id":"<linux-cifs.vger.kernel.org>","List-Subscribe":"<mailto:linux-cifs+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-cifs+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"From: Shyam Prasad N <sprasad@microsoft.com>\n\nToday there is no way to disable time-based eviction of dir cache.\ndir_cache_timeout = 0 meant immediate free up of dir cache on next\nlaundromat scan. We already have nohandlecache to disable dir cache.\n\nThis changes the meaning of dir_cache_timeout = 0 to mean unlimited\ntimeout. Shrinker-based eviction is still possible.\n\nSigned-off-by: Shyam Prasad N <sprasad@microsoft.com>\n---\n fs/smb/client/cifsfs.c  | 2 +-\n fs/smb/client/connect.c | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/fs/smb/client/cifsfs.c b/fs/smb/client/cifsfs.c\nindex ee5de358e27f8..79a6a4c297ee3 100644\n--- a/fs/smb/client/cifsfs.c\n+++ b/fs/smb/client/cifsfs.c\n@@ -121,7 +121,7 @@ MODULE_PARM_DESC(cifs_max_pending, \"Simultaneous requests to server for \"\n unsigned int dir_cache_timeout = 30;\n module_param(dir_cache_timeout, uint, 0644);\n MODULE_PARM_DESC(dir_cache_timeout, \"Number of seconds to cache directory contents for which we have a lease. Default: 30 \"\n-\t\t\t\t \"Range: 1 to 65000 seconds, 0 to disable caching dir contents\");\n+\t\t\t\t \"Range: 0 to 65000 seconds. 0 disables timeout-based cleanup (cached dirs persist until explicitly invalidated).\");\n /* Module-wide total cached dirents (in bytes) across all tcons */\n atomic64_t cifs_dircache_bytes_used = ATOMIC64_INIT(0);\n static struct shrinker *cifs_dircache_shrinker;\ndiff --git a/fs/smb/client/connect.c b/fs/smb/client/connect.c\nindex 69b38f0ccf2b2..849c16c538353 100644\n--- a/fs/smb/client/connect.c\n+++ b/fs/smb/client/connect.c\n@@ -2698,7 +2698,7 @@ cifs_get_tcon(struct cifs_ses *ses, struct smb3_fs_context *ctx)\n \n \tif (ses->server->dialect >= SMB20_PROT_ID &&\n \t    (ses->server->capabilities & SMB2_GLOBAL_CAP_DIRECTORY_LEASING))\n-\t\tnohandlecache = ctx->nohandlecache || !dir_cache_timeout;\n+\t\tnohandlecache = ctx->nohandlecache;\n \telse\n \t\tnohandlecache = true;\n \ttcon = tcon_info_alloc(!nohandlecache, netfs_trace_tcon_ref_new);\n","prefixes":["v4","13/19"]}