{"id":2231706,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2231706/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260501095717.1032151-1-matt@readmodwrite.com/","project":{"id":46,"url":"http://patchwork.ozlabs.org/api/1.1/projects/46/?format=json","name":"Intel Wired Ethernet development","link_name":"intel-wired-lan","list_id":"intel-wired-lan.osuosl.org","list_email":"intel-wired-lan@osuosl.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260501095717.1032151-1-matt@readmodwrite.com>","date":"2026-05-01T09:57:17","name":"[net,v2] ice: Fix missing 1's complement negation in GCS raw checksum","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"6be537700114fea203c57ba411843962e948684a","submitter":{"id":93093,"url":"http://patchwork.ozlabs.org/api/1.1/people/93093/?format=json","name":"Matt Fleming","email":"matt@readmodwrite.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260501095717.1032151-1-matt@readmodwrite.com/mbox/","series":[{"id":502435,"url":"http://patchwork.ozlabs.org/api/1.1/series/502435/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=502435","date":"2026-05-01T09:57:17","name":"[net,v2] ice: Fix missing 1's complement negation in GCS raw checksum","version":2,"mbox":"http://patchwork.ozlabs.org/series/502435/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2231706/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2231706/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=gjjABjBs;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g6RKl5SShz1y04\n\tfor ; Fri, 01 May 2026 19:57:29 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 56A9D61769;\n\tFri, 1 May 2026 09:57:27 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id P18ZxBUrXna8; Fri, 1 May 2026 09:57:26 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 8BB0C61B28;\n\tFri, 1 May 2026 09:57:26 +0000 (UTC)","from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n by lists1.osuosl.org (Postfix) with ESMTP id 5A3CC127\n for ; Fri, 1 May 2026 09:57:25 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp3.osuosl.org (Postfix) with ESMTP id 3F6B161B28\n for ; Fri, 1 May 2026 09:57:25 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id qsJ_kV1qoXDz for ;\n Fri, 1 May 2026 09:57:24 +0000 (UTC)","from mail-wm1-x332.google.com (mail-wm1-x332.google.com\n [IPv6:2a00:1450:4864:20::332])\n by smtp3.osuosl.org (Postfix) with ESMTPS id A374561769\n for ; Fri, 1 May 2026 09:57:23 +0000 (UTC)","by mail-wm1-x332.google.com with SMTP id\n 5b1f17b1804b1-483487335c2so19320335e9.2\n for ; Fri, 01 May 2026 02:57:23 -0700 (PDT)","from matt-Precision-5490.. ([2a09:bac6:37a8:26d2::3de:68])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48a8eb3427fsm73837315e9.0.2026.05.01.02.57.19\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 01 May 2026 02:57:20 -0700 (PDT)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp3.osuosl.org 8BB0C61B28","OpenDKIM Filter v2.11.0 smtp3.osuosl.org A374561769"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1777629446;\n\tbh=1xTN6OsAVuW3jnezW6FjJSAEG6gFeBXpHPEFbG0OKV4=;\n\th=From:To:Cc:Date:Subject:List-Id:List-Unsubscribe:List-Archive:\n\t List-Post:List-Help:List-Subscribe:From;\n\tb=gjjABjBsXLv2b1JF1mLh4UATGPI1dzE9HTGPUicQ+6Wl5NtymEjJLCnKKOwmCxIsC\n\t Zdu7qi/c5/+3aFbhln8xrqXNukeevQjQR5zUBN8VekAdO1a+RewoTDVD8UGW0q8GWC\n\t rAb2RCRG2mMidfnSKWbZWeL+Bm6GmWXysWAFtQNBB2fF41MjIhrYZZwSsY4ocHiTDO\n\t 0dXwvqHjoIlf3HtwgJOGyTk00RzuNOonGzKfJJxpGZJEVj/0FuSSaCaFVuRPwHXICv\n\t Lg08I3PJhOo7u6ONzqCyTA0omNgwX0fBRR1HP8EE+WGTYuq3IiC9Kpsdg2opZGxyIa\n\t CmiDAO8ETXbrA==","Received-SPF":"None (mailfrom) identity=mailfrom;\n client-ip=2a00:1450:4864:20::332; helo=mail-wm1-x332.google.com;\n envelope-from=matt@readmodwrite.com; receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp3.osuosl.org A374561769","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777629441; x=1778234241;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=1xTN6OsAVuW3jnezW6FjJSAEG6gFeBXpHPEFbG0OKV4=;\n b=T3GOzc4FTZHkBtxAJepXN8wNI5blv6ThmoEA+rBh+BiT7XX2w+JXaAIP2tQMZi9U4v\n 4jRrHYr14jwass6VJhaCWrXcVo6f3wxfuaDqhSmAqW+rMHW7ezdcfU5j1wS1UVEBgYWX\n GjDqtqMJA8zAXdkoYOcJIb8yKL5Ax6PqVhZaXo6S0oHnabIgYSHI989vQRCruRc6CSE/\n +ZYrGR9yIxbJI/0/pLuCNi9C4iRgOIz8CaVntjAt/ftwQBvOLBBHZVvEV27hWBXmjUYX\n Pf7ARa5JJUZbF7i/8cIPMFgFtBV0lKbHqyZQRXil+BcKCrq7pk+TNBkLXVGJbP0J8gIG\n pvRw==","X-Forwarded-Encrypted":"i=1;\n AFNElJ+h4DZHN9j+dHBkni8ihD4Rh0Qn+UWrnN1SCo/AUP58zo4fv1VLvKieUmxkqq+iS9TCVmNHUCOynusNUGrY45g=@lists.osuosl.org","X-Gm-Message-State":"AOJu0Yz9wmg2qd+qP1Agmtw/3P2T4q31Xb+uW/KIsOOAh1d/y/IF9ePG\n j+0AjZGOFAYN4wr3BGe8tKaRWAriKKAJqSlJXfY3AF0HHE2DaFhjDHUZyp8SR+oOodM=","X-Gm-Gg":"AeBDievzqtyRMfdV3nDmmd/aQ/NySyIhJBMztD4+AGe2lM/bnwVc0KO2NGGudptjEp1\n 7bIw1Nt/sDvEIIEPU4vv3z7/obkXH3J6hpxO99NW/aeBzOHbk2jDYitWjYBACDTPhMSBr0EmjA5\n WwjdUu1AV9oof0ObO576qJGQInW6XmwypZ5nyBQw1Grhmwyi036TRXkhhAsQlo6JJXVBWyuz1i3\n DENgavGsllasndWmvLni9zz1wi8Dz1CoHS23qCC2+XIHRw65VDI99MOpyiMw0y6LEZIx+6CZzRn\n RAYKy/7CZpaxlR6X2Bp4WlujuMf7X+K2obqUDqB1Rlnm+ZpR39R7KtLE+KIKhLzjCHrsmElVdds\n 1+IqDZ68/fd9mpNJbY6TaapDy+IxfUZCCl7mlkd2yV/IZ6f+boAJafBowUn2YRUnIzHiZJMsSs7\n +2wsj0P3qcXEQOXV7S8FMYf0KZHqKFa3bhLSor","X-Received":"by 2002:a05:600c:154d:b0:485:39b2:a47c with SMTP id\n 5b1f17b1804b1-48a8452db0fmr108898045e9.25.1777629441256;\n Fri, 01 May 2026 02:57:21 -0700 (PDT)","From":"Matt Fleming ","To":"Tony Nguyen ","Cc":"Aleksandr Loktionov ,\n kernel-team@cloudflare.com, Matt Fleming ,\n stable@vger.kernel.org, Simon Horman ,\n Przemek Kitszel ,\n Andrew Lunn ,\n \"David S. Miller\" ,\n Eric Dumazet , Jakub Kicinski ,\n Paolo Abeni , Eric Joyner ,\n Paul Greenwalt ,\n Alice Michael , intel-wired-lan@lists.osuosl.org,\n netdev@vger.kernel.org, linux-kernel@vger.kernel.org","Date":"Fri, 1 May 2026 10:57:17 +0100","Message-ID":"<20260501095717.1032151-1-matt@readmodwrite.com>","X-Mailer":"git-send-email 2.43.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=readmodwrite-com.20251104.gappssmtp.com; s=20251104; t=1777629441;\n x=1778234241; darn=lists.osuosl.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=1xTN6OsAVuW3jnezW6FjJSAEG6gFeBXpHPEFbG0OKV4=;\n b=HxRtlYZJqF+BgSgNXo4plj7uNnwuQ6ORUvYuLiI25R38OLd6rJ5YGabrUV3XtT9kCP\n d5b/uryap/MrSIfs96YFpJkkIp9x/fTPlOrC3sA9riqVPtOdtBJC0kS2/Ej/MfjaBDxg\n Qre4m42VqihqKJL4k9Q+uPd+SwRKQZx+gXAkNqhoduVIbVQyKFpmpFh70oHdw9OSHF9M\n 8b+Io/6M3kaq/SuaHsT6J1LhdIACRcGzXROSwmFUjbZVwg9pxhh51mHSU83V0iwVmU/T\n XpyQNQ/RFzYbXVZMsCd9ZYJWpAEXxpev6uZhf7ewuSevkhmxVkpWfIB+GBhKvMaY2HVA\n gp3g==","X-Mailman-Original-Authentication-Results":["smtp3.osuosl.org;\n dmarc=none (p=none dis=none)\n header.from=readmodwrite.com","smtp3.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=readmodwrite-com.20251104.gappssmtp.com\n header.i=@readmodwrite-com.20251104.gappssmtp.com header.a=rsa-sha256\n header.s=20251104 header.b=HxRtlYZJ"],"Subject":"[Intel-wired-lan] [PATCH net v2] ice: Fix missing 1's complement\n negation in GCS raw checksum","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "},"content":"From: Matt Fleming \n\nCommit 905d1a220e8d (\"ice: Add E830 checksum offload support\") added\nGeneric Checksum (GCS) support for E830 NICs but omitted the 1's\ncomplement negation (~) when converting the hardware raw_csum to\nskb->csum for CHECKSUM_COMPLETE.\n\nWithout the negation, every CHECKSUM_COMPLETE packet fails the\nfast-path validation in nf_ip_checksum() and falls through to software\nchecksumming via __skb_checksum_complete(), which triggers the\nrate-limited \"hw csum failure\" warning. Packets are still accepted\n(the software recheck passes) but hardware checksum offload is\neffectively disabled and the warning floods dmesg on systems running\nnf_conntrack on VLAN sub-interfaces.\n\nMultiple other drivers (idpf, ehea, iwlwifi, cassini, sunhme, enetc)\nalso apply ~ for CHECKSUM_COMPLETE. The ice driver was the only in-tree\nuser of csum_unfold() for CHECKSUM_COMPLETE that omitted it.\n\nFixes: 905d1a220e8d (\"ice: Add E830 checksum offload support\")\nCc: stable@vger.kernel.org\nReviewed-by: Aleksandr Loktionov \nReviewed-by: Simon Horman \nSigned-off-by: Matt Fleming \n---\nv2:\n - Add Cc: stable@vger.kernel.org (Aleksandr)\n - Pick up Reviewed-by tags from Aleksandr and Simon\n - No code changes\nv1: https://lore.kernel.org/netdev/20260408190214.1287708-1-matt@readmodwrite.com/\n\n drivers/net/ethernet/intel/ice/ice_txrx_lib.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/drivers/net/ethernet/intel/ice/ice_txrx_lib.c b/drivers/net/ethernet/intel/ice/ice_txrx_lib.c\nindex e695a664e53d..c177579e0114 100644\n--- a/drivers/net/ethernet/intel/ice/ice_txrx_lib.c\n+++ b/drivers/net/ethernet/intel/ice/ice_txrx_lib.c\n@@ -92,7 +92,7 @@ static void ice_rx_gcs(struct sk_buff *skb,\n \tdesc = (struct ice_32b_rx_flex_desc_nic *)rx_desc;\n \tskb->ip_summed = CHECKSUM_COMPLETE;\n \tcsum = (__force u16)desc->raw_csum;\n-\tskb->csum = csum_unfold((__force __sum16)swab16(csum));\n+\tskb->csum = csum_unfold((__force __sum16)~swab16(csum));\n }\n \n /**\n","prefixes":["net","v2"]}