{"id":2231646,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2231646/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/patch/CAMe9rOqLjhvhqVfwZZUZrUhjVs+fFdvEUGFoY5aFCsQ=9aJ45Q@mail.gmail.com/","project":{"id":17,"url":"http://patchwork.ozlabs.org/api/1.1/projects/17/?format=json","name":"GNU Compiler Collection","link_name":"gcc","list_id":"gcc-patches.gcc.gnu.org","list_email":"gcc-patches@gcc.gnu.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"","date":"2026-05-01T02:33:59","name":"x86: Correct last_4x_vec_label in ix86_expand_movmem","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"49fcadefcf36c0a1417f90b69af690ca465a175c","submitter":{"id":4387,"url":"http://patchwork.ozlabs.org/api/1.1/people/4387/?format=json","name":"H.J. Lu","email":"hjl.tools@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/gcc/patch/CAMe9rOqLjhvhqVfwZZUZrUhjVs+fFdvEUGFoY5aFCsQ=9aJ45Q@mail.gmail.com/mbox/","series":[{"id":502415,"url":"http://patchwork.ozlabs.org/api/1.1/series/502415/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/list/?series=502415","date":"2026-05-01T02:33:59","name":"x86: Correct last_4x_vec_label in ix86_expand_movmem","version":1,"mbox":"http://patchwork.ozlabs.org/series/502415/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2231646/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2231646/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=Yd13VO8Y;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=Yd13VO8Y","sourceware.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","sourceware.org; spf=pass smtp.mailfrom=gmail.com","server2.sourceware.org;\n arc=pass smtp.remote-ip=209.85.215.179"],"Received":["from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g6FWN63Kkz1xvV\n\tfor ; Fri, 01 May 2026 12:35:11 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id B5451436A06D\n\tfor ; Fri, 1 May 2026 02:35:07 +0000 (GMT)","from mail-pg1-f179.google.com (mail-pg1-f179.google.com\n [209.85.215.179])\n by sourceware.org (Postfix) with ESMTPS id 32DF44371D5C\n for ; Fri, 1 May 2026 02:34:38 +0000 (GMT)","by mail-pg1-f179.google.com with SMTP id\n 41be03b00d2f7-c7963df6f17so973265a12.0\n for ; Thu, 30 Apr 2026 19:34:38 -0700 (PDT)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org B5451436A06D","OpenDKIM Filter v2.11.0 sourceware.org 32DF44371D5C"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org 32DF44371D5C","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org 32DF44371D5C","ARC-Seal":["i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1777602878; cv=pass;\n b=XTKtuO0C9usaSo9sIYiDazVOsC2UYjsWstoX/Fm1q/N/K1Ah/zM5+qoPKbMcN5glylNBxwhy4blkQFKquIQL5SYHO4BUumpJNiUD/+rLOpQJSSYxzo9RWn9eLsvNBQVFBPhU9waT8YfqZx5IP2+VCgn1rlLCaKqSCYP3F+0MKXQ=","i=1; a=rsa-sha256; t=1777602877; cv=none;\n d=google.com; s=arc-20240605;\n b=FpoNE0S0+gFX8q/q6GvL1D3Gxnxx1lRsy/mp0lcBrQWTGtHEhlKazOqq9k7A8W3ug/\n Zxvg+msFHrhCU0fyuDCjhpWrvEk7R56AsC/gl0iudm9ITrL/ogEDqY4C2dvD3c6fwWQd\n M4rTaqZ4YU2qm32bzpTIgIGo0ORNKq5peAmr1XBGnXXrvH90McyAeIXEsHcWnMsD1L5B\n 0CCVKnuuLlOKxYcnX32DbsrfALAerskn7lFWNQYwl+++S9gOE7mVoYKpTiVgbnF64Zbu\n FhKDTqLuPK4W7h3HsiDAhjYIsXju9Oxe2zaVtHNYgx0WFEXCeryJlRiCLHAJjA2j5ljj\n o31A=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=sourceware.org; s=key;\n t=1777602878; c=relaxed/simple;\n bh=E19iBT1aggSThubzC+BV1OdRYpm1gG7vfSalGe9wA2c=;\n h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To;\n b=uP0FVhslana06hs2cb8brFLy/MWjFsjOWsk2WGFe83fIaefPSg+rb2LJ0ssMzGZcui0eELbKH5mzMxIW0a3IuQm8Nic5f94aFNaG5eqCXK7zoWcNAjv/Ka99Iiu6bnaTpjmj3+NAyswHQv9Vwj7Bzl5k6//z5AFdD8WUkMGa0Uk=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=to:subject:message-id:date:from:mime-version:dkim-signature;\n bh=yxlcdXuUUBDlTY974lPDuc0ofcVWuGXhFMSmQpvJuvo=;\n fh=83snE5t1iR5QXMcAAhy1f7NFmMeqVCeXIkq3dVlORPM=;\n b=MO9X0tBFDnlrlHiMdDrXpO9QanmMvsfpvsm3iSPS/NIeba73P8M1wJCU1yEjPsVVia\n nSph5iOsLxlN24Rm/0rPUmkPXh8D42sdF2rfmxN+Sf5OIw8i72n9W9f6I+pqNMbMhTgU\n 3XNs6d09NBSMxx1w8nQzN+vycImSSAmwhl3+EbpU7qVmg0K5mIAQh59A2fsITbGITDWO\n hlUsmXW8de64BBReE62FrQC74rtUHAXoZWQ/2UgKZ7FAB/a8M2nc1mOhCE96w3qNr9SL\n 2CSl9bBNWJ+opiH0zHjnV0nTBWTaqW+FSmTopb4W6EOzxsW23M/82TbKzgbu5LC/umzK\n fKmA==; darn=gcc.gnu.org"],"ARC-Authentication-Results":["i=2; server2.sourceware.org","i=1; mx.google.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777602877; x=1778207677; darn=gcc.gnu.org;\n h=to:subject:message-id:date:from:mime-version:from:to:cc:subject\n :date:message-id:reply-to;\n bh=yxlcdXuUUBDlTY974lPDuc0ofcVWuGXhFMSmQpvJuvo=;\n b=Yd13VO8YL9Jl6HWUaYqEg3M1J/aYt8rxNcuRWjZxOH947WZDAdkszwVXJwWvzR+ST9\n sbL+upo2SLJpy4QwGoi4DWvCvlKfVIhhUx0RzQUDYCbLBdKXV4GwEk1gSeHWNN+Y/d/+\n MsPdznb20Bdz5NX7kgjeGimUZ1ZBy27M24D+dNoM3Plndo14lSzc2dVO21zwhuWjO+Mf\n wfQbEjgT66iiwRVdEvlgdGka4G376q5t8W4evwUTW8u8IPZoSYjCPVwxWcDg7BF8i39Z\n AC+aWQNsLsXV15xTYmqdZy4bxaedoMRnbE7/8opNF4CGKd83/U2HmV7s8vGFqb+RQYcZ\n Z0Ow==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777602877; x=1778207677;\n h=to:subject:message-id:date:from:mime-version:x-gm-gg\n :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n bh=yxlcdXuUUBDlTY974lPDuc0ofcVWuGXhFMSmQpvJuvo=;\n b=ZtDh5cM+rjgnstHqd35NqJrQu1QJelk8WgljJr4XG0OXReW+kaAG+WJKI7iCMWMK7J\n 3s25WMJbaff9KLIi338roIzObEMsA3hhNwGNOKonYawMcocFQosiyFIezll94Dd/9u3P\n E+jTQUsSZuPCJ6VzyzU+qPaYKWSpfveYCLfhKq27bgdMXR6GRUPF5pRe18gMCQu9fySV\n TDF/IERYM5EYQhmZcH976svClnwzsfQqrKYG5CXDY8Ir+XPGjHXRWue8XQeTnBzjQLKF\n EhEUHu7EEJMzWwiKbk+a8aQhgfWoF8jQlByy3IG9SNck16YOfn1GUXz9Smi50MVxO1Qn\n AMNA==","X-Gm-Message-State":"AOJu0Yyv3a4Vrbs3B5iRsy/sJRcK8qkFKylBOu22P0ZBsQf6/6A+ZcX4\n zeullvJcewS97P5BbyoDfZRAjZgtEHACpA7ux4zZSsJ75vqzITRdaeN+05jZjdVsQF9m5+iNvzW\n KORDSbn/rKPe6phasQNqXYLVYQhOs1MZldmVVcSP2cQmL","X-Gm-Gg":"AeBDievmo0/sZ2xASIP5f1pfaA/uugl9wooklF1kKGCq5d5JPHEjSpnuQvwQNbeC8zN\n WPkM0trzW7QTgY5XFArS7ollAbYgbVkm2yQICVygaH9JJ1zlHtJ6OicEpCuHqXwJw0+4UwZm+2/\n OnDeeO6tv+I1eFpvidzJ8w0mZyPAptqO/cz4z/WG49eWe68wyWjyuxWUYf8aU9LgWydKNmTsyUx\n ftjaF7788s8ntxH+IoUpYWQNElwKwvmrsGyzyV8MO7mMNXuY1zf75R/OkVkB1Ncfn/0kMTCk+Vw\n gVfLE7mygpt1F7AS7zPNAy9Myc6Q","X-Received":"by 2002:a05:6a20:12ca:b0:3a1:76d3:c1b4 with SMTP id\n adf61e73a8af0-3a45fdd506amr1647774637.30.1777602876627; Thu, 30 Apr 2026\n 19:34:36 -0700 (PDT)","MIME-Version":"1.0","From":"\"H.J. Lu\" ","Date":"Fri, 1 May 2026 10:33:59 +0800","X-Gm-Features":"AVHnY4JkAB3jGQy0IhVs42cO77S0FpAiYD9q5EYgBMawlGoeZyGp0MTqQYiDn98","Message-ID":"\n ","Subject":"[PATCH] x86: Correct last_4x_vec_label in ix86_expand_movmem","To":"GCC Patches , Uros Bizjak ,\n Hongtao Liu ","Content-Type":"multipart/mixed; boundary=\"0000000000000440cc0650b86c28\"","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"},"content":"commit b41f96465190751561f6909e858604ceab00595b\nAuthor: H.J. Lu \n\n x86-64: Inline memmove with overlapping unaligned loads and stores\n\nhas\n\n rtx_code_label *last_4x_vec_label = nullptr;\n if (min_size == 0 || min_size < 4 * move_max)\n last_4x_vec_label = gen_label_rtx ();\n\n /* Jump to LAST_4X_VEC_LABEL if size < 4 * MOVE_MAX. */\n if (last_4x_vec_label)\n emit_cmp_and_jump_insns (count_exp, GEN_INT (4 * move_max), LTU,\n nullptr, count_mode, 1,\n last_4x_vec_label);\n\n...\n\n if (last_4x_vec_label)\n {\n /* Size > 2 * MOVE_MAX and size <= 4 * MOVE_MAX. */\n emit_label (last_4x_vec_label);\n\nThe last_4x_vec_label block covers min_size <= 4 * MOVE_MAX, not\nmin_size < 4 * MOVE_MAX. When MOVE_MAX == 16 bytes and min_size == 64,\nthe last_4x_vec_label isn't generated. Change min_size < 4 * move_max\nto min_size <= 4 * move_max to correct the last_4x_vec_label condition.\n\ngcc/\n\nPR target/125117\n* config/i386/i386-expand.cc (ix86_expand_movmem): Generate\nlast_4x_vec_label when min_size <= 4 * MOVE_MAX.\n\ngcc/testsuite/\n\nPR target/125117\n* gcc.dg/pr125117.c: New test.\n* gfortran.dg/pr125117.f90: Likewise.","diff":"From c115fdc5b865d44186bf9bc65b86e3b50640abfd Mon Sep 17 00:00:00 2001\nFrom: \"H.J. Lu\" \nDate: Fri, 1 May 2026 09:13:21 +0800\nSubject: [PATCH] x86: Correct last_4x_vec_label in ix86_expand_movmem\n\ncommit b41f96465190751561f6909e858604ceab00595b\nAuthor: H.J. Lu \n\n x86-64: Inline memmove with overlapping unaligned loads and stores\n\nhas\n\n rtx_code_label *last_4x_vec_label = nullptr;\n if (min_size == 0 || min_size < 4 * move_max)\n last_4x_vec_label = gen_label_rtx ();\n\n /* Jump to LAST_4X_VEC_LABEL if size < 4 * MOVE_MAX. */\n if (last_4x_vec_label)\n emit_cmp_and_jump_insns (count_exp, GEN_INT (4 * move_max), LTU,\n nullptr, count_mode, 1,\n last_4x_vec_label);\n\n...\n\n if (last_4x_vec_label)\n {\n /* Size > 2 * MOVE_MAX and size <= 4 * MOVE_MAX. */\n emit_label (last_4x_vec_label);\n\nThe last_4x_vec_label block covers min_size <= 4 * MOVE_MAX, not\nmin_size < 4 * MOVE_MAX. When MOVE_MAX == 16 bytes and min_size == 64,\nthe last_4x_vec_label isn't generated. Change min_size < 4 * move_max\nto min_size <= 4 * move_max to correct the last_4x_vec_label condition.\n\ngcc/\n\n\tPR target/125117\n\t* config/i386/i386-expand.cc (ix86_expand_movmem): Generate\n\tlast_4x_vec_label when min_size <= 4 * MOVE_MAX.\n\ngcc/testsuite/\n\n\tPR target/125117\n\t* gcc.dg/pr125117.c: New test.\n\t* gfortran.dg/pr125117.f90: Likewise.\n\nSigned-off-by: H.J. Lu \n---\n gcc/config/i386/i386-expand.cc | 4 ++--\n gcc/testsuite/gcc.dg/pr125117.c | 31 ++++++++++++++++++++++++++\n gcc/testsuite/gfortran.dg/pr125117.f90 | 23 +++++++++++++++++++\n 3 files changed, 56 insertions(+), 2 deletions(-)\n create mode 100644 gcc/testsuite/gcc.dg/pr125117.c\n create mode 100644 gcc/testsuite/gfortran.dg/pr125117.f90\n\ndiff --git a/gcc/config/i386/i386-expand.cc b/gcc/config/i386/i386-expand.cc\nindex b29af705fff..06eb675703a 100644\n--- a/gcc/config/i386/i386-expand.cc\n+++ b/gcc/config/i386/i386-expand.cc\n@@ -10585,10 +10585,10 @@ ix86_expand_movmem (rtx operands[])\n \t\t\t\t more_8x_vec_label);\n \n rtx_code_label *last_4x_vec_label = nullptr;\n- if (min_size == 0 || min_size < 4 * move_max)\n+ if (min_size == 0 || min_size <= 4 * move_max)\n \tlast_4x_vec_label = gen_label_rtx ();\n \n- /* Jump to LAST_4X_VEC_LABEL if size < 4 * MOVE_MAX. */\n+ /* Jump to LAST_4X_VEC_LABEL if size <= 4 * MOVE_MAX. */\n if (last_4x_vec_label)\n \temit_cmp_and_jump_insns (count_exp, GEN_INT (4 * move_max), LTU,\n \t\t\t\t nullptr, count_mode, 1,\ndiff --git a/gcc/testsuite/gcc.dg/pr125117.c b/gcc/testsuite/gcc.dg/pr125117.c\nnew file mode 100644\nindex 00000000000..6535484bce5\n--- /dev/null\n+++ b/gcc/testsuite/gcc.dg/pr125117.c\n@@ -0,0 +1,31 @@\n+/* { dg-do run } */\n+/* { dg-options \"-O0\" } */\n+\n+#include \n+#include \n+\n+#define OFFSET 32\n+\n+char buffer[128];\n+char expected[64];\n+\n+void\n+foo (char *dest, char *src, size_t n)\n+{\n+ if (n == 64)\n+ __builtin_memmove (dest, src, n);\n+}\n+\n+int\n+main ()\n+{\n+ memset (buffer, -2, sizeof (buffer));\n+ memset (buffer + OFFSET, -1, sizeof (buffer) - OFFSET);\n+ memset (expected, -2, sizeof (expected));\n+ memset (expected + OFFSET / 2, -1, OFFSET + OFFSET / 2);\n+ foo (buffer, buffer + OFFSET / 2, 64);\n+ if (memcmp (expected, buffer, 64) != 0)\n+ abort ();\n+\n+ return 0;\n+}\ndiff --git a/gcc/testsuite/gfortran.dg/pr125117.f90 b/gcc/testsuite/gfortran.dg/pr125117.f90\nnew file mode 100644\nindex 00000000000..a03250dde08\n--- /dev/null\n+++ b/gcc/testsuite/gfortran.dg/pr125117.f90\n@@ -0,0 +1,23 @@\n+! { dg-do run }\n+! { dg-options \"-O0\" }\n+! PR fortran/125117\n+\n+program test\n+ implicit none\n+ character(len=64) :: fixed\n+ character(:), allocatable :: got\n+ fixed = 'hello world'\n+ got = getName(fixed)\n+ if (trim(got) == 'hello world') then\n+ print *, 'PASS'\n+ else\n+ print *, 'FAIL: got=[', trim(got), ']'\n+ call abort()\n+ end if\n+contains\n+ function getName(fixed) result(name)\n+ character(len=64), intent(in) :: fixed\n+ character(:), allocatable :: name\n+ name = fixed\n+ end function\n+end program\n-- \n2.54.0\n\n","prefixes":[]}