{"id":2231635,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2231635/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260501012507.461044-1-boolli@google.com/","project":{"id":46,"url":"http://patchwork.ozlabs.org/api/1.1/projects/46/?format=json","name":"Intel Wired Ethernet development","link_name":"intel-wired-lan","list_id":"intel-wired-lan.osuosl.org","list_email":"intel-wired-lan@osuosl.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260501012507.461044-1-boolli@google.com>","date":"2026-05-01T01:25:07","name":"[iwl-next,v4] libie: log more info when virtchnl fails","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"30e4513eeef6c0c6d1582302a9e5c31a78f76758","submitter":{"id":92373,"url":"http://patchwork.ozlabs.org/api/1.1/people/92373/?format=json","name":"Li Li","email":"boolli@google.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260501012507.461044-1-boolli@google.com/mbox/","series":[{"id":502412,"url":"http://patchwork.ozlabs.org/api/1.1/series/502412/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=502412","date":"2026-05-01T01:25:07","name":"[iwl-next,v4] libie: log more info when virtchnl fails","version":4,"mbox":"http://patchwork.ozlabs.org/series/502412/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2231635/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2231635/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=iNKbrwSp;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g6Cym5XDxz1y1d\n\tfor ; Fri, 01 May 2026 11:25:18 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 78CD741183;\n\tFri, 1 May 2026 01:25:16 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id WnawyuPk8UBS; Fri, 1 May 2026 01:25:15 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 1ABA1411A5;\n\tFri, 1 May 2026 01:25:15 +0000 (UTC)","from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n by lists1.osuosl.org (Postfix) with ESMTP id 27A47127\n for ; Fri, 1 May 2026 01:25:13 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id 1942083BB8\n for ; Fri, 1 May 2026 01:25:13 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 4WlY56wK5Skg for ;\n Fri, 1 May 2026 01:25:12 +0000 (UTC)","from mail-dy1-x1349.google.com (mail-dy1-x1349.google.com\n [IPv6:2607:f8b0:4864:20::1349])\n by smtp1.osuosl.org (Postfix) with ESMTPS id 5E38F83AE6\n for ; Fri, 1 May 2026 01:25:12 +0000 (UTC)","by mail-dy1-x1349.google.com with SMTP id\n 5a478bee46e88-2ba8013a9e3so2434212eec.0\n for ; Thu, 30 Apr 2026 18:25:12 -0700 (PDT)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org 1ABA1411A5","OpenDKIM Filter v2.11.0 smtp1.osuosl.org 5E38F83AE6"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1777598715;\n\tbh=oVNJyuWqlMR4ml4qJTrmF4Dl7mhOJUtG2QO1Cc6843I=;\n\th=Date:To:Cc:Subject:List-Id:List-Unsubscribe:List-Archive:\n\t List-Post:List-Help:List-Subscribe:From:Reply-To:From;\n\tb=iNKbrwSpz1E39kptOJgZBQvotalh/oOPuWOoI5cEnu0gHm2Kr8tFxTeWSBjeaD/Fc\n\t 0SP+IdYTfMgVMleVt+rEz/+piPCx2rr1yzHiOiYoMmlPEGvuPvjrr06KjxWmHKZ1kf\n\t YPf9je3+fpWyyYldpYaHAkSPSWVvVBdbNLGLBxeZY9v5RXpQSFJ9rYuvunffUHdT1u\n\t uZqagG7eKf9DoevntoGHy0KsCzUf5Y5tUGe6blO8M35ZV5YH0RB5rxKRBBxAzXK6tF\n\t 8rCCgMSVRgYCUHiDFos7tTcanZKu7W+wLQnuhBNyNgQTFlUbuibMZXLhf0OJW41yro\n\t qC/DtLBY5mtiA==","Received-SPF":"Pass (mailfrom) identity=mailfrom;\n client-ip=2607:f8b0:4864:20::1349; helo=mail-dy1-x1349.google.com;\n envelope-from=39gd0aqykdx86jjggdbjjbg9.7jhdio9g-rdm98-g5igdnon.jnpjng.jmb@flex--boolli.bounces.google.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp1.osuosl.org 5E38F83AE6","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777598711; x=1778203511;\n h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state\n :from:to:cc:subject:date:message-id:reply-to;\n bh=oVNJyuWqlMR4ml4qJTrmF4Dl7mhOJUtG2QO1Cc6843I=;\n b=jH173uenUqw0oXiUApl3d9ERpRc+qH6jYlCqMcOu29VSlRRQy1OHp6SaEbio1/boRw\n 74GCguFeLIvAl0WDNjMe3cOUfI2ZG4gzgpEyIDg5/WYe2/xB86rFAdJFd6e3eXAOE+ZK\n CjQ49s04iSBI7lVkxsFANDt6YY2FRrom1mjyVc1vN5cO3muktf0KW0ZkKZkNAgqGR2ch\n da97HOhA1ivpsTKspixVYVNuia9j1CFU6k0LwTkO9GaNtpcFq6OkGgPxRsXkQS8v6VBK\n X6f0QdIO1XZpKHMPSSjyHOrgMuI6Lm5ILcMJU3wt1mHF0+3yYbF77AfugU+7CtjMTeiW\n 29Kw==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/sq7oND1zGq40KsUkuroakT9AeYUbD3BBPs7NELo3vxWG4CEu4hT6F1Qi49TXlOkM4XoRcaVY+5XHzs4snUVs=@lists.osuosl.org","X-Gm-Message-State":"AOJu0Yzhp9qgt/TLwTidlVx6ITMhtIZB+BRdnhH48P9Urn2EMaC1bn7F\n Jeznmbt04L4wCD7Zcf8pigyCOP3xJHhuAbcl3pcP8LqPZI+1s/yyERsIRPPluu6uOvI5WwDvEX4\n 80frDiQ==","X-Received":"from dybvi26.prod.google.com\n ([2002:a05:7301:531a:b0:2d8:dd18:baee])\n (user=boolli job=prod-delivery.src-stubby-dispatcher) by\n 2002:a05:7301:6743:b0:2d9:bc8d:f62a\n with SMTP id 5a478bee46e88-2ed3e486c61mr2586087eec.16.1777598710661; Thu, 30\n Apr 2026 18:25:10 -0700 (PDT)","Date":"Fri, 1 May 2026 01:25:07 +0000","Mime-Version":"1.0","X-Mailer":"git-send-email 2.54.0.545.g6539524ca2-goog","Message-ID":"<20260501012507.461044-1-boolli@google.com>","To":"Tony Nguyen ,\n Przemek Kitszel ,\n \"David S. Miller\" ,\n Jakub Kicinski , Eric Dumazet ,\n intel-wired-lan@lists.osuosl.org","Cc":"netdev@vger.kernel.org, linux-kernel@vger.kernel.org,\n David Decotigny ,\n Anjali Singhai ,\n Sridhar Samudrala ,\n Brian Vazquez ,\n Li Li , emil.s.tantilov@intel.com","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=google.com; s=20251104; t=1777598711; x=1778203511; darn=lists.osuosl.org;\n h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject\n :date:message-id:reply-to;\n bh=oVNJyuWqlMR4ml4qJTrmF4Dl7mhOJUtG2QO1Cc6843I=;\n b=JHPXaRqqkdaXV272idJ4VNgEsTN/W2GomXKaXQCvAQg+w+IsJAIte3wcWR7GE03mU+\n k5eWJtZnSdGtnwVRsyoMGSFrSa4OPH5YM0I8vZioU2ymWbfCRHYL5WYsU0QzlP3DJhPd\n REaOow/3YtW82H6HZuMjPr9fsf3qDRO/+dut8ZFnCCXTk89GN1AjjReZofYmXoFmQHjY\n yhHEEEsPMFjlIzurmlr3F3iA8tAcl8Inaa0K/qa0ZZUxR+tE0MhVmlX6OOhlJL37qYZE\n k0dK0j5Bfe4O9dwcaOR6em5cbGlLQtvLD9dpmsNsXZYPeWYlVTp/XAXrobI5fOTbFaHR\n zFVQ==","X-Mailman-Original-Authentication-Results":["smtp1.osuosl.org;\n dmarc=pass (p=reject dis=none)\n header.from=google.com","smtp1.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256\n header.s=20251104 header.b=JHPXaRqq"],"Subject":"[Intel-wired-lan] [PATCH iwl-next v4] libie: log more info when\n virtchnl fails","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","From":"Li Li via Intel-wired-lan ","Reply-To":"Li Li ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "},"content":"Virtchnl failures can be hard to debug without logs. Logging the details\nof virtchnl transactions can be useful for debugging virtchnl-related\nissues.\n\nTested: Built & booted on a test machine and synthetically produced a\nvirtual failure to produce the following log:\n\nidpf 0000:01:00.0: Non-zero virtchnl ret val 6 (msg op: 1, data_len: 8);\nxn id: 0, cookie: 0\nidpf 0000:01:00.0: Transaction failed (op 1, xn state:\n3, id: 0, cookie: 0, size: 8)\n\nSigned-off-by: Li Li \n---\nv4:\n - Simplify logging to reduce redundant \"ret val\"s.\n - Use %u for xn->state.\nv3:\n - Use dev_err_ratelimited in both logs.\n - Move log placement to after virtchnl field validation.\n - Remove redundant op/cookie fields since they were validated.\nv2:\n - Use dev_warn_ratelimited instead of dev_notice_ratelimited based on\n reviewer feedback.\n drivers/net/ethernet/intel/libie/controlq.c | 13 +++++++++++++\n 1 file changed, 13 insertions(+)","diff":"diff --git a/drivers/net/ethernet/intel/libie/controlq.c b/drivers/net/ethernet/intel/libie/controlq.c\nindex ebc05355e39d..e1bc19d6cdbf 100644\n--- a/drivers/net/ethernet/intel/libie/controlq.c\n+++ b/drivers/net/ethernet/intel/libie/controlq.c\n@@ -766,6 +766,14 @@ libie_ctlq_xn_process_recv(struct libie_ctlq_xn_recv_params *params,\n \t msg_cookie != xn->cookie)\n \t\treturn false;\n \n+\tif (ctlq_msg->chnl_retval) {\n+\t\tdev_err_ratelimited(\n+\t\t\tparams->ctlq->dev,\n+\t\t\t\"Non-zero virtchnl ret val %u (msg op: %u, data_len: %u); xn id: %u, cookie: %u\\n\",\n+\t\t\tctlq_msg->chnl_retval, ctlq_msg->chnl_opcode,\n+\t\t\tctlq_msg->data_len, xn->index, xn->cookie);\n+\t}\n+\n \tspin_lock(&xn->xn_lock);\n \tif (xn->state != LIBIE_CTLQ_XN_ASYNC &&\n \t xn->state != LIBIE_CTLQ_XN_WAITING) {\n@@ -1011,6 +1019,11 @@ int libie_ctlq_xn_send(struct libie_ctlq_xn_send_params *params)\n \t\tparams->recv_mem = xn->recv_mem;\n \t\tbreak;\n \tdefault:\n+\t\tdev_err_ratelimited(\n+\t\t\tparams->ctlq->dev,\n+\t\t\t\"Transaction failed (op %u, xn state: %u, id: %u, cookie: %u, size: %zu)\\n\",\n+\t\t\tparams->chnl_opcode, xn->state, xn->index, xn->cookie,\n+\t\t\txn->recv_mem.iov_len);\n \t\tret = -EBADMSG;\n \t\tbreak;\n \t}\n","prefixes":["iwl-next","v4"]}