{"id":2231550,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2231550/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260430202547.274256-2-pablo@netfilter.org/","project":{"id":26,"url":"http://patchwork.ozlabs.org/api/1.1/projects/26/?format=json","name":"Netfilter Development","link_name":"netfilter-devel","list_id":"netfilter-devel.vger.kernel.org","list_email":"netfilter-devel@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260430202547.274256-2-pablo@netfilter.org>","date":"2026-04-30T20:25:45","name":"[nf,v6,2/4] netfilter: flowtable: fix inline vlan encapsulation in xmit path","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"4a59d63a0d42debd08df74fba9db47c6d20a19a6","submitter":{"id":1315,"url":"http://patchwork.ozlabs.org/api/1.1/people/1315/?format=json","name":"Pablo Neira Ayuso","email":"pablo@netfilter.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260430202547.274256-2-pablo@netfilter.org/mbox/","series":[{"id":502378,"url":"http://patchwork.ozlabs.org/api/1.1/series/502378/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/list/?series=502378","date":"2026-04-30T20:25:46","name":"[nf,v6,1/4] netfilter: flowtable: ensure sufficient headroom in xmit path","version":6,"mbox":"http://patchwork.ozlabs.org/series/502378/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2231550/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2231550/checks/","tags":{},"headers":{"Return-Path":"\n <netfilter-devel+bounces-12353-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","netfilter-devel@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=netfilter.org header.i=@netfilter.org\n header.a=rsa-sha256 header.s=2025 header.b=Yx+7Uo4T;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-12353-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=netfilter.org header.i=@netfilter.org\n header.b=\"Yx+7Uo4T\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=217.70.190.124","smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=netfilter.org","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=netfilter.org"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g65b50S72z1yHZ\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 01 May 2026 06:37:53 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 7C296317C056\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 30 Apr 2026 20:29:07 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 710503AE1A2;\n\tThu, 30 Apr 2026 20:25:56 +0000 (UTC)","from mail.netfilter.org (mail.netfilter.org [217.70.190.124])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F4233A5E68\n\tfor <netfilter-devel@vger.kernel.org>; Thu, 30 Apr 2026 20:25:54 +0000 (UTC)","from localhost.localdomain (mail-agni [217.70.190.124])\n\tby mail.netfilter.org (Postfix) with ESMTPSA id 4F65260181\n\tfor <netfilter-devel@vger.kernel.org>; Thu, 30 Apr 2026 22:25:52 +0200 (CEST)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777580756; cv=none;\n b=ZyceG3nyHEz+y5QQW7z+RACftJ+8RKW5cWxJGJTPDX6zYkUKWRzXSRdEW7Xuv8kyZtbZd211Kg7umQ1we1jTWAT4lRVqhkGgexGqNJ4CfDe092zHVrhmRbRt5802gQ8NpUa98Ne2cwtUW0KXgG++Y0ORnB3d8bwVO6JPW2H8exc=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777580756; c=relaxed/simple;\n\tbh=hajEqtkiwmwGsxnvIqijxcJe9bz3B6WO/8JmrnsLx9o=;\n\th=From:To:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=gO/6tqdZeEkwNIigxJVR72yr5uarChnEGPvA/ByRsoFXE9ShxgGOUhU812+olyVW4wI7Zw03MSlZvsJcpAjB6dv/HZVf15HxVKSoNxBJ3NOVZQFYT3ngb3lg2NlWLJBuiJAB2kx2tUCvTg+efpAyAqr360QSH53M7dPEsz4q/4M=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=netfilter.org;\n spf=pass smtp.mailfrom=netfilter.org;\n dkim=pass (2048-bit key) header.d=netfilter.org header.i=@netfilter.org\n header.b=Yx+7Uo4T; arc=none smtp.client-ip=217.70.190.124","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=netfilter.org;\n\ts=2025; t=1777580752;\n\tbh=Ub4edRqRByLPOLIXcNYyFw/lQPHmk2pXs3IlT8bHcdA=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=Yx+7Uo4TmFS7aM/qmJHU1t7fVk5LvFoLSnUmWlATWgfSZ3yw7iL2TkpJXXDkE5CNA\n\t 7Vtjf6xNfILxT+Avp7zITRWnS5V9S/lRXdNh9/UNXWXgrR2NIrcZrf4qb5PRs7jjZi\n\t lX1L/Y0OYQKiGiIMFfA9m3EwwPa9c72qJFKEMUv743ceTzhp1rVCI7+eK5/RrUcRaP\n\t QQcS3AfWzWmBcTlCwKx0bydYIjgEGyVJWzZH8Bh7G9XlwRHVV1D2/b3gfu6U1d0P96\n\t 0qwDdPM5eEeFLgMCJU14/6MIJnhb7u/mUSnmVEW0Be3P/0E2R5o+HHa5F0UcRxLUgw\n\t gsCvsNOTgjnbg==","From":"Pablo Neira Ayuso <pablo@netfilter.org>","To":"netfilter-devel@vger.kernel.org","Subject":"[PATCH nf,v6 2/4] netfilter: flowtable: fix inline vlan encapsulation\n in xmit path","Date":"Thu, 30 Apr 2026 22:25:45 +0200","Message-ID":"<20260430202547.274256-2-pablo@netfilter.org>","X-Mailer":"git-send-email 2.47.3","In-Reply-To":"<20260430202547.274256-1-pablo@netfilter.org>","References":"<20260430202547.274256-1-pablo@netfilter.org>","Precedence":"bulk","X-Mailing-List":"netfilter-devel@vger.kernel.org","List-Id":"<netfilter-devel.vger.kernel.org>","List-Subscribe":"<mailto:netfilter-devel+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:netfilter-devel+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"Several issues in the inline vlan support:\n\n- The layer 2 encapsulation representation in the tuple takes encap[0] as\n  the outer header and encap[1] as the inner header as seen from the ingress\n  path. Reverse the encap loop to push first the inner then the outer vlan\n  header.\n\n- Postpone pushing the layer 2 header once destination device is known.\n  This allows to calculate the needed hearoom via LL_RESERVED_SPACE to\n  accommodate the layer 2 headers.\n\n- Add and use nf_flow_vlan_push() as suggested by Eric Woudstra, this\n  is a simplified version of skb_vlan_push() for egress path only.\n\n- skb_postpush_rcsum()\n\nFixes: c653d5a78f34 (\"netfilter: flowtable: inline vlan encapsulation in xmit path\")\nSigned-off-by: Pablo Neira Ayuso <pablo@netfilter.org>\n---\nv6: add skb_postpush_rcsum() as suggested by AI reviewer.\n\n net/netfilter/nf_flow_table_ip.c | 110 ++++++++++++++++++++-----------\n 1 file changed, 73 insertions(+), 37 deletions(-)","diff":"diff --git a/net/netfilter/nf_flow_table_ip.c b/net/netfilter/nf_flow_table_ip.c\nindex 8d5fb7e940a1..0ce3c209050c 100644\n--- a/net/netfilter/nf_flow_table_ip.c\n+++ b/net/netfilter/nf_flow_table_ip.c\n@@ -462,32 +462,6 @@ static void nf_flow_encap_pop(struct nf_flowtable_ctx *ctx,\n \t\tnf_flow_ip_tunnel_pop(ctx, skb);\n }\n \n-struct nf_flow_xmit {\n-\tconst void\t\t*dest;\n-\tconst void\t\t*source;\n-\tstruct net_device\t*outdev;\n-};\n-\n-static unsigned int nf_flow_queue_xmit(struct net *net, struct sk_buff *skb,\n-\t\t\t\t       struct nf_flow_xmit *xmit)\n-{\n-\tstruct net_device *dev = xmit->outdev;\n-\tunsigned int hh_len = LL_RESERVED_SPACE(dev);\n-\n-\tif (unlikely(skb_headroom(skb) < hh_len && dev->header_ops)) {\n-\t\tskb = skb_expand_head(skb, hh_len);\n-\t\tif (!skb)\n-\t\t\treturn NF_STOLEN;\n-\t}\n-\n-\tskb->dev = dev;\n-\tdev_hard_header(skb, dev, ntohs(skb->protocol),\n-\t\t\txmit->dest, xmit->source, skb->len);\n-\tdev_queue_xmit(skb);\n-\n-\treturn NF_STOLEN;\n-}\n-\n static struct flow_offload_tuple_rhash *\n nf_flow_offload_lookup(struct nf_flowtable_ctx *ctx,\n \t\t       struct nf_flowtable *flow_table, struct sk_buff *skb)\n@@ -553,6 +527,32 @@ static int nf_flow_offload_forward(struct nf_flowtable_ctx *ctx,\n \treturn 1;\n }\n \n+/* Similar to skb_vlan_push. */\n+static int nf_flow_vlan_push(struct sk_buff *skb, __be16 proto, u16 id,\n+\t\t\t     u32 needed_headroom)\n+{\n+\tif (skb_vlan_tag_present(skb)) {\n+\t\tstruct vlan_hdr *vhdr;\n+\n+\t\tif (skb_cow_head(skb, needed_headroom + VLAN_HLEN))\n+\t\t\treturn -1;\n+\n+\t\t__skb_push(skb, VLAN_HLEN);\n+\t\tif (skb_mac_header_was_set(skb))\n+\t\t\tskb->mac_header -= VLAN_HLEN;\n+\n+\t\tvhdr = (struct vlan_hdr *)skb->data;\n+\t\tskb->network_header -= VLAN_HLEN;\n+\t\tvhdr->h_vlan_TCI = htons(skb_vlan_tag_get(skb));\n+\t\tvhdr->h_vlan_encapsulated_proto = skb->protocol;\n+\t\tskb->protocol = skb->vlan_proto;\n+\t\tskb_postpush_rcsum(skb, skb->data, VLAN_HLEN);\n+\t}\n+\t__vlan_hwaccel_put_tag(skb, proto, id);\n+\n+\treturn 0;\n+}\n+\n static int nf_flow_pppoe_push(struct sk_buff *skb, u16 id)\n {\n \tint data_len = skb->len + sizeof(__be16);\n@@ -739,17 +739,19 @@ static int nf_flow_tunnel_v6_push(struct net *net, struct sk_buff *skb,\n }\n \n static int nf_flow_encap_push(struct sk_buff *skb,\n-\t\t\t      struct flow_offload_tuple *tuple)\n+\t\t\t      struct flow_offload_tuple *tuple,\n+\t\t\t      struct net_device *outdev)\n {\n+\tu32 needed_headroom = LL_RESERVED_SPACE(outdev);\n \tint i;\n \n-\tfor (i = 0; i < tuple->encap_num; i++) {\n+\tfor (i = tuple->encap_num - 1; i >= 0; i--) {\n \t\tswitch (tuple->encap[i].proto) {\n \t\tcase htons(ETH_P_8021Q):\n \t\tcase htons(ETH_P_8021AD):\n-\t\t\tskb_reset_mac_header(skb);\n-\t\t\tif (skb_vlan_push(skb, tuple->encap[i].proto,\n-\t\t\t\t\t  tuple->encap[i].id) < 0)\n+\t\t\tif (nf_flow_vlan_push(skb, tuple->encap[i].proto,\n+\t\t\t\t\t      tuple->encap[i].id,\n+\t\t\t\t\t      needed_headroom) < 0)\n \t\t\t\treturn -1;\n \t\t\tbreak;\n \t\tcase htons(ETH_P_PPP_SES):\n@@ -762,6 +764,44 @@ static int nf_flow_encap_push(struct sk_buff *skb,\n \treturn 0;\n }\n \n+struct nf_flow_xmit {\n+\tconst void\t\t*dest;\n+\tconst void\t\t*source;\n+\tstruct net_device\t*outdev;\n+\tstruct flow_offload_tuple *tuple;\n+};\n+\n+static void __nf_flow_queue_xmit(struct net *net, struct sk_buff *skb,\n+\t\t\t\t struct nf_flow_xmit *xmit)\n+{\n+\tstruct net_device *dev = xmit->outdev;\n+\tunsigned int hh_len = LL_RESERVED_SPACE(dev);\n+\n+\tif (unlikely(skb_headroom(skb) < hh_len && dev->header_ops)) {\n+\t\tskb = skb_expand_head(skb, hh_len);\n+\t\tif (!skb)\n+\t\t\treturn;\n+\t}\n+\n+\tskb->dev = dev;\n+\tdev_hard_header(skb, dev, ntohs(skb->protocol),\n+\t\t\txmit->dest, xmit->source, skb->len);\n+\tdev_queue_xmit(skb);\n+}\n+\n+static unsigned int nf_flow_queue_xmit(struct net *net, struct sk_buff *skb,\n+\t\t\t\t       struct nf_flow_xmit *xmit)\n+{\n+\tif (xmit->tuple->encap_num) {\n+\t\tif (nf_flow_encap_push(skb, xmit->tuple, xmit->outdev) < 0)\n+\t\t\treturn NF_DROP;\n+\t}\n+\n+\t__nf_flow_queue_xmit(net, skb, xmit);\n+\n+\treturn NF_STOLEN;\n+}\n+\n unsigned int\n nf_flow_offload_ip_hook(void *priv, struct sk_buff *skb,\n \t\t\tconst struct nf_hook_state *state)\n@@ -806,9 +846,6 @@ nf_flow_offload_ip_hook(void *priv, struct sk_buff *skb,\n \tif (nf_flow_tunnel_v4_push(state->net, skb, other_tuple, &ip_daddr) < 0)\n \t\treturn NF_DROP;\n \n-\tif (nf_flow_encap_push(skb, other_tuple) < 0)\n-\t\treturn NF_DROP;\n-\n \tswitch (tuplehash->tuple.xmit_type) {\n \tcase FLOW_OFFLOAD_XMIT_NEIGH:\n \t\trt = dst_rtable(tuplehash->tuple.dst_cache);\n@@ -838,6 +875,7 @@ nf_flow_offload_ip_hook(void *priv, struct sk_buff *skb,\n \t\tWARN_ON_ONCE(1);\n \t\treturn NF_DROP;\n \t}\n+\txmit.tuple = other_tuple;\n \n \treturn nf_flow_queue_xmit(state->net, skb, &xmit);\n }\n@@ -1128,9 +1166,6 @@ nf_flow_offload_ipv6_hook(void *priv, struct sk_buff *skb,\n \t\t\t\t   &ip6_daddr, encap_limit) < 0)\n \t\treturn NF_DROP;\n \n-\tif (nf_flow_encap_push(skb, other_tuple) < 0)\n-\t\treturn NF_DROP;\n-\n \tswitch (tuplehash->tuple.xmit_type) {\n \tcase FLOW_OFFLOAD_XMIT_NEIGH:\n \t\trt = dst_rt6_info(tuplehash->tuple.dst_cache);\n@@ -1160,6 +1195,7 @@ nf_flow_offload_ipv6_hook(void *priv, struct sk_buff *skb,\n \t\tWARN_ON_ONCE(1);\n \t\treturn NF_DROP;\n \t}\n+\txmit.tuple = other_tuple;\n \n \treturn nf_flow_queue_xmit(state->net, skb, &xmit);\n }\n","prefixes":["nf","v6","2/4"]}