{"id":2231048,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2231048/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260430094238.987976-3-grzegorz.nitka@intel.com/","project":{"id":46,"url":"http://patchwork.ozlabs.org/api/1.1/projects/46/?format=json","name":"Intel Wired Ethernet development","link_name":"intel-wired-lan","list_id":"intel-wired-lan.osuosl.org","list_email":"intel-wired-lan@osuosl.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260430094238.987976-3-grzegorz.nitka@intel.com>","date":"2026-04-30T09:42:32","name":"[v7,net-next,2/8] dpll: allow registering FW-identified pin with a different DPLL","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"ccb4649b3fd3608dfba7bf38c03d13ac5b128f01","submitter":{"id":82711,"url":"http://patchwork.ozlabs.org/api/1.1/people/82711/?format=json","name":"Nitka, Grzegorz","email":"grzegorz.nitka@intel.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260430094238.987976-3-grzegorz.nitka@intel.com/mbox/","series":[{"id":502259,"url":"http://patchwork.ozlabs.org/api/1.1/series/502259/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=502259","date":"2026-04-30T09:42:30","name":"dpll/ice: Add generic DPLL type and full TX reference clock control for E825","version":7,"mbox":"http://patchwork.ozlabs.org/series/502259/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2231048/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2231048/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=WZ2iWEbD;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5q8B5zJBz1yHZ\n\tfor ; Thu, 30 Apr 2026 19:47:06 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 79B0284467;\n\tThu, 30 Apr 2026 09:47:04 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id wvMMt04NPzez; Thu, 30 Apr 2026 09:47:00 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 0FECA84464;\n\tThu, 30 Apr 2026 09:46:56 +0000 (UTC)","from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n by lists1.osuosl.org (Postfix) with ESMTP id 4E8AF18F\n for ; Thu, 30 Apr 2026 09:46:54 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id 34B6442782\n for ; Thu, 30 Apr 2026 09:46:54 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id AQx0Bk4T7Wsy for ;\n Thu, 30 Apr 2026 09:46:53 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [192.198.163.12])\n by smtp4.osuosl.org (Postfix) with ESMTPS id DB02D42781\n for ; Thu, 30 Apr 2026 09:46:52 +0000 (UTC)","from orviesa001.jf.intel.com ([10.64.159.141])\n by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 30 Apr 2026 02:46:52 -0700","from gklab-003-001.igk.intel.com ([10.91.173.48])\n by orviesa001.jf.intel.com with ESMTP; 30 Apr 2026 02:46:47 -0700"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp1.osuosl.org 0FECA84464","OpenDKIM Filter v2.11.0 smtp4.osuosl.org DB02D42781"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1777542416;\n\tbh=3iUAXAMhvXecm+oHVms/+wGjpA7ssvDLru0iFsh2l+U=;\n\th=From:To:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t Cc:From;\n\tb=WZ2iWEbDPS0G6V3ISku4/S9/2fcdcYtzk8/3G19ozzrphHQU8NA0C/f+5Yud5toFm\n\t AnGg+ltC/FmnZHCy/y6l6zJI9rgb6ssJ+uHqqQUyRQ6MNkK0j3TWaz4rT5z0sc/SdB\n\t toz9XvcCm90viVS9OnuNK/IW38bFlPqv7YwDE81htBG2WffYsk5iN4QmXd06vssGcX\n\t mwaQgGmudqeGRhZ5DlajMZz/gePweiUdjnQKkJMGUthaSaDuFTHdjL58D/ISmjbmGg\n\t n09nlZPlWOpWLQfN57V0svTQGjhottLDW/+0ux1dPoWXpJ01zzr/+jnt7MDQydwwBj\n\t OAXdRhOhHNnhg==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.12;\n helo=mgamail.intel.com; envelope-from=grzegorz.nitka@intel.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp4.osuosl.org DB02D42781","X-CSE-ConnectionGUID":["Gao/FpaiS++zHDbjjrHWwA==","59Py9SOzQTWl3mG6rX/Zlg=="],"X-CSE-MsgGUID":["rIWpeuUjTzSi1tL+ZGtoFw==","N9nGTysXSpSRPoxcZo0z1w=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11771\"; a=\"82342590\"","E=Sophos;i=\"6.23,207,1770624000\"; d=\"scan'208\";a=\"82342590\"","E=Sophos;i=\"6.23,207,1770624000\"; d=\"scan'208\";a=\"272649754\""],"X-ExtLoop1":"1","From":"Grzegorz Nitka ","To":"netdev@vger.kernel.org","Date":"Thu, 30 Apr 2026 11:42:32 +0200","Message-Id":"<20260430094238.987976-3-grzegorz.nitka@intel.com>","X-Mailer":"git-send-email 2.39.3","In-Reply-To":"<20260430094238.987976-1-grzegorz.nitka@intel.com>","References":"<20260430094238.987976-1-grzegorz.nitka@intel.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1777542413; x=1809078413;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=/HBM1v6M04Z+Jc0mYsEibM5D9jaupGjKj8gDCUGJ9xY=;\n b=D/NggZxYybTb8cT3ktSaM93AEBCuHDT+ShglguWKK4+WfhSE2fR+uNKy\n 08VAgvCH1QG8pTMnQ8rcfiTyqHklpLo5itFdEugpFlFoIHfJqplFI+LLi\n JpmUbPzhHSACSZTDUY1VWAioGnFM+kG88Y+0iiqneEi/idB1+oXHm/NtN\n qj+QVHW7ScqLVCekZtinlwhwAZlFAcS6pWcYo9X89UDO5gfMRQ1/1NPby\n UufH2+Z9NdLkUmfoYpaSJ8LJ0G0WIKpuf83Ie9dwmb4vkBfl6yq8VTpx/\n VqwhWJaKCsRMt/WslXCPwxS9oCNrEqajFXf6nuz0tTNPD4eBWHJ2FDR7F\n g==;","X-Mailman-Original-Authentication-Results":["smtp4.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com","smtp4.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=D/NggZxY"],"Subject":"[Intel-wired-lan] [PATCH v7 net-next 2/8] dpll: allow registering\n FW-identified pin with a different DPLL","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"ivecera@redhat.com, vadim.fedorenko@linux.dev, kuba@kernel.org,\n jiri@resnulli.us, edumazet@google.com, przemyslaw.kitszel@intel.com,\n richardcochran@gmail.com, donald.hunter@gmail.com,\n linux-kernel@vger.kernel.org, arkadiusz.kubalewski@intel.com,\n Aleksandr Loktionov , andrew+netdev@lunn.ch,\n intel-wired-lan@lists.osuosl.org, horms@kernel.org,\n Prathosh.Satish@microchip.com, anthony.l.nguyen@intel.com, pabeni@redhat.com,\n davem@davemloft.net, Jiri Pirko ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "},"content":"Relax the (module, clock_id) equality requirement when registering a\npin identified by firmware (pin->fwnode). Some platforms associate a\nFW-described pin with a DPLL instance that differs from the pin's\n(module, clock_id) tuple. For such pins, permit registration without\nrequiring the strict match. Non-FW pins still require equality.\n\nReviewed-by: Jiri Pirko \nReviewed-by: Arkadiusz Kubalewski \nReviewed-by: Aleksandr Loktionov \nSigned-off-by: Grzegorz Nitka \n---\n drivers/dpll/dpll_core.c | 18 ++++++++++++++----\n 1 file changed, 14 insertions(+), 4 deletions(-)","diff":"diff --git a/drivers/dpll/dpll_core.c b/drivers/dpll/dpll_core.c\nindex cbb635db4321..afe4552bdcd4 100644\n--- a/drivers/dpll/dpll_core.c\n+++ b/drivers/dpll/dpll_core.c\n@@ -883,11 +883,21 @@ dpll_pin_register(struct dpll_device *dpll, struct dpll_pin *pin,\n \t\treturn -EINVAL;\n \n \tmutex_lock(&dpll_lock);\n-\tif (WARN_ON(!(dpll->module == pin->module &&\n-\t\t dpll->clock_id == pin->clock_id)))\n+\n+\t/*\n+\t * For pins identified via firmware (pin->fwnode), allow registration\n+\t * even if the pin's (module, clock_id) differs from the target DPLL.\n+\t * For non-fwnode pins, require a strict (module, clock_id) match.\n+\t */\n+\tif (!pin->fwnode &&\n+\t WARN_ON_ONCE(dpll->module != pin->module ||\n+\t\t\t dpll->clock_id != pin->clock_id)) {\n \t\tret = -EINVAL;\n-\telse\n-\t\tret = __dpll_pin_register(dpll, pin, ops, priv, NULL);\n+\t\tgoto out_unlock;\n+\t}\n+\n+\tret = __dpll_pin_register(dpll, pin, ops, priv, NULL);\n+out_unlock:\n \tmutex_unlock(&dpll_lock);\n \n \treturn ret;\n","prefixes":["v7","net-next","2/8"]}