{"id":2231039,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2231039/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-ppc/patch/20260430093810.2762539-24-peter.maydell@linaro.org/","project":{"id":69,"url":"http://patchwork.ozlabs.org/api/1.1/projects/69/?format=json","name":"QEMU powerpc development","link_name":"qemu-ppc","list_id":"qemu-ppc.nongnu.org","list_email":"qemu-ppc@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260430093810.2762539-24-peter.maydell@linaro.org>","date":"2026-04-30T09:38:08","name":"[v2,23/25] monitor/hmp-cmds: Use cpu_translate_for_debug()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"8046bdf29dc59a95a08913234525636a0ff52f29","submitter":{"id":5111,"url":"http://patchwork.ozlabs.org/api/1.1/people/5111/?format=json","name":"Peter Maydell","email":"peter.maydell@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-ppc/patch/20260430093810.2762539-24-peter.maydell@linaro.org/mbox/","series":[{"id":502256,"url":"http://patchwork.ozlabs.org/api/1.1/series/502256/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-ppc/list/?series=502256","date":"2026-04-30T09:37:46","name":"Handle sub-page granularity in cpu_memory_rw_debug()","version":2,"mbox":"http://patchwork.ozlabs.org/series/502256/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2231039/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2231039/checks/","tags":{},"headers":{"Return-Path":"<qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=NHMMIryZ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5q5l0LfMz1xqf\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 30 Apr 2026 19:44:59 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-ppc-bounces@nongnu.org>)\n\tid 1wINrK-0005Xq-Gs; Thu, 30 Apr 2026 05:39:02 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <peter.maydell@linaro.org>)\n id 1wINrG-0005N1-Al\n for qemu-ppc@nongnu.org; Thu, 30 Apr 2026 05:38:58 -0400","from mail-wm1-x329.google.com ([2a00:1450:4864:20::329])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <peter.maydell@linaro.org>)\n id 1wINr1-0002px-EP\n for qemu-ppc@nongnu.org; Thu, 30 Apr 2026 05:38:58 -0400","by mail-wm1-x329.google.com with SMTP id\n 5b1f17b1804b1-4891cd41959so6386495e9.3\n for <qemu-ppc@nongnu.org>; Thu, 30 Apr 2026 02:38:42 -0700 (PDT)","from lanath.. (wildly.archaic.org.uk. [81.2.115.145])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-447b421721fsm10816795f8f.15.2026.04.30.02.38.40\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 30 Apr 2026 02:38:40 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777541922; x=1778146722; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=WCh2RmxvYZV/ZNYedrXNpgq7MB2RbmztWhGGLEAmQKE=;\n b=NHMMIryZJ3T0hN38xfIijGnCf6Gw8wVkfFH1I+E29DBm1sJpIJZ0vsF9Dh8o/iKtiC\n Bd93aGXbK/Js1KG9eRYV61nCmNTDrOWdVB2LNtpBNX+PGIXIJ8olM/IMDOcoP0E2KW7J\n o7fGSV3UfSEzq/jl+U5whM0poja+AmzweendhOcIcxtiFTq6CEOLAeCf/fSvKwu4+1KZ\n AwHBRFfb9IyCROYjEf23KbOtv4yvNcdRSOyINrsNNvWyJH8dFldZ1KGQx/4eQ7RviPwt\n XhafervI6ScriK1YxUG3GuFGgEgc0MgdxnNi9nx2hl1JlBYSsHDi63sdFIqLieuHcJr8\n YXPQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777541922; x=1778146722;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=WCh2RmxvYZV/ZNYedrXNpgq7MB2RbmztWhGGLEAmQKE=;\n b=IwHLjncNtqy+jwEuWXCcAUCGXbaX+I6sZJXhhrgX65jlcRp/PJIy35idAnHBo3Og34\n obzQjQLkHIkCcF8I+EEBmTw5/DOUVKvflaionDnKzOzNrE7C1/UZv4CQ2H6chmFV6x8B\n n2lUP0mF4bVDUfqIsjqAZgTkP0ZExiEMJr6p1uw6WvH1ipa6i8k18z7J0JHXvII7Xx50\n DRhwYeeOtbRoGQQheJJTM8y8L8cCdSKdV98rBz0NDmGX3uTjp8lkjT981mV1NUs6Dx8s\n P3Ov84L8eYRL7MGdA6GgPtap+znAEiwyVECOxcHLkRekcufbdP5/rkViBVGbMP3yNLQt\n 43yg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ9e13Y6mXKuWWsuz/WVYru7aJGx5tXBkENU8e9WU3bsTY4U8Ti7fAQ3pJN02rPzJb6+ZLi0ZAjbhw==@nongnu.org","X-Gm-Message-State":"AOJu0YwlEU55/ne8DzQlppFcf/cb1CFAxDWdwdqeZjygwBw3GBtO8V/o\n Vc8SSh+I38vwVcN9W5mYQFWutXidqG4DHywWUdr3RDptP/dIIuDrxFux4E4WfCNJIhM=","X-Gm-Gg":"AeBDietPHeofHfKB+b6eFgNLdhn0D4gAG7b5cEF2JeYL9fmamx7DIRtHO6QXjmHDrn+\n PswYgpkH/yYss8oH4VHah17O0Wkj8ehl3CM/6Ntz+xM0QIkga1SW/BPu+EFf4JRjaIWp23hCYne\n pDbB65sVLUz3khL7wloU6f5OozB5TrBS7PPXY1EpRjZwSfz6PWHhYv6c243x1dm0uUYEDUTYB8g\n BZ5DQpYiKFnKzgYIppzJMKSjzXGhSaPDbufZvwsKZ9JpOAqEUnIqihC9VxapHLEKnh5GeBSsiha\n Kg29hlpbL/fxSOgwB/HKuCtQop//hrgWsd3W6Ubq3FjZYsu1Xm8Mxr1qDOq+7c+JVzM3l53wiyf\n o23VqLNqQ5h/kLKfLXbDjBr6NA4D8888nuB+acChMj+DXkXIk2ufgT5P0WKGppeO4S7tpIH2+Jp\n Nvs4u0e3T/OXPQOyeEMusd7F30wwX74rfHGrpHj5KUmdPMG01fWrzAGkCRxBjNdcvCgePupj2pi\n b7dZcboL7YwjOCDr7e8mtzTGOUTzTBW7a9xQf2P/A==","X-Received":"by 2002:a05:600c:4594:b0:488:e7e4:8425 with SMTP id\n 5b1f17b1804b1-48a8445d10cmr36275865e9.23.1777541921847;\n Thu, 30 Apr 2026 02:38:41 -0700 (PDT)","From":"Peter Maydell <peter.maydell@linaro.org>","To":"qemu-devel@nongnu.org","Cc":"qemu-arm@nongnu.org, qemu-ppc@nongnu.org, qemu-riscv@nongnu.org,\n qemu-s390x@nongnu.org,\n =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>,\n Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,\n Yanan Wang <wangyanan55@huawei.com>, Zhao Liu <zhao1.liu@intel.com>,\n Paolo Bonzini <pbonzini@redhat.com>,\n Richard Henderson <richard.henderson@linaro.org>,\n \"Dr. David Alan Gilbert\" <dave@treblig.org>,\n =?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>,\n Alexandre Iooss <erdnaxe@crans.org>, Mahmoud Mandour <ma.mandourr@gmail.com>,\n Peter Xu <peterx@redhat.com>, \"Edgar E. Iglesias\" <edgar.iglesias@gmail.com>,\n Jiaxun Yang <jiaxun.yang@flygoat.com>, Nicholas Piggin <npiggin@gmail.com>,\n Chinmay Rath <rathc@linux.ibm.com>, Glenn Miles <milesg@linux.ibm.com>,\n Palmer Dabbelt <palmer@dabbelt.com>,\n Alistair Francis <alistair.francis@wdc.com>, Weiwei Li <liwei1518@gmail.com>,\n Daniel Henrique Barboza <daniel.barboza@oss.qualcomm.com>,\n Liu Zhiwei <zhiwei_liu@linux.alibaba.com>,\n Chao Liu <chao.liu.zevorn@gmail.com>, Ilya Leoshkevich <iii@linux.ibm.com>,\n David Hildenbrand <david@kernel.org>,\n Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,\n Artyom Tarasenko <atar4qemu@gmail.com>, Max Filippov <jcmvbkbc@gmail.com>","Subject":"[PATCH v2 23/25] monitor/hmp-cmds: Use cpu_translate_for_debug()","Date":"Thu, 30 Apr 2026 10:38:08 +0100","Message-ID":"<20260430093810.2762539-24-peter.maydell@linaro.org>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260430093810.2762539-1-peter.maydell@linaro.org>","References":"<20260430093810.2762539-1-peter.maydell@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::329;\n envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x329.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-ppc@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<qemu-ppc.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-ppc>,\n <mailto:qemu-ppc-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-ppc>","List-Post":"<mailto:qemu-ppc@nongnu.org>","List-Help":"<mailto:qemu-ppc-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-ppc>,\n <mailto:qemu-ppc-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"We want to remove the cpu_get_phys_addr_debug() function; update the\nHMP gva2gpa command implementation to use cpu_translate_for_debug()\ninstead.\n\nSigned-off-by: Peter Maydell <peter.maydell@linaro.org>\n---\n monitor/hmp-cmds.c | 7 +++----\n 1 file changed, 3 insertions(+), 4 deletions(-)","diff":"diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c\nindex f8380bda58..2acdcf7d78 100644\n--- a/monitor/hmp-cmds.c\n+++ b/monitor/hmp-cmds.c\n@@ -713,18 +713,17 @@ void hmp_gva2gpa(Monitor *mon, const QDict *qdict)\n {\n     vaddr addr = qdict_get_int(qdict, \"addr\");\n     CPUState *cs = mon_get_cpu(mon);\n-    hwaddr gpa;\n+    TranslateForDebugResult tres;\n \n     if (!cs) {\n         monitor_printf(mon, \"No cpu\\n\");\n         return;\n     }\n \n-    gpa  = cpu_get_phys_addr_debug(cs, addr);\n-    if (gpa == -1) {\n+    if (!cpu_translate_for_debug(cs, addr, &tres)) {\n         monitor_printf(mon, \"Unmapped\\n\");\n     } else {\n-        monitor_printf(mon, \"gpa: 0x%\" HWADDR_PRIx \"\\n\", gpa);\n+        monitor_printf(mon, \"gpa: 0x%\" HWADDR_PRIx \"\\n\", tres.physaddr);\n     }\n }\n \n","prefixes":["v2","23/25"]}