{"id":2231035,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2231035/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-ppc/patch/20260430093810.2762539-21-peter.maydell@linaro.org/","project":{"id":69,"url":"http://patchwork.ozlabs.org/api/1.1/projects/69/?format=json","name":"QEMU powerpc development","link_name":"qemu-ppc","list_id":"qemu-ppc.nongnu.org","list_email":"qemu-ppc@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260430093810.2762539-21-peter.maydell@linaro.org>","date":"2026-04-30T09:38:05","name":"[v2,20/25] target/sparc: Use cpu_translate_for_debug()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"ef5d604c193d5b6aead21edb09fa05ac6ac81135","submitter":{"id":5111,"url":"http://patchwork.ozlabs.org/api/1.1/people/5111/?format=json","name":"Peter Maydell","email":"peter.maydell@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-ppc/patch/20260430093810.2762539-21-peter.maydell@linaro.org/mbox/","series":[{"id":502256,"url":"http://patchwork.ozlabs.org/api/1.1/series/502256/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-ppc/list/?series=502256","date":"2026-04-30T09:37:46","name":"Handle sub-page granularity in cpu_memory_rw_debug()","version":2,"mbox":"http://patchwork.ozlabs.org/series/502256/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2231035/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2231035/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=pdNILHMJ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5q5T2SSRz1xqf\n\tfor ; Thu, 30 Apr 2026 19:44:45 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wINrH-0005PU-KN; Thu, 30 Apr 2026 05:38:59 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wINrB-0005B3-SC\n for qemu-ppc@nongnu.org; Thu, 30 Apr 2026 05:38:53 -0400","from mail-wr1-x430.google.com ([2a00:1450:4864:20::430])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wINqy-0002mU-8J\n for qemu-ppc@nongnu.org; Thu, 30 Apr 2026 05:38:53 -0400","by mail-wr1-x430.google.com with SMTP id\n ffacd0b85a97d-446fea16729so636835f8f.3\n for ; Thu, 30 Apr 2026 02:38:39 -0700 (PDT)","from lanath.. (wildly.archaic.org.uk. [81.2.115.145])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-447b421721fsm10816795f8f.15.2026.04.30.02.38.36\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 30 Apr 2026 02:38:37 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777541918; x=1778146718; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=WDQ7la2K8WbK8u2/23ch5pBkMkaDcwKmzot+lA8IzKQ=;\n b=pdNILHMJZ7QVh0cmQ6Y6dadwjvmv63QU75CS7bYaPTq8IkSxG9BxEg93lhFBL7+0mh\n zGa8XhGMK+TbUcPplaSDcxOjQ3qt4ENXLid7WNgb8FeHulS9+1jj8jBo+owRLU8xHLtV\n GKDVN8pF847wC5Y1nE9vNuDR8tqgNgAfmgKqpuOcJhlsEiGDozPwlQvTo/+jY0hOOWgd\n r66FXpy5Aw3y3E4+M2dSNCO+03hLUdljAHNYrvD7CsOJrD3ndhnK8289YdWyhBgtXI5u\n CYX4YPkLLzIEcKz5PoEOUqgW6nU/Mx5OYEgzVXBxxcL5qZC17y4g0dEtSprjY2vZKogo\n GEFA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777541918; x=1778146718;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=WDQ7la2K8WbK8u2/23ch5pBkMkaDcwKmzot+lA8IzKQ=;\n b=O+COEELFPtRGsYeIORwtlncxzvietz/9WOehS5C9+ZtrDIbZj2URlOidNF9tqu23Ky\n QHTTWA8Ol3rN8BOj0NTCzcFielmSE0L3jwCZZvNU3LZSe72J8EJv2eMaJFNGkZ4aeTzV\n xuZ3E8Y5l6l6pUjwn5qb9l42StYB7UNV/TRAVfyENsTsaZ4H1hnPUPSzMUVt2f1VdYpT\n /hD4mLsoInjxE1Ap749itUB0prw3fvXt/TisQtPHYsufJUDnaL3YWQUswqR9iDNmoyjT\n lmzpc0oCGtepYD/C3JVhufd8b7/qj3b1mhhkdIA6Efh+yGGrQw3ShFEKUqnJ2wCTEqL9\n 0viQ==","X-Forwarded-Encrypted":"i=1;\n AFNElJ8QvEAcgQ6tMynqlDC+5Pa9ariee7bYDP5bF1cnLYumA73wPaGSs9DWD1qy9JOVImL5RQ9vokinpw==@nongnu.org","X-Gm-Message-State":"AOJu0YyWmlBflIaQrRM4K65pheTFKKKRM2F/NRZXBu99YET1rWLoSNgS\n FQVYOjHBBzRckS9M9vyl34/+tmZeJBaD04VzTsZ1MxQJC3SgLV+eoIi2SKdXormkiRs=","X-Gm-Gg":"AeBDietBTmsU+tagsE/HEay85XWiisbjjv2mfy/8HVVz5dK4bVDSwCPjj8WLSJC3j2Y\n egQeZFWbOud7/kHP6hAUbvtSAbU/PXlRdscNckVkOnJFgCqp+Uh9n/Di6/3/7IdgPjck9pnLod2\n TvJotKf/WU+/yuSxVwl9k1PMYYf2IqFxw9qAYNfAo5+bMdlOSSRWue/hQIgBois4uI17TWNgUsV\n nmo3VUpl794n9x3cVjdXyZn0YPBoWGLhhOjumko2zJ5hvVr7PI2HA4RpALYT6FKKbQn95XdLW8R\n HkVJcvljQ5erV+sL/hLV749JCHu/KWSPx4wrbPRRtUIaibWe2iHJ5R6t0tRs6dlgTi2Ic8mUSWe\n mt8AKoZw/7Wib5rYf/GABlRyIwj0pNOgRfvBl1yN9wiCJRp5SNcNKG2HlUoT3RUqTF0KcPEJT1Y\n Xzj/HXKfKytAfaJpQaEnZ4JmfOmN0zojnfhnNLV3jBNQGcWIwHSfh3uw+b5q+WjNFM4D0AmeOKY\n yleTolnV15dj+qOrhJhUQOy5yaTSlGU4wAsS1+YBg==","X-Received":"by 2002:a05:6000:2585:b0:43b:498f:dceb with SMTP id\n ffacd0b85a97d-4493c37ef0cmr3506822f8f.9.1777541917911;\n Thu, 30 Apr 2026 02:38:37 -0700 (PDT)","From":"Peter Maydell ","To":"qemu-devel@nongnu.org","Cc":"qemu-arm@nongnu.org, qemu-ppc@nongnu.org, qemu-riscv@nongnu.org,\n qemu-s390x@nongnu.org,\n =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n Marcel Apfelbaum ,\n Yanan Wang , Zhao Liu ,\n Paolo Bonzini ,\n Richard Henderson ,\n \"Dr. David Alan Gilbert\" ,\n =?utf-8?q?Alex_Benn=C3=A9e?= ,\n Alexandre Iooss , Mahmoud Mandour ,\n Peter Xu , \"Edgar E. Iglesias\" ,\n Jiaxun Yang , Nicholas Piggin ,\n Chinmay Rath , Glenn Miles ,\n Palmer Dabbelt ,\n Alistair Francis , Weiwei Li ,\n Daniel Henrique Barboza ,\n Liu Zhiwei ,\n Chao Liu , Ilya Leoshkevich ,\n David Hildenbrand ,\n Mark Cave-Ayland ,\n Artyom Tarasenko , Max Filippov ","Subject":"[PATCH v2 20/25] target/sparc: Use cpu_translate_for_debug()","Date":"Thu, 30 Apr 2026 10:38:05 +0100","Message-ID":"<20260430093810.2762539-21-peter.maydell@linaro.org>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260430093810.2762539-1-peter.maydell@linaro.org>","References":"<20260430093810.2762539-1-peter.maydell@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::430;\n envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x430.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-ppc@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"We want to remove the cpu_get_phys_addr_debug() function; update the\nsparc dump_mmu() function to use cpu_translate_for_debug() instead.\n\nThe \"mmu_probe succeeds but debug translate fails\" cases are probably\nnot possible in practice; since cpu_get_phys_addr_debug() would\nreturn -1 in that situation we make this conversion retain that\nbehaviour.\n\nSigned-off-by: Peter Maydell \n---\n target/sparc/mmu_helper.c | 19 ++++++++++++++++---\n 1 file changed, 16 insertions(+), 3 deletions(-)","diff":"diff --git a/target/sparc/mmu_helper.c b/target/sparc/mmu_helper.c\nindex e1abd520c4..e441ffb8f7 100644\n--- a/target/sparc/mmu_helper.c\n+++ b/target/sparc/mmu_helper.c\n@@ -360,26 +360,39 @@ void dump_mmu(CPUSPARCState *env)\n unsigned int n, m, o;\n hwaddr pa;\n uint32_t pde;\n+ TranslateForDebugResult tres;\n \n qemu_printf(\"Root ptr: \" HWADDR_FMT_plx \", ctx: %d\\n\",\n (hwaddr)env->mmuregs[1] << 4, env->mmuregs[2]);\n for (n = 0, va = 0; n < 256; n++, va += 16 * 1024 * 1024) {\n pde = mmu_probe(env, va, 2);\n if (pde) {\n- pa = cpu_get_phys_addr_debug(cs, va);\n+ if (!cpu_translate_for_debug(cs, va, &tres)) {\n+ pa = -1;\n+ } else {\n+ pa = tres.physaddr;\n+ }\n qemu_printf(\"VA: \" TARGET_FMT_lx \", PA: \" HWADDR_FMT_plx\n \" PDE: \" TARGET_FMT_lx \"\\n\", va, pa, pde);\n for (m = 0, va1 = va; m < 64; m++, va1 += 256 * 1024) {\n pde = mmu_probe(env, va1, 1);\n if (pde) {\n- pa = cpu_get_phys_addr_debug(cs, va1);\n+ if (!cpu_translate_for_debug(cs, va1, &tres)) {\n+ pa = -1;\n+ } else {\n+ pa = tres.physaddr;\n+ }\n qemu_printf(\" VA: \" TARGET_FMT_lx \", PA: \"\n HWADDR_FMT_plx \" PDE: \" TARGET_FMT_lx \"\\n\",\n va1, pa, pde);\n for (o = 0, va2 = va1; o < 64; o++, va2 += 4 * 1024) {\n pde = mmu_probe(env, va2, 0);\n if (pde) {\n- pa = cpu_get_phys_addr_debug(cs, va2);\n+ if (!cpu_translate_for_debug(cs, va2, &tres)) {\n+ pa = -1;\n+ } else {\n+ pa = tres.physaddr;\n+ }\n qemu_printf(\" VA: \" TARGET_FMT_lx \", PA: \"\n HWADDR_FMT_plx \" PTE: \"\n TARGET_FMT_lx \"\\n\",\n","prefixes":["v2","20/25"]}