{"id":2231022,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2231022/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-ppc/patch/20260430093810.2762539-7-peter.maydell@linaro.org/","project":{"id":69,"url":"http://patchwork.ozlabs.org/api/1.1/projects/69/?format=json","name":"QEMU powerpc development","link_name":"qemu-ppc","list_id":"qemu-ppc.nongnu.org","list_email":"qemu-ppc@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260430093810.2762539-7-peter.maydell@linaro.org>","date":"2026-04-30T09:37:51","name":"[v2,06/25] target/x86: Make get_phys_page_attrs_debug handle non-page-aligned addrs","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"a52791bd400a72a92d531fb48b5d73ef14d4eb30","submitter":{"id":5111,"url":"http://patchwork.ozlabs.org/api/1.1/people/5111/?format=json","name":"Peter Maydell","email":"peter.maydell@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-ppc/patch/20260430093810.2762539-7-peter.maydell@linaro.org/mbox/","series":[{"id":502256,"url":"http://patchwork.ozlabs.org/api/1.1/series/502256/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-ppc/list/?series=502256","date":"2026-04-30T09:37:46","name":"Handle sub-page granularity in cpu_memory_rw_debug()","version":2,"mbox":"http://patchwork.ozlabs.org/series/502256/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2231022/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2231022/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=NlYoKLXO;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5q2z3Dlgz1xqf\n\tfor ; Thu, 30 Apr 2026 19:42:35 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wINr1-0004sv-6K; Thu, 30 Apr 2026 05:38:43 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wINqn-0004dv-KG\n for qemu-ppc@nongnu.org; Thu, 30 Apr 2026 05:38:29 -0400","from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wINqi-0002Uq-Ee\n for qemu-ppc@nongnu.org; Thu, 30 Apr 2026 05:38:29 -0400","by mail-wr1-x42b.google.com with SMTP id\n ffacd0b85a97d-43cff5dafc3so472856f8f.1\n for ; Thu, 30 Apr 2026 02:38:20 -0700 (PDT)","from lanath.. (wildly.archaic.org.uk. [81.2.115.145])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-447b421721fsm10816795f8f.15.2026.04.30.02.38.18\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 30 Apr 2026 02:38:18 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777541900; x=1778146700; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=PKFk4CN3FBO853sFmh35BMyRf7rQp8uz5AZqJXrG9f0=;\n b=NlYoKLXOLrcQGAOlWDO5P6fan8m93Sk+39VuTYaxNIQhzI38rQ2LODJLfGp80ETUj3\n y5AjMOHcTymEY8aIMfRTsvacEP8w/8HvvJPZ9AB98l3ZlWnHsdWOAy7ODzexN1vgvU03\n YqdozUWiBeBVX6qvWdkJ++WqbQpVhXlnDiEtyeDIbDg5vruKFcXMVb2od+r30LQi2Pdf\n Lu36cqV99LOjLGLQHvsxo/Ulr3Ebf6m4eS+CBaHmZ5CIAXdyP1pFygH7LMM5Grn76xI/\n EEIM3AMgECgHyMcHIx5tcDCgy1IvrQSOgs2uCCr0nPJpJ0N8z1ofSxUA+aSc0ki7rodS\n W7ww==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777541900; x=1778146700;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=PKFk4CN3FBO853sFmh35BMyRf7rQp8uz5AZqJXrG9f0=;\n b=AH9bjWt0ruIIfnuk5BtUr/xHOIapqTXcGkbAlaJ0uaqq3IVcdUGKuVNnxiJ9TDfxRu\n 6Ot0NIEEPnfKiGcjkzYhFKgKGiI0pWYgywggiYpoanLRdLaMFGtgBOE7zC0EJ1qmKPD0\n NV54Qpb8VhMHolA5a5r0dZnRm0aM0Uap4wh19Hj7jQ3/dXGUmsc+hMgVXwrNYt4IVIXa\n g2241qXFUcj1I12vPX5Khk0KN9cymAtCu16OXXkjbmaPxZLgzQrM+RTL6LEGTvse29J8\n wIRCwFpXK/MrWU2mt+p7kJJRgAQSMNe7jG/0RtJlElus3WdGPsbEe8oozw4qFiWUECUA\n r7EA==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/0tlRs4nNzSK8A9auLu2ptmxi41oxIx9r/UbsOCRg6OlM3ePXRChIyq2nxkAx8Y59Rd8dJ6JW5VA==@nongnu.org","X-Gm-Message-State":"AOJu0YwHRLflTh9A7JBto5HdEGVcdCMIB6cD2fG7LQF7QP5jEeC45XhA\n bx+9/VSEAkd0NeMVWltpEBvm5co0CyfiQFeAU7e5LlsdBOfuquK3BYoL2DPOfFDb58U=","X-Gm-Gg":"AeBDiesZN2A3+I+w4bUy5qYBF086zA3XctTwNkl2nudQXZ96MhXsfey3jaMZWkex4zz\n I1xweaNnSIeRLYV9s/lXY7U0ck26Fe7+7kJOGVf8keNQp/wMphHgMa06Rz0RTzJZTiOulYcdSUl\n 3brRML/8zXz+0TRITXo72V/g86rXKciBWqtte1BTycEu7/+jV/OFfh+2C6RDZU0Rpj7t9NAyPNg\n R2fKIO9DQqW9+vcI1jOS8Pm5+/6FBd/Tuo2s/tb7t5qgYKdLUWe8dDFBNIi3acnsRlWqlBSYP2h\n kDftSVjyPsB8rQQWVs70reyzuxaE1zR2ndeLT+rfW/AXbJMX8pvvlgDNYYSiy1wYTGJtoQcVC/S\n nQqqRbY8982Q78IQoHSAUKjgewzWQgslUWAsEm0/GYWOu/kFs7u4yqMGExhkBAxBc9RsnwVB1IK\n EJtPqqKbjeIctCDyRdiBr2I+1d76n08L91tNr60+7hU1yqLqxBP0gWl2KXzBUEz/hwklsuWi40T\n Gn4nJQf3TPP4Sw4stV0efh+OYjwFdOyGk4wcUIWlQ==","X-Received":"by 2002:a05:6000:144a:b0:437:711c:8754 with SMTP id\n ffacd0b85a97d-4493cb432dcmr3271035f8f.7.1777541899477;\n Thu, 30 Apr 2026 02:38:19 -0700 (PDT)","From":"Peter Maydell ","To":"qemu-devel@nongnu.org","Cc":"qemu-arm@nongnu.org, qemu-ppc@nongnu.org, qemu-riscv@nongnu.org,\n qemu-s390x@nongnu.org,\n =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n Marcel Apfelbaum ,\n Yanan Wang , Zhao Liu ,\n Paolo Bonzini ,\n Richard Henderson ,\n \"Dr. David Alan Gilbert\" ,\n =?utf-8?q?Alex_Benn=C3=A9e?= ,\n Alexandre Iooss , Mahmoud Mandour ,\n Peter Xu , \"Edgar E. Iglesias\" ,\n Jiaxun Yang , Nicholas Piggin ,\n Chinmay Rath , Glenn Miles ,\n Palmer Dabbelt ,\n Alistair Francis , Weiwei Li ,\n Daniel Henrique Barboza ,\n Liu Zhiwei ,\n Chao Liu , Ilya Leoshkevich ,\n David Hildenbrand ,\n Mark Cave-Ayland ,\n Artyom Tarasenko , Max Filippov ","Subject":"[PATCH v2 06/25] target/x86: Make get_phys_page_attrs_debug handle\n non-page-aligned addrs","Date":"Thu, 30 Apr 2026 10:37:51 +0100","Message-ID":"<20260430093810.2762539-7-peter.maydell@linaro.org>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260430093810.2762539-1-peter.maydell@linaro.org>","References":"<20260430093810.2762539-1-peter.maydell@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::42b;\n envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x42b.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-ppc@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Currently our implementations of SysemuCPUOps::get_phys_page_debug\nand SysemuCPUOps::get_phys_page_attrs_debug are a mix of \"accepts a\nnon-page-aligned virtual address and returns the corresponding\nnon-page-aligned physical address\" and \"only returns a page-aligned\nphysical address\". This is awkward for callsites, which in practice\nall want the physical address for an arbitrary virtual address and\nhave to work around the possibility of getting a page-aligned\naddress, and it doesn't account for protection being possibly on a\nsub-page-sized granularity. We want to standardize on the\nimplementation having to handle non-page-aligned addresses.\n\nFor x86 this is simple: we just need to stop rounding down the\ninput address to a TARGET_PAGE boundary when calculating the\nresult to return.\n\nSigned-off-by: Peter Maydell \nReviewed-by: Richard Henderson \nMessage-id: 20260417173105.1648172-6-peter.maydell@linaro.org\n---\n target/i386/helper.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/target/i386/helper.c b/target/i386/helper.c\nindex c397a6fde5..108b02396d 100644\n--- a/target/i386/helper.c\n+++ b/target/i386/helper.c\n@@ -372,7 +372,7 @@ hwaddr x86_cpu_get_phys_page_attrs_debug(CPUState *cs, vaddr addr,\n out:\n #endif\n pte &= PG_ADDRESS_MASK & ~(page_size - 1);\n- page_offset = (addr & TARGET_PAGE_MASK) & (page_size - 1);\n+ page_offset = addr & (page_size - 1);\n return pte | page_offset;\n }\n \n","prefixes":["v2","06/25"]}