{"id":2230999,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2230999/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260430093810.2762539-14-peter.maydell@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260430093810.2762539-14-peter.maydell@linaro.org>","date":"2026-04-30T09:37:58","name":"[v2,13/25] monitor: hmp_gva2gpa: Don't page-align cpu_get_phys_addr_debug() arg and return","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"b4053b687de7d45e80088a797fea2722d8f3d427","submitter":{"id":5111,"url":"http://patchwork.ozlabs.org/api/1.1/people/5111/?format=json","name":"Peter Maydell","email":"peter.maydell@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260430093810.2762539-14-peter.maydell@linaro.org/mbox/","series":[{"id":502257,"url":"http://patchwork.ozlabs.org/api/1.1/series/502257/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502257","date":"2026-04-30T09:37:47","name":"Handle sub-page granularity in cpu_memory_rw_debug()","version":2,"mbox":"http://patchwork.ozlabs.org/series/502257/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2230999/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2230999/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=QYzET7K/;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5pzH4cb7z1yGq\n\tfor ; Thu, 30 Apr 2026 19:39:23 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wINrE-0005JJ-Ll; Thu, 30 Apr 2026 05:38:56 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wINr2-0004uj-LL\n for qemu-devel@nongnu.org; Thu, 30 Apr 2026 05:38:44 -0400","from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wINqp-0002aU-3A\n for qemu-devel@nongnu.org; Thu, 30 Apr 2026 05:38:44 -0400","by mail-wr1-x42c.google.com with SMTP id\n ffacd0b85a97d-43fe3e22e33so399778f8f.0\n for ; Thu, 30 Apr 2026 02:38:30 -0700 (PDT)","from lanath.. (wildly.archaic.org.uk. [81.2.115.145])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-447b421721fsm10816795f8f.15.2026.04.30.02.38.27\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 30 Apr 2026 02:38:28 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777541909; x=1778146709; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=jeiJLcMiad4H/zhSQfsPf5Zc6NaSRLrWE13Uwy30mq4=;\n b=QYzET7K/BBExjVUvTgwvJEpwEtDC0IFg8J0Q3EJho2IlgA6zOvCKKEYlHQrcV+5bwA\n XgcvpzwVCZYedSSZbaYsO9SzOCpWU+/7x1QSDsSv5HON7T9uhWX3WheCv/abUe36vZMN\n Y3B+rlyyH8hpaT4o31kwzo0ukY3uJiw+6A0Hg+AKYuKMbB1Sp1fu8OqxF2VE4gbnvY18\n Cc+VUxqSqY9etv5a4lBwcqkqs/bzL396vOFjl2VRlwjgItZkXmzWMKRdvB+h8Aax3NZJ\n RPa4w72p37XYVmxlCDtwS7PlqHSGvEWhab8RIuIP03TfyCuEQwXYjJZb6SqRq9S8dpyP\n oKww==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777541909; x=1778146709;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=jeiJLcMiad4H/zhSQfsPf5Zc6NaSRLrWE13Uwy30mq4=;\n b=V355W07vbJE/Qz6HBo3grz0kIsK0ZWVIF+KWJc4jsfPk1jZNWz3oDX5AFtd5O9j3ik\n 3qCoqg5aKgvJEzA6NfY3AWjRoazSKMqwOUP0omxc50+r+SOqLGzv6ABqzMI+VDNBgcDD\n YI1fRQaTjGgCN70MlGdZYDdSFP0ZVMgvK4BlKaCt52ev3bXKGKcYS7Y4YnQ+Frdt2Wfx\n G2NBPwlJzUrcN+pi7JiwmHD0631lrBgaWeOQHufauy7I9Dhj0cj8OmY9sbUBcXSKT4G7\n a3ZMKsxVB+DCe2T42pTgGhw0mb+Wff7SdW2v9x2XU47pSuBv1TMr9zqnpRoUkiZGSQw5\n QZWQ==","X-Gm-Message-State":"AOJu0YxqDRVJMxz13gMAeWOq8vBwtYL+r3ywYpjerpAnmmtL3NwUehwK\n FZZuJxF+e6H1hRN46w+wiYQgEv5VGWBjONn/rGaxMzhxRYIS1UWXGZiBxnWyINYV4SBXjd5O4mp\n FGrh4","X-Gm-Gg":"AeBDietY0XMqbFiHM0vPtFRmaFkUOeFWgUeVAj5u8z6yseOMDED5Q560eC7EGu+Vwt2\n S28nC5iMTrQ2Wbm0IVCdIG5b/JEJSFEW6Q1IFxXvsqVRYUXmybjXkDbwE7OWrfMSDz5hS5lJXUf\n /8Ddvtl2UTisw4i7Fauap2LH+lM1b3akHTyiKqO8yICzBjewQzk7IkuN5GWUP5leFsj3+pSqtPP\n ohJFFbmAvtXoUT6kV/6QCIwCSSQRpl5mfxRQZJZHLreay9arrb0JrotUJI1P7qbgdlwIVRhB+pW\n MP+dNaIWCnus0lMNwbogkHklW/NZKupc6ie8pJ9BUTVkBXacUzH99v4zy3IrwhrHKR1+HFD++sk\n KsVGCJUmPwxjUGoyFJeO50ALimpbetEAzpkj4MPVhjkMf3tO8DivH7js1E+i4z81gJlQP5CNeT0\n sTq5gEzQs0mBSoUy7P6OXXem6Ji6WSszzizz8svX9kYQyIlBxQ6R8FQV8LioGF7TVILe0DiPxuI\n Mr3A3v6ZA0plky3nWxysCkoWJjMOCFlea8GHJkcSA==","X-Received":"by 2002:a05:6000:4310:b0:43d:733f:aee6 with SMTP id\n ffacd0b85a97d-4493dcd3444mr3263214f8f.10.1777541909076;\n Thu, 30 Apr 2026 02:38:29 -0700 (PDT)","From":"Peter Maydell ","To":"qemu-devel@nongnu.org","Cc":"qemu-arm@nongnu.org, qemu-ppc@nongnu.org, qemu-riscv@nongnu.org,\n qemu-s390x@nongnu.org,\n =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n Marcel Apfelbaum ,\n Yanan Wang , Zhao Liu ,\n Paolo Bonzini ,\n Richard Henderson ,\n \"Dr. David Alan Gilbert\" ,\n =?utf-8?q?Alex_Benn=C3=A9e?= ,\n Alexandre Iooss , Mahmoud Mandour ,\n Peter Xu , \"Edgar E. Iglesias\" ,\n Jiaxun Yang , Nicholas Piggin ,\n Chinmay Rath , Glenn Miles ,\n Palmer Dabbelt ,\n Alistair Francis , Weiwei Li ,\n Daniel Henrique Barboza ,\n Liu Zhiwei ,\n Chao Liu , Ilya Leoshkevich ,\n David Hildenbrand ,\n Mark Cave-Ayland ,\n Artyom Tarasenko , Max Filippov ","Subject":"[PATCH v2 13/25] monitor: hmp_gva2gpa: Don't page-align\n cpu_get_phys_addr_debug() arg and return","Date":"Thu, 30 Apr 2026 10:37:58 +0100","Message-ID":"<20260430093810.2762539-14-peter.maydell@linaro.org>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260430093810.2762539-1-peter.maydell@linaro.org>","References":"<20260430093810.2762539-1-peter.maydell@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::42c;\n envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x42c.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"In hmp_gva2gpa() we currently have a workaround for not all implementations\nof get_phys_addr_debug handling non-page-aligned addresses: we round the\ninput address from the user down to the target page boundary before the\ncall and then add the page offset back to the returned value.\n\nNow that we guarantee that all implementations will return the correct\nexact physaddr for a virtual address, we can drop this handling.\n\nSigned-off-by: Peter Maydell \nAcked-by: Dr. David Alan Gilbert \nReviewed-by: Philippe Mathieu-Daudé \nMessage-id: 20260417173105.1648172-13-peter.maydell@linaro.org\n---\n monitor/hmp-cmds.c | 5 ++---\n 1 file changed, 2 insertions(+), 3 deletions(-)","diff":"diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c\nindex e6d8322bcc..f8380bda58 100644\n--- a/monitor/hmp-cmds.c\n+++ b/monitor/hmp-cmds.c\n@@ -720,12 +720,11 @@ void hmp_gva2gpa(Monitor *mon, const QDict *qdict)\n return;\n }\n \n- gpa = cpu_get_phys_addr_debug(cs, addr & TARGET_PAGE_MASK);\n+ gpa = cpu_get_phys_addr_debug(cs, addr);\n if (gpa == -1) {\n monitor_printf(mon, \"Unmapped\\n\");\n } else {\n- monitor_printf(mon, \"gpa: 0x%\" HWADDR_PRIx \"\\n\",\n- gpa + (addr & ~TARGET_PAGE_MASK));\n+ monitor_printf(mon, \"gpa: 0x%\" HWADDR_PRIx \"\\n\", gpa);\n }\n }\n \n","prefixes":["v2","13/25"]}