{"id":2230993,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2230993/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-ppc/patch/20260430093810.2762539-2-peter.maydell@linaro.org/","project":{"id":69,"url":"http://patchwork.ozlabs.org/api/1.1/projects/69/?format=json","name":"QEMU powerpc development","link_name":"qemu-ppc","list_id":"qemu-ppc.nongnu.org","list_email":"qemu-ppc@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260430093810.2762539-2-peter.maydell@linaro.org>","date":"2026-04-30T09:37:46","name":"[v2,01/25] hw/i386/vapic: Cope with non-page-aligned return from cpu_get_phys_page_debug()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"106218b1fdf685bfbe2606841d08b1b6325837fb","submitter":{"id":5111,"url":"http://patchwork.ozlabs.org/api/1.1/people/5111/?format=json","name":"Peter Maydell","email":"peter.maydell@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-ppc/patch/20260430093810.2762539-2-peter.maydell@linaro.org/mbox/","series":[{"id":502256,"url":"http://patchwork.ozlabs.org/api/1.1/series/502256/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-ppc/list/?series=502256","date":"2026-04-30T09:37:46","name":"Handle sub-page granularity in cpu_memory_rw_debug()","version":2,"mbox":"http://patchwork.ozlabs.org/series/502256/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2230993/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2230993/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=MPkuY9ak;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5pyc69k6z1yGq\n\tfor ; Thu, 30 Apr 2026 19:38:47 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wINqn-0004eY-Ub; Thu, 30 Apr 2026 05:38:29 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wINqg-0004Xw-Lk\n for qemu-ppc@nongnu.org; Thu, 30 Apr 2026 05:38:24 -0400","from mail-wr1-x430.google.com ([2a00:1450:4864:20::430])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wINqb-0002Rw-3V\n for qemu-ppc@nongnu.org; Thu, 30 Apr 2026 05:38:19 -0400","by mail-wr1-x430.google.com with SMTP id\n ffacd0b85a97d-449e96a8a80so36898f8f.3\n for ; Thu, 30 Apr 2026 02:38:14 -0700 (PDT)","from lanath.. (wildly.archaic.org.uk. [81.2.115.145])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-447b421721fsm10816795f8f.15.2026.04.30.02.38.12\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 30 Apr 2026 02:38:12 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777541893; x=1778146693; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=1Axtq64X+5rSvIEqryvcspUpFF2IjRCQsS7/Lsf4JrE=;\n b=MPkuY9akhcw6HuHD7r3F2Oc8P/xcwX5Ognkvun23QXB+owtMpSQbDFkTE66EUd/Rpq\n rweqAnCbXKNwwJUzHdM6yF1M2caN3jeSE7EOoE/LEcyukyEIsB/X/Kl52olrgCyCyHDu\n eReW4EsGqi356/4/Jxw161ElNGZn54Z3YYn0hxg+6HtakTPYohBO9L/xZfLBxoxdRPtb\n SHADi/rI8I+Nt89O7bmYCPTmVSskD5iPIVyvulN1474Y7a+iFPsGiEv32+2liW5jmyCr\n b2zIvjE6SsJR3uIeACsdFGJHod76K7yZdBP+J2pxH5j251hVYnfpxzzX28X3aHAUCHo9\n zmtA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777541893; x=1778146693;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=1Axtq64X+5rSvIEqryvcspUpFF2IjRCQsS7/Lsf4JrE=;\n b=baG+nH8FhPyfeZLbjAlQTdj5ibf+y/nsQNs/KN78RahhUS+gOKrb/XWckKByihbaB6\n 8qA2quLBGl61ReC8PDsk+VMaE73rK5N2moINFeaHkyq7nATc1cPOnZHTBm4xawDGydAx\n 3mJiyTYYdWk6vzudF3G+MPknodzeUW4708Bf/94oX5vcYbO3LgZdKB82Cl2B2+TM361D\n tKaa1uVJcwJXl0Bod9KLLoKTl/UEovIlOF62Pp1G18fYlL+uft9yOxhuXLjQpv9ihG5Q\n Egu9Y407aFPTVPv3EdRczZmHzZUYN5DbuMjTRv3jjMYnDIESqMlb6BnL1aCGV7cIQqux\n B5Sg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ8q0ia/mPiD3WN4vlP5g9rWsZBYIMXbf/x/0CF2dyYrnohNZ7n6wXTUs0TEILhAnF68WdQCM9oDqg==@nongnu.org","X-Gm-Message-State":"AOJu0Ywd2NMUOpdb16SL7bKdB6A/hR/+AYqeJcXVo5kxLiGXr38Q5jgR\n i9sQRypMTtqfdsJNEHdaOn+LI0mkZbb7IIO9g7QnEfQ6+vu18Hmox63uTOS9Sksg2Tk=","X-Gm-Gg":"AeBDieuh6ABZR/xSHJ9zGVZWykEKQsT6b/wq8XhfTOPy/8dD5Xth1sUNQt9nckuZ5Ae\n Qp/jcMx/NfIWm2OXA2C+nUrHTG7UB6V7myLK6lizxGfH2G9Ra5BtdRegzoZq47Gogn+nLpb9KoQ\n nimML+3YtQ/52nIqhVKKKvqtRoiZ/LJIfyVIUdoCOQF3fUBdyy9x7TR41S+HmNLYbU2XWF6n4aj\n BfbpLjpamCHXb6hz0/VPN6GKnyLR/LNp6PXlrmAmS3Cyo3MNIu0L+lnTeFeNtFtR+WC3hHyPtId\n R3cWBv6/RvqhsSE7/QCKeyWLibPLA8OEnqjoTzm11FGheKV5O+qvA7ZLKrhKKuWIIlwRWmqjbye\n Q9zHNUnj2aYO+aXfCQh2FdDS7L1TP45Kj8PoPJskt/0wzdZBOB1OarumstJ+73tvJ8XmwSA63/G\n OgusU+2gl6pWp/PiU8vM0PDg3l/UW3kunzzF7GELLQtNesKiTI0/BoO8LQVN7XLLjeQ9RDlAL5+\n iPgs2nxGutNlFI7HxC95lezC2wy/6f21QguTD0QAg==","X-Received":"by 2002:a05:6000:40cc:b0:441:1df5:480c with SMTP id\n ffacd0b85a97d-4493ffcdca0mr3451189f8f.42.1777541893235;\n Thu, 30 Apr 2026 02:38:13 -0700 (PDT)","From":"Peter Maydell ","To":"qemu-devel@nongnu.org","Cc":"qemu-arm@nongnu.org, qemu-ppc@nongnu.org, qemu-riscv@nongnu.org,\n qemu-s390x@nongnu.org,\n =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n Marcel Apfelbaum ,\n Yanan Wang , Zhao Liu ,\n Paolo Bonzini ,\n Richard Henderson ,\n \"Dr. David Alan Gilbert\" ,\n =?utf-8?q?Alex_Benn=C3=A9e?= ,\n Alexandre Iooss , Mahmoud Mandour ,\n Peter Xu , \"Edgar E. Iglesias\" ,\n Jiaxun Yang , Nicholas Piggin ,\n Chinmay Rath , Glenn Miles ,\n Palmer Dabbelt ,\n Alistair Francis , Weiwei Li ,\n Daniel Henrique Barboza ,\n Liu Zhiwei ,\n Chao Liu , Ilya Leoshkevich ,\n David Hildenbrand ,\n Mark Cave-Ayland ,\n Artyom Tarasenko , Max Filippov ","Subject":"[PATCH v2 01/25] hw/i386/vapic: Cope with non-page-aligned return\n from cpu_get_phys_page_debug()","Date":"Thu, 30 Apr 2026 10:37:46 +0100","Message-ID":"<20260430093810.2762539-2-peter.maydell@linaro.org>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260430093810.2762539-1-peter.maydell@linaro.org>","References":"<20260430093810.2762539-1-peter.maydell@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::430;\n envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x430.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-ppc@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Currently the i386 implementation of get_phys_page_debug() always\nreturns an address aligned to a page boundary, and the vapic.c code\nassumes this: it adds back in the page offset after the call. Change\nthis to OR in the page offset, so that it works whether\ncpu_get_phys_page_debug() returns the page address or the exact\nphysical address. This will mean the code continues to work when\nwe change the semantics to standardize on \"return exact\nphysical address\".\n\nSigned-off-by: Peter Maydell \n---\n hw/i386/vapic.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/hw/i386/vapic.c b/hw/i386/vapic.c\nindex 1acb9f91b2..3738031a05 100644\n--- a/hw/i386/vapic.c\n+++ b/hw/i386/vapic.c\n@@ -309,7 +309,7 @@ static int update_rom_mapping(VAPICROMState *s, CPUX86State *env, target_ulong i\n if (paddr == -1) {\n return -1;\n }\n- paddr += rom_state_vaddr & ~TARGET_PAGE_MASK;\n+ paddr |= rom_state_vaddr & ~TARGET_PAGE_MASK;\n if (paddr != s->rom_state_paddr) {\n return -1;\n }\n","prefixes":["v2","01/25"]}