{"id":2230987,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2230987/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-gpio/patch/20260430093422.74812-7-biju.das.jz@bp.renesas.com/","project":{"id":42,"url":"http://patchwork.ozlabs.org/api/1.1/projects/42/?format=json","name":"Linux GPIO development","link_name":"linux-gpio","list_id":"linux-gpio.vger.kernel.org","list_email":"linux-gpio@vger.kernel.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260430093422.74812-7-biju.das.jz@bp.renesas.com>","date":"2026-04-30T09:34:11","name":"[v4,6/7] pinctrl: renesas: rzg2l: Simplify rzg2l_pinctrl_set_mux()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"06d612340c583111b351f551093a0b3f6ac49060","submitter":{"id":87968,"url":"http://patchwork.ozlabs.org/api/1.1/people/87968/?format=json","name":"Biju","email":"biju.das.au@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-gpio/patch/20260430093422.74812-7-biju.das.jz@bp.renesas.com/mbox/","series":[{"id":502254,"url":"http://patchwork.ozlabs.org/api/1.1/series/502254/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-gpio/list/?series=502254","date":"2026-04-30T09:34:06","name":"Add Renesas RZ/G3L PINCONTROL support","version":4,"mbox":"http://patchwork.ozlabs.org/series/502254/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2230987/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2230987/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=mUZlAghV;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c15:e001:75::12fc:5321; helo=sin.lore.kernel.org;\n envelope-from=linux-gpio+bounces-35853-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"mUZlAghV\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.221.46","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from sin.lore.kernel.org (sin.lore.kernel.org\n [IPv6:2600:3c15:e001:75::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5ptF5N8Jz1yHZ\n\tfor ; Thu, 30 Apr 2026 19:35:01 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id 871C1300E6AA\n\tfor ; Thu, 30 Apr 2026 09:34:39 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 5FC063A3E7E;\n\tThu, 30 Apr 2026 09:34:35 +0000 (UTC)","from mail-wr1-f46.google.com (mail-wr1-f46.google.com\n [209.85.221.46])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 5454139B4A0\n\tfor ; Thu, 30 Apr 2026 09:34:33 +0000 (UTC)","by mail-wr1-f46.google.com with SMTP id\n ffacd0b85a97d-4486b5fcf3cso635660f8f.2\n for ;\n Thu, 30 Apr 2026 02:34:33 -0700 (PDT)","from localhost.localdomain ([2a00:23c4:a758:8a01:342:901:e785:f7d2])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-447b76e5c22sm11953913f8f.28.2026.04.30.02.34.31\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 30 Apr 2026 02:34:31 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777541675; cv=none;\n b=Fxqel8DxuC8aQkVdB9FzLTe+U+2gN+SZyV3KCgTKRybWtUW3Fc7KQGMfreda7oVPh8yKgE67pBVTbAMZWRDfJZGWOy+g097VGKKwNH1vha7MTgOKKcwaY+lA6y36fAnyPHf5x8cVRqPKDPKVngnxHzvudX4SJ5lLU6gZRUk+GVg=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777541675; c=relaxed/simple;\n\tbh=pT4vlRF+WTam/ZKzQMnbpk8803cXtcadIPthrcyiQug=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=naFPL1uJq9vgncOmK4hCQZ9HiL4GoM/9FjyEfC9ETvoXIm/GiDFNkQJ04dzjxmxgKPoVaiwu01Aexi5/tfi9Or3VRG9eHUMS7PxlzX7dDag4w94tSheUALDmUOxcsgCppGn1smTImSN6/A2TDIo/4meClYpm3UzynfTErIFXyaI=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=mUZlAghV; arc=none smtp.client-ip=209.85.221.46","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777541672; x=1778146472;\n darn=vger.kernel.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=p/8sLHc9W5tl1EvtfSg0BszVcVjlDsk9IiIlQDWOyFU=;\n b=mUZlAghVi7jtwP77dbSHVcC4Hte47yLkAJbssNX0zSwrU5I7wVgEpZai5CTC0n1FjS\n yjfGbzESDwnewdhns1GNU1O3GAs7nYoNinlR0KwA2cyNMzBjqCexXib4XqZWiYB7hG4/\n Qj3A5eBAhRPT1qwksd/guAFV111h9zEi0fT0BxKi1sgsbM4cz2NxaZXA2VBGxyP7QMrG\n 8ozTpbcMjJTjwE/BzaHvBzmQ7GlNMd7Az4B8cFrrucdchblP+9WwoaynbBBslKjYaJB0\n 6hFT3e76Kj+wEHuHwEosESkk/1nLPgtpTh14Q5v0D7C9n0gMIHxRUFXn1SplEOLdaGQz\n rcAw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777541672; x=1778146472;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=p/8sLHc9W5tl1EvtfSg0BszVcVjlDsk9IiIlQDWOyFU=;\n b=Phz57dWswE21GiLVNQiZRUs6MN7pgStkU45Wrh3DzmX280pa+Qn4VNDjCUgJMaUaab\n 7vD5FNpNG/w31gi+CSs4vWIIcyMZDLAFi9UdPAioTbrCs7vsR1ZsmVfTWkztUJ3m6qz9\n 27KXP9NRFM/xEoNGQk+WPdJB3f2wxYR7ZzcOCv9PJ5Z4zDM86QVc3G2LnX35RC0reuH6\n 9BB/PXlmzhESOke7x7dqfrjwi50/VLdOeCPLCbKw764n//NA69JjAiAXBTay9sdDTa+X\n hTQEquLrtZA1ZSqQ7/v3fg3YnoWrESG3iScogXOP6ke0cwDaZwFExKf/gscXInYnavTw\n rsvw==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/+FHbX/n/tJkXgERKN7Pwoay0DGzUloPMPBMtdYBJI8rVt17ML+oIEU22mdRX4n0IKTaOUQ7lw3R9G@vger.kernel.org","X-Gm-Message-State":"AOJu0YyY2uRFR2t8TyMCw9X5AD3AtdWVukUr0ZHbn/aRANBimKeJXAL2\n\tF6MO1yVBGofmLaA6VRsgy+onZldgI60CmFGwtwSwSV8crycerye2Fd8f","X-Gm-Gg":"AeBDiesWgpGZtNMtmIXoMnDjbevOWVwCfsgwccjqG01XTvolvzNo+SJJtAfhafC1qBo\n\teIDn6RSISfZSAzM604GC3wBnItD5oHFg8xKxLDzIi22hpv6xENddfM1EaAZ8rYSnTCQ+LtqwTx3\n\t5iHaX5RnVa7X9z7tFEaNagkSVwD79t918b6KTonIwgTB1DQ5z7B3CTAobuyFMmDxD4n8Bc9Hf5I\n\toXwCniEFlt/RosEEQ+JVo14URsQrsAhGmODptbt7zVCMqFx74ns9e/z2YsxQh2sAtfF6P2IGtQT\n\tlgZaWIbDwQp85sZlK+kC1vcW56pDdu/igmry2GC5trvhJM6nwd2UwYOXlNDaY1O8nohqM9oRocR\n\t+MpLSRv6jHFlEQpfyWI31gpU3bDptTqYF0gTfNquQAWPAjz7w09EA1I663buW+EqlUt0aW7ROXT\n\t7bAnVGHCrc3gGEGMXr4wAYz768wqeW599ZzM7hlP6w10k2nT8EaMpRb/P0","X-Received":"by 2002:a5d:5f47:0:b0:43c:f1a5:56f6 with SMTP id\n ffacd0b85a97d-449401ba950mr3616456f8f.43.1777541671742;\n Thu, 30 Apr 2026 02:34:31 -0700 (PDT)","From":"Biju ","X-Google-Original-From":"Biju ","To":"Geert Uytterhoeven ,\n\tLinus Walleij ,\n\tMagnus Damm ","Cc":"Biju Das ,\n\tlinux-renesas-soc@vger.kernel.org,\n\tlinux-gpio@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tPrabhakar Mahadev Lad ,\n\tBiju Das ","Subject":"[PATCH v4 6/7] pinctrl: renesas: rzg2l: Simplify\n rzg2l_pinctrl_set_mux()","Date":"Thu, 30 Apr 2026 10:34:11 +0100","Message-ID":"<20260430093422.74812-7-biju.das.jz@bp.renesas.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260430093422.74812-1-biju.das.jz@bp.renesas.com>","References":"<20260430093422.74812-1-biju.das.jz@bp.renesas.com>","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"From: Biju Das \n\nThe port and function selectors are evaluated multiple times\nin rzg2l_pinctrl_set_mux(). Simplify the function by dropping\ndupicate evaluation storing them in local variables.\n\nSigned-off-by: Biju Das \nReviewed-by: Geert Uytterhoeven \n---\nv3->v4:\n * Updated the data type of func varaible from u8 to unsigned int.\n * Collected the tag.\nv3:\n * New patch.\n---\n drivers/pinctrl/renesas/pinctrl-rzg2l.c | 10 ++++++----\n 1 file changed, 6 insertions(+), 4 deletions(-)","diff":"diff --git a/drivers/pinctrl/renesas/pinctrl-rzg2l.c b/drivers/pinctrl/renesas/pinctrl-rzg2l.c\nindex 004096d5d1d1..eff5fc081ec8 100644\n--- a/drivers/pinctrl/renesas/pinctrl-rzg2l.c\n+++ b/drivers/pinctrl/renesas/pinctrl-rzg2l.c\n@@ -687,16 +687,18 @@ static int rzg2l_pinctrl_set_mux(struct pinctrl_dev *pctldev,\n \tfor (i = 0; i < group->grp.npins; i++) {\n \t\tu64 *pin_data = pctrl->desc.pins[pins[i]].drv_data;\n \t\tu32 off = RZG2L_PIN_CFG_TO_PORT_OFFSET(*pin_data);\n+\t\tu32 port = RZG2L_PIN_ID_TO_PORT(pins[i]);\n \t\tu32 pin = RZG2L_PIN_ID_TO_PIN(pins[i]);\n+\t\tunsigned int func;\n \n-\t\tret = rzg2l_validate_pin(pctrl, *pin_data, RZG2L_PIN_ID_TO_PORT(pins[i]), pin);\n+\t\tret = rzg2l_validate_pin(pctrl, *pin_data, port, pin);\n \t\tif (ret)\n \t\t\treturn ret;\n \n-\t\tdev_dbg(pctrl->dev, \"port:%u pin: %u off:%x PSEL:%u\\n\",\n-\t\t\tRZG2L_PIN_ID_TO_PORT(pins[i]), pin, off, psel_val[i] - hwcfg->func_base);\n+\t\tfunc = psel_val[i] - hwcfg->func_base;\n+\t\tdev_dbg(pctrl->dev, \"port:%u pin: %u off:%x PSEL:%u\\n\", port, pin, off, func);\n \n-\t\trzg2l_pinctrl_set_pfc_mode(pctrl, pin, off, psel_val[i] - hwcfg->func_base);\n+\t\trzg2l_pinctrl_set_pfc_mode(pctrl, pin, off, func);\n \t}\n \n \treturn 0;\n","prefixes":["v4","6/7"]}