{"id":2230983,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2230983/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-gpio/patch/20260430093422.74812-3-biju.das.jz@bp.renesas.com/","project":{"id":42,"url":"http://patchwork.ozlabs.org/api/1.1/projects/42/?format=json","name":"Linux GPIO development","link_name":"linux-gpio","list_id":"linux-gpio.vger.kernel.org","list_email":"linux-gpio@vger.kernel.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260430093422.74812-3-biju.das.jz@bp.renesas.com>","date":"2026-04-30T09:34:07","name":"[v4,2/7] pinctrl: renesas: rzg2l: Make QSPI register handling conditional","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"63581ebefe53fd74c6a0e89aeec89d322d1f086a","submitter":{"id":87968,"url":"http://patchwork.ozlabs.org/api/1.1/people/87968/?format=json","name":"Biju","email":"biju.das.au@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-gpio/patch/20260430093422.74812-3-biju.das.jz@bp.renesas.com/mbox/","series":[{"id":502254,"url":"http://patchwork.ozlabs.org/api/1.1/series/502254/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-gpio/list/?series=502254","date":"2026-04-30T09:34:06","name":"Add Renesas RZ/G3L PINCONTROL support","version":4,"mbox":"http://patchwork.ozlabs.org/series/502254/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2230983/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2230983/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=sGHUrYnt;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c09:e001:a7::12fc:5321; helo=sto.lore.kernel.org;\n envelope-from=linux-gpio+bounces-35850-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"sGHUrYnt\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.221.43","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from sto.lore.kernel.org (sto.lore.kernel.org\n [IPv6:2600:3c09:e001:a7::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5pst3FVNz1yHZ\n\tfor ; Thu, 30 Apr 2026 19:34:42 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 99AAE300B5B2\n\tfor ; Thu, 30 Apr 2026 09:34:33 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id F05B53A5E7F;\n\tThu, 30 Apr 2026 09:34:31 +0000 (UTC)","from mail-wr1-f43.google.com (mail-wr1-f43.google.com\n [209.85.221.43])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id BCD333A3816\n\tfor ; Thu, 30 Apr 2026 09:34:29 +0000 (UTC)","by mail-wr1-f43.google.com with SMTP id\n ffacd0b85a97d-43d70b3e159so371759f8f.0\n for ;\n Thu, 30 Apr 2026 02:34:29 -0700 (PDT)","from localhost.localdomain ([2a00:23c4:a758:8a01:342:901:e785:f7d2])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-447b76e5c22sm11953913f8f.28.2026.04.30.02.34.26\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 30 Apr 2026 02:34:27 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777541671; cv=none;\n b=TbVRghKM77ogs3UFa+wQxOp80cTwqcZ4FrR1cnbSBqydpjJqYY0JmgVUnIUqjUuC1oLHY9tODGe8LPvkazCH/TtkLGnWHkdKdNhsPWlTpRK9XZ/0XVvyt9tA7Bsc18jmF4OD8tIpCrjqSHyUhE8Tf5j5RBigUzyVVycux1Qv5Og=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777541671; c=relaxed/simple;\n\tbh=+VsM6Ck+0mhhhcVKrksxgtMDsF2usvUzWlIisd1MRss=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=Osx9EM6in5krpI3LratGxlVOGHAoQ5Zz1PEt74ratr7O9OevAD32QSsnbpirWr5pU78fI/lhEeM1xfhTbwrlts3KPXNyrKZBpm846kPqiOoJINY2MG1V/lEr9rXmtlgM0kcYJDOHPShIK782DR5Qa4gdbgN6zRCk6Fhp9/Xkmfo=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=sGHUrYnt; arc=none smtp.client-ip=209.85.221.43","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777541668; x=1778146468;\n darn=vger.kernel.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=BKg3OC8AKD5+2DyohOa+42Ozw5Xain5YLEWs5Ro/WAo=;\n b=sGHUrYntl1yNwgfTuFDxFe27FNOB7qW+2NPFctc06VGgl2kxZEik0X5P9cNEehTybn\n kXzDX4zLK5YIJMz9/DcaWMB71KGXWxtiwMkIPQqYOxPbzHFmmn4XnjBzmKqe7gHvH7IZ\n t9xFm+eSdJEiZAFALsgMpEOjZZmy2fDTKNKKDiP/EOsXePT59B05mntltqszFN+SFzWH\n c2/u5Z6Aqo1dbOhy4AG6TEoXXxt9CvwzHrBuT22p+lxFn27L/NHwkj1Su9yoNCnZlMUt\n RCQWmMCZ+n/4zRolDoGhKYAeJzHvtuK8VJVNy0fT4IXRiLn7LWUrZFIaWm8kGycdcdL2\n YszQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777541668; x=1778146468;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=BKg3OC8AKD5+2DyohOa+42Ozw5Xain5YLEWs5Ro/WAo=;\n b=C+/jbYEi/dvMcv2QWs/vhGM2PSEUnv8zg0BeIl5ZEPBfOlt1NqovIapg4Q5O3kAUxG\n CZGPap5qjNSoFoU/maCk9mLwDxtnjSKJ1gLMUDX1pTYufltaYGVO2GQuL/jg6JFtDC3d\n kJYP2FNA14j1f6OsoZjAZ20E9bIJz7O/0XTVnWlkUWGnlTgh0w/tgTeS0W0//Pz29Ptu\n J5VfEE6KKHJURN0nuuPqTbahvO1JUlw8pib52YGYsj4eNF51BOnwqhb0XBcwUSU3XFuA\n bVdbnCrbrAcNdbM5Nd+VHFR8fXktMyFotzxq2mL6I4O+Fcnls1ywo6R8I03SrQDrA1yY\n E2Tg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ9CGS7cc5OpoSRQmxp5SZ8ztYpqbChwMUrOLXPV/y8gyFF+/yMxl6eScy2JimjkCqI0K4pDipHFmJ+i@vger.kernel.org","X-Gm-Message-State":"AOJu0Yx685sDctW3R+FdKfTC0W67lGO5b55rLDQMZ+m0kQJZaVkd9Kfs\n\tpnrtA8e7jfkR5OeYL52YBaRWDLqC9x6f/S4Y4ePykSHHXESdMiGMvvuE","X-Gm-Gg":"AeBDieuAffnXBhO4t1A+p6UswJ+5xfbo8xWNT16kbliSXI/AUFJbk0YHaxkAN1lYLLs\n\tf4IJo5y4fzUbzILn4DvClmUO2pNl4aX9KuhYv9PBRUg9JiLPD616UXZPeEmPx7r45or5B/q2bdg\n\tOGpBA+mu1Cg3eXX33i2jRpEiBDvP4SQ3QXNtAWs1fyB6NYFCAm6es/kjqe84LC3yAx5+LYmfrq1\n\tCajH3uxhjANHk0LiLxG/Y0BWWrSSmU+TEkjeZaey+omSv8yXiEuEjpxSGKxt8vsQS3PPiNnhDfT\n\td4QnmStsyuJ6guzUKaCF0uu74qeNAsDWLW2AD1MzgZUj5nXNrT3SkeyxhiWhshSsJeMbGzKeMKh\n\tlghWUW305hkUI2MsxHxBv7bHqe8Z0ei8fR4Zv1WNygjiZ4SXAPPVtp+jlvV1o4t35oG7q7rBRY9\n\tEPyhuP88RIGzRdTL8e6hMv5OKMlabtYas0VQ1ktRY+VLE7BReUasbjVs16","X-Received":"by 2002:a05:6000:25c4:b0:43d:2f94:3b40 with SMTP id\n ffacd0b85a97d-4493c381e7dmr3475621f8f.6.1777541667841;\n Thu, 30 Apr 2026 02:34:27 -0700 (PDT)","From":"Biju ","X-Google-Original-From":"Biju ","To":"Geert Uytterhoeven ,\n\tLinus Walleij ","Cc":"Biju Das ,\n\tlinux-renesas-soc@vger.kernel.org,\n\tlinux-gpio@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tPrabhakar Mahadev Lad ,\n\tBiju Das ","Subject":"[PATCH v4 2/7] pinctrl: renesas: rzg2l: Make QSPI register handling\n conditional","Date":"Thu, 30 Apr 2026 10:34:07 +0100","Message-ID":"<20260430093422.74812-3-biju.das.jz@bp.renesas.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260430093422.74812-1-biju.das.jz@bp.renesas.com>","References":"<20260430093422.74812-1-biju.das.jz@bp.renesas.com>","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"From: Biju Das \n\nThe QSPI register at offset 0x3008 is not present on all SoCs supported by\nthe RZ/G2L pinctrl driver. Unconditionally reading and writing this\nregister during suspend/resume on hardware that lacks it can cause\nundefined behaviour.\n\nAdd a qspi field to rzg2l_register_offsets to allow per-SoC declaration of\nthe QSPI register offset, and guard the suspend/resume accesses with a\ncheck on that field. Populate the offset only for the RZ/{G2L,G2LC,G2UL,\nFive} hardware configuration, which is where the register is known to\nexist.\n\nSigned-off-by: Biju Das \n---\nv4:\n * New patch.\n---\n drivers/pinctrl/renesas/pinctrl-rzg2l.c | 11 ++++++++---\n 1 file changed, 8 insertions(+), 3 deletions(-)","diff":"diff --git a/drivers/pinctrl/renesas/pinctrl-rzg2l.c b/drivers/pinctrl/renesas/pinctrl-rzg2l.c\nindex bc2154b69514..ca9d4a3ec737 100644\n--- a/drivers/pinctrl/renesas/pinctrl-rzg2l.c\n+++ b/drivers/pinctrl/renesas/pinctrl-rzg2l.c\n@@ -145,7 +145,7 @@\n #define SMT(off)\t\t(0x3400 + (off) * 8)\n #define SD_CH(off, ch)\t\t((off) + (ch) * 4)\n #define ETH_POC(off, ch)\t((off) + (ch) * 4)\n-#define QSPI\t\t\t(0x3008)\n+#define QSPI\t\t\t(0x3008) /* known on RZ/{G2L,G2LC,G2UL,Five} only */\n \n #define PVDD_2500\t\t2\t/* I/O domain voltage 2.5V */\n #define PVDD_1800\t\t1\t/* I/O domain voltage <= 1.8V */\n@@ -220,12 +220,14 @@ static const struct pin_config_item renesas_rzv2h_conf_items[] = {\n * @sd_ch: SD_CH register offset\n * @eth_poc: ETH_POC register offset\n * @oen: OEN register offset\n+ * @qspi: QSPI register offset\n */\n struct rzg2l_register_offsets {\n \tu16 pwpr;\n \tu16 sd_ch;\n \tu16 eth_poc;\n \tu16 oen;\n+\tu16 qspi;\n };\n \n /**\n@@ -3297,7 +3299,8 @@ static int rzg2l_pinctrl_suspend_noirq(struct device *dev)\n \t\t\tcache->eth_poc[i] = readb(pctrl->base + ETH_POC(regs->eth_poc, i));\n \t}\n \n-\tcache->qspi = readb(pctrl->base + QSPI);\n+\tif (regs->qspi)\n+\t\tcache->qspi = readb(pctrl->base + regs->qspi);\n \tcache->oen = readb(pctrl->base + pctrl->data->hwcfg->regs.oen);\n \n \tif (!atomic_read(&pctrl->wakeup_path))\n@@ -3323,7 +3326,8 @@ static int rzg2l_pinctrl_resume_noirq(struct device *dev)\n \t\t\treturn ret;\n \t}\n \n-\twriteb(cache->qspi, pctrl->base + QSPI);\n+\tif (regs->qspi)\n+\t\twriteb(cache->qspi, pctrl->base + regs->qspi);\n \n \traw_spin_lock_irqsave(&pctrl->lock, flags);\n \trzg2l_oen_write_with_pwpr(pctrl, cache->oen);\n@@ -3381,6 +3385,7 @@ static const struct rzg2l_hwcfg rzg2l_hwcfg = {\n \t\t.sd_ch = 0x3000,\n \t\t.eth_poc = 0x300c,\n \t\t.oen = 0x3018,\n+\t\t.qspi = QSPI,\n \t},\n \t.iolh_groupa_ua = {\n \t\t/* 3v3 power source */\n","prefixes":["v4","2/7"]}