{"id":2230977,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2230977/?format=json","web_url":"http://patchwork.ozlabs.org/project/ltp/patch/20260430091956.10915-1-chrubis@suse.cz/","project":{"id":59,"url":"http://patchwork.ozlabs.org/api/1.1/projects/59/?format=json","name":"Linux Test Project development","link_name":"ltp","list_id":"ltp.lists.linux.it","list_email":"ltp@lists.linux.it","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260430091956.10915-1-chrubis@suse.cz>","date":"2026-04-30T09:19:56","name":"lib: tst_test: tst_reinit() abort when already initialized","commit_ref":null,"pull_url":null,"state":"needs-review-ack","archived":false,"hash":"9d7ba1734040aeb8ea1f97a99fe339d9fd8fb868","submitter":{"id":8530,"url":"http://patchwork.ozlabs.org/api/1.1/people/8530/?format=json","name":"Cyril Hrubis","email":"chrubis@suse.cz"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/ltp/patch/20260430091956.10915-1-chrubis@suse.cz/mbox/","series":[{"id":502250,"url":"http://patchwork.ozlabs.org/api/1.1/series/502250/?format=json","web_url":"http://patchwork.ozlabs.org/project/ltp/list/?series=502250","date":"2026-04-30T09:19:56","name":"lib: tst_test: tst_reinit() abort when already initialized","version":1,"mbox":"http://patchwork.ozlabs.org/series/502250/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2230977/comments/","check":"success","checks":"http://patchwork.ozlabs.org/api/patches/2230977/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256\n header.s=susede2_rsa header.b=L4Dd5y9B;\n\tdkim=fail reason=\"signature verification failed\" header.d=suse.cz\n header.i=@suse.cz header.a=ed25519-sha256 header.s=susede2_ed25519\n header.b=Qtq0VGau;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key)\n header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256 header.s=susede2_rsa\n header.b=L4Dd5y9B;\n\tdkim=neutral header.d=suse.cz header.i=@suse.cz header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=Qtq0VGau;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=2001:1418:10:5::2; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)","smtp-out1.suse.de;\n\tnone"],"Received":["from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5pXy5Ktyz1yHZ\n\tfor ; Thu, 30 Apr 2026 19:20:02 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id 4E8323E658A\n\tfor ; Thu, 30 Apr 2026 11:20:00 +0200 (CEST)","from in-7.smtp.seeweb.it (in-7.smtp.seeweb.it [217.194.8.7])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id C088A3E210C\n for ; Thu, 30 Apr 2026 11:19:57 +0200 (CEST)","from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-7.smtp.seeweb.it (Postfix) with ESMTPS id 29CC2200B3D\n for ; Thu, 30 Apr 2026 11:19:56 +0200 (CEST)","from imap1.dmz-prg2.suse.org (unknown [10.150.64.97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out1.suse.de (Postfix) with ESMTPS id 85F696A7CD\n for ; Thu, 30 Apr 2026 09:19:56 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 75FC7593B0\n for ; Thu, 30 Apr 2026 09:19:56 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id tNarG7we82k4OgAAD6G6ig\n (envelope-from )\n for ; Thu, 30 Apr 2026 09:19:56 +0000"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_rsa;\n t=1777540796; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding;\n bh=1Xwc4dzH4mXgvOWli6Hm3DROT3gfQ4A4tIwzKIUo19M=;\n b=L4Dd5y9Bm5jQ2pCdQ+I4BzWNH8pt7X6RuxUuDRQiPLROzjc5Gi1F/8HUoL1kxR5KtdXIXx\n HgLAae+8YKOOd1qNVQBkABeexE9cxLGFBBiniFx8j4wMTRPsbGuXwwkoYpZwjaSHomdqYP\n jZehLVxTc10wQY7YTnPkl0X5o51Dzww=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_ed25519; t=1777540796;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding;\n bh=1Xwc4dzH4mXgvOWli6Hm3DROT3gfQ4A4tIwzKIUo19M=;\n b=Qtq0VGauC+n/1nHjodoljiXOV7T7aa3vAMMCDQwVwAdKQ2VXBSPBvK+6ELNAMKHGNROmq7\n s2uzgNvUVerDOSBA==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_rsa;\n t=1777540796; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding;\n bh=1Xwc4dzH4mXgvOWli6Hm3DROT3gfQ4A4tIwzKIUo19M=;\n b=L4Dd5y9Bm5jQ2pCdQ+I4BzWNH8pt7X6RuxUuDRQiPLROzjc5Gi1F/8HUoL1kxR5KtdXIXx\n HgLAae+8YKOOd1qNVQBkABeexE9cxLGFBBiniFx8j4wMTRPsbGuXwwkoYpZwjaSHomdqYP\n jZehLVxTc10wQY7YTnPkl0X5o51Dzww=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_ed25519; t=1777540796;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding;\n bh=1Xwc4dzH4mXgvOWli6Hm3DROT3gfQ4A4tIwzKIUo19M=;\n b=Qtq0VGauC+n/1nHjodoljiXOV7T7aa3vAMMCDQwVwAdKQ2VXBSPBvK+6ELNAMKHGNROmq7\n s2uzgNvUVerDOSBA=="],"From":"Cyril Hrubis ","To":"ltp@lists.linux.it","Date":"Thu, 30 Apr 2026 11:19:56 +0200","Message-ID":"<20260430091956.10915-1-chrubis@suse.cz>","X-Mailer":"git-send-email 2.53.0","MIME-Version":"1.0","X-Spamd-Result":"default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[100.00%];\n NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[];\n R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000];\n MIME_GOOD(-0.10)[text/plain];\n FUZZY_RATELIMITED(0.00)[rspamd.com];\n RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_ONE(0.00)[1];\n ARC_NA(0.00)[];\n DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519];\n DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.cz:mid,suse.cz:email];\n FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[];\n MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2];\n TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[];\n PREVIOUSLY_DELIVERED(0.00)[ltp@lists.linux.it];\n RCVD_TLS_ALL(0.00)[]","X-Spam-Score":"-2.80","X-Spam-Level":"","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS shortcircuit=no\n autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-7.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-7.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"[LTP] [PATCH] lib: tst_test: tst_reinit() abort when already\n initialized","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "},"content":"Calling tst_reinit() when library is already initialized or calling it\nfor a second time is always mistake. With that we silenty drop the old\nIPC region, that may have contained test results and there are likely\nother problems possibly caused by initializing the test library twice.\n\nTo fix that this patch adds tst_brk() that abort the test if we call\ntst_reinit() with already initialized test library.\n\nSigned-off-by: Cyril Hrubis \n---\n lib/tst_test.c | 3 +++\n 1 file changed, 3 insertions(+)","diff":"diff --git a/lib/tst_test.c b/lib/tst_test.c\nindex 26f6510a0..fa61e1be4 100644\n--- a/lib/tst_test.c\n+++ b/lib/tst_test.c\n@@ -196,6 +196,9 @@ void tst_reinit(void)\n \tsize_t size = getpagesize();\n \tint fd;\n \n+\tif (ipc)\n+\t\ttst_brk(TBROK, \"Test library already initialized!\");\n+\n \tif (!path)\n \t\ttst_brk(TBROK, IPC_ENV_VAR\" is not defined\");\n \n","prefixes":[]}