{"id":2230959,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2230959/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260430090534.841894-8-pbonzini@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260430090534.841894-8-pbonzini@redhat.com>","date":"2026-04-30T09:05:28","name":"[07/13] minikconf: simplify self.tok","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"77c4a6c6ba6bd91575cd13c13caecc37031a5af3","submitter":{"id":2701,"url":"http://patchwork.ozlabs.org/api/1.1/people/2701/?format=json","name":"Paolo Bonzini","email":"pbonzini@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260430090534.841894-8-pbonzini@redhat.com/mbox/","series":[{"id":502245,"url":"http://patchwork.ozlabs.org/api/1.1/series/502245/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502245","date":"2026-04-30T09:05:25","name":"kconfig cleanups and mypy annotations","version":1,"mbox":"http://patchwork.ozlabs.org/series/502245/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2230959/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2230959/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=Mcpuy5nL;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=DMvlMwRR;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5pFC3jhSz1yK1\n\tfor ; Thu, 30 Apr 2026 19:06:21 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wINLL-0007zP-Vd; Thu, 30 Apr 2026 05:06:00 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wINLI-0007yd-OH\n for qemu-devel@nongnu.org; Thu, 30 Apr 2026 05:05:56 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wINLH-00038W-4S\n for qemu-devel@nongnu.org; Thu, 30 Apr 2026 05:05:56 -0400","from mail-ej1-f69.google.com (mail-ej1-f69.google.com\n [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-364-_FHXJsO1O0m8QAObEQh4Zw-1; Thu, 30 Apr 2026 05:05:52 -0400","by mail-ej1-f69.google.com with SMTP id\n a640c23a62f3a-bb9fdd62dceso57585066b.0\n for ; Thu, 30 Apr 2026 02:05:51 -0700 (PDT)","from [192.168.10.48] ([151.49.85.67])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-447b421721fsm10662427f8f.15.2026.04.30.02.05.48\n for \n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 30 Apr 2026 02:05:48 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777539954;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=a04HJwacH/7HHwrr3Yw5Am+YrjLFb+c7Jru2AF+J9Z0=;\n b=Mcpuy5nLlgszLsGrqje5gVc5vZrbY1mXFzEiH5XIPTyUKE/l5HkdVZOMmBRCiatW7O/nNr\n FRzIu8JYL9L3J6b6kWp1VPp9AgkqU4tLR8iJ90alIuYgCcT1uL2ntU2MDCLkEpguw9b255\n ThJxQ+A7fCoxvKiZq5cb7Rkt6zik5B0=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1777539950; x=1778144750; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:from:to:cc:subject:date:message-id\n :reply-to; bh=a04HJwacH/7HHwrr3Yw5Am+YrjLFb+c7Jru2AF+J9Z0=;\n b=DMvlMwRRI0vUwPOkM5MYvrQ2dpkSx1es2A9YdwfUngiOC35W8FIVdfpuNlbKKaAjLV\n A6l0Il/VdZtzbn87AvKXIGQOgkChyIEVUmWFO34lBcUlEF6JNKy+3LT+XwaMPVO0MJ8t\n R+WY+wRD2StgIBE6pc25/EWEEWgP79KHJhfxIxJ1ir+Kq8XxkVrfkJ453R0FgoRrKR3O\n Q7caoE1Y49WYe6efS6FmAjIa/iiOCCfTmPfBlaI0OngydgJOsjrJoNJPDRZbtxrvgnma\n pNTB7mcpver+mDvLhbNCU88mlv1lz5us8qhc3C6AWM3NOTP3L2xK7fNwk68ZxZwvWVz7\n zUHw=="],"X-MC-Unique":"_FHXJsO1O0m8QAObEQh4Zw-1","X-Mimecast-MFC-AGG-ID":"_FHXJsO1O0m8QAObEQh4Zw_1777539951","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777539950; x=1778144750;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=a04HJwacH/7HHwrr3Yw5Am+YrjLFb+c7Jru2AF+J9Z0=;\n b=m5cD2UaTCQj9P9t4X5PutwrM8L1YHAFeAEJyQ7lB70EF+HfnbXkQMPNKoBow4vCk6r\n S8hUoA1Q026xCvXlOUWJ/EyMvfE7ltma4bxkA5yL7EljsXJPIAnKmrf1K21SQoPC/0J1\n 4HifDVsKMt4UiwXPkTMFeFtiL2rc3ahdkt6lttvdi3etoKhJduQxCjBmKxptwGiKPSGH\n Ltoov2sfWaTZkyaGXTWibbRMSFo3QH8xdTpAdAMPl9mPFy3DOSdau3/6TDh1fZvehMjG\n /ax6K3koZdoIxo6HlBF+p30M0xshVX8YbFg+x5qQUr7pcnSBsWkD6RRlB3SYtS1QNw+5\n VGPA==","X-Gm-Message-State":"AOJu0Yy5hA/m8Y8wdJ1nqflJGlMkDM18dqyp4vKthYB4RKaQ/wlVcKLZ\n 7u6sm7G3EMN6qZa3oUSzmXuQVxF2TFGT321NEr9JZKmF+YUn8a0cn8/qcxjkhb17BEThNTABk4O\n 8zUQwrXaOO13VGnxxUc2Is5ChMFz0qQwEfRKunimsvTipxmnuQnClwRB1dOr996v+A/Q5cY7nhq\n kub8Q8ebMe9KOhIDt5Vj6MOYXhiSfWM6+xGLCBWImy","X-Gm-Gg":"AeBDievRpBYLi9dmx9oM145LuRVXZVnS5zuxWHHUQzc9loYNOTflw+2p1pdv04cF0mU\n jrn2SBqfG0KBURbLAX990Kogo+L6dSKWBTM0NFsrOHRBg3sR5mr00wVYlKMsUDcv0fjmm6E32VE\n Qilctk881/pTU9UUN3lNAyeBivkTQMLRi7RQeoo3dcinKNsWOTQrrysCXZhln67fBjiGxQ6TY8T\n VdaV0mpOyuKeOeB/fil/pC7vWZI5yTei+U4sjF51N4Wk5xfki/i22N8r8a/ZpbIDiZL7NcZ4lzj\n DrhFoQKY+X9N/QaxMhM63s+/ylxicNv3WrA61feysRcglPhI5JO+AbIgnTyKXgK7v/9VlfnKY9L\n ATwM380OIYbl4T26VOjFvoE0dPJM0+/umoj0x2Ck8+ides/q6nKcgZwxdA3rAb7ezsVYpK37PeH\n TKGwNWC/17M+O6PI5rKOl4khr1TG5UnB4o+Qg=","X-Received":["by 2002:a17:906:518c:10b0:bb4:92dc:b84b with SMTP id\n a640c23a62f3a-bbac7890ca8mr101285666b.26.1777539949860;\n Thu, 30 Apr 2026 02:05:49 -0700 (PDT)","by 2002:a17:906:518c:10b0:bb4:92dc:b84b with SMTP id\n a640c23a62f3a-bbac7890ca8mr101282666b.26.1777539949048;\n Thu, 30 Apr 2026 02:05:49 -0700 (PDT)"],"From":"Paolo Bonzini ","To":"qemu-devel@nongnu.org","Subject":"[PATCH 07/13] minikconf: simplify self.tok","Date":"Thu, 30 Apr 2026 11:05:28 +0200","Message-ID":"<20260430090534.841894-8-pbonzini@redhat.com>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260430090534.841894-1-pbonzini@redhat.com>","References":"<20260430090534.841894-1-pbonzini@redhat.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=pbonzini@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Do not ever store a string in self.tok, only a finished token.\n\nSigned-off-by: Paolo Bonzini \n---\n scripts/minikconf.py | 59 ++++++++++++++++++++++----------------------\n 1 file changed, 30 insertions(+), 29 deletions(-)","diff":"diff --git a/scripts/minikconf.py b/scripts/minikconf.py\nindex 2656d364920..3d63cc6b21f 100644\n--- a/scripts/minikconf.py\n+++ b/scripts/minikconf.py\n@@ -330,9 +330,9 @@ def do_imply(self, var, symbol, cond=None):\n class KconfigParserError(Exception):\n def __init__(self, parser, msg, tok=None):\n self.loc = parser.location()\n- tok = tok or parser.tok\n+ tok = tok if tok is not None else parser.tok\n if tok != TOK_NONE:\n- location = TOKENS.get(tok, None) or ('\"%s\"' % tok)\n+ location = TOKENS[tok] if isinstance(tok, int) else '\"%s\"' % tok\n msg = '%s before %s' % (msg, location)\n self.msg = msg\n \n@@ -573,13 +573,14 @@ def parse_config(self):\n \n def get_token(self):\n while True:\n- self.tok = self.src[self.cursor]\n+ ch = self.src[self.cursor]\n self.pos = self.cursor\n self.cursor += 1\n \n self.val = None\n- self.tok = self.scan_token()\n- if self.tok is not None:\n+ tok = self.scan_token(ch)\n+ if tok is not None:\n+ self.tok = tok\n return\n \n def check_keyword(self, rest):\n@@ -591,46 +592,46 @@ def check_keyword(self, rest):\n self.cursor += length\n return True\n \n- def scan_token(self):\n- if self.tok == '#':\n+ def scan_token(self, ch):\n+ if ch == '#':\n self.cursor = self.src.find('\\n', self.cursor)\n return None\n- elif self.tok == '=':\n+ elif ch == '=':\n return TOK_EQUAL\n- elif self.tok == '(':\n+ elif ch == '(':\n return TOK_LPAREN\n- elif self.tok == ')':\n+ elif ch == ')':\n return TOK_RPAREN\n- elif self.tok == '&' and self.src[self.pos+1] == '&':\n+ elif ch == '&' and self.src[self.pos+1] == '&':\n self.cursor += 1\n return TOK_AND\n- elif self.tok == '|' and self.src[self.pos+1] == '|':\n+ elif ch == '|' and self.src[self.pos+1] == '|':\n self.cursor += 1\n return TOK_OR\n- elif self.tok == '!':\n+ elif ch == '!':\n return TOK_NOT\n- elif self.tok == 'd' and self.check_keyword(\"epends\"):\n+ elif ch == 'd' and self.check_keyword(\"epends\"):\n return TOK_DEPENDS\n- elif self.tok == 'o' and self.check_keyword(\"n\"):\n+ elif ch == 'o' and self.check_keyword(\"n\"):\n return TOK_ON\n- elif self.tok == 's' and self.check_keyword(\"elect\"):\n+ elif ch == 's' and self.check_keyword(\"elect\"):\n return TOK_SELECT\n- elif self.tok == 'i' and self.check_keyword(\"mply\"):\n+ elif ch == 'i' and self.check_keyword(\"mply\"):\n return TOK_IMPLY\n- elif self.tok == 'c' and self.check_keyword(\"onfig\"):\n+ elif ch == 'c' and self.check_keyword(\"onfig\"):\n return TOK_CONFIG\n- elif self.tok == 'd' and self.check_keyword(\"efault\"):\n+ elif ch == 'd' and self.check_keyword(\"efault\"):\n return TOK_DEFAULT\n- elif self.tok == 'b' and self.check_keyword(\"ool\"):\n+ elif ch == 'b' and self.check_keyword(\"ool\"):\n return TOK_BOOL\n- elif self.tok == 'i' and self.check_keyword(\"f\"):\n+ elif ch == 'i' and self.check_keyword(\"f\"):\n return TOK_IF\n- elif self.tok == 'y' and self.check_keyword(\"\"):\n+ elif ch == 'y' and self.check_keyword(\"\"):\n return TOK_Y\n- elif self.tok == 'n' and self.check_keyword(\"\"):\n+ elif ch == 'n' and self.check_keyword(\"\"):\n return TOK_N\n- elif (self.tok == 's' and self.check_keyword(\"ource\")) or \\\n- self.tok == 'i' and self.check_keyword(\"nclude\"):\n+ elif (ch == 's' and self.check_keyword(\"ource\")) or \\\n+ ch == 'i' and self.check_keyword(\"nclude\"):\n # source FILENAME\n # include FILENAME\n while self.src[self.cursor].isspace():\n@@ -639,19 +640,19 @@ def scan_token(self):\n self.cursor = self.src.find('\\n', self.cursor)\n self.val = self.src[start:self.cursor]\n return TOK_SOURCE\n- elif self.tok.isalnum():\n+ elif ch.isalnum():\n # identifier\n while self.src[self.cursor].isalnum() or self.src[self.cursor] == '_':\n self.cursor += 1\n self.val = self.src[self.pos:self.cursor]\n return TOK_ID\n- elif self.tok == '\\n':\n+ elif ch == '\\n':\n if self.cursor == len(self.src):\n return TOK_EOF\n self.line += 1\n self.line_pos = self.cursor\n- elif not self.tok.isspace():\n- raise KconfigParserError(self, 'invalid input')\n+ elif not ch.isspace():\n+ raise KconfigParserError(self, 'invalid input', ch)\n \n return None\n \n","prefixes":["07/13"]}