{"id":2230958,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2230958/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260430090534.841894-5-pbonzini@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260430090534.841894-5-pbonzini@redhat.com>","date":"2026-04-30T09:05:25","name":"[04/13] minikconf: small cleanups and dead code removal","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"825ee0b257199bb9b613c22ff197ee125fdf66b4","submitter":{"id":2701,"url":"http://patchwork.ozlabs.org/api/1.1/people/2701/?format=json","name":"Paolo Bonzini","email":"pbonzini@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260430090534.841894-5-pbonzini@redhat.com/mbox/","series":[{"id":502245,"url":"http://patchwork.ozlabs.org/api/1.1/series/502245/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502245","date":"2026-04-30T09:05:25","name":"kconfig cleanups and mypy annotations","version":1,"mbox":"http://patchwork.ozlabs.org/series/502245/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2230958/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2230958/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=TZY36L56;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=mjQPh12w;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5pFC2kF2z1yJr\n\tfor ; Thu, 30 Apr 2026 19:06:21 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wINLF-0007x9-Gm; Thu, 30 Apr 2026 05:05:53 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wINLE-0007ws-A8\n for qemu-devel@nongnu.org; Thu, 30 Apr 2026 05:05:52 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wINLC-00037U-Pd\n for qemu-devel@nongnu.org; Thu, 30 Apr 2026 05:05:52 -0400","from mail-wm1-f70.google.com (mail-wm1-f70.google.com\n [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-60-Twa8p2ZsOx6ik1hSP7qggQ-1; Thu, 30 Apr 2026 05:05:47 -0400","by mail-wm1-f70.google.com with SMTP id\n 5b1f17b1804b1-488dcaf2f2fso5316955e9.0\n for ; Thu, 30 Apr 2026 02:05:46 -0700 (PDT)","from [192.168.10.48] ([151.49.85.67])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-447b4216ecasm11966391f8f.14.2026.04.30.02.05.41\n for \n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 30 Apr 2026 02:05:41 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777539950;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=QCCs4RCOmtYxMOzifARQG7+H6mlv0elKLtfHjPN/uTQ=;\n b=TZY36L56rvuuqJC3Fzsh8ZHem7ljdWxcVnlZI7AXu58Cl3sHMD1ih2G/HLYPbMIBIrkeDM\n zcf9z4TCfioHFyZwzjDjkDrFYzxavmKg0pEnXYkGH7f6Kvuor0I9i0YW7gNvszw3JBx6a4\n 7PvB6pBJrFORjyhdZydnQkBThD5a3Qg=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1777539945; x=1778144745; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:from:to:cc:subject:date:message-id\n :reply-to; bh=QCCs4RCOmtYxMOzifARQG7+H6mlv0elKLtfHjPN/uTQ=;\n b=mjQPh12wrRio8GLm3YkycRD5Nl6L0l8Uen9aYL9LVMZTx4ZLmzpBs2h+BJyus8Z1Zr\n eb6Ky7xN4jEgdrcBkVybLcSNuZAFZLoaamJnt7qP3TaDmJXadiQIaV6sj5dfhMeOx07o\n /T9pFFDTOqZgqF1wJAluUHgDeELu7pa8d19n/baxYgHKX6yEi/wVVPe2WzjgESGz6N6B\n m3z+x2/H2Ujl8oizVi7KB5ahByNMfMb4yRWb7vIiIdQclB1hDJLm4XycYKV+rAGm+YCr\n JkfkkT+tkIrvEagnk7OMYQZnQUL7RDAbYZNfweQQn/p4EUgysd8aepRDEJVHKs7LBAI3\n 3nsg=="],"X-MC-Unique":"Twa8p2ZsOx6ik1hSP7qggQ-1","X-Mimecast-MFC-AGG-ID":"Twa8p2ZsOx6ik1hSP7qggQ_1777539946","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777539945; x=1778144745;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=QCCs4RCOmtYxMOzifARQG7+H6mlv0elKLtfHjPN/uTQ=;\n b=N86oimd5NI7giHUQlr/TXqaitOK++DmxnCuNy8CtbDmFs9XBs0ASky0K2l/ZK2wP9t\n b81VP+3kRPSi94cBrHY+vu+TvlAAhWpdmxKnJOmCiSO3qbsZpIUG/t1bypYS0sm9b4me\n fWbu3TtLQncdecu1vlE2t2OhUzL7YRLFuNNsVpyL/SCTYg2C87iB8FZYwu5jexrEV0yd\n +kp3Db1qDJcxvgOv+qxn82f+oP7lKijryCZ2OB26HvuXczZYATAiGM41kJeq3vEK0HkV\n ef3PEvlhYz1Bws443rcgDsGCWZyIHZ9fTirL12p1kVy3RUxvoTa76h51liH5QGYjUC8V\n +8sQ==","X-Gm-Message-State":"AOJu0YwvZlwBe18I+CxQrxsw+v1TCPN4UKPheSKiTCJKMGqbSZ4evMkq\n 5cb7SXmdsovdiqUSW7OlHDyjTeTtK03KJTztMrETm4aBEq/UqN5y0hoJSUuFLLpAVcL0BKI4xrl\n aYt2FVG45dR0gwJU/W7B9Lu5/teVgVUTdmo/P9VBZ+6z2+ZRWtBV+keEEztNSozSFPaibF/yxQu\n Nj6BBgXND8YqUoX/GydmVLH6tPjRoqygFcIiHw2i8b","X-Gm-Gg":"AeBDiesDxwv1HZ6zncOjqTatnSSeB0i/eNqFq+96DmVkYqGCm+XHRjiWDfNNi3gZSi4\n mtnA8cyVdX3bCAr227a0U02s2oui+Q5T7r3+5vRxT90fCG/d/7QxwHO46UMPYUagDTe8Ymye3N4\n XlTVhKWKvJp5nEDNw6lYiMTq2cDuAK/Ib81d7d+kmrVKsydklbAna43ASxZ+ZFq86H0F2o+/3qY\n iLgNUj79uRp+UoIv4RaxK53geGRIBQ8a1neOJ+b+GfXpBiiRwBQ1ZwGP0w2lAJEZI9xjYEsdt9t\n LixMa/oiCOEEv+olSIKMCvvWIsjQ8mGJHpwfb2g4991CMlbSnbq7EQq6Pj3ccPVFziph9YaJxXO\n 2j+9umah94XUbXhu8jBVKYq1pGWU7ALti+24G0xbgPlok4abVTj4NvAkSp7pfB+9rcBO0lQBMNb\n LyhhVTDMFQMKLHFGLa8k1mQsMxN2CUwvh4Rek=","X-Received":["by 2002:a05:600c:888e:b0:48a:592c:e655 with SMTP id\n 5b1f17b1804b1-48a84446da7mr26054825e9.17.1777539944652;\n Thu, 30 Apr 2026 02:05:44 -0700 (PDT)","by 2002:a05:600c:888e:b0:48a:592c:e655 with SMTP id\n 5b1f17b1804b1-48a84446da7mr26054365e9.17.1777539943990;\n Thu, 30 Apr 2026 02:05:43 -0700 (PDT)"],"From":"Paolo Bonzini ","To":"qemu-devel@nongnu.org","Subject":"[PATCH 04/13] minikconf: small cleanups and dead code removal","Date":"Thu, 30 Apr 2026 11:05:25 +0200","Message-ID":"<20260430090534.841894-5-pbonzini@redhat.com>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260430090534.841894-1-pbonzini@redhat.com>","References":"<20260430090534.841894-1-pbonzini@redhat.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=pbonzini@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Signed-off-by: Paolo Bonzini \n---\n scripts/minikconf.py | 21 ++++++++++-----------\n 1 file changed, 10 insertions(+), 11 deletions(-)","diff":"diff --git a/scripts/minikconf.py b/scripts/minikconf.py\nindex 24389763db0..08df8d5dabb 100644\n--- a/scripts/minikconf.py\n+++ b/scripts/minikconf.py\n@@ -108,7 +108,7 @@ def __str__(self):\n return self.name\n \n def has_value(self):\n- return not (self.value is None)\n+ return self.value is not None\n def set_value(self, val, clause):\n self.clauses_for_var.append(clause)\n if self.has_value() and self.value != val:\n@@ -158,7 +158,7 @@ def __init__(self, dest, value, cond=None):\n KconfigData.Clause.__init__(self, dest)\n self.value = value\n self.cond = cond\n- if not (self.cond is None):\n+ if self.cond is not None:\n self.cond.add_edges_to(self.dest)\n def __str__(self):\n value = 'y' if self.value else 'n'\n@@ -212,7 +212,7 @@ def __init__(self, value_mangler=defconfig):\n def check_undefined(self):\n undef = False\n for i in self.referenced_vars:\n- if not (i in self.defined_vars):\n+ if i not in self.defined_vars:\n print(\"undefined symbol %s\" % (i), file=sys.stderr)\n undef = True\n return undef\n@@ -220,7 +220,6 @@ def check_undefined(self):\n def compute_config(self):\n if self.check_undefined():\n raise KconfigDataError(\"there were undefined symbols\")\n- return None\n \n debug_print(\"Input:\")\n for clause in self.clauses:\n@@ -270,7 +269,7 @@ def do_declaration(self, var):\n \n # var is a string with the variable's name.\n def do_var(self, var):\n- if (var in self.referenced_vars):\n+ if var in self.referenced_vars:\n return self.referenced_vars[var]\n \n var_obj = self.referenced_vars[var] = KconfigData.Var(var)\n@@ -339,9 +338,9 @@ def __str__(self):\n class KconfigParser:\n \n @classmethod\n- def parse(self, fp, mode=None):\n+ def parse(cls, fp, mode=None):\n data = KconfigData(mode or defconfig)\n- parser = KconfigParser(data)\n+ parser = cls(data)\n parser.parse_file(fp)\n return data\n \n@@ -352,9 +351,10 @@ def parse_file(self, fp):\n self.abs_fname = os.path.abspath(fp.name)\n self.fname = fp.name\n self.data.previously_included.append(self.abs_fname)\n- self.src = fp.read()\n- if self.src == '' or self.src[-1] != '\\n':\n- self.src += '\\n'\n+ src = fp.read()\n+ if src == '' or src[-1] != '\\n':\n+ src += '\\n'\n+ self.src = src\n self.cursor = 0\n self.line = 1\n self.line_pos = 0\n@@ -534,7 +534,6 @@ def parse_property(self, var):\n # properties: properties property\n # | /* empty */\n def parse_properties(self, var):\n- had_default = False\n while self.tok == TOK_DEFAULT or self.tok == TOK_DEPENDS or \\\n self.tok == TOK_SELECT or self.tok == TOK_BOOL or \\\n self.tok == TOK_IMPLY:\n","prefixes":["04/13"]}