{"id":2230906,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2230906/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20260430080627.849636-4-dario.binacchi@amarulasolutions.com/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/1.1/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260430080627.849636-4-dario.binacchi@amarulasolutions.com>","date":"2026-04-30T08:06:04","name":"[v8,3/8] test: cmd: add unit tests for part command","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"f86fafae81a54d7d13b366f2b8048cd0364a6cb4","submitter":{"id":83038,"url":"http://patchwork.ozlabs.org/api/1.1/people/83038/?format=json","name":"Dario Binacchi","email":"dario.binacchi@amarulasolutions.com"},"delegate":{"id":70413,"url":"http://patchwork.ozlabs.org/api/1.1/users/70413/?format=json","username":"pchotard","first_name":"Patrice","last_name":"Chotard","email":"patrice.chotard@st.com"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20260430080627.849636-4-dario.binacchi@amarulasolutions.com/mbox/","series":[{"id":502228,"url":"http://patchwork.ozlabs.org/api/1.1/series/502228/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=502228","date":"2026-04-30T08:06:01","name":"Support metadata-driven A/B boot for STM32MP25","version":8,"mbox":"http://patchwork.ozlabs.org/series/502228/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2230906/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2230906/checks/","tags":{},"headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=amarulasolutions.com header.i=@amarulasolutions.com\n header.a=rsa-sha256 header.s=google header.b=lZ6xkDo6;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=amarulasolutions.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=amarulasolutions.com header.i=@amarulasolutions.com\n header.b=\"lZ6xkDo6\";\n\tdkim-atps=neutral","phobos.denx.de; dmarc=pass (p=none dis=none)\n header.from=amarulasolutions.com","phobos.denx.de; spf=pass\n smtp.mailfrom=dario.binacchi@amarulasolutions.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5mwp020dz1yGq\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 30 Apr 2026 18:07:06 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 32D618465A;\n\tThu, 30 Apr 2026 10:06:46 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 2F10584656; Thu, 30 Apr 2026 10:06:45 +0200 (CEST)","from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com\n [IPv6:2a00:1450:4864:20::62b])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 747BD8465A\n for <u-boot@lists.denx.de>; Thu, 30 Apr 2026 10:06:42 +0200 (CEST)","by mail-ej1-x62b.google.com with SMTP id\n a640c23a62f3a-ba60d78aff3so90105666b.2\n for <u-boot@lists.denx.de>; Thu, 30 Apr 2026 01:06:42 -0700 (PDT)","from dario-ThinkPad-P14s-Gen-5.homenet.telecomitalia.it\n (host-82-56-22-134.retail.telecomitalia.it. [82.56.22.134])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-449c576d0a2sm668071f8f.31.2026.04.30.01.06.39\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 30 Apr 2026 01:06:40 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=amarulasolutions.com; s=google; t=1777536402; x=1778141202;\n darn=lists.denx.de;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=ww/f9aAS1MjQvIGRcDgGP8JqUvShvBL+WVU2d+FjAR4=;\n b=lZ6xkDo601IQKrNXxgsvoTrxuykUT3vGiPPVBPmYzGCRScjqplPG2FavSH9m63ESGt\n 1hh4HW8VpgB15fWmTp4C9yas86Gu1Dez739ZS1sHcWOqd5Xarq6mog+QxUKgBT6/t7dD\n BkI8pnYwzetgxxO15mqg50MD6+jQpgWvky/1I=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777536402; x=1778141202;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=ww/f9aAS1MjQvIGRcDgGP8JqUvShvBL+WVU2d+FjAR4=;\n b=TFprUue8VVYfrIum/aiNl/9jLbaUeEMIfXDMYvMFIVXnlgAGP1E9HCPgwF48wqnIQ1\n kd+ECHYiIY72chI7zug+vYA1BJxdyZTtJ7FTrECGEUUs8HKlNgiacPBNtQ6nk3PazIYn\n ZzzLrxKR4svluHJWmzdBqBlDEGel4LYlXENMXV3fel3OZzePB9RldJjuOJ0RepCAeNnB\n JhTKp9PcSOUYbmxJzx+0IJ6juCGU0P8jWMhvtOcF+HWLUeL9RVDXwQmCPypRXYDEDa5i\n 4T+0pvMYqUmuLDAY2mwV8iOKvN4O2ei/NQEdoUKdX2aoSCmS/evCbwr0bHEmRGyGiPnX\n 30dA==","X-Gm-Message-State":"AOJu0YxgjcXYK+kQT8QqWahNei9asboxPnRPyNe0MQkyZB7m8FhZMPGj\n 8udvJe8X86zbafl0rFt/77KRLOHEOdtrh6A2M/5cDABXWcB1l5AJpd+7uLgE2CFVDdkpcfCQGgc\n znKH6","X-Gm-Gg":"AeBDieuM3O7Gvt1Qkq1uTc2TX9hlhDnL68iLVgJQAhbK/pZ2azqp8WUnumsTPLsBE+J\n xufI6onfEqI/3ij8ARhyQsucU/vsnWtMFmu+P8Nlm1tzi3Qhr0aGQZ+MAIMtkXXaNPMpQi1sQDr\n 0EHJ3SHRJRyX3oIL/qPILBgmzPVk80SIASHURFM/UnGgtJ76M7ddSXByrCatpG1p0tnHrh37xq+\n 2xCVXZjazLcyww2tEtNlgGvGqg4OgkzcwAGv4ZQEwwxSAdJawgMUinhNfP09rFT2ToHinYWA3NO\n dN7WpTxkPLaVsy3H4VekwJHLuF4/B/KHiFeUrIbW+7lo1i/jONxADiTEquM37hgSL7mtUovoJsO\n tOnkwpVGHpf/PZlSLfdl4ofRiEdkgigR5zI4y0xc4p3Bu1A3L3T3Udmag1T/i5g73PfLXAjei6q\n Wi8DC+O/4Xg/iHgWi10W7LnTZlXO0cQn7N8CPBrpS5U2LT4YfPCXR+cbbBNcOSDypYq8GXYqLs9\n zkhaQqGeGVVZPTWDS2SA1RMcsRhb+ALqKoYbbGr6jpFx1VprSnJsfFAfH+Y8pwfpU+j97j+/FJz\n ODk4Z35VFBsA+hVZvcfMSsIlUOcY+uD4zIE=","X-Received":"by 2002:a17:907:1c19:b0:bb8:c3d9:3a33 with SMTP id\n a640c23a62f3a-bbac52dcf9cmr107066766b.12.1777536401339;\n Thu, 30 Apr 2026 01:06:41 -0700 (PDT)","From":"Dario Binacchi <dario.binacchi@amarulasolutions.com>","To":"u-boot@lists.denx.de","Cc":"linux-amarula@amarulasolutions.com,\n Dario Binacchi <dario.binacchi@amarulasolutions.com>,\n Simon Glass <sjg@chromium.org>, Dinesh Maniyam <dinesh.maniyam@altera.com>,\n Heinrich Schuchardt <xypron.glpk@gmx.de>,\n Marek Vasut <marek.vasut+renesas@mailbox.org>,\n Mattijs Korpershoek <mkorpershoek@kernel.org>,\n Quentin Schulz <quentin.schulz@cherry.de>, Tom Rini <trini@konsulko.com>","Subject":"[PATCH v8 3/8] test: cmd: add unit tests for part command","Date":"Thu, 30 Apr 2026 10:06:04 +0200","Message-ID":"<20260430080627.849636-4-dario.binacchi@amarulasolutions.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260430080627.849636-1-dario.binacchi@amarulasolutions.com>","References":"<20260430080627.849636-1-dario.binacchi@amarulasolutions.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"},"content":"Add unit tests for the 'part' command, specifically for the 'number',\n'start', and 'size' subcommands.\n\nThese tests establish a baseline for the current partition lookup\nfunctionality by name. This foundation will be used by subsequent\npatches to extend the command, ensuring consistent behavior as new\nfeatures are introduced.\n\nSigned-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>\nReviewed-by: Simon Glass <sjg@chromium.org>\n\n---\n\nChanges in v8:\n- Skip the test in case the CONFIG_MCC is not enabled or the mmc\n  device is not found.\n\nChanges in v6:\n- Add Reviewed-by of Simon Glass to patch 3/8 \"test: cmd: add unit\n  tests for part command\"\n\nChanges in v4:\n- Place the part command tests in the cmd suite rather than the dm\n  suite.\n- Order the include files according the U-Boot coding style.\n\nChanges in v3:\n- Wrap the lines exceeding 80 columns\n- Combine run_command() and ut_asserteq() -> ut_asserteq(1, run_command(\n\n test/cmd/Makefile |   1 +\n test/cmd/part.c   | 183 ++++++++++++++++++++++++++++++++++++++++++++++\n 2 files changed, 184 insertions(+)\n create mode 100644 test/cmd/part.c","diff":"diff --git a/test/cmd/Makefile b/test/cmd/Makefile\nindex 5f2815b1bb65..8d6932f1176c 100644\n--- a/test/cmd/Makefile\n+++ b/test/cmd/Makefile\n@@ -26,6 +26,7 @@ obj-$(CONFIG_CMD_LOADM) += loadm.o\n obj-$(CONFIG_CMD_MEMINFO) += meminfo.o\n obj-$(CONFIG_CMD_MEMORY) += mem_copy.o\n obj-$(CONFIG_CMD_MEM_SEARCH) += mem_search.o\n+obj-$(CONFIG_CMD_PART) += part.o\n ifdef CONFIG_CMD_PCI\n obj-$(CONFIG_CMD_PCI_MPS) += pci_mps.o\n endif\ndiff --git a/test/cmd/part.c b/test/cmd/part.c\nnew file mode 100644\nindex 000000000000..cac57a1a0e35\n--- /dev/null\n+++ b/test/cmd/part.c\n@@ -0,0 +1,183 @@\n+// SPDX-License-Identifier: GPL-2.0+\n+/*\n+ * Test for part command\n+ *\n+ * Copyright (C) 2026 Amarula Solutions\n+ * Written by Dario Binacchi <dario.binacchi@amarulasolutions.com>\n+ */\n+\n+#include <command.h>\n+#include <dm.h>\n+#include <env.h>\n+#include <part.h>\n+#include <vsprintf.h>\n+#include <dm/test.h>\n+#include <test/cmd.h>\n+#include <test/test.h>\n+#include <test/ut.h>\n+\n+static struct disk_partition gpt_parts[] = {\n+\t{\n+\t\t.start = 48,\n+\t\t.size = 1,\n+\t\t.name = \"test1\",\n+\t\t.uuid = \"c5bce7a2-03f0-4d03-9048-01ff23b9d527\",\n+\t},\n+\t{\n+\t\t.start = 49,\n+\t\t.size = 2,\n+\t\t.name = \"test2\",\n+\t\t.uuid = \"9df346e8-2c53-4cd8-b9ac-3af83f9a9b74\",\n+\t},\n+};\n+\n+static char disk_guid[UUID_STR_LEN + 1] =\n+\t\"8d60b397-1bb6-4d33-80ee-b1587d24c2f8\";\n+\n+static int setup_gpt_partitions(struct unit_test_state *uts,\n+\t\t\t\tunsigned int mmc_dev_num)\n+{\n+\tstruct blk_desc *mmc_dev_desc;\n+\tchar dev_str[10];\n+\tint i, ret;\n+\n+\tif (!CONFIG_IS_ENABLED(MMC))\n+\t\treturn -EAGAIN;\n+\n+\tsnprintf(dev_str, sizeof(dev_str), \"%u\", mmc_dev_num);\n+\n+\tret = blk_get_device_by_str(\"mmc\", dev_str, &mmc_dev_desc);\n+\tif (ret == -ENODEV)\n+\t\treturn -EAGAIN;\n+\n+\tut_asserteq(mmc_dev_num, ret);\n+\n+\tif (CONFIG_IS_ENABLED(RANDOM_UUID)) {\n+\t\tfor (i = 0; i < ARRAY_SIZE(gpt_parts); i++)\n+\t\t\tgen_rand_uuid_str(gpt_parts[i].uuid,\n+\t\t\t\t\t  UUID_STR_FORMAT_STD);\n+\n+\t\tgen_rand_uuid_str(disk_guid, UUID_STR_FORMAT_STD);\n+\t}\n+\n+\tut_assertok(gpt_restore(mmc_dev_desc, disk_guid, gpt_parts,\n+\t\t\t\tARRAY_SIZE(gpt_parts)));\n+\treturn 0;\n+}\n+\n+static int cmd_test_part_number(struct unit_test_state *uts)\n+{\n+\tunsigned int mmc_dev_num = 2;\n+\tchar expected[10];\n+\tint i, ret;\n+\n+\tret = setup_gpt_partitions(uts, mmc_dev_num);\n+\tif (ret == -EAGAIN)\n+\t\treturn ret;\n+\n+\tut_assertok(ret);\n+\n+\tfor (i = 0; i < ARRAY_SIZE(gpt_parts); i++) {\n+\t\tenv_set(\"partnum\", NULL);\n+\t\tut_assertok(run_commandf(\"part number mmc %u %s partnum\",\n+\t\t\t\t\t mmc_dev_num, gpt_parts[i].name));\n+\t\tsnprintf(expected, sizeof(expected), \"0x%x\", i + 1);\n+\t\tut_asserteq_str(expected, env_get(\"partnum\"));\n+\t}\n+\n+\tenv_set(\"partnum\", NULL);\n+\tut_asserteq(1, run_commandf(\"part number mmc %u bogus partnum\",\n+\t\t\t\t    mmc_dev_num));\n+\tut_assertnull(env_get(\"partnum\"));\n+\n+\treturn 0;\n+}\n+CMD_TEST(cmd_test_part_number, UTF_CONSOLE);\n+\n+static int cmd_test_part_start(struct unit_test_state *uts)\n+{\n+\tunsigned int mmc_dev_num = 2;\n+\tchar expected[32];\n+\tint i, ret;\n+\n+\tret = setup_gpt_partitions(uts, mmc_dev_num);\n+\tif (ret == -EAGAIN)\n+\t\treturn ret;\n+\n+\tut_assertok(ret);\n+\n+\tfor (i = 0; i < ARRAY_SIZE(gpt_parts); i++) {\n+\t\tenv_set(\"partstart\", NULL);\n+\t\tut_assertok(run_commandf(\"part start mmc %u %d partstart\",\n+\t\t\t\t\t mmc_dev_num, i + 1));\n+\t\tsnprintf(expected, sizeof(expected), \"%lx\",\n+\t\t\t (unsigned long)gpt_parts[i].start);\n+\t\tut_asserteq_str(expected, env_get(\"partstart\"));\n+\t}\n+\n+\tenv_set(\"partstart\", NULL);\n+\tut_asserteq(1, run_commandf(\"part start mmc %u 3 partstart\",\n+\t\t\t\t    mmc_dev_num));\n+\tut_assertnull(env_get(\"partstart\"));\n+\n+\tfor (i = 0; i < ARRAY_SIZE(gpt_parts); i++) {\n+\t\tenv_set(\"partstart\", NULL);\n+\t\tut_assertok(run_commandf(\"part start mmc %u %s partstart\",\n+\t\t\t\t\t mmc_dev_num, gpt_parts[i].name));\n+\t\tsnprintf(expected, sizeof(expected), \"%lx\",\n+\t\t\t (unsigned long)gpt_parts[i].start);\n+\t\tut_asserteq_str(expected, env_get(\"partstart\"));\n+\t}\n+\n+\tenv_set(\"partstart\", NULL);\n+\tut_asserteq(1, run_commandf(\"part start mmc %u bogus partstart\",\n+\t\t\t\t    mmc_dev_num));\n+\tut_assertnull(env_get(\"partstart\"));\n+\n+\treturn 0;\n+}\n+CMD_TEST(cmd_test_part_start, UTF_CONSOLE);\n+\n+static int cmd_test_part_size(struct unit_test_state *uts)\n+{\n+\tunsigned int mmc_dev_num = 2;\n+\tchar expected[32];\n+\tint i, ret;\n+\n+\tret = setup_gpt_partitions(uts, mmc_dev_num);\n+\tif (ret == -EAGAIN)\n+\t\treturn ret;\n+\n+\tut_assertok(ret);\n+\n+\tfor (i = 0; i < ARRAY_SIZE(gpt_parts); i++) {\n+\t\tenv_set(\"partsize\", NULL);\n+\t\tut_assertok(run_commandf(\"part size mmc %u %d partsize\",\n+\t\t\t\t\t mmc_dev_num, i + 1));\n+\t\tsnprintf(expected, sizeof(expected), \"%lx\",\n+\t\t\t (unsigned long)gpt_parts[i].size);\n+\t\tut_asserteq_str(expected, env_get(\"partsize\"));\n+\t}\n+\n+\tenv_set(\"partsize\", NULL);\n+\tut_asserteq(1, run_commandf(\"part size mmc %u 3 partsize\",\n+\t\t\t\t    mmc_dev_num));\n+\tut_assertnull(env_get(\"partsize\"));\n+\n+\tfor (i = 0; i < ARRAY_SIZE(gpt_parts); i++) {\n+\t\tenv_set(\"partsize\", NULL);\n+\t\tut_assertok(run_commandf(\"part size mmc %u %s partsize\",\n+\t\t\t\t\t mmc_dev_num, gpt_parts[i].name));\n+\t\tsnprintf(expected, sizeof(expected), \"%lx\",\n+\t\t\t (unsigned long)gpt_parts[i].size);\n+\t\tut_asserteq_str(expected, env_get(\"partsize\"));\n+\t}\n+\n+\tenv_set(\"partsize\", NULL);\n+\tut_asserteq(1, run_commandf(\"part size mmc %u bogus partsize\",\n+\t\t\t\t    mmc_dev_num));\n+\tut_assertnull(env_get(\"partsize\"));\n+\n+\treturn 0;\n+}\n+CMD_TEST(cmd_test_part_size, UTF_CONSOLE);\n","prefixes":["v8","3/8"]}