{"id":2230714,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2230714/?format=json","web_url":"http://patchwork.ozlabs.org/project/openbmc/patch/20260429-winbond-v6-18-rc1-cont-read-v3-9-0f38b3c229ad@bootlin.com/","project":{"id":56,"url":"http://patchwork.ozlabs.org/api/1.1/projects/56/?format=json","name":"OpenBMC development","link_name":"openbmc","list_id":"openbmc.lists.ozlabs.org","list_email":"openbmc@lists.ozlabs.org","web_url":"http://github.com/openbmc/","scm_url":"","webscm_url":""},"msgid":"<20260429-winbond-v6-18-rc1-cont-read-v3-9-0f38b3c229ad@bootlin.com>","date":"2026-04-29T17:56:46","name":"[v3,09/11] mtd: spinand: winbond: Create a helper to write the HS bit","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"cf55b6004e51bc6f87543936bb9513f6b9058cff","submitter":{"id":73368,"url":"http://patchwork.ozlabs.org/api/1.1/people/73368/?format=json","name":"Miquel Raynal","email":"miquel.raynal@bootlin.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/openbmc/patch/20260429-winbond-v6-18-rc1-cont-read-v3-9-0f38b3c229ad@bootlin.com/mbox/","series":[{"id":502171,"url":"http://patchwork.ozlabs.org/api/1.1/series/502171/?format=json","web_url":"http://patchwork.ozlabs.org/project/openbmc/list/?series=502171","date":"2026-04-29T17:56:37","name":"mtd: spinand: Winbond continuous read support","version":3,"mbox":"http://patchwork.ozlabs.org/series/502171/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2230714/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2230714/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","openbmc@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256\n header.s=dkim header.b=Vmb/o8DH;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=openbmc+bounces-1881-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=185.246.84.56","lists.ozlabs.org;\n dmarc=pass (p=reject dis=none) header.from=bootlin.com","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256\n header.s=dkim header.b=Vmb/o8DH;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=bootlin.com\n (client-ip=185.246.84.56; helo=smtpout-02.galae.net;\n envelope-from=miquel.raynal@bootlin.com; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5ZWS19J4z1yGq\n\tfor ; Thu, 30 Apr 2026 10:17:56 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4g5ZSn4M4pz2yvr;\n\tThu, 30 Apr 2026 10:15:37 +1000 (AEST)","from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4g5QK168mpz2ySc\n\tfor ; Thu, 30 Apr 2026 04:08:21 +1000 (AEST)","from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233])\n\tby smtpout-02.galae.net (Postfix) with ESMTPS id 3D8511A3464;\n\tWed, 29 Apr 2026 17:58:14 +0000 (UTC)","from mail.galae.net (mail.galae.net [212.83.136.155])\n\tby smtpout-01.galae.net (Postfix) with ESMTPS id 09E735FD43;\n\tWed, 29 Apr 2026 17:58:14 +0000 (UTC)","from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon)\n with ESMTPSA id 1A14B1072B175;\n\tWed, 29 Apr 2026 19:58:07 +0200 (CEST)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1777486102;\n\tcv=none;\n b=SocufaXLVCdlwAA1qiwajf0QfrxD7t37r77UR1YE/SGsKbnH8bfAJuA3dsb+/KBXN/69CgeMUWpadt0hneM6/hMfm9iL8eKrNPD17thW2mdF4mbek8Ij/b87rZeB0rquUFGMye6sTzORGpWIqWGqKt3YZAAK+5j2z7E8Un/4c8TRWlAhjnpZU+75AYfAgYpUxqMlXtbf+SzX8swG02GqQtRWtZOBeB70FruEq7hYftP1yp+I094pmBHpr/Jq0cKDh74n0X0J3XOdu/uJrLyo0JC0Z9FXSgHdhSnKJN2Be9zLs3Ori46Tn1LwQ31tJ9mEaaLwNRQQdeyvV95MzUnN1Q==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1777486102; c=relaxed/relaxed;\n\tbh=5tIkRnE1ORjoj4u0h1eWmFg73tjo03bMRc5hBjhSYqM=;\n\th=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References:\n\t In-Reply-To:To:Cc;\n b=M12jeXFTGT4rHDI6pj6v6XmGDmdvfgCFKcnS/lHk7zJuoEMUz2iV6EUjqUUNYCxkbnTQl8h6cfRjqhU0j2K1hPuDaGzDtfy9o8bKULV6KHnQvDxmEtJFDAjqw56xHys1N494iV8zhoG8b5mFtbO3J11OVmV6tQSdD14e/4FpFi1veBYHUHoi4zvf2HdzG7yYEK3VE1h+J2Uw6G4eYKq3wGEoJf39KgQAePhRDAv3dinvzHcXnj5N99qIMzky8XKQYdNz3lY5VVQ05kGrmu9wv40ExG35FJ2vhnNP46mdwD82wrvUHAsOuj+yIt348fNTLkWSTD6/voP4c/hX3AbaHQ==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=reject dis=none) header.from=bootlin.com;\n dkim=pass (2048-bit key;\n unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256\n header.s=dkim header.b=Vmb/o8DH; dkim-atps=neutral;\n spf=pass (client-ip=185.246.84.56; helo=smtpout-02.galae.net;\n envelope-from=miquel.raynal@bootlin.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=bootlin.com","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim;\n\tt=1777485491; h=from:subject:date:message-id:to:cc:mime-version:content-type:\n\t content-transfer-encoding:in-reply-to:references;\n\tbh=5tIkRnE1ORjoj4u0h1eWmFg73tjo03bMRc5hBjhSYqM=;\n\tb=Vmb/o8DHri8qfjlDxdgxVCmz1cOiWo5fai2OHnEYLHyIsyVdpDTgWD44JJKYBik+Bop6+W\n\tqO/mPLDC2HvVPtzzFzJzmO0zmj8Ud0q8Cl6mkOzfLIV5t4BqhYfAOS/P4cCduBkSpSOfmM\n\t5M8eLmzfXkqP4D5NBRKhvhmcWtsq9c1mg0MVwung6UnlsGwZeb4fsNZ/pNVgjm2S/Vrlqz\n\tcQsoBDbxgbA6MAC7jdwUUgJJZj7f2xsTfwFvpawEIDwOwqd6ZhkIt1k16aESiXmhdrWfdA\n\tWg5O+8KVvlIUYgrSqKw5HE7tXplaioeNXtYi4yXBgQzvAFVe4lpxohvMt0C13A==","From":"Miquel Raynal ","Date":"Wed, 29 Apr 2026 19:56:46 +0200","Subject":"[PATCH v3 09/11] mtd: spinand: winbond: Create a helper to write\n the HS bit","X-Mailing-List":"openbmc@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"\n <20260429-winbond-v6-18-rc1-cont-read-v3-9-0f38b3c229ad@bootlin.com>","References":"\n <20260429-winbond-v6-18-rc1-cont-read-v3-0-0f38b3c229ad@bootlin.com>","In-Reply-To":"\n <20260429-winbond-v6-18-rc1-cont-read-v3-0-0f38b3c229ad@bootlin.com>","To":"Mark Brown , Richard Weinberger ,\n Vignesh Raghavendra , Michael Walle ,\n Miquel Raynal ,\n Takahiro Kuwano ,\n Lorenzo Bianconi , Ray Liu ,\n Chin-Ting Kuo , =?utf-8?q?C=C3=A9dric_Le_Goa?=\n\t=?utf-8?q?ter?= , Joel Stanley ,\n Andrew Jeffery ,\n Avi Fishman , Tomer Maimon ,\n Tali Perry , Patrick Venture ,\n Nancy Yuen , Benjamin Fair ,\n Maxime Coquelin ,\n Alexandre Torgue , =?utf-8?q?Jonathan_Neusch?=\n\t=?utf-8?q?=C3=A4fer?= ","Cc":"Pratyush Yadav ,\n Thomas Petazzoni ,\n Steam Lin , Santhosh Kumar K ,\n linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,\n linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org,\n linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org,\n linux-stm32@st-md-mailman.stormreply.com","X-Mailer":"b4 0.14.3","X-Last-TLS-Session-Version":"TLSv1.3","X-Spam-Status":"No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tDKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS autolearn=disabled\n\tversion=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"},"content":"Updating the HS bit is not complex but implies reading, setting/clearing\na bit and writing. Clean a bit this section by moving this logic in its\nown helper.\n\nSigned-off-by: Miquel Raynal \n---\n drivers/mtd/nand/spi/winbond.c | 34 ++++++++++++++++++----------------\n 1 file changed, 18 insertions(+), 16 deletions(-)","diff":"diff --git a/drivers/mtd/nand/spi/winbond.c b/drivers/mtd/nand/spi/winbond.c\nindex 6c11f59a9f8d..b30a343a6672 100644\n--- a/drivers/mtd/nand/spi/winbond.c\n+++ b/drivers/mtd/nand/spi/winbond.c\n@@ -404,13 +404,28 @@ static int w25w35nxxjw_ecc_get_status(struct spinand_device *spinand, u8 status)\n \treturn -EINVAL;\n }\n \n+static int w25n0xjw_set_sr4_hs(struct spinand_device *spinand, bool enable)\n+{\n+\tint ret;\n+\tu8 sr4;\n+\n+\tret = spinand_read_reg_op(spinand, W25N0XJW_SR4, &sr4);\n+\tif (ret)\n+\t\treturn ret;\n+\n+\tif (enable)\n+\t\tsr4 |= W25N0XJW_SR4_HS;\n+\telse\n+\t\tsr4 &= ~W25N0XJW_SR4_HS;\n+\n+\treturn spinand_write_reg_op(spinand, W25N0XJW_SR4, sr4);\n+}\n+\n static int w25n0xjw_hs_cfg(struct spinand_device *spinand,\n \t\t\t enum spinand_bus_interface iface)\n {\n \tconst struct spi_mem_op *op;\n \tbool hs;\n-\tu8 sr4;\n-\tint ret;\n \n \tif (iface != SSDR)\n \t\treturn -EOPNOTSUPP;\n@@ -429,20 +444,7 @@ static int w25n0xjw_hs_cfg(struct spinand_device *spinand,\n \telse\n \t\ths = true;\n \n-\tret = spinand_read_reg_op(spinand, W25N0XJW_SR4, &sr4);\n-\tif (ret)\n-\t\treturn ret;\n-\n-\tif (hs)\n-\t\tsr4 |= W25N0XJW_SR4_HS;\n-\telse\n-\t\tsr4 &= ~W25N0XJW_SR4_HS;\n-\n-\tret = spinand_write_reg_op(spinand, W25N0XJW_SR4, sr4);\n-\tif (ret)\n-\t\treturn ret;\n-\n-\treturn 0;\n+\treturn w25n0xjw_set_sr4_hs(spinand, hs);\n }\n \n static int w35n0xjw_write_vcr(struct spinand_device *spinand, u8 reg, u8 val)\n","prefixes":["v3","09/11"]}