{"id":2230711,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2230711/?format=json","web_url":"http://patchwork.ozlabs.org/project/openbmc/patch/20260429-winbond-v6-18-rc1-cont-read-v3-10-0f38b3c229ad@bootlin.com/","project":{"id":56,"url":"http://patchwork.ozlabs.org/api/1.1/projects/56/?format=json","name":"OpenBMC development","link_name":"openbmc","list_id":"openbmc.lists.ozlabs.org","list_email":"openbmc@lists.ozlabs.org","web_url":"http://github.com/openbmc/","scm_url":"","webscm_url":""},"msgid":"<20260429-winbond-v6-18-rc1-cont-read-v3-10-0f38b3c229ad@bootlin.com>","date":"2026-04-29T17:56:47","name":"[v3,10/11] mtd: spinand: winbond: Create a helper to detect the need for the HS bit","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"ec8263fbf6e4bc5d164f585d63d120ea855abd2f","submitter":{"id":73368,"url":"http://patchwork.ozlabs.org/api/1.1/people/73368/?format=json","name":"Miquel Raynal","email":"miquel.raynal@bootlin.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/openbmc/patch/20260429-winbond-v6-18-rc1-cont-read-v3-10-0f38b3c229ad@bootlin.com/mbox/","series":[{"id":502171,"url":"http://patchwork.ozlabs.org/api/1.1/series/502171/?format=json","web_url":"http://patchwork.ozlabs.org/project/openbmc/list/?series=502171","date":"2026-04-29T17:56:37","name":"mtd: spinand: Winbond continuous read support","version":3,"mbox":"http://patchwork.ozlabs.org/series/502171/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2230711/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2230711/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","openbmc@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256\n header.s=dkim header.b=NmSZF+iW;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=openbmc+bounces-1879-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=185.246.84.56","lists.ozlabs.org;\n dmarc=pass (p=reject dis=none) header.from=bootlin.com","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256\n header.s=dkim header.b=NmSZF+iW;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=bootlin.com\n (client-ip=185.246.84.56; helo=smtpout-02.galae.net;\n envelope-from=miquel.raynal@bootlin.com; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5ZVv0QBqz1yGq\n\tfor ; Thu, 30 Apr 2026 10:17:27 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4g5ZSm54hRz2yvM;\n\tThu, 30 Apr 2026 10:15:36 +1000 (AEST)","from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4g5QK169Wbz2yjp\n\tfor ; Thu, 30 Apr 2026 04:08:21 +1000 (AEST)","from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233])\n\tby smtpout-02.galae.net (Postfix) with ESMTPS id 409131A3470;\n\tWed, 29 Apr 2026 17:58:18 +0000 (UTC)","from mail.galae.net (mail.galae.net [212.83.136.155])\n\tby smtpout-01.galae.net (Postfix) with ESMTPS id 0CCFF5FD43;\n\tWed, 29 Apr 2026 17:58:18 +0000 (UTC)","from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon)\n with ESMTPSA id 3C0971072B171;\n\tWed, 29 Apr 2026 19:58:12 +0200 (CEST)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1777486102;\n\tcv=none;\n b=blEhXXH6CReEBP2vmUfysbtjz7vr8rmvl7UVO3p2nRylESIH35dQGwbY52/D9upL/iZGmKTpF1EMkBp6M4bp6xrIwAMpzLhUpJ9lqy/h23HkxIOrpr37fBZLdVaoyH+Td0PlKjw7W/tUOc1NBav+H0TjGn/JYKEwE55hz7Zo54WAFFYmskT67dJKiEkvsma5KKP5TyFtj+m4JWIHJuN6NtS2+2QQ37vnh9/X/CV1lVa67J4qILJ2Ji8RIeV/A8J5YvxA1ySY9l/KYi4V+YCvkNbq3r+ptsXxIMvi8MEF3sHHs8XSPApzd/t2OrTaVk+mqH2Jpa3hC4bEdu0TljToCA==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1777486102; c=relaxed/relaxed;\n\tbh=djNQC+WiehgbSjZPUHPGAOR2nkZcZmEr0KjHIcYf3t4=;\n\th=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References:\n\t In-Reply-To:To:Cc;\n b=LkCnSYZazTHYaw1ugnDC3Jpg5ELxnOxegtxgVJS2H9IUpL3gWTsjquVApYjDSegW5KGyrCQzwMK93VrAlvNL9hbPiPLpFhq5izzwTrxgcV1rjnuDW41FKBYs+9Cm8fFxxeSMTg/8RnVBSnRqPtvHGuo78TTv6dRUzXrru6aq+Loi2VdG+USL/o7/uHsfDRrRv4KL5Kc0TPVbpJaetD+iTMzwEkcQGyVzVGl3MXJmcQKUeW5klpyiwKH1zmh/QOLGPRVom2oST1CKsoELTaDuMj0dMyoOVR1XDk52XrNZQg2sDPaaY76czvlqVUqx9KnZqlweTj81jR/qYzvrSmY0kw==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=reject dis=none) header.from=bootlin.com;\n dkim=pass (2048-bit key;\n unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256\n header.s=dkim header.b=NmSZF+iW; dkim-atps=neutral;\n spf=pass (client-ip=185.246.84.56; helo=smtpout-02.galae.net;\n envelope-from=miquel.raynal@bootlin.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=bootlin.com","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim;\n\tt=1777485495; h=from:subject:date:message-id:to:cc:mime-version:content-type:\n\t content-transfer-encoding:in-reply-to:references;\n\tbh=djNQC+WiehgbSjZPUHPGAOR2nkZcZmEr0KjHIcYf3t4=;\n\tb=NmSZF+iWjEyn2SmSbXR4+EkHCCLdjDtILUG9X51p5SCiphlxZnjKNNGhMMDdv6+IE8Z0pT\n\tASIHf/oK5ins8abEGkf3OT/DpAh4+l/rTkVjcESvNc56zjX3c6MzBilErApZ2Bhx8qWhnA\n\tq4skr5wiZcq3mmwHq2jiVNGW1mYCJN/tNbDh2F3BzrrvyfD4fdGmhsSID0jKhhjNOiGAz6\n\tjJJPYq8QKvuUtagfzMs9+zJqCAJairETws7j+Woa85G71iDosgPBr85dnsTyIGKlD82Shb\n\tllYfvCKlpMGTCJF/Xyt0qdAzxC71iYXH4L/FxQpv9jVgln0FJY4chh9edS6YQw==","From":"Miquel Raynal ","Date":"Wed, 29 Apr 2026 19:56:47 +0200","Subject":"[PATCH v3 10/11] mtd: spinand: winbond: Create a helper to detect\n the need for the HS bit","X-Mailing-List":"openbmc@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"\n <20260429-winbond-v6-18-rc1-cont-read-v3-10-0f38b3c229ad@bootlin.com>","References":"\n <20260429-winbond-v6-18-rc1-cont-read-v3-0-0f38b3c229ad@bootlin.com>","In-Reply-To":"\n <20260429-winbond-v6-18-rc1-cont-read-v3-0-0f38b3c229ad@bootlin.com>","To":"Mark Brown , Richard Weinberger ,\n Vignesh Raghavendra , Michael Walle ,\n Miquel Raynal ,\n Takahiro Kuwano ,\n Lorenzo Bianconi , Ray Liu ,\n Chin-Ting Kuo , =?utf-8?q?C=C3=A9dric_Le_Goa?=\n\t=?utf-8?q?ter?= , Joel Stanley ,\n Andrew Jeffery ,\n Avi Fishman , Tomer Maimon ,\n Tali Perry , Patrick Venture ,\n Nancy Yuen , Benjamin Fair ,\n Maxime Coquelin ,\n Alexandre Torgue , =?utf-8?q?Jonathan_Neusch?=\n\t=?utf-8?q?=C3=A4fer?= ","Cc":"Pratyush Yadav ,\n Thomas Petazzoni ,\n Steam Lin , Santhosh Kumar K ,\n linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,\n linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org,\n linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org,\n linux-stm32@st-md-mailman.stormreply.com","X-Mailer":"b4 0.14.3","X-Last-TLS-Session-Version":"TLSv1.3","X-Spam-Status":"No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tDKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS autolearn=disabled\n\tversion=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"},"content":"The logic is not complex but might be reused to cleanup a bit the\nsection by moving it to a dedicated helper.\n\nSigned-off-by: Miquel Raynal \n---\n drivers/mtd/nand/spi/winbond.c | 31 +++++++++++++++++--------------\n 1 file changed, 17 insertions(+), 14 deletions(-)","diff":"diff --git a/drivers/mtd/nand/spi/winbond.c b/drivers/mtd/nand/spi/winbond.c\nindex b30a343a6672..ffbcd25b0366 100644\n--- a/drivers/mtd/nand/spi/winbond.c\n+++ b/drivers/mtd/nand/spi/winbond.c\n@@ -421,30 +421,33 @@ static int w25n0xjw_set_sr4_hs(struct spinand_device *spinand, bool enable)\n \treturn spinand_write_reg_op(spinand, W25N0XJW_SR4, sr4);\n }\n \n+/*\n+ * SDR dual and quad I/O operations over 104MHz require the HS bit to\n+ * enable a few more dummy cycles.\n+ */\n+static bool w25n0xjw_op_needs_hs(const struct spi_mem_op *op)\n+{\n+\tif (op->cmd.dtr || op->addr.dtr || op->dummy.dtr || op->data.dtr)\n+\t\treturn false;\n+\telse if (op->cmd.buswidth != 1 || op->addr.buswidth == 1)\n+\t\treturn false;\n+\telse if (op->max_freq && op->max_freq <= 104 * HZ_PER_MHZ)\n+\t\treturn false;\n+\n+\treturn true;\n+}\n+\n static int w25n0xjw_hs_cfg(struct spinand_device *spinand,\n \t\t\t enum spinand_bus_interface iface)\n {\n \tconst struct spi_mem_op *op;\n-\tbool hs;\n \n \tif (iface != SSDR)\n \t\treturn -EOPNOTSUPP;\n \n-\t/*\n-\t * SDR dual and quad I/O operations over 104MHz require the HS bit to\n-\t * enable a few more dummy cycles.\n-\t */\n \top = spinand->op_templates->read_cache;\n-\tif (op->cmd.dtr || op->addr.dtr || op->dummy.dtr || op->data.dtr)\n-\t\ths = false;\n-\telse if (op->cmd.buswidth != 1 || op->addr.buswidth == 1)\n-\t\ths = false;\n-\telse if (op->max_freq && op->max_freq <= 104 * HZ_PER_MHZ)\n-\t\ths = false;\n-\telse\n-\t\ths = true;\n \n-\treturn w25n0xjw_set_sr4_hs(spinand, hs);\n+\treturn w25n0xjw_set_sr4_hs(spinand, w25n0xjw_op_needs_hs(op));\n }\n \n static int w35n0xjw_write_vcr(struct spinand_device *spinand, u8 reg, u8 val)\n","prefixes":["v3","10/11"]}