{"id":2230699,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2230699/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260430000524.56046-31-richard.henderson@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260430000524.56046-31-richard.henderson@linaro.org>","date":"2026-04-30T00:05:13","name":"[v2,30/40] fpu: Hoist nan check in partsN_addsub","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"0d247b04dadcf8ba044eaf97213d305336d94795","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/1.1/people/72104/?format=json","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260430000524.56046-31-richard.henderson@linaro.org/mbox/","series":[{"id":502170,"url":"http://patchwork.ozlabs.org/api/1.1/series/502170/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502170","date":"2026-04-30T00:04:48","name":"fpu: Export some internals for targets","version":2,"mbox":"http://patchwork.ozlabs.org/series/502170/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2230699/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2230699/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=U7KBFDGO;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5ZMN4rcTz1yHv\n\tfor ; Thu, 30 Apr 2026 10:10:56 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wIEvt-000089-KU; Wed, 29 Apr 2026 20:07:09 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wIEvQ-00082v-IL\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 20:06:41 -0400","from mail-pf1-x435.google.com ([2607:f8b0:4864:20::435])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wIEvO-0001w2-6N\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 20:06:40 -0400","by mail-pf1-x435.google.com with SMTP id\n d2e1a72fcca58-82fbf5d4dc2so266393b3a.1\n for ; Wed, 29 Apr 2026 17:06:37 -0700 (PDT)","from stoup.. ([180.233.125.15]) by smtp.gmail.com with ESMTPSA id\n d2e1a72fcca58-834ed7ef7a8sm2928667b3a.47.2026.04.29.17.06.35\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 29 Apr 2026 17:06:36 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777507597; x=1778112397; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=fQkQKLK77Dv6DrQmjWfjyf9hVFUzji/KbysWx+6wnbM=;\n b=U7KBFDGOLxm34Tl0Y/Br3aFOx3B4T2MUGU3y/WPwR9KtxZvg3hGtp3tMPHYJwDhMGG\n smi3/IGfaET73BDamxMuV8Sr6/lFevLN4UGeNndfQK/YiuT2ea6Tg1rsGZljvAPE02s/\n 844h/VuWR8rX6WvPWPCYuP9zN/XunfVLnqz2uYe+kZQUfhSWTxd8nMntzSpIg1MchSMz\n JA1XHEEUy6U0Y0ORre/s2SgIw1QHRlo6ZsGAVNZYrqIgUYJiFcYR0SS3tLSmQwI3DE3M\n ozDMg/svwMhxaXuWrw5UgxfuQ5PVfEgzdoWVKz+fQ9o5eO6JxRv+92136YYpm5XDyb7i\n 8BYA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777507597; x=1778112397;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=fQkQKLK77Dv6DrQmjWfjyf9hVFUzji/KbysWx+6wnbM=;\n b=XbIleRCt4ct49tDqDiNStOI51iueYJ1AtAuXzy7FSX4FTn3lMQZG7H4MbiRG/PIcrb\n QqiOhF/lwtKL/Z6CQ4fniLPX4Dw4Y8a3bKuFiS1JcefpzR5emW3MO7S9MknOsoYI+SIz\n Hc7S2fxManbe0r0wCzxwnRIQemKQAq9YhYgZbux9rzzcu2Jd3qGiU+cp4kZ+ynEt019n\n aVvdn9xbsWxTz/1XDPD3aWYxHrtsFpxne2n7UaHYFEU0e0y89f7jAAuJq/onNJ1FsZd5\n umz8CdKrnqyM1zTgpq7jXjLKDzjz5MPlcVJ+3MKvsvUFizCBE9vXicBEefK82R8ipazs\n z19A==","X-Gm-Message-State":"AOJu0YzHu6r0QeIKReL5z5bhq6Uk3Hz43ddO1zQO3RySzx9miOtEq9/q\n Uc19o1wegGlkymMtadCxo9B6eS3jL/ivTpH3F8X6eT8EdslVYh00dUtFRjWM8+RHFOycADqW3Oa\n jN/CA8FY=","X-Gm-Gg":"AeBDietO+2mry+NvUcQvMJ987oRFKLpwlU9cPL5HZS2SVbPXY2AedCjtbE3hsxKUxSe\n rSJnmn2X3fvGARwcJab/ALpEsfNgt0KulwrB8FHwDy3vWgIcB8qDZJm8SzFNSdcwv6Pyaoxhhup\n 6qAixRw2LZAYcuBgslusSEDavmTAu7UaVVTY2yD5NMiWNLukDqmFcGGlYhX9+mGkbNy80sDawlK\n ukEuiAbPo6b2IzytX3DDrb7U0CQWt1aUlU7SIqN5luCmtJz/jhrth2v861O+IVgZQZMyQCO5Vwn\n hh5J9Il2+0bb/eunfN0G+HmiEyKICo6fanUV3lGt5Rjc/DJceZghyHzFo+kJZr34K6AFrCFszG2\n aUY2lFeUb54mjTol7Y9A13IhtUwVr4yjFFNY94YVol49+uGlPaTr90B3QfCLcK/h3IH93T+UgwV\n qrtcYQ4oOxXV6fYf+dB6xXTgpV4So6G91XdKwcv1NJ","X-Received":"by 2002:a05:6a00:4503:b0:82f:7bec:2050 with SMTP id\n d2e1a72fcca58-834fdc3bd40mr928030b3a.39.1777507596806;\n Wed, 29 Apr 2026 17:06:36 -0700 (PDT)","From":"Richard Henderson ","To":"qemu-devel@nongnu.org","Cc":"philmd@linaro.org","Subject":"[PATCH v2 30/40] fpu: Hoist nan check in partsN_addsub","Date":"Thu, 30 Apr 2026 10:05:13 +1000","Message-ID":"<20260430000524.56046-31-richard.henderson@linaro.org>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260430000524.56046-1-richard.henderson@linaro.org>","References":"<20260430000524.56046-1-richard.henderson@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::435;\n envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x435.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"The nan test had been down below because it was unlikely.\nBut if we have to have one anyway because of denormals,\nwe might as well take care of them right away.\n\nSigned-off-by: Richard Henderson \n---\n fpu/softfloat-parts.c.inc | 21 ++++++---------------\n 1 file changed, 6 insertions(+), 15 deletions(-)","diff":"diff --git a/fpu/softfloat-parts.c.inc b/fpu/softfloat-parts.c.inc\nindex 84aeae2866..0a0f3a4f0b 100644\n--- a/fpu/softfloat-parts.c.inc\n+++ b/fpu/softfloat-parts.c.inc\n@@ -530,13 +530,16 @@ static FloatPartsN *partsN(addsub)(FloatPartsN *a, FloatPartsN *b,\n bool b_sign = b->sign ^ subtract;\n int ab_mask = float_cmask(a->cls) | float_cmask(b->cls);\n \n+ if (unlikely(ab_mask & float_cmask_anynan)) {\n+ *a = partsN(pick_nan)(a, b, s);\n+ return a;\n+ }\n+\n /*\n * For addition and subtraction, we will consume an\n * input denormal unless the other input is a NaN.\n */\n- if (!(ab_mask & float_cmask_anynan)) {\n- record_denormals_used(ab_mask, s);\n- }\n+ record_denormals_used(ab_mask, s);\n \n if (a->sign != b_sign) {\n /* Subtraction */\n@@ -553,10 +556,6 @@ static FloatPartsN *partsN(addsub)(FloatPartsN *a, FloatPartsN *b,\n return a;\n }\n \n- if (unlikely(ab_mask & float_cmask_anynan)) {\n- goto p_nan;\n- }\n-\n if (ab_mask & float_cmask_inf) {\n if (a->cls != float_class_inf) {\n /* N - Inf */\n@@ -582,10 +581,6 @@ static FloatPartsN *partsN(addsub)(FloatPartsN *a, FloatPartsN *b,\n return a;\n }\n \n- if (unlikely(ab_mask & float_cmask_anynan)) {\n- goto p_nan;\n- }\n-\n if (ab_mask & float_cmask_inf) {\n a->cls = float_class_inf;\n return a;\n@@ -602,10 +597,6 @@ static FloatPartsN *partsN(addsub)(FloatPartsN *a, FloatPartsN *b,\n return_b:\n b->sign = b_sign;\n return b;\n-\n- p_nan:\n- *a = partsN(pick_nan)(a, b, s);\n- return a;\n }\n \n /*\n","prefixes":["v2","30/40"]}