{"id":2230651,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2230651/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/177750474339.3016150.13196470704394042910@talencesecurity.com/","project":{"id":26,"url":"http://patchwork.ozlabs.org/api/1.1/projects/26/?format=json","name":"Netfilter Development","link_name":"netfilter-devel","list_id":"netfilter-devel.vger.kernel.org","list_email":"netfilter-devel@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<177750474339.3016150.13196470704394042910@talencesecurity.com>","date":"2026-04-29T23:19:03","name":"[v2,1/2] netfilter: ip_tables: guard ipt_unregister_table_pre_exit against NULL ops","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"0464f06ea73f07d7e6b264511e295897f74de44f","submitter":{"id":93179,"url":"http://patchwork.ozlabs.org/api/1.1/people/93179/?format=json","name":"Tristan Madani","email":"tristmd@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/177750474339.3016150.13196470704394042910@talencesecurity.com/mbox/","series":[{"id":502165,"url":"http://patchwork.ozlabs.org/api/1.1/series/502165/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/list/?series=502165","date":"2026-04-29T23:18:45","name":"netfilter: fix NULL ops dereference in iptable lazy init","version":2,"mbox":"http://patchwork.ozlabs.org/series/502165/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2230651/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2230651/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","netfilter-devel@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=MlQrKjdb;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.105.105.114; helo=tor.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-12310-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"MlQrKjdb\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.128.42","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org [172.105.105.114])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5YD70hDrz1yGq\n\tfor ; Thu, 30 Apr 2026 09:19:35 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 81E5630254A9\n\tfor ; Wed, 29 Apr 2026 23:19:14 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 09829397689;\n\tWed, 29 Apr 2026 23:19:09 +0000 (UTC)","from mail-wm1-f42.google.com (mail-wm1-f42.google.com\n [209.85.128.42])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E1383822BA\n\tfor ; Wed, 29 Apr 2026 23:19:07 +0000 (UTC)","by mail-wm1-f42.google.com with SMTP id\n 5b1f17b1804b1-488b0e1b870so4886445e9.2\n for ;\n Wed, 29 Apr 2026 16:19:06 -0700 (PDT)","from debian ([2001:41d0:303:db6b::])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48a82307f7csm21201605e9.12.2026.04.29.16.19.03\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 29 Apr 2026 16:19:03 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777504748; cv=none;\n b=W9UouwYe4DAxdUNg5L36huz4oPfjU7zMb/+26SSgjiOXstVVQhZk9oyPjN67tie5JdcoDqLogaxqujvr+6dMQ0PtLYajRFAXX/VfZY0O4Gq00tN3KLkczU1OqovroJARDdBarCOgEEhhyOa5SUOcgQmuHMepF5imJrg3j6Tno2k=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777504748; c=relaxed/simple;\n\tbh=igdzl3lWughU8xzCp/zAPhHTuBkDvNwNGNOG2lHylPA=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t Content-Type:MIME-Version;\n b=aYy35Y4FCXzqiwciYIcKsGCVfdKulrKXA0AzwmZhnz60ecOWFQzzktUDYTw+x4BAtqvYS8J1RNg8aVzgcHxontYFV1q6H8mFOEeifGQkeMpVc1MlwwIbGyqgrHKl4flR+gZ/y9MFTttPIngLc6avdcVBm8iJ4Ayb6q20Atg1sBo=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=MlQrKjdb; arc=none smtp.client-ip=209.85.128.42","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777504745; x=1778109545;\n darn=vger.kernel.org;\n h=mime-version:content-transfer-encoding:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=Hd/6unjwJeqPaRYpTI3Uva7eVyvTUW4co6d4pCO9ZrM=;\n b=MlQrKjdbqLfhRHKSUETNy+dcsdvcLMGFE0mwUK3+0EMp/UBUPtEL3nudeiuHYW1Dyr\n YZN0kOfRJ4VzM3LfXvty4/7DVSh8zHeyCL+rJbfOg5sIftW0k0/PWEHyWPs+3nl3vMaK\n NazR9A/jzHU4FpdZqKK1CDtVljCSIwAwYvj7LP7e1et2f+/No7cgJ3yub+930TYBjDMh\n oUub5Jk1lGvP2LUCGmITdNChvQ4UGu0Xnen/QE5sTFBfwbH844nsWUpJzkQ6FA7FdHvK\n fRvJTjcUpV8IMecTEKxEY4AbQmOBjMR6lTCo3sPBvfLbCXBhe8E+1MitrUss1kSOjbQj\n MAPg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777504745; x=1778109545;\n h=mime-version:content-transfer-encoding:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=Hd/6unjwJeqPaRYpTI3Uva7eVyvTUW4co6d4pCO9ZrM=;\n b=M8Ik0Clt3II4mxSu0Tyd/7v/Ifgg4GKExGs9Jhjp/xNP2sxtaVfRhd2Wwy815pEpW4\n I3CTRJ5itPkNTCJJTx3lTdxEzcOYVqIcmly7B9b9s+inrYZ5eV1AkWw+rLzY5fXaJshG\n S0269hLC7bOdS0ekn2PjfbQHmy7CdVMiLomlLPnSEVerDXKFyOaOVA6szVTqRbJHl7AW\n e8kFMdvt4tatdPy6fTOthdNEPfyXEL0rQHMZt0B5j3DcYR3nzCfBAzXU7DB62r+WtEkJ\n etdtzuUEmmdr1SbVun/+IvjAt9577ZLH29XwtaO5tHw6r4IGfFAiqYyBuip7nuLKps1A\n gnlA==","X-Forwarded-Encrypted":"i=1;\n AFNElJ8imksrpdrQvTzHC55GDQoPvJHGx+a49jXY+Ng4Pk+MSYUEHmb19eo5Ck4Un3M0g2f1CL2sZdzpk9MevAHHXa0=@vger.kernel.org","X-Gm-Message-State":"AOJu0Yxh3BLyEKLgZNh3eQw+NkLr6fYWes/pBfiM/38CUMeo0vR7Utgx\n\tmVSNaDWgepTWAqzXaigcP2JenPmxiP/7V0/S7SdCcFn0FZ6bevQEeiw=","X-Gm-Gg":"AeBDieuktA8e47KBlOJ3y0oaVaY85dhIEeFi6I4DoxWV87o1Ot3JpoG6J/BUbvnchd7\n\tVKsIGn5P47gVv+Plo1rIZdmdPTRE8gQekdB31NZj3KYks/XvL5FYP1uLeKJ4hbDVIKEFH6mLSos\n\tx7GZgRu2Zu2Huj1oYuWcRXyM2GH6zXbV4/z1FOU9NMQS0sj3teMtl9WsbaXu8UvtULjGtJ0iDvy\n\tVppbnafmEf2Ho4fn4uRFMwFx+SkLF+chPmbKaFbJqSlj2ptfJhQ2k24WaTg83FJ94//sen9aLNg\n\trpH97/oRKVEs6YHnEdUwTRu13qrk0aU1GxpgYfUep7wR62sLre/vp/1Xn/5RiF8RZB/3KzhSREw\n\teC6ob6SJR8g1/BTNhk6Rf8lZ/TRj3g31T2WtIDmNUe0MTMfVDx/cFmqw6vIzCHcuus4G//uSHQN\n\tYYZgoVpHomN5+73QFRFrP8ezsF","X-Received":"by 2002:a05:600c:c4b7:b0:489:1fa4:50c6 with SMTP id\n 5b1f17b1804b1-48a8447b30bmr8849785e9.20.1777504745521;\n Wed, 29 Apr 2026 16:19:05 -0700 (PDT)","From":"Tristan Madani ","X-Google-Original-From":"Tristan Madani ","To":"Pablo Neira Ayuso ","Cc":"Phil Sutter , Florian Westphal ,\n netfilter-devel@vger.kernel.org, netdev@vger.kernel.org,\n stable@vger.kernel.org, linux-kernel@vger.kernel.org","Subject":"[PATCH v2 1/2] netfilter: ip_tables: guard\n ipt_unregister_table_pre_exit against NULL ops","Date":"Wed, 29 Apr 2026 23:19:03 -0000","Message-ID":"<177750474339.3016150.13196470704394042910@talencesecurity.com>","In-Reply-To":"<177750472539.3004201.15967003942391945312@talencesecurity.com>","References":"<20260429175613.1459342-1-tristmd@gmail.com>\n <177750472539.3004201.15967003942391945312@talencesecurity.com>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"quoted-printable","Precedence":"bulk","X-Mailing-List":"netfilter-devel@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0"},"content":"ipt_register_table() adds the table to the per-netns list via\nxt_register_table() before assigning the per-net ops copy to\nnew_table->ops. If cleanup_net runs during this window,\nipt_unregister_table_pre_exit() finds the table via xt_find_table()\nand passes the NULL ops pointer to nf_unregister_net_hooks(), causing\na general protection fault.\n\nGuard against this by checking table->ops before calling\nnf_unregister_net_hooks(). If ops is NULL the table is still being\nset up; the register path will either complete and register the hooks\nnormally, or fail and clean up via __ipt_unregister_table().\n\nFixes: ae689334225f (\"netfilter: xtables: Bring back xt_register_table()\")\nCc: stable@vger.kernel.org\nSigned-off-by: Tristan Madani \n---\n net/ipv4/netfilter/ip_tables.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/net/ipv4/netfilter/ip_tables.c b/net/ipv4/netfilter/ip_tables.c\nindex XXXXXXX..XXXXXXX 100644\n--- a/net/ipv4/netfilter/ip_tables.c\n+++ b/net/ipv4/netfilter/ip_tables.c\n@@ -1795,7 +1795,7 @@ void ipt_unregister_table_pre_exit(struct net *net, const char *name)\n {\n \tstruct xt_table *table = xt_find_table(net, NFPROTO_IPV4, name);\n\n-\tif (table)\n+\tif (table && table->ops)\n \t\tnf_unregister_net_hooks(net, table->ops, hweight32(table->valid_hooks));\n }\n\n","prefixes":["v2","1/2"]}