{"id":2230640,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2230640/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260429222445.26301-47-richard.henderson@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260429222445.26301-47-richard.henderson@linaro.org>","date":"2026-04-29T22:24:43","name":"[PULL,46/48] fpu: Return struct from float128_unpack_canonical","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"ca64b250fed1e61d3c4561e9a365875cbd92283f","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/1.1/people/72104/?format=json","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260429222445.26301-47-richard.henderson@linaro.org/mbox/","series":[{"id":502161,"url":"http://patchwork.ozlabs.org/api/1.1/series/502161/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502161","date":"2026-04-29T22:23:57","name":"[PULL,01/48] fpu: Drop parts_canonicalize","version":1,"mbox":"http://patchwork.ozlabs.org/series/502161/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2230640/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2230640/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=lX+Ep3xF;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5X740sXvz1yHZ\n\tfor ; Thu, 30 Apr 2026 08:30:08 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wIDPp-0007Hf-NA; Wed, 29 Apr 2026 18:29:57 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wIDPn-0006xF-E0\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 18:29:55 -0400","from mail-pj1-x102a.google.com ([2607:f8b0:4864:20::102a])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wIDPl-00070E-AO\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 18:29:55 -0400","by mail-pj1-x102a.google.com with SMTP id\n 98e67ed59e1d1-35fb7c1a455so72586a91.3\n for ; Wed, 29 Apr 2026 15:29:52 -0700 (PDT)","from stoup.. ([180.233.125.15]) by smtp.gmail.com with ESMTPSA id\n 98e67ed59e1d1-364bdf54203sm630479a91.7.2026.04.29.15.29.49\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 29 Apr 2026 15:29:51 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777501792; x=1778106592; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=cKfv1vhY7Ui3LYik1NVKPOQOgbLeGD0tQcqmZyxoafw=;\n b=lX+Ep3xF6hmrQfPT1H2frKLXrWguRd2k9PitiTaIUsVej/pxT5i3gbObbt9tu3j3tF\n YWxv3G/U1b+qzCYLgbTfww9iX49x9L2Nwx8Xgd283jy1hteX2jNrsKG1sMvItGVvSNGe\n vGWDo8agtiCUA3rnz+YfsY9djyMp2aQDxZJykELWeS9V0r7QEcDkLlRi+R8FyMwxl0+v\n 2bWqYPiEpjc7zjGYvzTJrTToEG74W46CpXx+DxIYqJlEVQRoogF7cYgXsqtsd2AMpPBx\n ge+FAivJAtUuvCm3cLIExNVfLcDVNLup5C8ngtsX8hGxgoTuauTGibfCBTmkyT0KckO5\n 0org==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777501792; x=1778106592;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=cKfv1vhY7Ui3LYik1NVKPOQOgbLeGD0tQcqmZyxoafw=;\n b=fqDEHQ/VwEndO740FZ1fxg+0ksr702d38pAIz9C9uX4X3AwSelZWCoo+Er73NjP7o/\n Gk5j1dkk+8PT0TdxFVVKl++lGvhjxG6bFd7QoxJJeaNnhACYp53qOYH6M/srbhEsqjnC\n ipFhXRE4P1ouTkH5QiZ8US3uHhcW/RxXy+p01msCmx9QU12SGNsFd6T/oBY0RnDm0Zk0\n SXl7xU3TUcHvw1E2AXDdQSDnxljFIILCdT4tiwNwjvhCOg9VpyyEdabmsRtu1O9nPJOT\n d4MnJ7ePjcUbpaztQ0UvPoPyfyp3w2+ZgVXqH89kZLV1xBG29/vX6VXytUfE5sfUrHwk\n tW3w==","X-Gm-Message-State":"AOJu0Yy53DUUYENEM64i/E0QcjWc7pdIH7F2UcnzUoyMdDpn3X7OvPwB\n h0i08cza/7VNU88IFybN4MrMuSkTa6Exm9qeNbJR9NqL7t34V/+LNRIpoXzbz4bAfuZesBAG4cc\n tVbxUVeM=","X-Gm-Gg":"AeBDieu8nppSij5IW3awVGX0C+JdERN8gY2MAKWpgmOKSpOdCa0Dt5Nq2/T8DCxcOKi\n Lx1aQQBFXhtqFo5L2i4rigoYNPer15/QskrdX01ai6TO/rAViBneQQc9LsuAHvzSMnNLQAUDKX8\n 9sMvsu8rji00Uw6h7UEpqVT1TWvLb3HlZmWggGaIYi/YDnzgyKoKOO7OHBSkt//FKEGklBYNC9b\n hruqtIkvBPfzdD9QEX57dhLTJR5AYUwbhFjErIneE9ZS+7UU71gTT8CPfXuqShot7Yax1544BfP\n xUMVnKK7XRv6QWB8kpSIxJWVPyTs2jaPTazgcF2dl9EiNnpvd59XqSOGORINqP/MK2tB2wRw7Eo\n Ob7RAHbKHCLH+UtWS03DooElGFNkm9p4di2/veFkCfTpSu0D0+UecX9j2DW8ixp3xRRyxLxgzw8\n qALQ67Og4LgF21DIHqox5pjTJSspWIQgM0bD0bto5j","X-Received":"by 2002:a17:90a:d2c7:b0:35a:189b:43db with SMTP id\n 98e67ed59e1d1-364c2f97ceemr169653a91.4.1777501791829;\n Wed, 29 Apr 2026 15:29:51 -0700 (PDT)","From":"Richard Henderson ","To":"qemu-devel@nongnu.org","Cc":"stefanha@redhat.com,\n =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Subject":"[PULL 46/48] fpu: Return struct from float128_unpack_canonical","Date":"Thu, 30 Apr 2026 08:24:43 +1000","Message-ID":"<20260429222445.26301-47-richard.henderson@linaro.org>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260429222445.26301-1-richard.henderson@linaro.org>","References":"<20260429222445.26301-1-richard.henderson@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::102a;\n envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102a.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Reviewed-by: Philippe Mathieu-Daudé \nSigned-off-by: Richard Henderson \n---\n fpu/softfloat.c | 105 +++++++++++++++++-------------------------------\n 1 file changed, 37 insertions(+), 68 deletions(-)","diff":"diff --git a/fpu/softfloat.c b/fpu/softfloat.c\nindex a9c91fb8a4..77585fa11f 100644\n--- a/fpu/softfloat.c\n+++ b/fpu/softfloat.c\n@@ -1583,11 +1583,11 @@ static float64 float64r32_round_pack_canonical(FloatParts64 *p,\n return float64r32_pack_raw(p);\n }\n \n-static void float128_unpack_canonical(FloatParts128 *p, float128 f,\n- float_status *s)\n+static FloatParts128 float128_unpack_canonical(float128 f, float_status *s)\n {\n- *p = float128_unpack_raw(f);\n- parts128_canonicalize(p, s, &float128_params);\n+ FloatParts128 p = float128_unpack_raw(f);\n+ parts128_canonicalize(&p, s, &float128_params);\n+ return p;\n }\n \n static float128 float128_round_pack_canonical(FloatParts128 *p,\n@@ -1872,11 +1872,9 @@ bfloat16 bfloat16_sub(bfloat16 a, bfloat16 b, float_status *status)\n static float128 QEMU_FLATTEN\n float128_addsub(float128 a, float128 b, float_status *status, bool subtract)\n {\n- FloatParts128 pa, pb, *pr;\n-\n- float128_unpack_canonical(&pa, a, status);\n- float128_unpack_canonical(&pb, b, status);\n- pr = parts128_addsub(&pa, &pb, status, subtract);\n+ FloatParts128 pa = float128_unpack_canonical(a, status);\n+ FloatParts128 pb = float128_unpack_canonical(b, status);\n+ FloatParts128 *pr = parts128_addsub(&pa, &pb, status, subtract);\n \n return float128_round_pack_canonical(pr, status);\n }\n@@ -1994,11 +1992,9 @@ bfloat16_mul(bfloat16 a, bfloat16 b, float_status *status)\n float128 QEMU_FLATTEN\n float128_mul(float128 a, float128 b, float_status *status)\n {\n- FloatParts128 pa, pb, *pr;\n-\n- float128_unpack_canonical(&pa, a, status);\n- float128_unpack_canonical(&pb, b, status);\n- pr = parts128_mul(&pa, &pb, status);\n+ FloatParts128 pa = float128_unpack_canonical(a, status);\n+ FloatParts128 pb = float128_unpack_canonical(b, status);\n+ FloatParts128 *pr = parts128_mul(&pa, &pb, status);\n \n return float128_round_pack_canonical(pr, status);\n }\n@@ -2255,12 +2251,10 @@ bfloat16 QEMU_FLATTEN bfloat16_muladd(bfloat16 a, bfloat16 b, bfloat16 c,\n float128 QEMU_FLATTEN float128_muladd(float128 a, float128 b, float128 c,\n int flags, float_status *status)\n {\n- FloatParts128 pa, pb, pc, *pr;\n-\n- float128_unpack_canonical(&pa, a, status);\n- float128_unpack_canonical(&pb, b, status);\n- float128_unpack_canonical(&pc, c, status);\n- pr = parts128_muladd_scalbn(&pa, &pb, &pc, 0, flags, status);\n+ FloatParts128 pa = float128_unpack_canonical(a, status);\n+ FloatParts128 pb = float128_unpack_canonical(b, status);\n+ FloatParts128 pc = float128_unpack_canonical(c, status);\n+ FloatParts128 *pr = parts128_muladd_scalbn(&pa, &pb, &pc, 0, flags, status);\n \n /* Round before applying negate result. */\n parts128_uncanon(pr, status, &float128_params, false);\n@@ -2383,11 +2377,9 @@ bfloat16_div(bfloat16 a, bfloat16 b, float_status *status)\n float128 QEMU_FLATTEN\n float128_div(float128 a, float128 b, float_status *status)\n {\n- FloatParts128 pa, pb, *pr;\n-\n- float128_unpack_canonical(&pa, a, status);\n- float128_unpack_canonical(&pb, b, status);\n- pr = parts128_div(&pa, &pb, status);\n+ FloatParts128 pa = float128_unpack_canonical(a, status);\n+ FloatParts128 pb = float128_unpack_canonical(b, status);\n+ FloatParts128 *pr = parts128_div(&pa, &pb, status);\n \n return float128_round_pack_canonical(pr, status);\n }\n@@ -2429,11 +2421,9 @@ float64 float64_rem(float64 a, float64 b, float_status *status)\n \n float128 float128_rem(float128 a, float128 b, float_status *status)\n {\n- FloatParts128 pa, pb, *pr;\n-\n- float128_unpack_canonical(&pa, a, status);\n- float128_unpack_canonical(&pb, b, status);\n- pr = parts128_modrem(&pa, &pb, NULL, status);\n+ FloatParts128 pa = float128_unpack_canonical(a, status);\n+ FloatParts128 pb = float128_unpack_canonical(b, status);\n+ FloatParts128 *pr = parts128_modrem(&pa, &pb, NULL, status);\n \n return float128_round_pack_canonical(pr, status);\n }\n@@ -2782,20 +2772,18 @@ bfloat16 float64_to_bfloat16(float64 a, float_status *s)\n \n float32 float128_to_float32(float128 a, float_status *s)\n {\n+ FloatParts128 p128 = float128_unpack_canonical(a, s);\n FloatParts64 p64;\n- FloatParts128 p128;\n \n- float128_unpack_canonical(&p128, a, s);\n parts_float_to_float_narrow(&p64, &p128, s);\n return float32_round_pack_canonical(&p64, s);\n }\n \n float64 float128_to_float64(float128 a, float_status *s)\n {\n+ FloatParts128 p128 = float128_unpack_canonical(a, s);\n FloatParts64 p64;\n- FloatParts128 p128;\n \n- float128_unpack_canonical(&p128, a, s);\n parts_float_to_float_narrow(&p64, &p128, s);\n return float64_round_pack_canonical(&p64, s);\n }\n@@ -2876,9 +2864,8 @@ floatx80 float64_to_floatx80(float64 a, float_status *s)\n \n floatx80 float128_to_floatx80(float128 a, float_status *s)\n {\n- FloatParts128 p;\n+ FloatParts128 p = float128_unpack_canonical(a, s);\n \n- float128_unpack_canonical(&p, a, s);\n parts128_float_to_float(&p, s);\n return floatx80_round_pack_canonical(&p, s);\n }\n@@ -2921,9 +2908,8 @@ bfloat16 bfloat16_round_to_int(bfloat16 a, float_status *s)\n \n float128 float128_round_to_int(float128 a, float_status *s)\n {\n- FloatParts128 p;\n+ FloatParts128 p = float128_unpack_canonical(a, s);\n \n- float128_unpack_canonical(&p, a, s);\n parts128_round_to_int(&p, s->float_rounding_mode, 0, s, &float128_params);\n return float128_round_pack_canonical(&p, s);\n }\n@@ -3046,18 +3032,14 @@ int64_t bfloat16_to_int64_scalbn(bfloat16 a, FloatRoundMode rmode, int scale,\n static int32_t float128_to_int32_scalbn(float128 a, FloatRoundMode rmode,\n int scale, float_status *s)\n {\n- FloatParts128 p;\n-\n- float128_unpack_canonical(&p, a, s);\n+ FloatParts128 p = float128_unpack_canonical(a, s);\n return parts128_float_to_sint(&p, rmode, scale, INT32_MIN, INT32_MAX, s);\n }\n \n static int64_t float128_to_int64_scalbn(float128 a, FloatRoundMode rmode,\n int scale, float_status *s)\n {\n- FloatParts128 p;\n-\n- float128_unpack_canonical(&p, a, s);\n+ FloatParts128 p = float128_unpack_canonical(a, s);\n return parts128_float_to_sint(&p, rmode, scale, INT64_MIN, INT64_MAX, s);\n }\n \n@@ -3066,9 +3048,7 @@ static Int128 float128_to_int128_scalbn(float128 a, FloatRoundMode rmode,\n {\n int flags = 0;\n Int128 r;\n- FloatParts128 p;\n-\n- float128_unpack_canonical(&p, a, s);\n+ FloatParts128 p = float128_unpack_canonical(a, s);\n \n switch (p.cls) {\n case float_class_snan:\n@@ -3512,18 +3492,14 @@ uint64_t bfloat16_to_uint64_scalbn(bfloat16 a, FloatRoundMode rmode,\n static uint32_t float128_to_uint32_scalbn(float128 a, FloatRoundMode rmode,\n int scale, float_status *s)\n {\n- FloatParts128 p;\n-\n- float128_unpack_canonical(&p, a, s);\n+ FloatParts128 p = float128_unpack_canonical(a, s);\n return parts128_float_to_uint(&p, rmode, scale, UINT32_MAX, s);\n }\n \n static uint64_t float128_to_uint64_scalbn(float128 a, FloatRoundMode rmode,\n int scale, float_status *s)\n {\n- FloatParts128 p;\n-\n- float128_unpack_canonical(&p, a, s);\n+ FloatParts128 p = float128_unpack_canonical(a, s);\n return parts128_float_to_uint(&p, rmode, scale, UINT64_MAX, s);\n }\n \n@@ -3532,9 +3508,7 @@ static Int128 float128_to_uint128_scalbn(float128 a, FloatRoundMode rmode,\n {\n int flags = 0;\n Int128 r;\n- FloatParts128 p;\n-\n- float128_unpack_canonical(&p, a, s);\n+ FloatParts128 p = float128_unpack_canonical(a, s);\n \n switch (p.cls) {\n case float_class_snan:\n@@ -4210,11 +4184,9 @@ static float64 float64_minmax(float64 a, float64 b, float_status *s, int flags)\n static float128 float128_minmax(float128 a, float128 b,\n float_status *s, int flags)\n {\n- FloatParts128 pa, pb, *pr;\n-\n- float128_unpack_canonical(&pa, a, s);\n- float128_unpack_canonical(&pb, b, s);\n- pr = parts128_minmax(&pa, &pb, s, flags);\n+ FloatParts128 pa = float128_unpack_canonical(a, s);\n+ FloatParts128 pb = float128_unpack_canonical(b, s);\n+ FloatParts128 *pr = parts128_minmax(&pa, &pb, s, flags);\n \n return float128_round_pack_canonical(pr, s);\n }\n@@ -4393,10 +4365,9 @@ FloatRelation bfloat16_compare_quiet(bfloat16 a, bfloat16 b, float_status *s)\n static FloatRelation QEMU_FLATTEN\n float128_do_compare(float128 a, float128 b, float_status *s, bool is_quiet)\n {\n- FloatParts128 pa, pb;\n+ FloatParts128 pa = float128_unpack_canonical(a, s);\n+ FloatParts128 pb = float128_unpack_canonical(b, s);\n \n- float128_unpack_canonical(&pa, a, s);\n- float128_unpack_canonical(&pb, b, s);\n return parts128_compare(&pa, &pb, s, is_quiet);\n }\n \n@@ -4470,9 +4441,8 @@ bfloat16 bfloat16_scalbn(bfloat16 a, int n, float_status *status)\n \n float128 float128_scalbn(float128 a, int n, float_status *status)\n {\n- FloatParts128 p;\n+ FloatParts128 p = float128_unpack_canonical(a, status);\n \n- float128_unpack_canonical(&p, a, status);\n parts128_scalbn(&p, n, status);\n return float128_round_pack_canonical(&p, status);\n }\n@@ -4590,9 +4560,8 @@ bfloat16 QEMU_FLATTEN bfloat16_sqrt(bfloat16 a, float_status *status)\n \n float128 QEMU_FLATTEN float128_sqrt(float128 a, float_status *status)\n {\n- FloatParts128 p;\n+ FloatParts128 p = float128_unpack_canonical(a, status);\n \n- float128_unpack_canonical(&p, a, status);\n parts128_sqrt(&p, status, &float128_params);\n return float128_round_pack_canonical(&p, status);\n }\n","prefixes":["PULL","46/48"]}