{"id":2230634,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2230634/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260429222445.26301-8-richard.henderson@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260429222445.26301-8-richard.henderson@linaro.org>","date":"2026-04-29T22:24:04","name":"[PULL,07/48] fpu: Drop parts_pick_nan","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"517890ea9ad56f5c16a7d44b6eb2e76baa2b83c2","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/1.1/people/72104/?format=json","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260429222445.26301-8-richard.henderson@linaro.org/mbox/","series":[{"id":502161,"url":"http://patchwork.ozlabs.org/api/1.1/series/502161/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502161","date":"2026-04-29T22:23:57","name":"[PULL,01/48] fpu: Drop parts_canonicalize","version":1,"mbox":"http://patchwork.ozlabs.org/series/502161/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2230634/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2230634/checks/","tags":{},"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=B44MVBO/;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5X6506jtz1yHZ\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 30 Apr 2026 08:29:16 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wIDLK-000073-7H; Wed, 29 Apr 2026 18:25:18 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>)\n id 1wIDLE-00005b-9O\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 18:25:13 -0400","from mail-pj1-x1034.google.com ([2607:f8b0:4864:20::1034])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>)\n id 1wIDLC-0004mD-Ks\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 18:25:12 -0400","by mail-pj1-x1034.google.com with SMTP id\n 98e67ed59e1d1-35fc0d7c310so125435a91.1\n for <qemu-devel@nongnu.org>; Wed, 29 Apr 2026 15:25:10 -0700 (PDT)","from stoup.. ([180.233.125.15]) by smtp.gmail.com with ESMTPSA id\n 98e67ed59e1d1-364a2732502sm1888471a91.3.2026.04.29.15.25.07\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 29 Apr 2026 15:25:08 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777501509; x=1778106309; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=zWM87T66PJDj61eh/+kk68S5TIssJMc4SE+XJlzZd4M=;\n b=B44MVBO/bMUsgfc1S6QWobYZoghh53GopC2RlEPBgF5GM4Cw+6h+kJ3eg4K9GwhuLM\n pH+nw1fC8fz5UzMw/XTBJ8/UqyNVTC8Yjnh04o7xWfJ1snCXcci2TiKldcWtTJC6IWoQ\n V8eev8QwWZ7CDTDFR4HX7wWs8lPHdZGKAoa04jiG6DO69EY/ZcJaQeviNpKbhi1lkzIR\n WhxGCK6BVBL0lK1/RWZpxMzbTSmosMsXZnbIEm3FJGNf+tpoa3Pe4nWLPT3yatwhTEZO\n n8JN1e0wZC5MsKQPUgnaqO9KDTB2FEhueVWI661cN675KE33ieoisvPeWwSRx/z9o1Hw\n lkSA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777501509; x=1778106309;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=zWM87T66PJDj61eh/+kk68S5TIssJMc4SE+XJlzZd4M=;\n b=EI0Jvpq1jB6bcfOisfvx1EZ2BJWQol7CAc1kIiTw5vOBX9NpkWQkzn4Qd/hKlrb+4L\n h4lHW2nlAfaqGJ2hVR3CDFuhoLBjoFVCkbyN05IpXRWJet/Nl5fi+72R+eBfmAbMB4DC\n VE8xX5r3KjasUANzuEPzM3tHNlue4qtLpaYXxzteB2WVFqJ921EtMxbO8rUaZ7RwprLN\n 9k4Pn0Cxrf/loxXL4L4PEP+9JL9VLE8WhRtk1TPA6UYsgyTNCpeXRzvwUpQA8prr7yx2\n DLNN7pOr9N8U/YDrDe7p8pwOzBGaun+zFstIkcOvF64l1Mhdlp3dBoFdoUDofPswGSdt\n Lz+w==","X-Gm-Message-State":"AOJu0Yw7yhhE3LUURhBB0ghpWkfvgK0XbCV/X3UKsQRslbmiVKQ8XwDb\n ZUHYJuEpHsyMO4TCsMn1Qytt9xlJTPwSbzz2Vaf9idTYJp2loCCOaPHeh1rsiykvWdVF7lIFWt+\n l1kJIu6U=","X-Gm-Gg":"AeBDietixOgd//OlWy0b4xhttY9sSkFtsjME6dXIULVgWFiSIge0A98z5E1ZjyWQzx2\n rKsCs/Pf1CoJ0Bykm/h5Y9MvEySz/WMnSbuM9tD7WLD/0iIinUKIkbuuRj4XJnnK5ke8FzZ+tPH\n yrdFsHKx3AnK+th/vKwrm+rfnTMZRB5EJZccvWmP7AembcEpqrziAeFvmme1hyBfFv49ce+mNs3\n DM984EKHOeV/eQHnUCk418pLYc5GxD1M9EeFeLbko1XplDuJKgb0kMne0QfNBiEamIF0cQt0ded\n nWDK8Hltf3W8qnnj1380iTayrFrOvvCQ9yUHU1mDPldeBiikSzN7l67E5YH+beHd8t0zcJJ09vN\n 24i6egzZiRasTxGImNM6HDdUblR1ViqwuQSnxSmt5pz91eKY2Kh2urfkhzXXqoH4UKVKU1Pw6Gw\n 7y4mnvwdul3FKr+yNSkLxNFXSv4wpBP6u3kBaJeWku","X-Received":"by 2002:a17:90b:2f0f:b0:361:45df:102 with SMTP id\n 98e67ed59e1d1-364c308d224mr157511a91.17.1777501509043;\n Wed, 29 Apr 2026 15:25:09 -0700 (PDT)","From":"Richard Henderson <richard.henderson@linaro.org>","To":"qemu-devel@nongnu.org","Cc":"stefanha@redhat.com,\n =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>","Subject":"[PULL 07/48] fpu: Drop parts_pick_nan","Date":"Thu, 30 Apr 2026 08:24:04 +1000","Message-ID":"<20260429222445.26301-8-richard.henderson@linaro.org>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260429222445.26301-1-richard.henderson@linaro.org>","References":"<20260429222445.26301-1-richard.henderson@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::1034;\n envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1034.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Use parts{64,128}_pick_nan at each call site.\n\nReviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>\nSigned-off-by: Richard Henderson <richard.henderson@linaro.org>\n---\n fpu/softfloat.c           | 11 ++---------\n fpu/softfloat-parts.c.inc | 10 +++++-----\n 2 files changed, 7 insertions(+), 14 deletions(-)","diff":"diff --git a/fpu/softfloat.c b/fpu/softfloat.c\nindex 50a625fd0a..98ddc00936 100644\n--- a/fpu/softfloat.c\n+++ b/fpu/softfloat.c\n@@ -779,13 +779,6 @@ static float128 QEMU_FLATTEN float128_pack_raw(const FloatParts128 *p)\n                   FloatParts128 *: parts128_##NAME, \\\n                   FloatParts256 *: parts256_##NAME)\n \n-static FloatParts64 *parts64_pick_nan(FloatParts64 *a, FloatParts64 *b,\n-                                      float_status *s);\n-static FloatParts128 *parts128_pick_nan(FloatParts128 *a, FloatParts128 *b,\n-                                        float_status *s);\n-\n-#define parts_pick_nan(A, B, S)    PARTS_GENERIC_64_128(pick_nan, A)(A, B, S)\n-\n static FloatParts64 *parts64_pick_nan_muladd(FloatParts64 *a, FloatParts64 *b,\n                                              FloatParts64 *c, float_status *s,\n                                              int ab_mask, int abc_mask);\n@@ -5175,7 +5168,7 @@ floatx80 propagateFloatx80NaN(floatx80 a, floatx80 b, float_status *status)\n         return floatx80_default_nan(status);\n     }\n \n-    pr = parts_pick_nan(&pa, &pb, status);\n+    pr = parts128_pick_nan(&pa, &pb, status);\n     return floatx80_round_pack_canonical(pr, status);\n }\n \n@@ -5525,7 +5518,7 @@ static void parts_s390_divide_to_integer(FloatParts64 *a, FloatParts64 *b,\n {\n     /* POp table \"Results: DIVIDE TO INTEGER (Part 1 of 2)\" */\n     if ((float_cmask(a->cls) | float_cmask(b->cls)) & float_cmask_anynan) {\n-        *r = *parts_pick_nan(a, b, status);\n+        *r = *parts64_pick_nan(a, b, status);\n         *n = *r;\n         *cc = 1;\n     } else if (a->cls == float_class_inf || b->cls == float_class_zero) {\ndiff --git a/fpu/softfloat-parts.c.inc b/fpu/softfloat-parts.c.inc\nindex 3bde254bfe..1a2eb7852d 100644\n--- a/fpu/softfloat-parts.c.inc\n+++ b/fpu/softfloat-parts.c.inc\n@@ -604,7 +604,7 @@ static FloatPartsN *partsN(addsub)(FloatPartsN *a, FloatPartsN *b,\n     return b;\n \n  p_nan:\n-    return parts_pick_nan(a, b, s);\n+    return partsN(pick_nan)(a, b, s);\n }\n \n /*\n@@ -646,7 +646,7 @@ static FloatPartsN *partsN(mul)(FloatPartsN *a, FloatPartsN *b,\n     }\n \n     if (unlikely(ab_mask & float_cmask_anynan)) {\n-        return parts_pick_nan(a, b, s);\n+        return partsN(pick_nan)(a, b, s);\n     }\n \n     /* Multiply by 0 or Inf */\n@@ -832,7 +832,7 @@ static FloatPartsN *partsN(div)(FloatPartsN *a, FloatPartsN *b,\n \n     /* All the NaN cases */\n     if (unlikely(ab_mask & float_cmask_anynan)) {\n-        return parts_pick_nan(a, b, s);\n+        return partsN(pick_nan)(a, b, s);\n     }\n \n     if ((ab_mask & float_cmask_denormal) && b->cls != float_class_zero) {\n@@ -890,7 +890,7 @@ static FloatPartsN *partsN(modrem)(FloatPartsN *a, FloatPartsN *b,\n \n     /* All the NaN cases */\n     if (unlikely(ab_mask & float_cmask_anynan)) {\n-        return parts_pick_nan(a, b, s);\n+        return partsN(pick_nan)(a, b, s);\n     }\n \n     /* Inf % N; N % 0 */\n@@ -1592,7 +1592,7 @@ static FloatPartsN *partsN(minmax)(FloatPartsN *a, FloatPartsN *b,\n             return is_nan(a->cls) ? b : a;\n         }\n \n-        return parts_pick_nan(a, b, s);\n+        return partsN(pick_nan)(a, b, s);\n     }\n \n     if (ab_mask & float_cmask_denormal) {\n","prefixes":["PULL","07/48"]}