{"id":2230626,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2230626/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260429222445.26301-26-richard.henderson@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260429222445.26301-26-richard.henderson@linaro.org>","date":"2026-04-29T22:24:22","name":"[PULL,25/48] fpu: Drop parts_compare","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"33d3c35b8760849816f1f223581df3e3b19c90ba","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/1.1/people/72104/?format=json","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260429222445.26301-26-richard.henderson@linaro.org/mbox/","series":[{"id":502161,"url":"http://patchwork.ozlabs.org/api/1.1/series/502161/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502161","date":"2026-04-29T22:23:57","name":"[PULL,01/48] fpu: Drop parts_canonicalize","version":1,"mbox":"http://patchwork.ozlabs.org/series/502161/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2230626/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2230626/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=rVd/J3YN;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5X5b1WlCz1yHZ\n\tfor ; Thu, 30 Apr 2026 08:28:51 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wIDM0-0000xL-5u; Wed, 29 Apr 2026 18:26:00 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wIDLy-0000tw-4c\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 18:25:58 -0400","from mail-pj1-x1030.google.com ([2607:f8b0:4864:20::1030])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wIDLw-0005Ag-G6\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 18:25:57 -0400","by mail-pj1-x1030.google.com with SMTP id\n 98e67ed59e1d1-35e563b0ee7so162494a91.1\n for ; Wed, 29 Apr 2026 15:25:56 -0700 (PDT)","from stoup.. ([180.233.125.15]) by smtp.gmail.com with ESMTPSA id\n 98e67ed59e1d1-364a2732502sm1888471a91.3.2026.04.29.15.25.53\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 29 Apr 2026 15:25:54 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777501555; x=1778106355; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=xhNV1JSBOi39LblTgxFILqkjIcMCbg311nb9LeNaPVQ=;\n b=rVd/J3YNjK/zM1cXtkZcSWlWFi20oDJoqojF1obMUrvbTuj2Ro9Kg5iNSLdnAtjLPL\n fF6zkoHSZC5pJYoOUq6GQidCNlnpg3mn83cpoo8tV2mVOzYFTrrYcD8HYMp1fFmpylIT\n lUyIQiQT1teTcb6CO91r4cEMc72ELJ0OFumPlerhRMQ7p5qas3NKK5UnG+E9ujrfeIhg\n BTv+ZtYAPdBHoKQfZPo2KOmvkTFCThE7zg8BegB2WX9W3cjB6s5q59SK3k4CnhgtFZzd\n VH8W09EbwR5Ivvh6z1IGtP9sXUh2Nlk3X2qcN9446RiCVoTxPp8r25JD0tmLo8W9ZcWG\n 71Hg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777501555; x=1778106355;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=xhNV1JSBOi39LblTgxFILqkjIcMCbg311nb9LeNaPVQ=;\n b=U+Go5N0RgCHjTk24HpDbC3gsJ2tPSclr56xxoS88INf4+R+geXjAo0aKaaFhTpOMa8\n vLeyuGXi/DkohiXcwoA/S1R47xejR3+UHL6hnBVP7PxMVooN4uyqfqa6LtCKIBi1IjO1\n Vm5Fu96XdR//6ahLOO18F0dfbSsg0sZcEvfh4noEdzJ4y87Y00GxZjs7rfBJNMUVMza+\n TYFAiy0yh2qQ0OHahtWDy1Cv7vEJ8+Bx11Lii888PgkR4DY8zJt63y4jAo/MGcu4DTeI\n s9AfHAcwGikwn/oT28kW/RROhSwxEVy4WU63LKJwwJfuF5g6FeuQpa0aOepb/wvDU+0l\n /tyA==","X-Gm-Message-State":"AOJu0YzhiyhlcUaHoeMZufsZRrw9qZRvze8bG3rQagfjzCIHNu4QfaMH\n Ssh80g6yH5GYKXuOfL9QhQ9AuID3Cs6Z8hjj3o70dWE3i+C6bY663g1UZ+1GD6MhAdUyme0frrg\n 59oUBCY0=","X-Gm-Gg":"AeBDieuIjKx4pFbHHiw2/asdhlQB0X4JcMs1nSMZrbXu1ZWnKjq8Qg8POneULlf6Pmc\n eLzICQnPUA3UBXw2UqO4oMYHsrS/x41l81ok2FHmnIcrvjUEWQr43t4nlkNQylyTtJnhnyMQxPp\n TberQW47lDpP1GdMi7ylZ1k5NhfOMr1xw87mp3+ri1lcvnrXLUzcl7KifoZjRhFvIMi634sMVix\n DjMZOa/fhnZbtaxgxNm5NvofKpPfyN0fxL1F0TLFMAMVoVM+fhjKAotZZsBel5nycsoMm1G48Ug\n px3C+DZh9qCUJqnznPW7sW9m9QeGCTEJpRYsw3J3Q98P8xqT3yN4vh7AtI1ENC2yxkSx3wUOUrI\n gUL/RnLgwB9nqCKXZdoxXsJ2mvk+vgJTOcZFzfjdB3OiyQjG/LFgKYGtrxUy+j+SHNJvUQIXOUi\n gAovMkK37t1fPh4968sunuQsyF2XScrrTlbNn09vSW","X-Received":"by 2002:a17:90b:2f48:b0:35f:c1cc:fee0 with SMTP id\n 98e67ed59e1d1-364c3409173mr115273a91.8.1777501555158;\n Wed, 29 Apr 2026 15:25:55 -0700 (PDT)","From":"Richard Henderson ","To":"qemu-devel@nongnu.org","Cc":"stefanha@redhat.com,\n =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Subject":"[PULL 25/48] fpu: Drop parts_compare","Date":"Thu, 30 Apr 2026 08:24:22 +1000","Message-ID":"<20260429222445.26301-26-richard.henderson@linaro.org>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260429222445.26301-1-richard.henderson@linaro.org>","References":"<20260429222445.26301-1-richard.henderson@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::1030;\n envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1030.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Use parts{64,128}_compare at each call site.\n\nReviewed-by: Philippe Mathieu-Daudé \nSigned-off-by: Richard Henderson \n---\n fpu/softfloat.c | 22 +++++++---------------\n 1 file changed, 7 insertions(+), 15 deletions(-)","diff":"diff --git a/fpu/softfloat.c b/fpu/softfloat.c\nindex 158d539376..3aebe4a058 100644\n--- a/fpu/softfloat.c\n+++ b/fpu/softfloat.c\n@@ -779,14 +779,6 @@ static float128 QEMU_FLATTEN float128_pack_raw(const FloatParts128 *p)\n FloatParts128 *: parts128_##NAME, \\\n FloatParts256 *: parts256_##NAME)\n \n-static FloatRelation parts64_compare(FloatParts64 *a, FloatParts64 *b,\n- float_status *s, bool q);\n-static FloatRelation parts128_compare(FloatParts128 *a, FloatParts128 *b,\n- float_status *s, bool q);\n-\n-#define parts_compare(A, B, S, Q) \\\n- PARTS_GENERIC_64_128(compare, A)(A, B, S, Q)\n-\n static void parts64_scalbn(FloatParts64 *a, int n, float_status *s);\n static void parts128_scalbn(FloatParts128 *a, int n, float_status *s);\n \n@@ -4494,7 +4486,7 @@ float16_do_compare(float16 a, float16 b, float_status *s, bool is_quiet)\n \n float16_unpack_canonical(&pa, a, s);\n float16_unpack_canonical(&pb, b, s);\n- return parts_compare(&pa, &pb, s, is_quiet);\n+ return parts64_compare(&pa, &pb, s, is_quiet);\n }\n \n FloatRelation float16_compare(float16 a, float16 b, float_status *s)\n@@ -4514,7 +4506,7 @@ float32_do_compare(float32 a, float32 b, float_status *s, bool is_quiet)\n \n float32_unpack_canonical(&pa, a, s);\n float32_unpack_canonical(&pb, b, s);\n- return parts_compare(&pa, &pb, s, is_quiet);\n+ return parts64_compare(&pa, &pb, s, is_quiet);\n }\n \n static FloatRelation QEMU_FLATTEN\n@@ -4568,7 +4560,7 @@ float64_do_compare(float64 a, float64 b, float_status *s, bool is_quiet)\n \n float64_unpack_canonical(&pa, a, s);\n float64_unpack_canonical(&pb, b, s);\n- return parts_compare(&pa, &pb, s, is_quiet);\n+ return parts64_compare(&pa, &pb, s, is_quiet);\n }\n \n static FloatRelation QEMU_FLATTEN\n@@ -4622,7 +4614,7 @@ bfloat16_do_compare(bfloat16 a, bfloat16 b, float_status *s, bool is_quiet)\n \n bfloat16_unpack_canonical(&pa, a, s);\n bfloat16_unpack_canonical(&pb, b, s);\n- return parts_compare(&pa, &pb, s, is_quiet);\n+ return parts64_compare(&pa, &pb, s, is_quiet);\n }\n \n FloatRelation bfloat16_compare(bfloat16 a, bfloat16 b, float_status *s)\n@@ -4642,7 +4634,7 @@ float128_do_compare(float128 a, float128 b, float_status *s, bool is_quiet)\n \n float128_unpack_canonical(&pa, a, s);\n float128_unpack_canonical(&pb, b, s);\n- return parts_compare(&pa, &pb, s, is_quiet);\n+ return parts128_compare(&pa, &pb, s, is_quiet);\n }\n \n FloatRelation float128_compare(float128 a, float128 b, float_status *s)\n@@ -4664,7 +4656,7 @@ floatx80_do_compare(floatx80 a, floatx80 b, float_status *s, bool is_quiet)\n !floatx80_unpack_canonical(&pb, b, s)) {\n return float_relation_unordered;\n }\n- return parts_compare(&pa, &pb, s, is_quiet);\n+ return parts128_compare(&pa, &pb, s, is_quiet);\n }\n \n FloatRelation floatx80_compare(floatx80 a, floatx80 b, float_status *s)\n@@ -5518,7 +5510,7 @@ static void parts_s390_divide_to_integer(FloatParts64 *a, FloatParts64 *b,\n saved_r_precise_sign = r_precise->sign;\n r->sign = false;\n r_precise->sign = false;\n- if (parts_compare(r, r_precise, status, true) <\n+ if (parts64_compare(r, r_precise, status, true) <\n float_relation_equal) {\n *dxc = 0x8;\n } else {\n","prefixes":["PULL","25/48"]}