{"id":2230615,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2230615/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260429222445.26301-12-richard.henderson@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260429222445.26301-12-richard.henderson@linaro.org>","date":"2026-04-29T22:24:08","name":"[PULL,11/48] fpu: Drop parts_addsub","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"e5622e41a194ea5d73c6fa72cf5f1430dc66a4f7","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/1.1/people/72104/?format=json","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260429222445.26301-12-richard.henderson@linaro.org/mbox/","series":[{"id":502161,"url":"http://patchwork.ozlabs.org/api/1.1/series/502161/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502161","date":"2026-04-29T22:23:57","name":"[PULL,01/48] fpu: Drop parts_canonicalize","version":1,"mbox":"http://patchwork.ozlabs.org/series/502161/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2230615/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2230615/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=zuIAW2XW;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5X4R4KvZz1yJr\n\tfor ; Thu, 30 Apr 2026 08:27:51 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wIDLR-000093-Q4; Wed, 29 Apr 2026 18:25:25 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wIDLP-00008K-U7\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 18:25:23 -0400","from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wIDLO-0004ox-4M\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 18:25:23 -0400","by mail-pl1-x634.google.com with SMTP id\n d9443c01a7336-2ad617d5b80so1706595ad.1\n for ; Wed, 29 Apr 2026 15:25:21 -0700 (PDT)","from stoup.. ([180.233.125.15]) by smtp.gmail.com with ESMTPSA id\n 98e67ed59e1d1-364a2732502sm1888471a91.3.2026.04.29.15.25.17\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 29 Apr 2026 15:25:19 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777501520; x=1778106320; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=fk4LVgA4H/YvbA+lA5J1oGuNn1ZmeLVjbkEn+60TJ6g=;\n b=zuIAW2XW1fAgoD533Nxz/F68EBS5lSjEIHDmUYo3IbOo0U29w/qWsKLt3c0hF7Jl6z\n lVxR++WJCp36rfZgnTtiugaMMK7doOT1pAzpeF0IhgnsVV63HLKfKKtyAEYV9R9KmIGd\n ioDSjeJU2n8SsQPQB6PgOylUawmVVx5p6i1L/lXk9I86qJdYz3z9mzD4Pl6gXeQnOrgz\n 1MxEavD1GA4Ou3WV37dwcCDYGo1TjRZNbzpA2jKDroKZ3YuUMRvRtPg2tUrH3+82XY9/\n iHNJ1N2183rlNPCWjacfbEade0aGOXh8FCluFm4d+AarEMCx4LQwtyBPw9++tQ+2FT9a\n ntZw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777501520; x=1778106320;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=fk4LVgA4H/YvbA+lA5J1oGuNn1ZmeLVjbkEn+60TJ6g=;\n b=VGjR8GhkZRKgBrl1vVa3Eaq44f49uDnFO/YrQeHmem4IHQfQY9CAwUELMTevKWGc44\n qqiVfaBQcby3Y6IV0Zq5aC3g3AJ2yq8QtXe0C162orbtaoejMjWIuMotB1CAux3r6JLi\n vPhVloXDnbPYeZSg/gKROjfa6ERQYh/Eaj2d9MiuLmCVDcGW8P4S4f/LGwO7a5BA4b0+\n bV+yEBnV96g7V248ndW/npuH/wtU5KKmg3cEDyPBjLW5j3DtbZmYFs41YyLxyr+5GT3N\n FS5rtl0yMJq9vFAExbLmFGes3T8sEzTa9w1vbTUsH+Y7sABq+GcViI2Dua6IgvMORUvD\n MLzw==","X-Gm-Message-State":"AOJu0YxyZuC8lF6bgdHGBEtwK5A+abCsqLYBodxs4Lilqtr9UgUBAUZH\n mUtP8wCDDR8VeSZtfcK3tiebrgEG024Ebm6DNwhrmHmyS15mcx3OAUaN/G31GvwnSzHxXFXUeFN\n cNY0F4W0=","X-Gm-Gg":"AeBDieuIUZwsUh2AMo5CjttqbrHNMlldQVACs+BusPHtGMc+D/70uJipvlTiKv+FaJX\n PW9vlSKfp7BNozWhLsKbUW91wWaQml/RmfPi1THlnypexVW8d7P4Ydm5Cg26tv4PxbgTITM/oYi\n Qig2GClvZnSv2MzQubSQRiGlXhelwJBIiXMP3TBm9OMy/oJr5yHmphOT4hUoYIEX+3AKijZu33Y\n yFaFtl+1nthArvDsRuDNr3Pz9XdRaqnklYnJvxaz1vsqwHN//oP+FLblYjR37sOoP49YNQ7+kdX\n 8hJM1DMAThoDZhwEbemFPwMkl+Amr0pvUsRq7A7U2eNVj42wohIAMjK+u9s+Aw6Ozp9sSNMlsBp\n c2AWLpiaoc82Zmd4+OeABWPvxK6Yl0L64gLzMFMknlrhpfpbmejHQztE8B5ZDQ3p8y0ST6ZZlVs\n jmDIcM/E5hEB80gLasQr78BLBY0zck68oDCtxJR0RG","X-Received":"by 2002:a17:90b:2fc8:b0:364:87dd:b2c4 with SMTP id\n 98e67ed59e1d1-364c32aa4bdmr144060a91.25.1777501520004;\n Wed, 29 Apr 2026 15:25:20 -0700 (PDT)","From":"Richard Henderson ","To":"qemu-devel@nongnu.org","Cc":"stefanha@redhat.com,\n =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Subject":"[PULL 11/48] fpu: Drop parts_addsub","Date":"Thu, 30 Apr 2026 08:24:08 +1000","Message-ID":"<20260429222445.26301-12-richard.henderson@linaro.org>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260429222445.26301-1-richard.henderson@linaro.org>","References":"<20260429222445.26301-1-richard.henderson@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::634;\n envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x634.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Use parts{64,128}_addsub at each call site.\n\nReviewed-by: Philippe Mathieu-Daudé \nSigned-off-by: Richard Henderson \n---\n fpu/softfloat.c | 22 +++++++---------------\n 1 file changed, 7 insertions(+), 15 deletions(-)","diff":"diff --git a/fpu/softfloat.c b/fpu/softfloat.c\nindex 117c335d66..dc5ce53105 100644\n--- a/fpu/softfloat.c\n+++ b/fpu/softfloat.c\n@@ -779,14 +779,6 @@ static float128 QEMU_FLATTEN float128_pack_raw(const FloatParts128 *p)\n FloatParts128 *: parts128_##NAME, \\\n FloatParts256 *: parts256_##NAME)\n \n-static FloatParts64 *parts64_addsub(FloatParts64 *a, FloatParts64 *b,\n- float_status *s, bool subtract);\n-static FloatParts128 *parts128_addsub(FloatParts128 *a, FloatParts128 *b,\n- float_status *s, bool subtract);\n-\n-#define parts_addsub(A, B, S, Z) \\\n- PARTS_GENERIC_64_128(addsub, A)(A, B, S, Z)\n-\n static FloatParts64 *parts64_mul(FloatParts64 *a, FloatParts64 *b,\n float_status *s);\n static FloatParts128 *parts128_mul(FloatParts128 *a, FloatParts128 *b,\n@@ -1923,7 +1915,7 @@ float16_addsub(float16 a, float16 b, float_status *status, bool subtract)\n \n float16_unpack_canonical(&pa, a, status);\n float16_unpack_canonical(&pb, b, status);\n- pr = parts_addsub(&pa, &pb, status, subtract);\n+ pr = parts64_addsub(&pa, &pb, status, subtract);\n \n return float16_round_pack_canonical(pr, status);\n }\n@@ -1945,7 +1937,7 @@ soft_f32_addsub(float32 a, float32 b, float_status *status, bool subtract)\n \n float32_unpack_canonical(&pa, a, status);\n float32_unpack_canonical(&pb, b, status);\n- pr = parts_addsub(&pa, &pb, status, subtract);\n+ pr = parts64_addsub(&pa, &pb, status, subtract);\n \n return float32_round_pack_canonical(pr, status);\n }\n@@ -1967,7 +1959,7 @@ soft_f64_addsub(float64 a, float64 b, float_status *status, bool subtract)\n \n float64_unpack_canonical(&pa, a, status);\n float64_unpack_canonical(&pb, b, status);\n- pr = parts_addsub(&pa, &pb, status, subtract);\n+ pr = parts64_addsub(&pa, &pb, status, subtract);\n \n return float64_round_pack_canonical(pr, status);\n }\n@@ -2064,7 +2056,7 @@ static float64 float64r32_addsub(float64 a, float64 b, float_status *status,\n \n float64_unpack_canonical(&pa, a, status);\n float64_unpack_canonical(&pb, b, status);\n- pr = parts_addsub(&pa, &pb, status, subtract);\n+ pr = parts64_addsub(&pa, &pb, status, subtract);\n \n return float64r32_round_pack_canonical(pr, status);\n }\n@@ -2086,7 +2078,7 @@ bfloat16_addsub(bfloat16 a, bfloat16 b, float_status *status, bool subtract)\n \n bfloat16_unpack_canonical(&pa, a, status);\n bfloat16_unpack_canonical(&pb, b, status);\n- pr = parts_addsub(&pa, &pb, status, subtract);\n+ pr = parts64_addsub(&pa, &pb, status, subtract);\n \n return bfloat16_round_pack_canonical(pr, status);\n }\n@@ -2108,7 +2100,7 @@ float128_addsub(float128 a, float128 b, float_status *status, bool subtract)\n \n float128_unpack_canonical(&pa, a, status);\n float128_unpack_canonical(&pb, b, status);\n- pr = parts_addsub(&pa, &pb, status, subtract);\n+ pr = parts128_addsub(&pa, &pb, status, subtract);\n \n return float128_round_pack_canonical(pr, status);\n }\n@@ -2133,7 +2125,7 @@ floatx80_addsub(floatx80 a, floatx80 b, float_status *status, bool subtract)\n return floatx80_default_nan(status);\n }\n \n- pr = parts_addsub(&pa, &pb, status, subtract);\n+ pr = parts128_addsub(&pa, &pb, status, subtract);\n return floatx80_round_pack_canonical(pr, status);\n }\n \n","prefixes":["PULL","11/48"]}