{"id":2230597,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2230597/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260429222445.26301-20-richard.henderson@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260429222445.26301-20-richard.henderson@linaro.org>","date":"2026-04-29T22:24:16","name":"[PULL,19/48] fpu: Drop parts_float_to_sint","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"df43f9b8dfa78812b95eefb4332b60a98fc12fbb","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/1.1/people/72104/?format=json","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260429222445.26301-20-richard.henderson@linaro.org/mbox/","series":[{"id":502161,"url":"http://patchwork.ozlabs.org/api/1.1/series/502161/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502161","date":"2026-04-29T22:23:57","name":"[PULL,01/48] fpu: Drop parts_canonicalize","version":1,"mbox":"http://patchwork.ozlabs.org/series/502161/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2230597/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2230597/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=zpp0XG5q;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5X286prbz1yHZ\n\tfor ; Thu, 30 Apr 2026 08:25:52 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wIDLl-0000OT-VJ; Wed, 29 Apr 2026 18:25:45 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wIDLj-0000N1-CF\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 18:25:43 -0400","from mail-pj1-x102d.google.com ([2607:f8b0:4864:20::102d])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wIDLh-00050W-9f\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 18:25:43 -0400","by mail-pj1-x102d.google.com with SMTP id\n 98e67ed59e1d1-362bb3260f1so143922a91.2\n for ; Wed, 29 Apr 2026 15:25:40 -0700 (PDT)","from stoup.. ([180.233.125.15]) by smtp.gmail.com with ESMTPSA id\n 98e67ed59e1d1-364a2732502sm1888471a91.3.2026.04.29.15.25.37\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 29 Apr 2026 15:25:39 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777501540; x=1778106340; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=TnqgFo2n96o5/hz/wNbPC/lo1mCwyjcbZvtAcdzySuY=;\n b=zpp0XG5q3nhgWa+nMh7MYqH/Ks7d0ynKXrO6uclsT1coY5AjJ5RbtXvf658O1OGR8n\n zUvWkksHNCbaPeZzWY/AcTRsgpTdhopinVxlvslFEJolaPeGC7Tyy7Q/CAR6EtGrUakg\n LJtGZS96+aVI43FtYO+xs0rtsKM0x7DhRCERgZkKbHIf9LiaW6erJ5BFhuGqQMkHlsq0\n wj1sJ3W4ncV5gD2AzfyXsrnzDBZ/ul6ei0tV9kzrnCMJfjWI2Z8TSJl8155JvBuKkI2/\n XZGgGAHhwHeuF7OiIYxzaz7+ns2i6b5I5NdTLoMEmFie4YOEPLoOUroDZhi6TBIUT0Nh\n cLQQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777501540; x=1778106340;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=TnqgFo2n96o5/hz/wNbPC/lo1mCwyjcbZvtAcdzySuY=;\n b=QvQc5FVT6rI/fxITWHw66+iT89tg2grcFjAujwjbE5jjJdtPBgeGFZtKfYh9j+47Eg\n qU/SPpIFO5zRYgDtP/Dyz+Q8WqwbF5DeEXUVIDLbiseMn0ZErS3z8yw1BrOheweAGc/U\n Oo+4nzcAJbbzKYrYUzDp2vOlZSvZI1NwN0Sol0ZH8vHIeAVct4hpKlkSUzThsfd6xZQB\n dsEj4K7vpsLreGX6ElKwwXMkjCUebnn7YdX+HPpVF6Pb7uioN7oWqwbJSYTqqhPLjQck\n VE8uIc2D7uStg5q5xofiiz/OXJAEAvYHIxNqIEP0xYUxEsJGRY7z8S/gnRWEUhNcZLVa\n Jjrw==","X-Gm-Message-State":"AOJu0YyMTceFZZ6h+m6rfzFAS9kKWKY4XtGKp/33iZqbSHXymqKmYFYI\n LZ7XVjZ2HEIvYVUAMX1rSpF9ZrMSPnP1I+KaSLzuvfs0ZQ6sqqH4FSRrnr9QVid+W4+98Uzm2yX\n 6y0c5m9I=","X-Gm-Gg":"AeBDieto932FmYdsMdHVtdJKRxhFYkfQiGWxY+j8rewhZw9j2wQag0ysYtro1P2H73A\n fVRoO+XuHQWZlzQPtUInamnw7jefKeW+KNx6BUw5VJKUAYIhxeyeQOAPV79GtCZ4p3iJJ6zzMC5\n s+M/+S8/calpV8BsdhX/VmXLDzXHqdawMqEbdNydBYyaIeuZm1M5DLa3iiVFD5IWMBoMvnHxOPh\n Axt4uTFWdg8FSLRg7xTMmbF2Fhex1IhDYaZYGzUc6QL8XYQsemKtz5lG25w3Lm+YWYGqOcV4x1V\n z8bHnZfOAuM2ufKeg3v4K4jX4P1cTq/r3njnzJGeLoYycFgYPqMPGx4em8ATL4dFNJqn82ngKAD\n 2gm0kMXHRLZnr+7p+8s2soeOIJm9f4e2iZQAz+qtXbwCUj9FZYim0hpT8srBQK+yQ3AOFCRAEgQ\n dxYBkpGfaH0XUW+vjHOEdp9ovQEDA9iiqILvuYEmdR","X-Received":"by 2002:a17:90b:3d89:b0:35e:d012:5a39 with SMTP id\n 98e67ed59e1d1-364c30cb703mr178419a91.14.1777501539898;\n Wed, 29 Apr 2026 15:25:39 -0700 (PDT)","From":"Richard Henderson ","To":"qemu-devel@nongnu.org","Cc":"stefanha@redhat.com,\n =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Subject":"[PULL 19/48] fpu: Drop parts_float_to_sint","Date":"Thu, 30 Apr 2026 08:24:16 +1000","Message-ID":"<20260429222445.26301-20-richard.henderson@linaro.org>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260429222445.26301-1-richard.henderson@linaro.org>","References":"<20260429222445.26301-1-richard.henderson@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::102d;\n envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102d.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Use parts{64,128}_float_to_sint at each call site.\nNote that there was a duplicate macro redefinition.\n\nReviewed-by: Philippe Mathieu-Daudé \nSigned-off-by: Richard Henderson \n---\n fpu/softfloat.c | 49 ++++++++++++++++++-------------------------------\n 1 file changed, 18 insertions(+), 31 deletions(-)","diff":"diff --git a/fpu/softfloat.c b/fpu/softfloat.c\nindex e2341871bd..42ef537e12 100644\n--- a/fpu/softfloat.c\n+++ b/fpu/softfloat.c\n@@ -779,16 +779,6 @@ static float128 QEMU_FLATTEN float128_pack_raw(const FloatParts128 *p)\n FloatParts128 *: parts128_##NAME, \\\n FloatParts256 *: parts256_##NAME)\n \n-static int64_t parts64_float_to_sint(FloatParts64 *p, FloatRoundMode rmode,\n- int scale, int64_t min, int64_t max,\n- float_status *s);\n-static int64_t parts128_float_to_sint(FloatParts128 *p, FloatRoundMode rmode,\n- int scale, int64_t min, int64_t max,\n- float_status *s);\n-\n-#define parts_float_to_sint(P, R, Z, MN, MX, S) \\\n- PARTS_GENERIC_64_128(float_to_sint, P)(P, R, Z, MN, MX, S)\n-\n static uint64_t parts64_float_to_uint(FloatParts64 *p, FloatRoundMode rmode,\n int scale, uint64_t max,\n float_status *s);\n@@ -814,9 +804,6 @@ static void parts64_sint_to_float(FloatParts64 *p, int64_t a,\n static void parts128_sint_to_float(FloatParts128 *p, int64_t a,\n int scale, float_status *s);\n \n-#define parts_float_to_sint(P, R, Z, MN, MX, S) \\\n- PARTS_GENERIC_64_128(float_to_sint, P)(P, R, Z, MN, MX, S)\n-\n #define parts_sint_to_float(P, I, Z, S) \\\n PARTS_GENERIC_64_128(sint_to_float, P)(P, I, Z, S)\n \n@@ -3181,7 +3168,7 @@ int8_t float16_to_int8_scalbn(float16 a, FloatRoundMode rmode, int scale,\n FloatParts64 p;\n \n float16_unpack_canonical(&p, a, s);\n- return parts_float_to_sint(&p, rmode, scale, INT8_MIN, INT8_MAX, s);\n+ return parts64_float_to_sint(&p, rmode, scale, INT8_MIN, INT8_MAX, s);\n }\n \n int16_t float16_to_int16_scalbn(float16 a, FloatRoundMode rmode, int scale,\n@@ -3190,7 +3177,7 @@ int16_t float16_to_int16_scalbn(float16 a, FloatRoundMode rmode, int scale,\n FloatParts64 p;\n \n float16_unpack_canonical(&p, a, s);\n- return parts_float_to_sint(&p, rmode, scale, INT16_MIN, INT16_MAX, s);\n+ return parts64_float_to_sint(&p, rmode, scale, INT16_MIN, INT16_MAX, s);\n }\n \n int32_t float16_to_int32_scalbn(float16 a, FloatRoundMode rmode, int scale,\n@@ -3199,7 +3186,7 @@ int32_t float16_to_int32_scalbn(float16 a, FloatRoundMode rmode, int scale,\n FloatParts64 p;\n \n float16_unpack_canonical(&p, a, s);\n- return parts_float_to_sint(&p, rmode, scale, INT32_MIN, INT32_MAX, s);\n+ return parts64_float_to_sint(&p, rmode, scale, INT32_MIN, INT32_MAX, s);\n }\n \n int64_t float16_to_int64_scalbn(float16 a, FloatRoundMode rmode, int scale,\n@@ -3208,7 +3195,7 @@ int64_t float16_to_int64_scalbn(float16 a, FloatRoundMode rmode, int scale,\n FloatParts64 p;\n \n float16_unpack_canonical(&p, a, s);\n- return parts_float_to_sint(&p, rmode, scale, INT64_MIN, INT64_MAX, s);\n+ return parts64_float_to_sint(&p, rmode, scale, INT64_MIN, INT64_MAX, s);\n }\n \n int16_t float32_to_int16_scalbn(float32 a, FloatRoundMode rmode, int scale,\n@@ -3217,7 +3204,7 @@ int16_t float32_to_int16_scalbn(float32 a, FloatRoundMode rmode, int scale,\n FloatParts64 p;\n \n float32_unpack_canonical(&p, a, s);\n- return parts_float_to_sint(&p, rmode, scale, INT16_MIN, INT16_MAX, s);\n+ return parts64_float_to_sint(&p, rmode, scale, INT16_MIN, INT16_MAX, s);\n }\n \n int32_t float32_to_int32_scalbn(float32 a, FloatRoundMode rmode, int scale,\n@@ -3226,7 +3213,7 @@ int32_t float32_to_int32_scalbn(float32 a, FloatRoundMode rmode, int scale,\n FloatParts64 p;\n \n float32_unpack_canonical(&p, a, s);\n- return parts_float_to_sint(&p, rmode, scale, INT32_MIN, INT32_MAX, s);\n+ return parts64_float_to_sint(&p, rmode, scale, INT32_MIN, INT32_MAX, s);\n }\n \n int64_t float32_to_int64_scalbn(float32 a, FloatRoundMode rmode, int scale,\n@@ -3235,7 +3222,7 @@ int64_t float32_to_int64_scalbn(float32 a, FloatRoundMode rmode, int scale,\n FloatParts64 p;\n \n float32_unpack_canonical(&p, a, s);\n- return parts_float_to_sint(&p, rmode, scale, INT64_MIN, INT64_MAX, s);\n+ return parts64_float_to_sint(&p, rmode, scale, INT64_MIN, INT64_MAX, s);\n }\n \n int16_t float64_to_int16_scalbn(float64 a, FloatRoundMode rmode, int scale,\n@@ -3244,7 +3231,7 @@ int16_t float64_to_int16_scalbn(float64 a, FloatRoundMode rmode, int scale,\n FloatParts64 p;\n \n float64_unpack_canonical(&p, a, s);\n- return parts_float_to_sint(&p, rmode, scale, INT16_MIN, INT16_MAX, s);\n+ return parts64_float_to_sint(&p, rmode, scale, INT16_MIN, INT16_MAX, s);\n }\n \n int32_t float64_to_int32_scalbn(float64 a, FloatRoundMode rmode, int scale,\n@@ -3253,7 +3240,7 @@ int32_t float64_to_int32_scalbn(float64 a, FloatRoundMode rmode, int scale,\n FloatParts64 p;\n \n float64_unpack_canonical(&p, a, s);\n- return parts_float_to_sint(&p, rmode, scale, INT32_MIN, INT32_MAX, s);\n+ return parts64_float_to_sint(&p, rmode, scale, INT32_MIN, INT32_MAX, s);\n }\n \n int64_t float64_to_int64_scalbn(float64 a, FloatRoundMode rmode, int scale,\n@@ -3262,7 +3249,7 @@ int64_t float64_to_int64_scalbn(float64 a, FloatRoundMode rmode, int scale,\n FloatParts64 p;\n \n float64_unpack_canonical(&p, a, s);\n- return parts_float_to_sint(&p, rmode, scale, INT64_MIN, INT64_MAX, s);\n+ return parts64_float_to_sint(&p, rmode, scale, INT64_MIN, INT64_MAX, s);\n }\n \n int8_t bfloat16_to_int8_scalbn(bfloat16 a, FloatRoundMode rmode, int scale,\n@@ -3271,7 +3258,7 @@ int8_t bfloat16_to_int8_scalbn(bfloat16 a, FloatRoundMode rmode, int scale,\n FloatParts64 p;\n \n bfloat16_unpack_canonical(&p, a, s);\n- return parts_float_to_sint(&p, rmode, scale, INT8_MIN, INT8_MAX, s);\n+ return parts64_float_to_sint(&p, rmode, scale, INT8_MIN, INT8_MAX, s);\n }\n \n int16_t bfloat16_to_int16_scalbn(bfloat16 a, FloatRoundMode rmode, int scale,\n@@ -3280,7 +3267,7 @@ int16_t bfloat16_to_int16_scalbn(bfloat16 a, FloatRoundMode rmode, int scale,\n FloatParts64 p;\n \n bfloat16_unpack_canonical(&p, a, s);\n- return parts_float_to_sint(&p, rmode, scale, INT16_MIN, INT16_MAX, s);\n+ return parts64_float_to_sint(&p, rmode, scale, INT16_MIN, INT16_MAX, s);\n }\n \n int32_t bfloat16_to_int32_scalbn(bfloat16 a, FloatRoundMode rmode, int scale,\n@@ -3289,7 +3276,7 @@ int32_t bfloat16_to_int32_scalbn(bfloat16 a, FloatRoundMode rmode, int scale,\n FloatParts64 p;\n \n bfloat16_unpack_canonical(&p, a, s);\n- return parts_float_to_sint(&p, rmode, scale, INT32_MIN, INT32_MAX, s);\n+ return parts64_float_to_sint(&p, rmode, scale, INT32_MIN, INT32_MAX, s);\n }\n \n int64_t bfloat16_to_int64_scalbn(bfloat16 a, FloatRoundMode rmode, int scale,\n@@ -3298,7 +3285,7 @@ int64_t bfloat16_to_int64_scalbn(bfloat16 a, FloatRoundMode rmode, int scale,\n FloatParts64 p;\n \n bfloat16_unpack_canonical(&p, a, s);\n- return parts_float_to_sint(&p, rmode, scale, INT64_MIN, INT64_MAX, s);\n+ return parts64_float_to_sint(&p, rmode, scale, INT64_MIN, INT64_MAX, s);\n }\n \n static int32_t float128_to_int32_scalbn(float128 a, FloatRoundMode rmode,\n@@ -3307,7 +3294,7 @@ static int32_t float128_to_int32_scalbn(float128 a, FloatRoundMode rmode,\n FloatParts128 p;\n \n float128_unpack_canonical(&p, a, s);\n- return parts_float_to_sint(&p, rmode, scale, INT32_MIN, INT32_MAX, s);\n+ return parts128_float_to_sint(&p, rmode, scale, INT32_MIN, INT32_MAX, s);\n }\n \n static int64_t float128_to_int64_scalbn(float128 a, FloatRoundMode rmode,\n@@ -3316,7 +3303,7 @@ static int64_t float128_to_int64_scalbn(float128 a, FloatRoundMode rmode,\n FloatParts128 p;\n \n float128_unpack_canonical(&p, a, s);\n- return parts_float_to_sint(&p, rmode, scale, INT64_MIN, INT64_MAX, s);\n+ return parts128_float_to_sint(&p, rmode, scale, INT64_MIN, INT64_MAX, s);\n }\n \n static Int128 float128_to_int128_scalbn(float128 a, FloatRoundMode rmode,\n@@ -3382,7 +3369,7 @@ static int32_t floatx80_to_int32_scalbn(floatx80 a, FloatRoundMode rmode,\n if (!floatx80_unpack_canonical(&p, a, s)) {\n parts128_default_nan(&p, s);\n }\n- return parts_float_to_sint(&p, rmode, scale, INT32_MIN, INT32_MAX, s);\n+ return parts128_float_to_sint(&p, rmode, scale, INT32_MIN, INT32_MAX, s);\n }\n \n static int64_t floatx80_to_int64_scalbn(floatx80 a, FloatRoundMode rmode,\n@@ -3393,7 +3380,7 @@ static int64_t floatx80_to_int64_scalbn(floatx80 a, FloatRoundMode rmode,\n if (!floatx80_unpack_canonical(&p, a, s)) {\n parts128_default_nan(&p, s);\n }\n- return parts_float_to_sint(&p, rmode, scale, INT64_MIN, INT64_MAX, s);\n+ return parts128_float_to_sint(&p, rmode, scale, INT64_MIN, INT64_MAX, s);\n }\n \n int8_t float16_to_int8(float16 a, float_status *s)\n","prefixes":["PULL","19/48"]}