{"id":2230584,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2230584/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260429213453.26235-1-FredTheDude@proton.me/","project":{"id":12,"url":"http://patchwork.ozlabs.org/api/1.1/projects/12/?format=json","name":"Linux CIFS Client","link_name":"linux-cifs-client","list_id":"linux-cifs.vger.kernel.org","list_email":"linux-cifs@vger.kernel.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260429213453.26235-1-FredTheDude@proton.me>","date":"2026-04-29T21:34:53","name":"smb: client: change allocation requirements in smb2_compound_op","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"2d1671b0ead18cc2d92f32a222c19edddc9b5b9b","submitter":{"id":93268,"url":"http://patchwork.ozlabs.org/api/1.1/people/93268/?format=json","name":"Fredric Cover","email":"fredric.cover.lkernel@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260429213453.26235-1-FredTheDude@proton.me/mbox/","series":[{"id":502155,"url":"http://patchwork.ozlabs.org/api/1.1/series/502155/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/list/?series=502155","date":"2026-04-29T21:34:53","name":"smb: client: change allocation requirements in smb2_compound_op","version":1,"mbox":"http://patchwork.ozlabs.org/series/502155/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2230584/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2230584/checks/","tags":{},"headers":{"Return-Path":"\n <linux-cifs+bounces-11301-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-cifs@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=TuL7um63;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c15:e001:75::12fc:5321; helo=sin.lore.kernel.org;\n envelope-from=linux-cifs+bounces-11301-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"TuL7um63\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.214.173","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from sin.lore.kernel.org (sin.lore.kernel.org\n [IPv6:2600:3c15:e001:75::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5VwG5BBjz1yHv\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 30 Apr 2026 07:35:42 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id BE23D300A582\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 29 Apr 2026 21:35:40 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 4C833381B0A;\n\tWed, 29 Apr 2026 21:35:39 +0000 (UTC)","from mail-pl1-f173.google.com (mail-pl1-f173.google.com\n [209.85.214.173])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 277F737472D\n\tfor <linux-cifs@vger.kernel.org>; Wed, 29 Apr 2026 21:35:37 +0000 (UTC)","by mail-pl1-f173.google.com with SMTP id\n d9443c01a7336-2a7a9b8ed69so2009645ad.2\n        for <linux-cifs@vger.kernel.org>;\n Wed, 29 Apr 2026 14:35:37 -0700 (PDT)","from FredPC.orting.wednet.edu ([164.116.47.202])\n        by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b98899055fsm32612315ad.80.2026.04.29.14.35.36\n        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n        Wed, 29 Apr 2026 14:35:37 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777498539; cv=none;\n b=hFhx3xqaxg74niQTflwZCP3Szt4rNg7/DyFW3lnAkBl7T8tp98jdZH5Ul7mWK+IYASmRMEnXYQScI0TSMiz6GzEc/05UqsqGTiCYe3SkQvIsPwmdkTm0aqh3IHriMIkEKcT1cAsDDRyqOfyhdhJ6k9Ps72UV8OC530QCAoVHaKI=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777498539; c=relaxed/simple;\n\tbh=OCy9Ao5J71zcrOapnb2HkESAFaMyMsMNa3UUjUxU/hM=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=ZFElVordcYNe5bQGyTlLX5Qfod55grvdVa0xBGI9wFX5VC3E4l8SGgop8Tj48QrlZw3spuRmNCcDD0AKd5WHGwthiNVHCV2G3/1sGWnStVrWmV6emetWS80z0b80hPOFTZD91aQfp+wa/2tFUt8FWxpgUVpceIdP8+I3/vuFJeE=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=TuL7um63; arc=none smtp.client-ip=209.85.214.173","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n        d=gmail.com; s=20251104; t=1777498537; x=1778103337;\n darn=vger.kernel.org;\n        h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n         :to:from:from:to:cc:subject:date:message-id:reply-to;\n        bh=d4qFM2xY0uWIBy0/+YAa6gQ04zbbRjdE4sek5AAXClk=;\n        b=TuL7um63zZeA9QFc0LHK+KUGh/IOK0rsA+fGfd0iyO15tAu0OM64a1IaqO8Suq5COI\n         UfI1CiOL05lxVvh6blXXGK8maMeYpZWd16yFzVKezxNT2KwTToIvmNL5zevq0l3Ajq8d\n         dIVcatmB6x5TXtNx4uHYQvwr1bRfBtIZ54K9+HgBgPaTIQdqxL1/1UzfUZkHavuTE4DL\n         pJWYyhy5BPbDnH9RLtUdFy7pW2lRSOCQ+VJ/PSowdAXCybnUf+2f13V60kF+Sxe3z9gM\n         Vr7TZxajqSSCL86WV7DEUsDUw+iqX0nYbtMr7OxrCOgRCw2CogB0V5mM3k0nCY3KY6ud\n         rFzw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n        d=1e100.net; s=20251104; t=1777498537; x=1778103337;\n        h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n         :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n         :message-id:reply-to;\n        bh=d4qFM2xY0uWIBy0/+YAa6gQ04zbbRjdE4sek5AAXClk=;\n        b=kjnndbFaiOYBaR+zWEwHRx82tFNtCSNOYqU7TRpqZ14xE+mEnIIoyN9cQ22peqZxM5\n         4krmStXQbKvjmDtCNPc80eKKGHUewzyHSEhhU4QVDYgIx6ufP+t9tW1eYmVIqcUikhNQ\n         wWDOKJp8touLHxwqQ5t+JJMwgBt+TyeCxkplAYwQ6vchr7ui9hHVQcbRbSIGN6MV4O7j\n         nuPHZiTnyxKyfaUqPdB7S7cx3nfFKF0r6HMwGqAyB0r5QfPl339RIdnDv4dt6GKJ1G/2\n         rb80Lb8XcLrxtZ1HC41nqQ0V8cWtnpAAUL0bTpzTpKE+LDnF29eLm4B3DI/S9UouzBrh\n         mDRA==","X-Gm-Message-State":"AOJu0YygBuFcyIWt2jFvD7O+RB/IseCrrYBP/+AWXUqdTiENtyO0MCKl\n\tArMyAuFLlGe58Dl2a4b0dfi/IQHmlgseTY7T++WSeg9jg7DPn1x/BMph","X-Gm-Gg":"AeBDiesI+fHHNYoTB55NKYYNoprEL6am9pv1Lv/817ueDLseGGyuLi65j0nYcYKIHRD\n\tAKhME08QEBWU4Q9Mp8+aTlg2P1X3Az+NeL9alzqpiuaVvwDaeFM0NoZZDc0azppDi93yStB7WsG\n\tyHStO7tcrjw+NB3S7PtSrNacp2bCMkNB62y8Jom5eQy4DgvBO4+AXSW1tu1FcwIdAfXXHQqNJR0\n\tT2z1tGjF/Q88r3eBxSyK76VxP4a2srAzG5yDwbXZmnyZvHgmocnOZL9p/eghjhXvzbhk5kZDgN3\n\t9e7UjvLENZwIQnip3tRADKpW76K+g88O/cyWXSns4vrWwTeP/8Q6G824e3BrNITlObxr9oR5e14\n\tMav9VWazTDwjAHyX9yHYs2eTtSwbK8UpmdIye+izHlfZQUhQBQRMxSv5A4ADn4/oOXjp6t4EQ6b\n\t11CsOfq6zggOrfVw7m1eDR320H9ckYoBq/lgK4ZNrBfUbH89iMLVWM","X-Received":"by 2002:a17:902:7d96:b0:2b4:5f19:1d34 with SMTP id\n d9443c01a7336-2b9a235e262mr1101845ad.17.1777498537422;\n        Wed, 29 Apr 2026 14:35:37 -0700 (PDT)","From":"Fredric Cover <fredric.cover.lkernel@gmail.com>","X-Google-Original-From":"Fredric Cover <FredTheDude@proton.me>","To":"Steve French <sfrench@samba.org>,\n\tPaulo Alcantara <pc@manguebit.com>","Cc":"linux-cifs@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tFredric Cover <fredric.cover.lkernel@gmail.com>","Subject":"[PATCH] smb: client: change allocation requirements in\n smb2_compound_op","Date":"Wed, 29 Apr 2026 14:34:53 -0700","Message-ID":"<20260429213453.26235-1-FredTheDude@proton.me>","X-Mailer":"git-send-email 2.43.0","Precedence":"bulk","X-Mailing-List":"linux-cifs@vger.kernel.org","List-Id":"<linux-cifs.vger.kernel.org>","List-Subscribe":"<mailto:linux-cifs+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-cifs+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"From: Fredric Cover <fredric.cover.lkernel@gmail.com>\n\nCurrently, smb2_compound_op() allocates\nstruct smb2_compound_vars *vars using GFP_ATOMIC, although\nsmb2_compound_op() can sleep when it calls compound_send_recv()\nbefore vars is freed.\n\nAllocate vars using GFP_KERNEL.\n\nSigned-off-by: Fredric Cover <fredric.cover.lkernel@gmail.com>\n---\nPlease note that I am new to patching the Linux kernel.\nI appreciate advice.\n---\n fs/smb/client/smb2inode.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/fs/smb/client/smb2inode.c b/fs/smb/client/smb2inode.c\nindex c6dd282fc..286912616 100644\n--- a/fs/smb/client/smb2inode.c\n+++ b/fs/smb/client/smb2inode.c\n@@ -230,7 +230,7 @@ static int smb2_compound_op(const unsigned int xid, struct cifs_tcon *tcon,\n \tnum_rqst = 0;\n \tserver = cifs_pick_channel(ses);\n \n-\tvars = kzalloc_obj(*vars, GFP_ATOMIC);\n+\tvars = kzalloc_obj(*vars, GFP_KERNEL);\n \tif (vars == NULL) {\n \t\trc = -ENOMEM;\n \t\tgoto out;\n","prefixes":[]}