{"id":2230565,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2230565/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260429210830.594724-4-berrange@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260429210830.594724-4-berrange@redhat.com>","date":"2026-04-29T21:08:24","name":"[3/9] qom: make errp last param in methods taking va_list","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"1ebf4df5e8f4e28fa90d75f8d7e81fad192a7f39","submitter":{"id":2694,"url":"http://patchwork.ozlabs.org/api/1.1/people/2694/?format=json","name":"Daniel P. Berrangé","email":"berrange@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260429210830.594724-4-berrange@redhat.com/mbox/","series":[{"id":502152,"url":"http://patchwork.ozlabs.org/api/1.1/series/502152/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502152","date":"2026-04-29T21:08:21","name":"qom: misc cleanups / fixes","version":1,"mbox":"http://patchwork.ozlabs.org/series/502152/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2230565/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2230565/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=cAGbgwtL;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5VKY2MB7z1yHv\n\tfor ; Thu, 30 Apr 2026 07:09:05 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wIC9P-0007Sb-Hx; Wed, 29 Apr 2026 17:08:55 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wIC9I-0007Im-Gt\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 17:08:48 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wIC9G-0004D1-DB\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 17:08:47 -0400","from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-596-Tax5HdwCNp-xXImDoEupdQ-1; Wed,\n 29 Apr 2026 17:08:41 -0400","from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 51AB81956094\n for ; Wed, 29 Apr 2026 21:08:40 +0000 (UTC)","from berrange.com (unknown [10.44.48.62])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id C95DF300019F; Wed, 29 Apr 2026 21:08:38 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777496923;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=4fUliCYpNrb/eUarNMfXsxVp9XH85AsuRgSEPvG/HNI=;\n b=cAGbgwtLluOCK5h+I0UE7fH3mG8Sl+GozbQPROgxDH5EE+thQ+bJteO2tgq2ZSksY+ZMWa\n s40ZFVI5NNUMQfr9p0b21vBwK2Xl1AZ+1v7OwitA4/3mIZlfu4gqKsZ3iD00BS/WVMwtIp\n pM4dOXVhlerI4xqO2bxpKT7OPAKrjQw=","X-MC-Unique":"Tax5HdwCNp-xXImDoEupdQ-1","X-Mimecast-MFC-AGG-ID":"Tax5HdwCNp-xXImDoEupdQ_1777496920","From":"=?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= ","To":"qemu-devel@nongnu.org","Cc":"Paolo Bonzini ,\n =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= ","Subject":"[PATCH 3/9] qom: make errp last param in methods taking va_list","Date":"Wed, 29 Apr 2026 22:08:24 +0100","Message-ID":"<20260429210830.594724-4-berrange@redhat.com>","In-Reply-To":"<20260429210830.594724-1-berrange@redhat.com>","References":"<20260429210830.594724-1-berrange@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.4","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=berrange@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"12","X-Spam_score":"1.2","X-Spam_bar":"+","X-Spam_report":"(1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"object_new_with_props can't put 'errp' last due to the use of\nvariadic arguments. That constraint does not apply to the use\nof va_list with object_new_with_propv, so follow normal practice\nwith 'errp' placement.\n\nThe same rationale applies to object_set_propv.\n\nSigned-off-by: Daniel P. Berrangé \n---\n include/qom/object.h | 10 +++++-----\n qom/object.c | 20 ++++++++++----------\n tests/unit/check-qom-proplist.c | 4 ++--\n 3 files changed, 17 insertions(+), 17 deletions(-)","diff":"diff --git a/include/qom/object.h b/include/qom/object.h\nindex 510885218b..c7d80914fb 100644\n--- a/include/qom/object.h\n+++ b/include/qom/object.h\n@@ -689,16 +689,16 @@ Object *object_new_with_props(const char *typename,\n * @typename: The name of the type of the object to instantiate.\n * @parent: the parent object\n * @id: The unique ID of the object\n- * @errp: pointer to error object\n * @vargs: list of property names and values\n+ * @errp: pointer to error object\n *\n * See object_new_with_props() for documentation.\n */\n Object *object_new_with_propv(const char *typename,\n Object *parent,\n const char *id,\n- Error **errp,\n- va_list vargs);\n+ va_list vargs,\n+ Error **errp);\n \n /**\n * object_set_props:\n@@ -739,14 +739,14 @@ bool object_set_props(Object *obj, Error **errp, ...) G_GNUC_NULL_TERMINATED;\n /**\n * object_set_propv:\n * @obj: the object instance to set properties on\n- * @errp: pointer to error object\n * @vargs: list of property names and values\n+ * @errp: pointer to error object\n *\n * See object_set_props() for documentation.\n *\n * Returns: %true on success, %false on error.\n */\n-bool object_set_propv(Object *obj, Error **errp, va_list vargs);\n+bool object_set_propv(Object *obj, va_list vargs, Error **errp);\n \n /**\n * object_initialize:\ndiff --git a/qom/object.c b/qom/object.c\nindex 9bbd02f4ab..2671c471ab 100644\n--- a/qom/object.c\n+++ b/qom/object.c\n@@ -550,7 +550,7 @@ bool object_initialize_child_with_propsv(Object *parentobj,\n object_initialize(childobj, size, type);\n obj = OBJECT(childobj);\n \n- if (!object_set_propv(obj, errp, vargs)) {\n+ if (!object_set_propv(obj, vargs, errp)) {\n goto out;\n }\n \n@@ -749,7 +749,7 @@ Object *object_new_with_props(const char *typename,\n Object *obj;\n \n va_start(vargs, errp);\n- obj = object_new_with_propv(typename, parent, id, errp, vargs);\n+ obj = object_new_with_propv(typename, parent, id, vargs, errp);\n va_end(vargs);\n \n return obj;\n@@ -759,8 +759,8 @@ Object *object_new_with_props(const char *typename,\n Object *object_new_with_propv(const char *typename,\n Object *parent,\n const char *id,\n- Error **errp,\n- va_list vargs)\n+ va_list vargs,\n+ Error **errp)\n {\n Object *obj;\n ObjectClass *klass;\n@@ -785,7 +785,7 @@ Object *object_new_with_propv(const char *typename,\n }\n obj = object_new_with_type(klass->type);\n \n- if (!object_set_propv(obj, errp, vargs)) {\n+ if (!object_set_propv(obj, vargs, errp)) {\n goto error;\n }\n \n@@ -813,14 +813,14 @@ Object *object_new_with_propv(const char *typename,\n \n \n bool object_set_props(Object *obj,\n- Error **errp,\n- ...)\n+ Error **errp,\n+ ...)\n {\n va_list vargs;\n bool ret;\n \n va_start(vargs, errp);\n- ret = object_set_propv(obj, errp, vargs);\n+ ret = object_set_propv(obj, vargs, errp);\n va_end(vargs);\n \n return ret;\n@@ -828,8 +828,8 @@ bool object_set_props(Object *obj,\n \n \n bool object_set_propv(Object *obj,\n- Error **errp,\n- va_list vargs)\n+ va_list vargs,\n+ Error **errp)\n {\n const char *propname;\n \ndiff --git a/tests/unit/check-qom-proplist.c b/tests/unit/check-qom-proplist.c\nindex ee3c6fb32b..7f31735459 100644\n--- a/tests/unit/check-qom-proplist.c\n+++ b/tests/unit/check-qom-proplist.c\n@@ -373,8 +373,8 @@ static Object *new_helper(Error **errp,\n obj = object_new_with_propv(TYPE_DUMMY,\n parent,\n \"dummy0\",\n- errp,\n- vargs);\n+ vargs,\n+ errp);\n va_end(vargs);\n return obj;\n }\n","prefixes":["3/9"]}