{"id":2230564,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2230564/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260429210830.594724-2-berrange@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260429210830.594724-2-berrange@redhat.com>","date":"2026-04-29T21:08:22","name":"[1/9] qom: add trace events for object/property lifecycle","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"fff905353f03a984fe6364449810069556856718","submitter":{"id":2694,"url":"http://patchwork.ozlabs.org/api/1.1/people/2694/?format=json","name":"Daniel P. Berrangé","email":"berrange@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260429210830.594724-2-berrange@redhat.com/mbox/","series":[{"id":502152,"url":"http://patchwork.ozlabs.org/api/1.1/series/502152/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502152","date":"2026-04-29T21:08:21","name":"qom: misc cleanups / fixes","version":1,"mbox":"http://patchwork.ozlabs.org/series/502152/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2230564/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2230564/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=GS/Q0A4I;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5VKP0P69z1yHv\n\tfor ; Thu, 30 Apr 2026 07:08:57 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wIC9H-0007F4-4o; Wed, 29 Apr 2026 17:08:47 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wIC9B-0007EN-5N\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 17:08:41 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wIC99-0004Ca-Gb\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 17:08:40 -0400","from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-674-RIyrnFNXM_W1Gm3MU7nUIA-1; Wed,\n 29 Apr 2026 17:08:36 -0400","from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 21BA8195605C\n for ; Wed, 29 Apr 2026 21:08:36 +0000 (UTC)","from berrange.com (unknown [10.44.48.62])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 8B955300019F; Wed, 29 Apr 2026 21:08:34 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777496918;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=2ZqsZv9loFBmynySrdqG5+CtntaPpDuLB1gnJtovPfo=;\n b=GS/Q0A4I2xIxIruTnxnWfo4FpnjSvXsQKMB6oqHIP1sI+SoInQicfiZVMGjSl9q5gcfE6v\n gAWKTv4p00n0brPttA4V/Z4p857fEXkXjazeTqfAAPL5mVEySQdeCFybffOHQXFTxgU1Zw\n GnpIBe7rCNNPFTwl0WxDsWf041pdBac=","X-MC-Unique":"RIyrnFNXM_W1Gm3MU7nUIA-1","X-Mimecast-MFC-AGG-ID":"RIyrnFNXM_W1Gm3MU7nUIA_1777496916","From":"=?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= ","To":"qemu-devel@nongnu.org","Cc":"Paolo Bonzini ,\n =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= ","Subject":"[PATCH 1/9] qom: add trace events for object/property lifecycle","Date":"Wed, 29 Apr 2026 22:08:22 +0100","Message-ID":"<20260429210830.594724-2-berrange@redhat.com>","In-Reply-To":"<20260429210830.594724-1-berrange@redhat.com>","References":"<20260429210830.594724-1-berrange@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.4","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=berrange@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"12","X-Spam_score":"1.2","X-Spam_bar":"+","X-Spam_report":"(1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"This adds tracing around object allocation & finalization, the addition &\ndeletion of properties, and the addition & deletion of children.\n\nSigned-off-by: Daniel P. Berrangé \n---\n qom/object.c | 34 +++++++++++++++++++++++++++-------\n qom/trace-events | 12 ++++++++++--\n 2 files changed, 37 insertions(+), 9 deletions(-)","diff":"diff --git a/qom/object.c b/qom/object.c\nindex f981e27044..b99da7309d 100644\n--- a/qom/object.c\n+++ b/qom/object.c\n@@ -603,6 +603,8 @@ static void object_property_del_all(Object *obj)\n object_property_iter_init(&iter, obj);\n while ((prop = object_property_iter_next(&iter)) != NULL) {\n if (g_hash_table_add(done, prop)) {\n+ trace_object_property_del(obj, obj->class->type->name,\n+ prop->name, prop->opaque);\n if (prop->release) {\n prop->release(obj, prop->name, prop->opaque);\n released = true;\n@@ -621,10 +623,14 @@ static void object_property_del_child(Object *obj, Object *child)\n GHashTableIter iter;\n gpointer key, value;\n \n+ trace_object_property_del_child(obj, obj->class->type->name,\n+ child, child->class->type->name);\n g_hash_table_iter_init(&iter, obj->properties);\n while (g_hash_table_iter_next(&iter, &key, &value)) {\n prop = value;\n if (object_property_is_child(prop) && prop->opaque == child) {\n+ trace_object_property_del(obj, obj->class->type->name,\n+ prop->name, prop->opaque);\n if (prop->release) {\n prop->release(obj, prop->name, prop->opaque);\n prop->release = NULL;\n@@ -664,7 +670,7 @@ static void object_finalize(void *data)\n {\n Object *obj = data;\n TypeImpl *ti = obj->class->type;\n-\n+ trace_object_finalize(obj, obj->class->type->name);\n object_property_del_all(obj);\n object_deinit(obj, ti);\n \n@@ -714,6 +720,7 @@ static Object *object_new_with_type(Type type)\n object_initialize_with_type(obj, size, type);\n obj->free = obj_free;\n \n+ trace_object_new(obj, obj ? obj->class->type->name : \"(null)\");\n return obj;\n }\n \n@@ -844,8 +851,9 @@ Object *object_dynamic_cast(Object *obj, const char *typename)\n Object *object_dynamic_cast_assert(Object *obj, const char *typename,\n const char *file, int line, const char *func)\n {\n- trace_object_dynamic_cast_assert(obj ? obj->class->type->name : \"(null)\",\n- typename, file, line, func);\n+ trace_object_dynamic_cast_assert(\n+ obj, obj ? obj->class->type->name : \"(null)\",\n+ typename, file, line, func);\n \n #ifdef CONFIG_QOM_CAST_DEBUG\n int i;\n@@ -935,8 +943,9 @@ ObjectClass *object_class_dynamic_cast_assert(ObjectClass *class,\n {\n ObjectClass *ret;\n \n- trace_object_class_dynamic_cast_assert(class ? class->type->name : \"(null)\",\n- typename, file, line, func);\n+ trace_object_class_dynamic_cast_assert(\n+ class ? class->type->name : \"(null)\",\n+ typename, file, line, func);\n \n #ifdef CONFIG_QOM_CAST_DEBUG\n int i;\n@@ -1220,6 +1229,8 @@ object_property_try_add(Object *obj, const char *name, const char *type,\n prop->release = release;\n prop->opaque = opaque;\n \n+ trace_object_property_add(obj, obj->class->type->name,\n+ prop->name, prop->opaque);\n g_hash_table_insert(obj->properties, prop->name, prop);\n return prop;\n }\n@@ -1258,6 +1269,8 @@ object_class_property_add(ObjectClass *klass,\n prop->release = release;\n prop->opaque = opaque;\n \n+ trace_object_class_property_add(klass->type->name, prop->name,\n+ prop->opaque);\n g_hash_table_insert(klass->properties, prop->name, prop);\n \n return prop;\n@@ -1346,6 +1359,8 @@ void object_property_del(Object *obj, const char *name)\n {\n ObjectProperty *prop = g_hash_table_lookup(obj->properties, name);\n \n+ trace_object_property_del(obj, obj->class->type->name, prop->name,\n+ prop->opaque);\n if (prop->release) {\n prop->release(obj, name, prop->opaque);\n }\n@@ -1634,8 +1649,11 @@ int object_property_get_enum(Object *obj, const char *name,\n bool object_property_parse(Object *obj, const char *name,\n const char *string, Error **errp)\n {\n- Visitor *v = string_input_visitor_new(string);\n- bool ok = object_property_set(obj, name, v, errp);\n+ Visitor *v;\n+ bool ok;\n+ trace_object_property_parse(obj, obj->class->type->name, name, string);\n+ v = string_input_visitor_new(string);\n+ ok = object_property_set(obj, name, v, errp);\n \n visit_free(v);\n return ok;\n@@ -1766,6 +1784,8 @@ object_property_try_add_child(Object *obj, const char *name,\n g_autofree char *type = NULL;\n ObjectProperty *op;\n \n+ trace_object_property_add_child(obj, obj->class->type->name, name,\n+ child, child->class->type->name);\n assert(!child->parent);\n \n type = g_strdup_printf(\"child<%s>\", object_get_typename(child));\ndiff --git a/qom/trace-events b/qom/trace-events\nindex b2e9f4a712..9aabbae4f7 100644\n--- a/qom/trace-events\n+++ b/qom/trace-events\n@@ -1,5 +1,13 @@\n # See docs/devel/tracing.rst for syntax documentation.\n \n # object.c\n-object_dynamic_cast_assert(const char *type, const char *target, const char *file, int line, const char *func) \"%s->%s (%s:%d:%s)\"\n-object_class_dynamic_cast_assert(const char *type, const char *target, const char *file, int line, const char *func) \"%s->%s (%s:%d:%s)\"\n+object_dynamic_cast_assert(void *obj, const char *type, const char *target, const char *file, int line, const char *func) \"obj=%p type=%s->%s (%s:%d:%s)\"\n+object_finalize(void *obj, const char *type) \"obj=%p type=%s\"\n+object_new(void *obj, const char *type) \"obj=%p type=%s\"\n+object_property_add(void *obj, const char *type, const char *name, void *value) \"obj=%p type=%s name=%s value=%p\"\n+object_property_add_child(void *obj, const char *type, const char *name, void *parent, const char *parenttype) \"obj=%p type=%s name=%s parent=%p parent-type=%s\"\n+object_property_del(void *obj, const char *type, const char *name, void *value) \"obj=%p type=%s name=%s value=%p\"\n+object_property_del_child(void *obj, const char *type, void *parent, const char *parenttype) \"obj=%p type=%s parent=%p parent-type=%s\"\n+object_property_parse(void *obj, const char *type, const char *name, const char *value) \"obj=%p type=%s prop=%s value=%s\"\n+object_class_dynamic_cast_assert(const char *type, const char *target, const char *file, int line, const char *func) \"type=%s->%s (%s:%d:%s)\"\n+object_class_property_add(const char *type, const char *name, void *value) \"type=%s name=%s value=%p\"\n","prefixes":["1/9"]}