{"id":2230561,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2230561/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260430-qemu-vnc-v3-19-be96757428d0@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260430-qemu-vnc-v3-19-be96757428d0@redhat.com>","date":"2026-04-29T21:02:52","name":"[v3,19/26] ui/vnc: add vnc-system unit, to allow different implementations","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"145597d88bd0e9463656974af09d705223e03c35","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.1/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260430-qemu-vnc-v3-19-be96757428d0@redhat.com/mbox/","series":[{"id":502150,"url":"http://patchwork.ozlabs.org/api/1.1/series/502150/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502150","date":"2026-04-29T21:02:34","name":"ui: add standalone VNC server over D-Bus","version":3,"mbox":"http://patchwork.ozlabs.org/series/502150/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2230561/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2230561/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=Muwkfuaf;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5VJL1S1rz1yHv\n\tfor ; Thu, 30 Apr 2026 07:08:02 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wIC7m-0001av-UU; Wed, 29 Apr 2026 17:07:15 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wIC5u-0006dU-Nf\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 17:05:23 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wIC5l-0003WE-M6\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 17:05:13 -0400","from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-468-XL3B-7QIMU62J1AERxpPRg-1; Wed,\n 29 Apr 2026 17:05:05 -0400","from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 7A2311800378\n for ; Wed, 29 Apr 2026 21:05:04 +0000 (UTC)","from localhost (unknown [10.44.22.2])\n by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 21C3E19560AB; Wed, 29 Apr 2026 21:05:02 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777496706;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=GvceuUgF9UWGi+mkdSUd1zm6+VCfNMZH/pssttX4eis=;\n b=MuwkfuafIeuw5+HmhGMpphc1Z7quDAC4mJ8kxfJu1urhsuDsuGHf/l1njI3pbQrBJeJtG6\n OyQvZVhvKx/IY6H0GyK30DysbXNzDHT5Mc0GfZpkLjiqFaugfctqoFAHu+4pDKYP+8/SrU\n m8MyK+fuCXtNWBahDWkCya192574ClA=","X-MC-Unique":"XL3B-7QIMU62J1AERxpPRg-1","X-Mimecast-MFC-AGG-ID":"XL3B-7QIMU62J1AERxpPRg_1777496704","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Thu, 30 Apr 2026 01:02:52 +0400","Subject":"[PATCH v3 19/26] ui/vnc: add vnc-system unit, to allow different\n implementations","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260430-qemu-vnc-v3-19-be96757428d0@redhat.com>","References":"<20260430-qemu-vnc-v3-0-be96757428d0@redhat.com>","In-Reply-To":"<20260430-qemu-vnc-v3-0-be96757428d0@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=2652;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=YzwkPRuZT+t1WALPng4UgvXGw1hhuhKzK7Bl0fT7wlw=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp8nIMOuk2e2TxtoDw8xrAjkZKxNSLglT/Onj66\n +hVV1c4SEeJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafJyDAAKCRDa6OEJdZac\n 5VHTD/4xqfK1+CNU92p/u2YiAs3EJOS6i7S3eeuGYamZDgUmowIo1z2r9aqJ/CD3mUyCJbKLmMY\n R0aX+ybX4ker7LFRwCH2DaS+G4cY1NuDvmz6peAdi9sPuhKlibDlqBbxTwK5xWl8VMPzdwM/J7c\n UEgZSTX4GRgNuQqZcaRJzW2nfNWIdCMtJI2yZRei93yKbrJVfH+FtX4SKBt4cWVeXOjFYloQgMD\n GgLFWOLiOEdwBafqWmvE9nJUayn01UMhBRMFdSfGaRJYwl7qg4xLl3SW63ff2KyGL6D+Qy2t8s+\n Sl8Dr3XTujJYjAYWXSeMaJUehHeaFTl4lJB2t1BBh5j8TCTEMLtS5LypnmSg7OK8JI5ZRfTMS8B\n an1iJsfuI5bJNGT8L6UGSJfjm7dJlpHsBKwt1TuQLYTGntFMCC/TmNGApzmmG6KJK8ImYgJeoN7\n BaDiX1b2KU8uzOyZwee5qU5NQ3ocbuXm7VqIrZa8GtEnn10JX1ZBDygQo7TC1S8cNrWwV7WBgQN\n jzGgbH6Kcn7T9+Qvri0lehvJqZQsq24rLUWAPe9dyYWC6W5Jh7j8oBLYUrffe/IGy+VAFO7Ppmd\n sgHyIf2V6KAcsL+BYyizBkaA367HC3iSE5UdsptnqCUjIG3pIuWoA13ubzCzqMSxb1v7JX+yp18\n eTispZ9UwxD7EiQ==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.12","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"The qemu-vnc server will want to signal the XVP requests, let it\nhave its own implementation.\n\nSigned-off-by: Marc-André Lureau \n---\n ui/vnc.h | 4 ++++\n ui/vnc-system.c | 19 +++++++++++++++++++\n ui/vnc.c | 4 ++--\n ui/meson.build | 2 +-\n 4 files changed, 26 insertions(+), 3 deletions(-)","diff":"diff --git a/ui/vnc.h b/ui/vnc.h\nindex d2ebb0f7f45..0b345246c8e 100644\n--- a/ui/vnc.h\n+++ b/ui/vnc.h\n@@ -648,4 +648,8 @@ void vnc_server_cut_text_caps(VncState *vs);\n void vnc_client_cut_text(VncState *vs, size_t len, uint8_t *text);\n void vnc_client_cut_text_ext(VncState *vs, int32_t len, uint32_t flags, uint8_t *data);\n \n+/* XVP events */\n+void vnc_action_shutdown(VncState *vs);\n+void vnc_action_reset(VncState *vs);\n+\n #endif /* QEMU_VNC_H */\ndiff --git a/ui/vnc-system.c b/ui/vnc-system.c\nnew file mode 100644\nindex 00000000000..0632885f655\n--- /dev/null\n+++ b/ui/vnc-system.c\n@@ -0,0 +1,19 @@\n+/*\n+ * QEMU VNC display driver\n+ *\n+ * SPDX-License-Identifier: GPL-2.0-or-later\n+ */\n+#include \"qemu/osdep.h\"\n+\n+#include \"ui/vnc.h\"\n+#include \"system/runstate.h\"\n+\n+void vnc_action_shutdown(VncState *vs)\n+{\n+ qemu_system_powerdown_request();\n+}\n+\n+void vnc_action_reset(VncState *vs)\n+{\n+ qemu_system_reset_request(SHUTDOWN_CAUSE_HOST_QMP_SYSTEM_RESET);\n+}\ndiff --git a/ui/vnc.c b/ui/vnc.c\nindex ea1579135b8..154b07e2e4e 100644\n--- a/ui/vnc.c\n+++ b/ui/vnc.c\n@@ -2522,13 +2522,13 @@ static int protocol_client_msg(VncState *vs, uint8_t *data, size_t len)\n \n switch (action) {\n case VNC_XVP_ACTION_SHUTDOWN:\n- qemu_system_powerdown_request();\n+ vnc_action_shutdown(vs);\n break;\n case VNC_XVP_ACTION_REBOOT:\n send_xvp_message(vs, VNC_XVP_CODE_FAIL);\n break;\n case VNC_XVP_ACTION_RESET:\n- qemu_system_reset_request(SHUTDOWN_CAUSE_HOST_QMP_SYSTEM_RESET);\n+ vnc_action_reset(vs);\n break;\n default:\n send_xvp_message(vs, VNC_XVP_CODE_FAIL);\ndiff --git a/ui/meson.build b/ui/meson.build\nindex 7b6e867d3af..74151b05033 100644\n--- a/ui/meson.build\n+++ b/ui/meson.build\n@@ -48,7 +48,7 @@ vnc_ss.add(files(\n vnc_ss.add(zlib, jpeg, png)\n vnc_ss.add(when: sasl, if_true: files('vnc-auth-sasl.c'))\n system_ss.add_all(when: [vnc, pixman], if_true: vnc_ss)\n-system_ss.add(when: vnc, if_false: files('vnc-stubs.c'))\n+system_ss.add(when: vnc, if_true: files('vnc-system.c'), if_false: files('vnc-stubs.c'))\n \n ui_modules = {}\n \n","prefixes":["v3","19/26"]}