{"id":2230554,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2230554/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260430-qemu-vnc-v3-18-be96757428d0@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260430-qemu-vnc-v3-18-be96757428d0@redhat.com>","date":"2026-04-29T21:02:51","name":"[v3,18/26] ui/vnc: defer listener registration until the console is known","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"fc45f23dec7e0b78a1325e2ba2b9f0389a0287c7","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.1/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260430-qemu-vnc-v3-18-be96757428d0@redhat.com/mbox/","series":[{"id":502150,"url":"http://patchwork.ozlabs.org/api/1.1/series/502150/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502150","date":"2026-04-29T21:02:34","name":"ui: add standalone VNC server over D-Bus","version":3,"mbox":"http://patchwork.ozlabs.org/series/502150/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2230554/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2230554/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=Ivkh4Pxj;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5VGz0zdfz1yHv\n\tfor ; Thu, 30 Apr 2026 07:06:51 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wIC7J-00005V-R0; Wed, 29 Apr 2026 17:06:45 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wIC5m-0006Ss-EO\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 17:05:12 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wIC5e-0003Vd-NU\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 17:05:05 -0400","from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-177-3l_ft1mkNP2D-gNrxN8AfA-1; Wed,\n 29 Apr 2026 17:04:59 -0400","from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id D2EB718004AD\n for ; Wed, 29 Apr 2026 21:04:58 +0000 (UTC)","from localhost (unknown [10.44.22.2])\n by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id D3D4D1800480; Wed, 29 Apr 2026 21:04:57 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777496701;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=4xEMaCQqjSebJ1+71cJFBJzEXz13GiV+gV7EIYyxol8=;\n b=Ivkh4Pxj2G8r+di/6Vkq2giMg95zY7HAjI20SvZMRMOVsaR3uXQnnWeR4qJk8NfP1jtzqu\n zdzL0aGhxxsW9WU5+fCtWHVtOdggoohcxtoliA7L+zb50dD3N5U7XqwiiOJaLYzKDJ3hdS\n Z+QAS2rGEemiLUwYbhDj41AuL8KeWII=","X-MC-Unique":"3l_ft1mkNP2D-gNrxN8AfA-1","X-Mimecast-MFC-AGG-ID":"3l_ft1mkNP2D-gNrxN8AfA_1777496698","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Thu, 30 Apr 2026 01:02:51 +0400","Subject":"[PATCH v3 18/26] ui/vnc: defer listener registration until the\n console is known","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260430-qemu-vnc-v3-18-be96757428d0@redhat.com>","References":"<20260430-qemu-vnc-v3-0-be96757428d0@redhat.com>","In-Reply-To":"<20260430-qemu-vnc-v3-0-be96757428d0@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n\t=?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=1763;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=RK09TmaDHI9YqNxso5kjLy2qpHqN5kF0JjAA2oakXGU=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp8nIMH3Nu8J+aiKH8UyK7dbTyZivqBc8wshoww\n UeEG2dABeyJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafJyDAAKCRDa6OEJdZac\n 5bqED/kB2HIIs7nJrZaHcJoXvWv8vy6SdBeoGHxBvMOUmdufdiVURXjrLY4VtLurf+GKh2guuBL\n mI5R9jAMj8DrKMz3smJDK1Ki2xWoB9YexsW/K0NxQfJ7FQMdju/fuGYSp+4kzs/QHydrwe01MEL\n T/L+P/LSZwkye+GFxj52+MKM2WDK921/6npKXq0B6vZNr/lqstvX493OlOHM151THGANwocShqY\n 9v8ei7qHoxMR/lV/g/I71UcGfLo7yuChYMEl5kdOENywdih+qqZJ1th68cIcPq4AgUhpDoMvp9l\n dyS7XjaoWwAGisYLiKY+SQKQPylMHdBG25aUy4StIA6jAtzAxRVc45M91cR6EmdsW7iAz6iQB0d\n oPa3C2zGo10mtF2NTaC77M8iW3MAzfUJsWJIZ3g1Yf4PVygzXk/Hd9XOXD99FzZesG3t9WGNDOj\n SZofDW7tKlp97/pWwTdl1bRTUtBC3VfdOcq+LBw/6c9LXCzCDLKSjLxbRzEZTjS8HQthicYIXxz\n OVd1hcwhfv7ucyB8J/sxFBBwjvnKH3FjyCsPTGyH/OoOkOOhaTTU3lVmg5GObeLvD0O3jUjbeST\n AD7GLZbQI5FX46wmpwVOWXeww5bTuLwLNfS5C8x7Wy6DvhIQ72Stc4ix0zm0T9wEiDkC8iX55Jo\n P3NPv79F6cUXlhg==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.93","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Previously, the display change listener was registered early in\nvnc_display_new() without a console, requiring vnc_display_open() to\nconditionally unregister and re-register it when the actual console was\nresolved. Since vnc_display_new() and vnc_display_open() were merged in\nthe previous commit, simply delay the registration and keyboard state\ninitialization to vnc_display_open(), after the console has been looked\nup. This removes the conditional re-registration and simplifies the code.\n\nReviewed-by: Daniel P. Berrangé \nSigned-off-by: Marc-André Lureau \n---\n ui/vnc.c | 12 +++---------\n 1 file changed, 3 insertions(+), 9 deletions(-)","diff":"diff --git a/ui/vnc.c b/ui/vnc.c\nindex d65153a5001..ea1579135b8 100644\n--- a/ui/vnc.c\n+++ b/ui/vnc.c\n@@ -3457,8 +3457,6 @@ VncDisplay *vnc_display_new(const char *id, Error **errp)\n \n vnc_start_worker_thread(vd);\n \n- register_displaychangelistener(&vd->dcl);\n- vd->kbd = qkbd_state_init(vd->dcl.con);\n vd->vmstate_handler_entry = qemu_add_vm_change_state_handler(\n &vmstate_change_handler, vd);\n \n@@ -4269,13 +4267,9 @@ static bool vnc_display_open(VncDisplay *vd, Error **errp)\n con = qemu_console_lookup_default();\n }\n \n- if (con != vd->dcl.con) {\n- qkbd_state_free(vd->kbd);\n- unregister_displaychangelistener(&vd->dcl);\n- vd->dcl.con = con;\n- register_displaychangelistener(&vd->dcl);\n- vd->kbd = qkbd_state_init(vd->dcl.con);\n- }\n+ vd->dcl.con = con;\n+ register_displaychangelistener(&vd->dcl);\n+ vd->kbd = qkbd_state_init(vd->dcl.con);\n qkbd_state_set_delay(vd->kbd, key_delay_ms);\n \n if (saddr_list == NULL) {\n","prefixes":["v3","18/26"]}