{"id":2230547,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2230547/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260430-qemu-vnc-v3-8-be96757428d0@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260430-qemu-vnc-v3-8-be96757428d0@redhat.com>","date":"2026-04-29T21:02:41","name":"[v3,08/26] ui/console-vc: extract vt100_input() from vc_chr_write()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"1ad5d3d12b7d5ffc9cae960626f73930eadcc82b","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.1/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260430-qemu-vnc-v3-8-be96757428d0@redhat.com/mbox/","series":[{"id":502150,"url":"http://patchwork.ozlabs.org/api/1.1/series/502150/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502150","date":"2026-04-29T21:02:34","name":"ui: add standalone VNC server over D-Bus","version":3,"mbox":"http://patchwork.ozlabs.org/series/502150/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2230547/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2230547/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=dsJztRWW;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5VFv2ClTz1yHv\n\tfor ; Thu, 30 Apr 2026 07:05:55 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wIC4n-0004BM-T3; Wed, 29 Apr 2026 17:04:09 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wIC4m-00049c-G0\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 17:04:08 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wIC4k-0003KQ-Rs\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 17:04:08 -0400","from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-460-OxV8MbYPPzik98JKQOR5rA-1; Wed,\n 29 Apr 2026 17:04:01 -0400","from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id B7D8F18004AD; Wed, 29 Apr 2026 21:04:00 +0000 (UTC)","from localhost (unknown [10.44.22.2])\n by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 4ED7819560AB; Wed, 29 Apr 2026 21:03:58 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777496646;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=s0K2K5fhhdNzX4OBI1xp73vrW9s2JcoHKgf5KZfeWgY=;\n b=dsJztRWWaKvjxv/kDNlIqU6Oudd8KIX6Eji2vM7QTkVq3tDEME0aTQ+DpEGjMMbX4bF9hU\n +PaSfOao/1h4hd7Us2T+5/CtMiHp+40Y7cGy3KUZCDF6NWjE9X/e0QaAtzqNl+oS2k91Ru\n EPMUz/m6rSslu2k+Ue4tn7QH55KWYqY=","X-MC-Unique":"OxV8MbYPPzik98JKQOR5rA-1","X-Mimecast-MFC-AGG-ID":"OxV8MbYPPzik98JKQOR5rA_1777496640","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Thu, 30 Apr 2026 01:02:41 +0400","Subject":"[PATCH v3 08/26] ui/console-vc: extract vt100_input() from\n vc_chr_write()","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260430-qemu-vnc-v3-8-be96757428d0@redhat.com>","References":"<20260430-qemu-vnc-v3-0-be96757428d0@redhat.com>","In-Reply-To":"<20260430-qemu-vnc-v3-0-be96757428d0@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=2581;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=OxentmOB0aHkFj9sS8PNhIY0KX1fP6rvOvIzMKx8ABo=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp8nILU9hCjHev+l7W8XAvJ9UnIAE86/cpdvkFx\n Aj2B/J7oTaJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafJyCwAKCRDa6OEJdZac\n 5bZ8D/9KPisxL+Ciodgx5lPxI3hvDl1zBZlCxwyWffEfmb38Do7B1hyT3U3WNN6ruDeubGMSTEV\n PZ/2548mfI2DL/SqXXlYRys0aEGGFt/Zn7BbzEABoqCa/pYbLTYJ5GuF+NuH5erpo+dgfqBALvP\n PyXHFj1BHmz5Ic50fjhcLktr+PN2q22BymRO73fGwrsu+anSzwtiOKYr/R3UHElm9W2G+xxkUNZ\n zVKwKnZDbzN0/WgLnPgNTyTEWS5MpUy2cTNpwB6Sb4diWGA1Vr2cbXqjRtJNkO9Ovl3tibs4Xwz\n UJwbX2yonbWsKI8tQDgkN5uCrYKU7VBw73A/Vu4ba4uImrl+d7H22JqZtpLbV9b4nh2lofwrlZv\n LgNhDVXiLsMNhydp0qob+IdiHym0N9yMC03Az9gaHXzUa8QpMBEs+tTsnpoPA5WTXrZD6mYtR+z\n 2jHBxnqEcxxLmIEb803dKQaBSdl/Ziz0q5liZ/DXeNnxlole6JkMg0RsqVKf/OLOp1HLa2en97a\n /yyOakFlpGO9hZKAZ0JCCQf2S7VIxBo+ImZrE+uQiTR8gXGg1t2z6+pWmyjRYmeVNIxCL5RbeCB\n hbffB0KEOgXSi42WosbbbKc0s9bukztv9nIqNOJ4UnlV8GzW/veIAThculxta26GW0TtirBtLew\n U3CT/fFrttN3gWg==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.12","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Move the VT100 input processing logic out of vc_chr_write() into a new\nvt100_input() function that operates on QemuVT100 directly, rather than\ngoing through the Chardev/VCChardev layers. This continues the effort\nto decouple the VT100 emulation from the chardev backend, making the\nVT100 layer self-contained and reusable.\n\nvc_chr_write() becomes a thin wrapper that extracts the QemuVT100 from\nthe chardev and delegates to vt100_input().\n\nReviewed-by: Philippe Mathieu-Daudé \nSigned-off-by: Marc-André Lureau \n---\n ui/console-vc.c | 34 ++++++++++++++++++++--------------\n 1 file changed, 20 insertions(+), 14 deletions(-)","diff":"diff --git a/ui/console-vc.c b/ui/console-vc.c\nindex cf1adfc3c71..024ab277e0b 100644\n--- a/ui/console-vc.c\n+++ b/ui/console-vc.c\n@@ -1059,29 +1059,35 @@ static void vt100_putchar(QemuVT100 *vt, int ch)\n DECLARE_INSTANCE_CHECKER(VCChardev, VC_CHARDEV,\n TYPE_CHARDEV_VC)\n \n-static int vc_chr_write(Chardev *chr, const uint8_t *buf, int len)\n+static size_t vt100_input(QemuVT100 *vt, const uint8_t *buf, size_t len)\n {\n- VCChardev *drv = VC_CHARDEV(chr);\n- QemuTextConsole *s = drv->console;\n int i;\n \n- s->vt.update_x0 = s->vt.width * FONT_WIDTH;\n- s->vt.update_y0 = s->vt.height * FONT_HEIGHT;\n- s->vt.update_x1 = 0;\n- s->vt.update_y1 = 0;\n- vt100_show_cursor(&s->vt, 0);\n+ vt->update_x0 = vt->width * FONT_WIDTH;\n+ vt->update_y0 = vt->height * FONT_HEIGHT;\n+ vt->update_x1 = 0;\n+ vt->update_y1 = 0;\n+ vt100_show_cursor(vt, 0);\n for(i = 0; i < len; i++) {\n- vt100_putchar(&s->vt, buf[i]);\n+ vt100_putchar(vt, buf[i]);\n }\n- vt100_show_cursor(&s->vt, 1);\n- if (s->vt.update_x0 < s->vt.update_x1) {\n- vt100_image_update(&s->vt, s->vt.update_x0, s->vt.update_y0,\n- s->vt.update_x1 - s->vt.update_x0,\n- s->vt.update_y1 - s->vt.update_y0);\n+ vt100_show_cursor(vt, 1);\n+ if (vt->update_x0 < vt->update_x1) {\n+ vt100_image_update(vt, vt->update_x0, vt->update_y0,\n+ vt->update_x1 - vt->update_x0,\n+ vt->update_y1 - vt->update_y0);\n }\n return len;\n }\n \n+static int vc_chr_write(Chardev *chr, const uint8_t *buf, int len)\n+{\n+ VCChardev *drv = VC_CHARDEV(chr);\n+ QemuTextConsole *s = drv->console;\n+\n+ return vt100_input(&s->vt, buf, len);\n+}\n+\n void vt100_update_cursor(void)\n {\n QemuVT100 *vt;\n","prefixes":["v3","08/26"]}