{"id":2230540,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2230540/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260430-qemu-vnc-v3-9-be96757428d0@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260430-qemu-vnc-v3-9-be96757428d0@redhat.com>","date":"2026-04-29T21:02:42","name":"[v3,09/26] ui/console-vc: extract vt100_keysym() from qemu_text_console_handle_keysym()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"b6c5bb900324e6891eac19ba335151d977307fd0","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.1/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260430-qemu-vnc-v3-9-be96757428d0@redhat.com/mbox/","series":[{"id":502150,"url":"http://patchwork.ozlabs.org/api/1.1/series/502150/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502150","date":"2026-04-29T21:02:34","name":"ui: add standalone VNC server over D-Bus","version":3,"mbox":"http://patchwork.ozlabs.org/series/502150/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2230540/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2230540/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=Tr4bowoy;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5VDP5JkFz23gs\n\tfor ; Thu, 30 Apr 2026 07:04:36 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wIC4r-0004Qn-HV; Wed, 29 Apr 2026 17:04:13 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wIC4q-0004O9-4c\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 17:04:12 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wIC4o-0003Kq-NP\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 17:04:11 -0400","from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-149-6daXo7iwMsGaUmEWulvX4g-1; Wed,\n 29 Apr 2026 17:04:08 -0400","from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 0D3B118002C5; Wed, 29 Apr 2026 21:04:07 +0000 (UTC)","from localhost (unknown [10.44.22.2])\n by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 122DC180045E; Wed, 29 Apr 2026 21:04:04 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777496650;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=JmFBcPpPg70cERCREd01+2LUoYOfsSp3YOvkB7jQRG0=;\n b=Tr4bowoy0XHn1L1EVNtLVnl8x28XFp0zL3HXOnXrfJ1VmOfEHtL/fEHybPW0eSYfev7VoS\n 0HTpU03O9p29NYAm4U/Ai8ZGZKXgoZ0BxZEO3AoWv2ERnMTCna38klaXP+3ada/lEjaef+\n tYFsCd3LlLnXy2sACNxPTG6mL0vWjiI=","X-MC-Unique":"6daXo7iwMsGaUmEWulvX4g-1","X-Mimecast-MFC-AGG-ID":"6daXo7iwMsGaUmEWulvX4g_1777496647","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Thu, 30 Apr 2026 01:02:42 +0400","Subject":"[PATCH v3 09/26] ui/console-vc: extract vt100_keysym() from\n qemu_text_console_handle_keysym()","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260430-qemu-vnc-v3-9-be96757428d0@redhat.com>","References":"<20260430-qemu-vnc-v3-0-be96757428d0@redhat.com>","In-Reply-To":"<20260430-qemu-vnc-v3-0-be96757428d0@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=2776;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=8joCuZ7b714/pI2LClfiZ7KWft0awWMucbiOwUmsTxo=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp8nILU+Q/oNywn9fn08iSyerRrEu/KyO0EmrpW\n oFflTXWRy+JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafJyCwAKCRDa6OEJdZac\n 5bGED/9XYcXEvdpVU7ZnV9pUa1NjfP872/1lqReXmRV3MgVn6IsBQk8cP0oc9znqYOalcWE3uya\n HHFwQPH2Y9505F733R3Gi1VwKgPtINSs0spschmlX9hxa9toazXV3A4oOR/Xo9JMVVcSCYjWlko\n qGA9JOEjLo02e2Eud6U9zb0QWdjlPOvMlw2ZMmr+Bg90KuhZXpzOCO/xa6dLvDiJ9P9XeyFZv3a\n GhjWRzhjc4gmllkWQWRNootwkypj2CQovrrpziPJ4yBPN9rUi+XryZGUi2HZIC1A4OpJi54Ww/6\n 6ZBTsYaRTLHV0KoQ/Dq+JsShNIg0HOBm32PSs1m9Ba65deUlwNVr86VNt2lAFOtuAX38ko/HwLn\n BmZ5PXZINpekffxa2VgbyWRH0EkgnwvFdv89doaVR63Dt1HJHO7XQf+WvOFK5VHeX2Wxd/q9mPK\n CnhsFMM813/9ZiCqM9B7XlfYUwd+WRCP3OazMIomTDUoADZkHF+jRsaJfCdgfj5CWq8tALRMBz1\n lAaqokIm00si2+K8g3dyfijgkp8y7kP4MmjW+PZtrCd32OZAwcpw6aoFkJgNJ4/vlfT5qNAXckT\n nkPQVFy7KYfCSeBQE3g+vioaKLMnP26NHRnJ/Vj/buCPE9JHKgbH6k1cocNScWV5bBMhjj6uH4M\n Gc1wv/osDJAUwKA==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.111","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Move the keysym handling logic out of qemu_text_console_handle_keysym()\ninto a new vt100_keysym() helper that operates on QemuVT100 directly,\ncontinuing the effort to decouple the VT100 layer from the console layer.\n\nThe echo path is updated to call vt100_input() instead of\nqemu_chr_write(), since the function no longer has direct access\nto the chardev.\n\nReviewed-by: Philippe Mathieu-Daudé \nSigned-off-by: Marc-André Lureau \n---\n ui/console-vc.c | 29 ++++++++++++++++++-----------\n 1 file changed, 18 insertions(+), 11 deletions(-)","diff":"diff --git a/ui/console-vc.c b/ui/console-vc.c\nindex 024ab277e0b..9f5f49413d2 100644\n--- a/ui/console-vc.c\n+++ b/ui/console-vc.c\n@@ -331,24 +331,25 @@ static void vt100_write(QemuVT100 *vt, const void *buf, size_t len)\n vt->out_flush(vt);\n }\n \n-/* called when an ascii key is pressed */\n-void qemu_text_console_handle_keysym(QemuTextConsole *s, int keysym)\n+static int vt100_input(QemuVT100 *vt, const uint8_t *buf, int len);\n+\n+static void vt100_keysym(QemuVT100 *vt, int keysym)\n {\n uint8_t buf[16], *q;\n int c;\n \n switch(keysym) {\n case QEMU_KEY_CTRL_UP:\n- vt100_scroll(&s->vt, -1);\n+ vt100_scroll(vt, -1);\n break;\n case QEMU_KEY_CTRL_DOWN:\n- vt100_scroll(&s->vt, 1);\n+ vt100_scroll(vt, 1);\n break;\n case QEMU_KEY_CTRL_PAGEUP:\n- vt100_scroll(&s->vt, -10);\n+ vt100_scroll(vt, -10);\n break;\n case QEMU_KEY_CTRL_PAGEDOWN:\n- vt100_scroll(&s->vt, 10);\n+ vt100_scroll(vt, 10);\n break;\n default:\n /* convert the QEMU keysym to VT100 key string */\n@@ -365,18 +366,24 @@ void qemu_text_console_handle_keysym(QemuTextConsole *s, int keysym)\n *q++ = '\\033';\n *q++ = '[';\n *q++ = keysym & 0xff;\n- } else if (s->vt.echo && (keysym == '\\r' || keysym == '\\n')) {\n- qemu_chr_write(s->chr, (uint8_t *)\"\\r\", 1, true);\n+ } else if (vt->echo && (keysym == '\\r' || keysym == '\\n')) {\n+ vt100_input(vt, (uint8_t *)\"\\r\", 1);\n *q++ = '\\n';\n } else {\n *q++ = keysym;\n }\n- if (s->vt.echo) {\n- qemu_chr_write(s->chr, buf, q - buf, true);\n+ if (vt->echo) {\n+ vt100_input(vt, buf, q - buf);\n }\n- vt100_write(&s->vt, buf, q - buf);\n+ vt100_write(vt, buf, q - buf);\n break;\n }\n+\n+}\n+/* called when an ascii key is pressed */\n+void qemu_text_console_handle_keysym(QemuTextConsole *s, int keysym)\n+{\n+ vt100_keysym(&s->vt, keysym);\n }\n \n static void text_console_update(void *opaque, console_ch_t *chardata)\n","prefixes":["v3","09/26"]}