{"id":2230538,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2230538/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260430-qemu-vnc-v3-2-be96757428d0@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260430-qemu-vnc-v3-2-be96757428d0@redhat.com>","date":"2026-04-29T21:02:35","name":"[v3,02/26] char: error out if given unhandled size options","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"13a7121cca79505236d8f0e4fb3a137d5f7aefdc","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.1/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260430-qemu-vnc-v3-2-be96757428d0@redhat.com/mbox/","series":[{"id":502150,"url":"http://patchwork.ozlabs.org/api/1.1/series/502150/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502150","date":"2026-04-29T21:02:34","name":"ui: add standalone VNC server over D-Bus","version":3,"mbox":"http://patchwork.ozlabs.org/series/502150/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2230538/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2230538/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=KzSTebnF;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5VDP54RGz1yK1\n\tfor ; Thu, 30 Apr 2026 07:04:36 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wIC4H-0003Ui-Fu; Wed, 29 Apr 2026 17:03:37 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wIC4B-0003TZ-7O\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 17:03:35 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wIC49-0003Cc-9t\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 17:03:30 -0400","from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-13-bvst9hv-PSOd6ARi-Iug2g-1; Wed,\n 29 Apr 2026 17:03:26 -0400","from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id C202519560A3\n for ; Wed, 29 Apr 2026 21:03:25 +0000 (UTC)","from localhost (unknown [10.44.22.2])\n by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 7441019560B6; Wed, 29 Apr 2026 21:03:23 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777496608;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=aEGhBdo4FIrkpLD+9d7/P2GvS/cJYUI8tGJGysFprBg=;\n b=KzSTebnFt2hweqyAZAkQuNN7Su4wFzrqiufX3Odfyy7pdzwG7y8l4fM2moNqNpqWoXP4T5\n S8NHfYjZanks4qX4zdnpmt8qqRF4GQcoxB5wJNLMhYuwouluO7h6dasS7tRL8jRZR9oto1\n cXHFj3s8M3BlwKgNuvi5tVSiVJQMKVk=","X-MC-Unique":"bvst9hv-PSOd6ARi-Iug2g-1","X-Mimecast-MFC-AGG-ID":"bvst9hv-PSOd6ARi-Iug2g_1777496605","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Thu, 30 Apr 2026 01:02:35 +0400","Subject":"[PATCH v3 02/26] char: error out if given unhandled size options","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260430-qemu-vnc-v3-2-be96757428d0@redhat.com>","References":"<20260430-qemu-vnc-v3-0-be96757428d0@redhat.com>","In-Reply-To":"<20260430-qemu-vnc-v3-0-be96757428d0@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=3309;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=I4+LryVaXPKdaH8bJajB6Zo4PYtkb+nVwNduq5g7EEw=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp8nILYMDi4EBmkn27F8+IAKd9qhV7vxX4QSqty\n 0hO+L3o6MaJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafJyCwAKCRDa6OEJdZac\n 5SjCD/wOzsjPXuVASot173e4hj7ZuEumW5idb3Rxx1nA8vVwMi/HhXT89OuUElliB0awSAj60to\n YMYy3JD55g2P9jKlP+kb2Pvn5cUjv3C/9kX2HRgLr54Fr20iM/7AFyKl9qzYAz2CcyNOwF3TN1l\n sI6g9LdSuqwJngXpv4Miy3ZWTnjNZezwbuZLahkttDXqtnS+zIS5BIso7Cd70vf2Z6j3cDGycYb\n /fkYew6OwX9GMFG/cfSuvIlKbrrbrYz33HXIkOmhaxgNL0IWrO33e+vY5zDRpV7Nmj1HvvrqWBG\n 5PMRmYrEVzoqQdkfhXtmbJYI8y9NAzLeh+9dV2d+8tJfN3k7ZCaftuCApHd4cE8XdelAC7E3lgb\n Hkk7hxGjEfi5cznpCL7J+gVtZzpX4XJ5bw2ZisOMLlpfgkHGe8M2cVAP4W3C4PEr9UoGy814MWC\n zBegkPLSckN/WdCogpO8Ozpl2WIWR5y6HNeZsSOD3Hjzk6oyk0WnfCIdnGm523nj/WSaSXdbrTI\n z/u+9dcwseDqUn0V7Y07iLJAAqKTc4sYp2DmAjR7KknB7p/6KFzRQcO9MLQylLLwX2qwcY4QQru\n HO+tj16oxud37I4QK1ukQ3Ma2HU3mYJWUZ9lFAJPxhJTp2vep0P3kSykhOE1p0mFI8/3pmrlHLX\n iS78/hInZUPdidA==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.12","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"12","X-Spam_score":"1.2","X-Spam_bar":"+","X-Spam_report":"(1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"This is a small help, because in fact all combined chardev\noptions are accepted by qemu_chardev_opts[]. But given that a user may\nlegitimately want to use the size options with a VC backend, we can\nreport an error when we know the backend doesn't support it.\n\nSigned-off-by: Marc-André Lureau \n---\n include/chardev/char.h | 1 +\n include/qemu/option.h | 1 +\n chardev/char.c | 12 ++++++++++++\n ui/console-vc.c | 1 +\n util/qemu-option.c | 13 +++++++++++++\n 5 files changed, 28 insertions(+)","diff":"diff --git a/include/chardev/char.h b/include/chardev/char.h\nindex c2c42e4b7a3..51995f06a82 100644\n--- a/include/chardev/char.h\n+++ b/include/chardev/char.h\n@@ -254,6 +254,7 @@ struct ChardevClass {\n \n bool internal; /* TODO: eventually use TYPE_USER_CREATABLE */\n bool supports_yank;\n+ bool supports_size_opts;\n \n /* parse command line options and populate QAPI @backend */\n void (*chr_parse)(QemuOpts *opts, ChardevBackend *backend, Error **errp);\ndiff --git a/include/qemu/option.h b/include/qemu/option.h\nindex 01e673ae03f..9a00ac0a356 100644\n--- a/include/qemu/option.h\n+++ b/include/qemu/option.h\n@@ -73,6 +73,7 @@ struct QemuOptsList {\n \n const char *qemu_opt_get(QemuOpts *opts, const char *name);\n char *qemu_opt_get_del(QemuOpts *opts, const char *name);\n+bool qemu_opt_has_any(QemuOpts *opts, const char * const *names);\n /**\n * qemu_opt_has_help_opt:\n * @opts: options to search for a help request\ndiff --git a/chardev/char.c b/chardev/char.c\nindex 48b326d57b9..55dce9725e8 100644\n--- a/chardev/char.c\n+++ b/chardev/char.c\n@@ -639,6 +639,18 @@ ChardevBackend *qemu_chr_parse_opts(QemuOpts *opts, Error **errp)\n return NULL;\n }\n \n+ if (!cc->supports_size_opts) {\n+ const char * const invalid_opts[] = {\n+ \"width\", \"height\", \"cols\", \"rows\", NULL\n+ };\n+\n+ if (qemu_opt_has_any(opts, invalid_opts)) {\n+ error_setg(errp, \"chardev '%s' does not support size options\",\n+ qemu_opts_id(opts));\n+ return NULL;\n+ }\n+ }\n+\n backend = g_new0(ChardevBackend, 1);\n backend->type = CHARDEV_BACKEND_KIND_NULL;\n \ndiff --git a/ui/console-vc.c b/ui/console-vc.c\nindex 6163e21d2c6..62a5e3caf57 100644\n--- a/ui/console-vc.c\n+++ b/ui/console-vc.c\n@@ -1251,6 +1251,7 @@ static void char_vc_class_init(ObjectClass *oc, const void *data)\n cc->chr_write = vc_chr_write;\n cc->chr_accept_input = vc_chr_accept_input;\n cc->chr_set_echo = vc_chr_set_echo;\n+ cc->supports_size_opts = true;\n }\n \n static const TypeInfo char_vc_type_info = {\ndiff --git a/util/qemu-option.c b/util/qemu-option.c\nindex 770300dff12..9fbf425f86e 100644\n--- a/util/qemu-option.c\n+++ b/util/qemu-option.c\n@@ -271,6 +271,19 @@ const char *qemu_opt_get(QemuOpts *opts, const char *name)\n return opt->str;\n }\n \n+bool qemu_opt_has_any(QemuOpts *opts, const char * const *names)\n+{\n+ int it;\n+\n+ for (it = 0; names[it]; it++) {\n+ if (qemu_opt_get(opts, names[it])) {\n+ return true;\n+ }\n+ }\n+ return false;\n+}\n+\n+\n void qemu_opt_iter_init(QemuOptsIter *iter, QemuOpts *opts, const char *name)\n {\n iter->opts = opts;\n","prefixes":["v3","02/26"]}